docs: correct stale resolver, status and duplication claims

ADR-0014 gains a dated correction: skill-size-check now sources the
boundary resolver from kyberforge (ef27c97), so restoring the external
hook contract needs it made self-contained first. ADR-0017's status
reflects its supersession, architecture.md and gates.md carry the
current duplication counts and reason, gates.md defines vacuous green
inline, and the gitleaks lesson is marked historical.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-09-16 15:27:29 +00:00
parent 25743911f1
commit 1f3d4f9962
5 changed files with 19 additions and 8 deletions

View File

@@ -273,6 +273,16 @@ restore the manifest under that constraint, and restore `test-vale-hooks-consume
was the only test that exercised the entry-resolution path that once shipped broken. Restore a
release gate only once a server-side job can run it on merge.
**Correction (2026-09-16, later the same day).** The paragraph above is wrong about
`skill-size-check.sh`. `ef27c97` removed its embedded resolver copy: the hook now sources
`plugins/kyberforge/.apm/skills/factory-audit/scripts/lib-boundary-resolver.sh` by path and fails
closed without it (ADR-0020's 2026-09-16 amendment; `docs/spec/gates.md`, "Duplicated constants").
An external consumer's checkout has no such file, so restoring the manifest as described would ship
a hook that fails for every consumer — the defect recorded at `LESSONS.md:101`. Only `vale-wrap.sh`
still meets the `entry[0]`-only constraint. A return must first make `skill-size-check.sh`
self-contained again, by re-embedding the resolver or shipping the library beside the hook, and
restore a consumer test that proves it.
**Superseded statements elsewhere.** ADR-0022's notes that the version-bump gate "is not exported
through `.pre-commit-hooks.yaml`" and that it shares its gaps with `check-release-needed`, and
ADR-0025's point 5 ("Both exported Vale hook IDs survive unchanged") and its case-33 port, describe

View File

@@ -19,7 +19,7 @@ for the parent decision. It resolves the one question ADR-0015's own execution f
did not block on: whether Claude Code's installer can actually load content out of `.apm/`. It
could not.
**Status: executed (2026-08-13, issue #90).** `scripts/sync-plugin-content.sh` has been run
**Status: superseded by ADR-0024** (originally executed 2026-08-13, issue #90; the text below is the record of that execution). `scripts/sync-plugin-content.sh` has been run
against all 6 plugins; flat `agents/`, `skills/`, `commands/` (etc., wherever `.apm/` populates
them), and a merged hooks file now exist at each plugin root as tracked, generated files. The
merged hooks file lands at `hooks/hooks.json`, not at the plugin root itself — see the second