fix(tests): point the strict-mode dependency citation at README.md
Why: this branch moved the prerequisites list out of AGENTS.md into README.md but left three references behind. The worst is run-tests.sh's --strict failure message, which a developer is handed at the exact moment a push gate fails and they need the dependency list: it named AGENTS.md, which no longer documents vale, apm or jq anywhere.56cc173re-anchored this same class of citation in .pre-commit-config.yaml, scripts/check-vale-style-sync.sh, scripts/sync-marketplace-mirror.sh and tests/test-check-vale-style-sync.sh -- tests/run-tests.sh was missed, and it is the only one a human actually reads. Implementation notes: - run-tests.sh:262 (user-visible), run-tests.sh:16 (header rationale) and test-run-tests.sh:395 all now cite README.md's Prerequisites table, verified to name vale, apm, jq, python3/PyYAML and the claude CLI. - Every assertion on this message greps for "a skip is a SETUP ERROR", which sits before the changed clause, so no test needed updating. - test-vale-wrap.sh's bash 3.2 citation is corrected in the same pass: it credited LESSONS.md and the script headers, but LESSONS.md's only mention of 3.2 is an aside inside an unrelated lesson, not a target declaration. It now cites scripts/lib/batch-run.sh and providers/claude-code/statusline-command.sh, which do declare it. The citation56cc173replaced was already false, so this finishes a half-fix rather than correcting a regression. Impact: forced the strict-failure path with vale removed from PATH and confirmed the corrected message printing -- 21 passed, 3 skipped, exit 1. Full suite with vale present: 24 passed, 0 skipped, 0 failed. Refs: #105 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TmFqzpuExLJv3m114XVE9w
This commit is contained in:
@@ -392,10 +392,11 @@ fi
|
||||
|
||||
# --- 10. --strict turns a skip into a failure, and names the suite AND the reason ---
|
||||
# Graceful skipping is right for an ad-hoc run and wrong for a gate. At pre-push a
|
||||
# suite exiting 77 means a dependency AGENTS.md documents as required is missing
|
||||
# on the pushing machine -- and pre-commit prints nothing at all for a passing
|
||||
# hook, so the skip list this script writes to stdout was swallowed whole. A
|
||||
# vale-less PATH shipped a green gate having verified 15 of 17 suites.
|
||||
# suite exiting 77 means a dependency README.md's Prerequisites table documents
|
||||
# as required is missing on the pushing machine -- and pre-commit prints nothing
|
||||
# at all for a passing hook, so the skip list this script writes to stdout was
|
||||
# swallowed whole. A vale-less PATH shipped a green gate having verified 15 of
|
||||
# 17 suites.
|
||||
#
|
||||
# The reason is asserted, not just the name: "something was skipped" leaves the
|
||||
# reader with no idea which binary to install, which is most of why the swallowed
|
||||
|
||||
Reference in New Issue
Block a user