Defame1297/holocron
0
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

chore: drop the duplicated package descriptions from root apm.yml

Browse Source 
Why: for a local-path marketplace entry, apm treats a root description: as
an override of the package's own apm.yml, reported only at verbose level,
so the "two copies stay identical" rule had no enforcement. Same fix as
2def060 made for version:.

Implementation Notes:
- All six root copies matched their package apm.yml before removal; the
  compiled marketplace.json descriptions are unchanged.
- apm-workflow references now scope the "omit it" advice to local-path
  entries: on a remote entry, version: is the semver range that selects
  the tag, and version: or ref: is required.

Impact: ADR-0021 amended; the package apm.yml is the single source.

ADR: 0021
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Defame1297
2026-09-16 11:24:22 +00:00
parent c5d43b4d63
commit 398515bcad
4 changed files with 53 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
plugins/kyberforge/.apm/skills/apm-workflow/references/configure.md
View File

@@ -53,13 +53,19 @@ output changes.** Two triggers, not one:
The version belongs to the package, not to the repo: editing `plugins/foo/.apm/` never bumps
`plugins/bar/apm.yml`.
Under a `per_package` strategy this `version:` is the single source: when a catalog's
`marketplace.packages[]` entry omits `version:`, `apm pack` reads it from the package's `apm.yml`.
Do not restate it there. A `version:` on the entry is an override, not a copy — it silently wins in
the compiled `marketplace.json`, and `apm pack --check-versions` still reports `[matches]` when it
disagrees with the package's own number, so drift between the two is never caught. Set one only
when an override is the intent. A skipped bump is not caught either: nothing infers intent from a
content diff. The catalog's own version follows a separate rule — see `references/marketplace.md`.
Under a `per_package` strategy this `version:` is the single source for a local-path
(`source: ./…`) catalog entry: when that `marketplace.packages[]` entry omits `version:`,
`apm pack` reads it from the package's `apm.yml`. Do not restate it there. On a local entry a
`version:` is an override, not a copy — it silently wins in the compiled `marketplace.json`, and
`apm pack --check-versions` still reports `[matches]` when it disagrees with the package's own
number, so drift between the two is never caught. Set one only when an override is the intent.
`description:` behaves the same way: a local entry that omits it publishes the package `apm.yml`'s
`description`, and one that sets it silently overrides it. A remote entry is different. There,
`version:` is the semver range that selects which git tag to resolve, and a remote entry must carry
`version:` or `ref:`. Its `description:`, when set, is the published text.
A skipped bump is not caught either: nothing infers intent from a content diff. The catalog's own
version follows a separate rule — see `references/marketplace.md`.
## Dependency reference forms