fix(scripts): close gates that passed while the thing they guard was disabled

Four repo gates reported success in states they exist to reject.

`check-vale-style-sync.sh` passed while a Kyberforge lint rule was silenced. The
check matched a blocklist of severity values, but Vale's semantic is an allowlist:
anything that is not exactly YES/error/warning/suggestion disables the rule. So
`= false`, `= 0`, `= garbage`, an empty value and — worst — a lowercase `= yes` all
killed enforcement while reading as "enabled" to a human. Inverted to an allowlist.
Two sibling holes: dropping `KyberforgeCopilot` from `BasedOnStyles` unloaded the
Copilot-only check silently, and narrowing a section glob to a location made Vale
lint zero files, which is the "0 files, hook Passed" failure the script's own
comment says it exists to catch.

`sync-marketplace-mirror.sh --check` failed open when its source was missing, while
its sibling correctly errored in the same state.

`check-scope-walkup-sync.sh` wrote to hardcoded `/tmp/fN.out` paths and read one
back, making it non-reentrant — a concurrent instance can flip a verdict, and this
branch made the test runner concurrent. Now per-run `mktemp -d`.

`check-manifests.sh` had no disk-to-marketplace pass, so a plugin directory absent
from `marketplace.json` passed every gate while the `validate-plugins` hook globbed
it. The "listed" match is restricted to remote-source entry names; matching any
entry name let a genuine orphan through on a name coincidence.

`run-bats.sh` reported an empty TAP stream as `0 tests, 0 failures`, exit 0 — a
total harness failure reading as a pass.

The test-side changes are the larger half, because the guards were the real problem.
`test-sync-marketplace-mirror.sh` could overwrite the live tracked mirror under an
inherited GIT_DIR, which is precisely the git-hook context it runs in. The bash-3.2
scan hand-maintained its file list, omitting the new shared runner, and had no rule
for `wait -n` or `nproc` — the two hazards the previous review round found live. It
now derives 43 files across three globs with per-glob floors. Several assertions
were decoration: the concurrency checks caught the reentrancy defect 0 times in 10,
the leak fix was green either way, and two manifest fixtures passed with the code
they claimed to cover deleted. Every assertion now has a revert it provably fails
against.

Refs: #90

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X7GvKuJfy2WrdBmUttV4DT

scripts/check-manifests.sh

@@ -19,6 +19,16 @@ set -euo pipefail
 # those paths resolve. The fallback block below restores that check, but only for
 # plugins without .apm/ -- apm-native plugins keep relying on the delegation above so
 # the two checks don't duplicate (and disagree) on the same manifest.
+#
+# Both of the above walk marketplace.json -> disk. Nothing walked disk -> marketplace,
+# so a plugins/<name>/ directory that never made it into marketplace.json was invisible
+# to every marketplace-derived gate at once (this script and sync-plugin-content.sh
+# --all both derive their plugin set from marketplace.json). The final block below
+# closes that direction: per ADR-0015 marketplace.json is compiled output of root
+# apm.yml's marketplace.packages[], so an on-disk apm package with no entry is
+# compiled-output drift of exactly the kind ADR-0017 wires pre-push gates for -- and it
+# is the same plugin set the validate-plugins pre-commit hook already globs as
+# plugins/*/.
 
 REPO_ROOT="${1:-$(git rev-parse --show-toplevel 2>/dev/null || pwd)}"
 FAIL=0
@@ -39,6 +49,11 @@ SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=lib/marketplace-plugins.sh
 source "$SCRIPT_DIR/lib/marketplace-plugins.sh"
 
+# Every local plugin directory marketplace.json claimed, canonicalized, so the
+# disk -> marketplace pass below can tell "listed" from "unlisted" regardless of how
+# the `source:` string was spelled (./plugins/x, plugins/x, plugins/x/).
+SEEN_PLUGIN_DIRS=()
+
 while IFS=$'\t' read -r name plugin_dir; do
   source_rel="${plugin_dir#"$REPO_ROOT"/}"
 
@@ -46,6 +61,9 @@ while IFS=$'\t' read -r name plugin_dir; do
     err "plugin '$name': source directory not found: $source_rel"
     continue
   fi
+  # -P so a plugin directory reached through a symlink compares equal to the same
+  # directory reached directly; the disk-side walk below resolves the same way.
+  SEEN_PLUGIN_DIRS+=("$(cd "$plugin_dir" && pwd -P)")
 
   manifest="$plugin_dir/.claude-plugin/plugin.json"
   if [[ ! -f "$manifest" ]]; then
@@ -80,6 +98,59 @@ while IFS=$'\t' read -r name plugin_dir; do
   done
 done < <(list_marketplace_local_plugins "$REPO_ROOT" "$MARKETPLACE")
 
+# Disk -> marketplace. The trigger is any of the three markers that make a directory
+# a plugin rather than scratch -- apm.yml (the ADR-0015 authoring source), .apm/ (its
+# content tree), or a compiled .claude-plugin/plugin.json. Matching all three keeps
+# this set aligned with the plugins/*/ glob the validate-plugins pre-commit hook uses,
+# which is the disagreement this check exists to close; a directory with none of them
+# is scratch and stays out of scope.
+#
+# A candidate counts as listed if it is either a directory some local entry pointed at
+# (path match, canonicalized above) or a directory whose name matches a REMOTE entry's
+# name. The name axis exists only for a plugin vendored on disk but declared with the
+# remote-object `source:` shape: list_marketplace_local_plugins deliberately skips those,
+# so a path-only match would report a missing entry that is in fact already there.
+#
+# It is restricted to non-string sources on purpose. Applied to local entries too, the
+# name axis silently rescues genuine orphans, because a local entry's name need not equal
+# the basename of the directory it points at: an entry named "beta" pointing at
+# ./plugins/alpha would mark an unrelated, entirely unlisted plugins/beta/ as listed.
+# Local entries already have an exact path to match on, so they need no name fallback.
+MARKETPLACE_NAMES=()
+while IFS= read -r entry_name; do
+  [[ -n "$entry_name" ]] && MARKETPLACE_NAMES+=("$entry_name")
+done < <(jq -r '.plugins[]? | select((.source | type) != "string") | .name // empty' "$MARKETPLACE")
+
+for candidate in "$REPO_ROOT"/plugins/*/; do
+  candidate="${candidate%/}"
+  [[ -d "$candidate" ]] || continue
+  if [[ ! -f "$candidate/apm.yml" && ! -d "$candidate/.apm" && ! -f "$candidate/.claude-plugin/plugin.json" ]]; then
+    continue
+  fi
+
+  candidate_abs="$(cd "$candidate" && pwd -P)"
+  candidate_name="$(basename "$candidate")"
+  listed=0
+  for seen in ${SEEN_PLUGIN_DIRS[@]+"${SEEN_PLUGIN_DIRS[@]}"}; do
+    if [[ "$seen" == "$candidate_abs" ]]; then
+      listed=1
+      break
+    fi
+  done
+  if [[ $listed -eq 0 ]]; then
+    for entry_name in ${MARKETPLACE_NAMES[@]+"${MARKETPLACE_NAMES[@]}"}; do
+      if [[ "$entry_name" == "$candidate_name" ]]; then
+        listed=1
+        break
+      fi
+    done
+  fi
+
+  if [[ $listed -eq 0 ]]; then
+    err "plugin directory '${candidate#"$REPO_ROOT"/}' has no entry in .claude-plugin/marketplace.json — it is skipped by every marketplace-derived check (this one, and sync-plugin-content.sh --all) while still being globbed by the validate-plugins hook. Add it to root apm.yml's marketplace.packages[] and recompile the manifests."
+  fi
+done
+
 if [[ $FAIL -gt 0 ]]; then
   echo "Manifest check failed: $FAIL error(s)" >&2
   exit 1

scripts/check-scope-walkup-sync.sh

@@ -46,6 +46,18 @@ FIXTURES=()
 cleanup() { [[ ${#FIXTURES[@]} -eq 0 ]] || rm -rf "${FIXTURES[@]}"; }
 trap cleanup EXIT
 
+# Per-run scratch directory for the per-fixture output captures below. These
+# used to be fixed paths in the shared system temp directory, which made this
+# script non-reentrant: tests/run-tests.sh now fans its scripts out
+# concurrently, and two instances sharing one path clobber each other's
+# captures. Fixture 6 reads its capture back (`[[ -z "$(cat ...)" ]]`), so a
+# cross-run write there silently flips a real verdict, and a pre-existing
+# directory sitting at one of the paths breaks the run outright. Keep these
+# under a per-run mktemp -d; tests/test-check-scope-walkup-sync.sh asserts it.
+# Registered in FIXTURES so the single cleanup trap already here removes it.
+RUN_TMP="$(mktemp -d)"
+FIXTURES+=("$RUN_TMP")
+
 # Fill a new-agent.sh-scaffolded pair's FILL IN: placeholders with valid
 # content, isolating the scope/counterpart-lookup question from unrelated
 # content-quality FAILs when cross-checking against validate.sh.
@@ -78,11 +90,11 @@ else
   else
     fill_agent_pair "$F1_HOME/.claude/agents/$NAME1.md" "$NAME1"
     fill_agent_pair "$F1_HOME/.copilot/agents/$NAME1.agent.md" "$NAME1"
-    if env HOME="$F1_HOME" bash "$VALIDATE" "$F1_HOME/.claude/agents/$NAME1.md" >/tmp/f1.out 2>&1; then
+    if env HOME="$F1_HOME" bash "$VALIDATE" "$F1_HOME/.claude/agents/$NAME1.md" >"$RUN_TMP/f1.out" 2>&1; then
       ok "validate.sh agrees: user scope, counterpart found under \$HOME/.copilot"
     else
       err "validate.sh disagreed with new-agent.sh's user-scope classification at root exactly \$HOME"
-      sed 's/^/    /' /tmp/f1.out
+      sed 's/^/    /' "$RUN_TMP/f1.out"
     fi
   fi
 fi
@@ -111,22 +123,22 @@ else
     ok "new-agent.sh: nested marker-less dir under \$HOME scaffolds project scope at the nested dir"
     fill_agent_pair "$F2_NESTED/.claude/agents/$NAME2.md" "$NAME2"
     fill_agent_pair "$F2_NESTED/.github/agents/$NAME2.agent.md" "$NAME2"
-    if env HOME="$F2_HOME" bash "$VALIDATE" "$F2_NESTED/.claude/agents/$NAME2.md" >/tmp/f2.out 2>&1; then
+    if env HOME="$F2_HOME" bash "$VALIDATE" "$F2_NESTED/.claude/agents/$NAME2.md" >"$RUN_TMP/f2.out" 2>&1; then
       ok "validate.sh agrees: project scope, counterpart found at the nested dir (not \$HOME/.copilot)"
     else
       err "validate.sh disagreed with new-agent.sh: misclassified the nested marker-less \$HOME subdirectory"
-      sed 's/^/    /' /tmp/f2.out
+      sed 's/^/    /' "$RUN_TMP/f2.out"
     fi
     # new-skill.sh has no user/project distinction of its own (no $HOME
     # awareness at all — see new-skill.sh's find_package_root), but it shares
     # the same .git/apm.yml walk-up primitive. It must land its standalone
     # scaffold at the given path too, not get redirected toward $HOME.
-    if env HOME="$F2_HOME" bash "$NEW_SKILL" probe-home-nested-skill "$F2_NESTED" >/tmp/f2skill.out 2>&1 \
+    if env HOME="$F2_HOME" bash "$NEW_SKILL" probe-home-nested-skill "$F2_NESTED" >"$RUN_TMP/f2skill.out" 2>&1 \
       && [[ -d "$F2_NESTED/probe-home-nested-skill" ]]; then
       ok "new-skill.sh agrees: standalone mode scaffolds at the nested dir, not redirected toward \$HOME"
     else
       err "new-skill.sh disagreed with new-agent.sh/validate.sh on the nested marker-less \$HOME subdirectory"
-      sed 's/^/    /' /tmp/f2skill.out
+      sed 's/^/    /' "$RUN_TMP/f2skill.out"
     fi
   fi
 fi
@@ -156,11 +168,11 @@ else
   else
     fill_agent_pair "$F3_PROBE/.claude/agents/$NAME3.md" "$NAME3"
     fill_agent_pair "$F3_PROBE/.github/agents/$NAME3.agent.md" "$NAME3"
-    if env HOME="$F3_HOME" bash "$VALIDATE" "$F3_PROBE/.claude/agents/$NAME3.md" >/tmp/f3.out 2>&1; then
+    if env HOME="$F3_HOME" bash "$VALIDATE" "$F3_PROBE/.claude/agents/$NAME3.md" >"$RUN_TMP/f3.out" 2>&1; then
       ok "validate.sh agrees: .git boundary keeps this project scope, not promoted to user scope at \$HOME"
     else
       err "validate.sh disagreed with new-agent.sh on the .git-boundary-before-\$HOME fixture"
-      sed 's/^/    /' /tmp/f3.out
+      sed 's/^/    /' "$RUN_TMP/f3.out"
     fi
   fi
 fi
@@ -188,11 +200,11 @@ else
   else
     fill_agent_pair "$F3B_PROBE/.claude/agents/$NAME3B.md" "$NAME3B"
     fill_agent_pair "$F3B_PROBE/.github/agents/$NAME3B.agent.md" "$NAME3B"
-    if bash "$VALIDATE" "$F3B_PROBE/.claude/agents/$NAME3B.md" >/tmp/f3b.out 2>&1; then
+    if bash "$VALIDATE" "$F3B_PROBE/.claude/agents/$NAME3B.md" >"$RUN_TMP/f3b.out" 2>&1; then
       ok "validate.sh agrees: scope root is <root>, not the .git ancestor above it"
     else
       err "validate.sh disagreed with new-agent.sh: resolved scope to the .git ancestor instead of <root>"
-      sed 's/^/    /' /tmp/f3b.out
+      sed 's/^/    /' "$RUN_TMP/f3b.out"
     fi
   fi
 fi
@@ -214,19 +226,19 @@ elif [[ ! -f "$F4_ROOT/.apm/agents/$NAME4.agent.md" ]]; then
   err "new-agent.sh did not scaffold plugin scope at the type-bearing apm.yml root"
 else
   ok "new-agent.sh: plugin scope at type-bearing apm.yml root"
-  if bash "$NEW_SKILL" probe-plugin-skill "$F4_ROOT" >/tmp/f4skill.out 2>&1 \
+  if bash "$NEW_SKILL" probe-plugin-skill "$F4_ROOT" >"$RUN_TMP/f4skill.out" 2>&1 \
     && [[ -d "$F4_ROOT/.apm/skills/probe-plugin-skill" ]]; then
     ok "new-skill.sh agrees: package mode at the same apm.yml root"
   else
     err "new-skill.sh disagreed with new-agent.sh on the type-bearing apm.yml root"
-    sed 's/^/    /' /tmp/f4skill.out
+    sed 's/^/    /' "$RUN_TMP/f4skill.out"
   fi
   fill_agent_pair "$F4_ROOT/.apm/agents/$NAME4.agent.md" "$NAME4"
-  if bash "$VALIDATE" "$F4_ROOT/.apm/agents/$NAME4.agent.md" >/tmp/f4validate.out 2>&1; then
+  if bash "$VALIDATE" "$F4_ROOT/.apm/agents/$NAME4.agent.md" >"$RUN_TMP/f4validate.out" 2>&1; then
     ok "validate.sh agrees: plugin/APM scope, structural checks pass"
   else
     err "validate.sh disagreed with new-agent.sh: did not treat the type-bearing apm.yml root as plugin scope"
-    sed 's/^/    /' /tmp/f4validate.out
+    sed 's/^/    /' "$RUN_TMP/f4validate.out"
   fi
   # source_keys + a matching sources.md round-trips only if validate-provenance.sh
   # resolves the SAME plugin root new-agent.sh/new-skill.sh did.
@@ -251,11 +263,11 @@ EOF
 - **Research doc:** (none)
 - **Status:** \`extracted\`
 EOF
-  if bash "$VALIDATE_PROVENANCE" "$F4_ROOT/.apm/agents/$NAME4.agent.md" >/tmp/f4prov.out 2>&1; then
+  if bash "$VALIDATE_PROVENANCE" "$F4_ROOT/.apm/agents/$NAME4.agent.md" >"$RUN_TMP/f4prov.out" 2>&1; then
     ok "validate-provenance.sh agrees: resolves the same plugin root, sources.md round-trips"
   else
     err "validate-provenance.sh disagreed on the plugin root for the type-bearing apm.yml fixture"
-    sed 's/^/    /' /tmp/f4prov.out
+    sed 's/^/    /' "$RUN_TMP/f4prov.out"
   fi
 fi
 
@@ -280,11 +292,11 @@ else
   else
     fill_agent_pair "$F5_ROOT/.claude/agents/$NAME5.md" "$NAME5"
     fill_agent_pair "$F5_ROOT/.github/agents/$NAME5.agent.md" "$NAME5"
-    if env HOME="$F5_UNRELATED_HOME" bash "$VALIDATE" "$F5_ROOT/.claude/agents/$NAME5.md" >/tmp/f5.out 2>&1; then
+    if env HOME="$F5_UNRELATED_HOME" bash "$VALIDATE" "$F5_ROOT/.claude/agents/$NAME5.md" >"$RUN_TMP/f5.out" 2>&1; then
       ok "validate.sh agrees: filesystem-boundary fallback resolves to project scope"
     else
       err "validate.sh disagreed with new-agent.sh on the filesystem-boundary fallback fixture"
-      sed 's/^/    /' /tmp/f5.out
+      sed 's/^/    /' "$RUN_TMP/f5.out"
     fi
   fi
 fi
@@ -325,12 +337,12 @@ EOF
   # No sources.md exists anywhere under $F6_HOME or at the ancestor package
   # root — if find_plugin_root walked past $HOME to the ancestor apm.yml,
   # this would FAIL on Check 0 (source_keys declared but sources.md absent).
-  if env HOME="$F6_HOME" bash "$VALIDATE_PROVENANCE" "$F6_HOME/.apm/agents/probe-prov.agent.md" >/tmp/f6.out 2>&1 \
-    && [[ -z "$(cat /tmp/f6.out)" ]]; then
+  if env HOME="$F6_HOME" bash "$VALIDATE_PROVENANCE" "$F6_HOME/.apm/agents/probe-prov.agent.md" >"$RUN_TMP/f6.out" 2>&1 \
+    && [[ -z "$(cat "$RUN_TMP/f6.out")" ]]; then
     ok "validate-provenance.sh agrees: \$HOME boundary stops the walk, exits 0 silently (not plugin scope)"
   else
     err "validate-provenance.sh walked past \$HOME to the ancestor apm.yml — disagrees with new-agent.sh"
-    sed 's/^/    /' /tmp/f6.out
+    sed 's/^/    /' "$RUN_TMP/f6.out"
   fi
 fi
 

scripts/check-vale-style-sync.sh

@@ -71,6 +71,13 @@ for ini in "$SKILL_INI" "$AGENT_INI"; do
     err "$rel_ini is missing — without it vale falls back to an upward config search and lints with whatever it finds"
     continue
   fi
+  # Present but unreadable is its own case: every assertion below is a grep, and
+  # grep exits 2 on a read error. The override capture swallows that into an
+  # empty result, which would read as "no findings" rather than "not checked".
+  if [[ ! -r "$ini" ]]; then
+    err "$rel_ini is not readable — none of its assertions could run, and an unreadable file cannot be distinguished from a clean one downstream"
+    continue
+  fi
   # StylesPath is resolved relative to the .vale.ini, which is the only reason
   # the bundled styles are found from a consuming repo's clone prefix.
   if ! grep -Eq '^[[:space:]]*StylesPath[[:space:]]*=[[:space:]]*styles[[:space:]]*$' "$ini"; then
@@ -81,8 +88,71 @@ for ini in "$SKILL_INI" "$AGENT_INI"; do
   if ! grep -Eq '^[[:space:]]*BasedOnStyles[[:space:]]*=.*Kyberforge([[:space:],]|$)' "$ini"; then
     err "$rel_ini has no section whose BasedOnStyles names Kyberforge — every rule the audit prefilters on lives in that style"
   fi
+  # Per-rule overrides are the third way to retire a rule without touching a
+  # style file or a glob. CONTEXT.md's "Vale audit prefilter" entry: "Every rule
+  # is `level: error` and every alert is a FAIL — no ignorable tier". Vale's exit
+  # code keys on `error` alerts alone, so any override that leaves a rule at
+  # anything other than `error` still lints the file, still exits 0, and still
+  # shows `Passed` in pre-commit. The glob probe below cannot backstop this: it
+  # keys on one `Kyberforge.VagueWording` alert, so DescriptionOpener,
+  # PaddingPhrase, SentenceOpenerThereIs and ProactivePhrase can each be retired
+  # underneath a passing probe.
+  #
+  # Asserted as an ALLOWLIST, not a blocklist of `NO|warning|suggestion`, because
+  # that is vale 3.15.2's own semantic: only the exact tokens `YES` and `error`
+  # keep a rule blocking. `warning`/`suggestion` downgrade it (alert still
+  # printed, exit 0 — invisible, since pre-commit swallows a passing hook's
+  # output); every other value — `NO`, `false`, `0`, `off`, `n`, empty,
+  # `garbage`, and lowercase `yes`, `true`, `1`, `on` — silences the rule
+  # outright. Lowercase `yes` is the trap a blocklist cannot cover: it reads as
+  # "enabled" to a human and disables the rule. Verified by enumerating the
+  # value space against vale 3.15.2.
+  #
+  # The allowlist demands a BARE `YES`/`error` with nothing after it, which also
+  # rejects `error # note` and `error ; note`. Vale itself strips those — a
+  # whitespace-preceded `#` or `;` comment is removed and the rule stays live —
+  # so rejecting them is deliberately stricter than vale, not a workaround for
+  # it. Uniformity is worth more here than the ability to annotate a line that
+  # should not exist: no shipped `.vale.ini` has any override line at all, and
+  # the failure mode is a loud false positive rather than a silent pass. The
+  # genuine hazard is the no-space form — `error# note` and `error; note` are
+  # NOT stripped and silence the rule outright — and a rule that demands a bare
+  # token catches those without having to reimplement vale's comment parsing.
+  #
+  # `[A-Za-z0-9_-]` on both halves of the name, not `[A-Za-z]`: a rule named
+  # `Kyberforge.Vague2` is genuinely silenced by `= NO` (verified: 1 error ->
+  # 0 errors), so an alpha-only class would let a digit-bearing rule name slip
+  # past the gate. All five current rule names are pure alpha, so this is
+  # forward cover, not a live hole.
+  bad_overrides="$(
+    grep -E '^[[:space:]]*Kyberforge[A-Za-z0-9_-]*\.[A-Za-z0-9_-]+[[:space:]]*=' "$ini" \
+      | grep -Ev '^[[:space:]]*Kyberforge[A-Za-z0-9_-]*\.[A-Za-z0-9_-]+[[:space:]]*=[[:space:]]*(YES|error)[[:space:]]*$' \
+      || true
+  )"
+  # No `grep -q` in that pipeline on purpose: `-q` exits on its first match, and
+  # under `set -o pipefail` the resulting SIGPIPE on the upstream grep would make
+  # the whole pipeline report 141 and read as "no findings".
+  if [[ -n "$bad_overrides" ]]; then
+    err "$rel_ini overrides a Kyberforge rule to something other than a bare YES or error (first: '${bad_overrides%%$'\n'*}') — every rule in this prefilter is level: error and every alert is a FAIL, and any other value downgrades or silences the rule while vale still exits 0. A trailing comment is rejected too: vale strips a spaced '# ...' but not 'error# ...', so this asks for the bare token rather than guessing which form you meant"
+  fi
 done
 
+# KyberforgeCopilot is agent-audit's alone — CONTEXT.md describes it as "scoped
+# only to `.agent.md` files for the Copilot-only 'Use proactively has no effect'
+# check". The loop above deliberately asserts only `Kyberforge`, since
+# skill-audit's copy legitimately has no Copilot style, so dropping
+# `, KyberforgeCopilot` from agent-audit's `[**/*.agent.md]` section unloaded the
+# whole style silently: no glob broke, the styles/ diff above stayed clean (the
+# style directory is still shipped, just never loaded), the two .vale.ini files
+# are deliberately unequal so no equality check applies, and the probe below
+# still passed because it keys on a Kyberforge alert. Assert the style is loaded
+# whenever it is shipped.
+if [[ -d "$AGENT_AUDIT/assets/vale/styles/KyberforgeCopilot" && -f "$AGENT_INI" ]]; then
+  if ! grep -Eq '^[[:space:]]*BasedOnStyles[[:space:]]*=.*KyberforgeCopilot([[:space:],]|$)' "$AGENT_INI"; then
+    err "${AGENT_INI#"$REPO_ROOT"/} ships a styles/KyberforgeCopilot style but no section's BasedOnStyles names it — the style is never loaded, so its Copilot-only rules lint nothing"
+  fi
+fi
+
 # Prints the `files:` regex of every hook, in ONE manifest ($2), whose entry
 # is $1's vale-wrap.sh. Records are delimited by their `- id:` line, so the
 # check does not depend on `entry:` preceding `files:` within a record.
@@ -227,10 +297,24 @@ while IFS='|' read -r skill rel scope; do
 # shape — per ADR-0016 every `.apm/agents/*` file is named `*.agent.md`, so
 # `.pre-commit-config.yaml`'s regex correctly no longer matches it and that's
 # not drift. `demo.agent.md` is the real, current shape and is `shared`.
+#
+# The two `.claude/`-prefixed probes carry the location-independence CONTEXT.md
+# asserts: "A `SKILL.md` outside `plugins/` (e.g. project-scope
+# `.claude/skills/foo/SKILL.md`) still matches `[**/SKILL.md]` and gets linted
+# normally — the globs constrain filename shape, not location." Every other
+# probe here starts with `plugins/`, so narrowing a glob to a `plugins/`-shaped
+# path (`[**/SKILL.md]` -> `[**/.apm/skills/*/SKILL.md]`) left all of them
+# matching while the project-scope shape started linting as `0 errors ... in 0
+# files` — the exact "vale lints zero files, hook shows Passed" failure the
+# comment at the top of this section describes. Both are `hooks-only`: only
+# `.pre-commit-hooks.yaml` is layout-agnostic, and `.pre-commit-config.yaml`
+# pinning this repo's own `plugins/**/.apm/` layout is by design, not drift.
 done <<'EOF_PROBE'
 skill-audit|plugins/demo/.apm/skills/demo/SKILL.md|shared
+skill-audit|.claude/skills/demo/SKILL.md|hooks-only
 agent-audit|plugins/demo/.apm/agents/demo.md|hooks-only
 agent-audit|plugins/demo/.apm/agents/demo.agent.md|shared
+agent-audit|.claude/agents/demo.md|hooks-only
 agent-audit|copilot/demo.agent.md|hooks-only
 EOF_PROBE
 

scripts/sync-marketplace-mirror.sh

@@ -29,6 +29,20 @@ fi
 [[ $# -eq 0 ]] || usage
 
 if [[ ! -f "$SRC" ]]; then
+  # A missing source with a surviving mirror is drift, not absence: the mirror
+  # can only be stale (nothing is left for it to be byte-identical to), which is
+  # precisely the silent divergence this script exists to prevent. Exiting 0
+  # here would report "no drift" over a mirror of a file that no longer exists,
+  # and would also swallow the case where REPO_ROOT resolved to the wrong tree —
+  # `git rev-parse --show-toplevel` falls back to `pwd` outside a worktree.
+  # scripts/sync-plugin-content.sh --check --all already errors on the same
+  # condition ("requires .../marketplace.json"); this matches it.
+  # Neither file present stays a genuine no-op: nothing to mirror, nothing stale.
+  if [[ "$CHECK" -eq 1 && -f "$DST" ]]; then
+    echo "DRIFT $DST: mirror exists but .claude-plugin/marketplace.json does not" >&2
+    echo "Fix: restore .claude-plugin/marketplace.json (apm's compiled Claude marketplace output), or delete $DST" >&2
+    exit 1
+  fi
   exit 0
 fi