fix(kyberforge): apply audit findings to agent-author skill

- Fix Copilot format conflation: split CLI vs cloud/IDE in Step 3,
  clean copilot template to CLI-only fields, add body length limit (30k)
- Add missing CC fields to Step 2: disallowedTools, skills, color,
  initialPrompt, background
- Fix Gotchas: add WaitForMcpServers to unavailable tools list,
  add ExitPlanMode plan-mode carve-out
- Make 'Use proactively' conditional (was unconditional directive)
- Clarify audit invocation to 'Invoke kyberforge:agent-audit skill directly'
- Add 'Would the agent get this wrong?' heuristic to Improve Step 4
- Add agent-audit co-install prerequisite check
- Add pre-audit manual checklist to validate/close step
- Add references/scripts.md for new-agent.sh conventions
- Fix sources.md: remove template/script files from Contributing files
  (templates can't carry YAML provenance without leaking into user files),
  add 3 missing research slugs with (none) contributing files
- Add context7-github-en-copilot to deployment-modes.md source_keys
- Update README.md and references/README.md with new scripts.md entry

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0147vXtL5sP6vorDdqXGJJU9
This commit is contained in:
2026-07-04 11:11:11 +00:00
parent 8463c87dfc
commit 4ea9e21ead
8 changed files with 142 additions and 36 deletions

View File

@@ -0,0 +1,42 @@
---
source_keys: []
---
# Scripts Reference
Conventions for `scripts/new-agent.sh` and any future scripts in this skill.
## Contract
All scripts in this skill must follow these rules:
- **No interactive prompts** — agents run non-interactive; blocking on TTY input hangs indefinitely. Accept all input via positional arguments, flags, or environment variables.
- **Structured output** — file paths and status messages to stderr; nothing to stdout unless a downstream tool needs to consume it.
- **Idempotent** — "create if not exists" per file. The scaffold script skips any file that already exists; agents may safely re-run it.
- **Meaningful exit codes** — `0` success, `1` invalid arguments or precondition failure. Document in `--help`.
- **Self-contained** — no external package installs at runtime. The script uses only bash builtins and POSIX tools (`sed`, `mkdir`, `cat`).
## Template variables
The scaffold script uses `sed "s/AGENT_NAME/$AGENT_NAME/g"` to substitute the agent name into templates. Template files must use `AGENT_NAME` (all caps, no delimiters) as the substitution token.
Do not add additional substitution tokens unless you update both the template files and the script in the same edit pass.
## File placement
The script creates files at paths determined by scope detection (plugin / project / user). Scope is detected from the presence of `plugin.json` or `.claude-plugin/plugin.json` in the root directory. If scope detection logic changes, update the `new-agent.sh` usage comment and `SKILL.md` Step 1 scope detection table in the same pass.
## Error messages
On failure, state: what went wrong, what was expected, what to try. Example:
```
Error: agent-name must use lowercase letters, numbers, and hyphens only.
No leading, trailing, or consecutive hyphens.
Received: 'My_Agent'
```
Vague errors leave agents unable to self-correct.
## --help output
Keep `--help` concise — it may enter the agent's context window. Include: usage line, argument descriptions with scope detection table, exit codes. Omit prose explanations.