diff --git a/core/AGENTS.md b/core/AGENTS.md index 2c3bffd..2e47854 100644 --- a/core/AGENTS.md +++ b/core/AGENTS.md @@ -22,6 +22,4 @@ Read these files on demand: - **Coding conventions** (`~/.claude/core/instructions/coding.md`) — when writing, editing, or reviewing code -- **Git conventions** (`~/.claude/core/instructions/git.md`) — when doing git operations - **Testing conventions** (`~/.claude/core/instructions/testing.md`) — when writing or running tests -- **Git Commit conventions** (`~/.claude/core/instructions/commits.md`) — when committing changes diff --git a/core/instructions/commits.md b/core/instructions/commits.md deleted file mode 100644 index 522a539..0000000 --- a/core/instructions/commits.md +++ /dev/null @@ -1,78 +0,0 @@ - - -## Why - - -## Implementation Notes - - -## Impact - - ---- -# References - - -Fixes: -Refs: -ADR: -RFC: -Design: -Co-authored-by: -Reviewed-by: -Signed-off-by: -BREAKING CHANGE: diff --git a/core/instructions/git.md b/core/instructions/git.md deleted file mode 100644 index 4087d4f..0000000 --- a/core/instructions/git.md +++ /dev/null @@ -1,16 +0,0 @@ -# Git conventions - -- Never skip hooks with `--no-verify`. Hooks are the automated QA gate; bypassing them breaks the pipeline. -- Never force-push `main` or `master`. -- Keep commits atomic. Each commit should represent one logical, independently reviewable and reversible change. -- Ensure every commit leaves the repository in a working state (buildable/testable where practical). -- Commit messages explain **why**, not **what**. The diff already documents what changed. -- Never commit secrets, credentials, or environment-specific config. -- Use Conventional Commits (`feat:`, `fix:`, `docs:`, `chore:`, `refactor:`, `test:`, etc.). -- Reference related issues, ADRs or design documents using Git trailers when applicable. - -## Submodules - -- When working with submodules: commit and push the submodule first, then update and push the parent repo. Pushing the parent while the submodule commit doesn't exist on the remote breaks `git submodule update` for anyone who pulls. -- Always use `rtk git` for parent repo operations; drop into the submodule directory for submodule-specific git commands. -- After adding a submodule, check `git status` in both the parent and the submodule — a `-dirty` flag means the submodule has uncommitted local changes that need to be committed before the parent pointer is updated. diff --git a/tests/test-instructions-and-docs.sh b/tests/test-instructions-and-docs.sh index 141359c..160d5ee 100755 --- a/tests/test-instructions-and-docs.sh +++ b/tests/test-instructions-and-docs.sh @@ -94,38 +94,6 @@ contains "[Aa]bstraction" "$CODING" \ echo "" -# ─── 0006: core/instructions/git.md ────────────────────────────────────────── - -echo "--- 0006: git.md ---" - -GIT="$REPO_ROOT/core/instructions/git.md" - -[[ -f "$GIT" ]] \ - && pass "git.md exists" \ - || fail "git.md missing" - -contains "\-\-no\-verify" "$GIT" \ - && pass "rule: never skip hooks (--no-verify)" \ - || fail "rule: --no-verify rule missing" - -contains "[Ff]orce.push" "$GIT" \ - && pass "rule: never force-push main" \ - || fail "rule: force-push rule missing" - -contains "feat:" "$GIT" \ - && pass "rule: conventional commits vocabulary present" \ - || fail "rule: conventional commits vocabulary missing" - -contains "[Ss]ecret" "$GIT" \ - && pass "rule: never commit secrets" \ - || fail "rule: secrets rule missing" - -contains "[Ww]hy" "$GIT" \ - && pass "rule: commit messages explain why" \ - || fail "rule: why-not-what rule missing" - -echo "" - # ─── 0007: core/instructions/testing.md ────────────────────────────────────── echo "--- 0007: testing.md ---"