From 5fdeada27aace8649a9859057ecf3dcca0bd3606 Mon Sep 17 00:00:00 2001 From: Defame1297 Date: Sat, 27 Jun 2026 09:33:24 +0000 Subject: [PATCH] fix(skill-author): resolve audit findings from post-#8 review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove implementation-focused sentence from description (was not user-intent language per agentskills.io spec) - Move source_keys template comment under metadata: block to match Step 5's instruction; contradicted agents scaffolding before reading Step 5 - Add Step 6 to new-skill.sh next-steps (populate references/sources.md); renumber validate step to 7 — script was missing the sources step entirely Co-Authored-By: Claude Sonnet 4.6 --- plugins/kyberforge/skills/skill-author/SKILL.md | 3 +-- .../skills/skill-author/assets/templates/SKILL.md | 11 ++++------- .../skills/skill-author/scripts/new-skill.sh | 3 ++- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/plugins/kyberforge/skills/skill-author/SKILL.md b/plugins/kyberforge/skills/skill-author/SKILL.md index 5a3c7b3..5f2c9bf 100644 --- a/plugins/kyberforge/skills/skill-author/SKILL.md +++ b/plugins/kyberforge/skills/skill-author/SKILL.md @@ -7,8 +7,7 @@ description: > audit findings", "update based on grill output"). Also use when the user provides inline feedback about a skill's behavior and wants it applied, or when a grill session, eval run, or audit has produced findings the user wants - acted on — even if they don't say "improve" explicitly. Authors and refines - skills following the agentskills.io specification. Do not use for read-only review — use + acted on — even if they don't say "improve" explicitly. Do not use for read-only review — use /skill-audit instead. Do not use to author agent definition files. allowed-tools: Bash Read Write Edit metadata: diff --git a/plugins/kyberforge/skills/skill-author/assets/templates/SKILL.md b/plugins/kyberforge/skills/skill-author/assets/templates/SKILL.md index 7ce4455..a9a3f12 100644 --- a/plugins/kyberforge/skills/skill-author/assets/templates/SKILL.md +++ b/plugins/kyberforge/skills/skill-author/assets/templates/SKILL.md @@ -28,14 +28,11 @@ description: > # author: your-name # version: "1.0" # category: general +# source_keys: +# - source-slug-one +# - source-slug-two # Optional. Arbitrary key-value map. Common keys: author, version, category. -# No restrictions on keys or values. - -# source_keys: -# - source-slug-one -# - source-slug-two -# Optional. Populated when this skill was built from /research output. -# Lists slugs from references/sources.md that informed this file. +# source_keys: populated when built from /research output. Lists slugs from references/sources.md. # Also add source_keys to each references/*.md file that was informed by research. # allowed-tools: Bash Read Write diff --git a/plugins/kyberforge/skills/skill-author/scripts/new-skill.sh b/plugins/kyberforge/skills/skill-author/scripts/new-skill.sh index 95dda0f..da52d64 100755 --- a/plugins/kyberforge/skills/skill-author/scripts/new-skill.sh +++ b/plugins/kyberforge/skills/skill-author/scripts/new-skill.sh @@ -85,4 +85,5 @@ echo " 2. Add scripts to scripts/ if needed (or delete the directory)" >&2 echo " 3. Add docs to references/ if needed (or delete the directory)" >&2 echo " 4. Add resources to assets/ if needed (or delete the directory)" >&2 echo " 5. Add tests to tests/ if the skill has scripts (or delete the directory)" >&2 -echo " 6. Validate: run /skill-audit on $TARGET" >&2 +echo " 6. Populate references/sources.md with research sources, or delete it" >&2 +echo " 7. Validate: run /skill-audit on $TARGET" >&2