refactor(kyberforge)!: merge skill-audit and agent-audit into factory-audit

Why

The two audit skills carried 1,724 lines of byte-identical duplication: the ADR-0020 boundary
resolver (1,061), vale-wrap.sh (526), the Vale style rules (44) and the Contributing-files parser
(93). Nothing shared them — they were held in sync by a 413-line pre-push gate and its 797-line
test suite. Sync-by-gate had already failed once: at 484357a the two parser copies drifted into
different spellings of the bullet loop while a docstring asserted they were identical. That drift
was behaviour-neutral and was re-unified by hand at 598a7c3, so the copies were identical at merge
time — but nothing had caught it, and the next drift need not be neutral.

Implementation Notes

Self-containment binds BETWEEN skills, not within one. The agentskills.io spec forbids reaching
across skill directories, which is why two separate skills needed embedded copies; two files inside
ONE skill may source a third. That is the whole reason the merge removes duplication rather than
relocating it.

The union of both bodies measured 1,532 words against BODY_MAX_WORDS=900, and only 211 of those
words were shared, so SKILL.md is a dispatch body. Step 0 resolves the flow from the target path
before any validation, and its table mirrors validate.sh's detection exactly: a directory holding
SKILL.md or a SKILL.md file (skill); a *.agent.md, or a .md directly under an agents/ directory
(agent); anything else stops without running a validator. Steps 1-3 live in
references/skill-flow.md and references/agent-flow.md, and gotchas that apply to one flow live in
that flow's file, since it is loaded on every invocation anyway. If validate.sh reports on the
other artifact type, the body restarts at Step 0.

Named factory-audit rather than forge-audit because forge is a live skill, and a family prefix that
matches a live sibling reads as ownership rather than membership.

The description carries one arrow per boundary target, because ADR-0020 resolves only the first
target after an arrow. It drops the quoted "audit this skill"-style phrases, which restated
"audited" in a second register (ADR-0020's duplicate-register rule). 241 characters, Gotchas 16%
of the body: no size SUGGESTIONs.

The boundary resolver stays embedded in two files rather than imported: a cache-installed plugin
cannot read outside its own directory, and the repo-root hook resolves via .pre-commit-hooks.yaml
where entry[0] is the only token pre-commit rewrites, so no single file is reachable by both.
tests/test-adr0020-contract.sh hashes both copies for byte-identity, and asserts validate.sh sources
the resolver and that no third copy exists.

The entry scripts classify the target from its resolved parent directory, so a bare agent filename
typed inside agents/ works; resolve SCRIPT_DIR CDPATH-safely; and exit 2 when a lib-*.sh is
missing, rather than dying with exit 1, the tier the flows relay as real findings.

The provenance run functions stash their findings code in KYBERFORGE_PROV_RC and
return 0, so validate-provenance.sh calls them UNTESTED. Testing a function's
status (`f || RC=$?`) disables errexit for its entire body, and no subshell or
`set -e` inside can re-arm it once the call sits in a condition context
(measured, both spellings). Their error paths use `exit`, which is unaffected
either way; this keeps errexit armed for anything added later.

Case 0's readability guard reads the file instead of asking `[[ -r ]]`. `-r` is
access(2), which answers yes for uid 0 even on a mode-000 file, and this repo's
dev environment is root -- so the guard could never fire where it exists to fire.
A read attempt is also the stricter question, catching EIO. This is the reasoning
scripts/check-vale-style-sync.sh carried before this commit deleted it; the
hazard did not go with it.

All three entry scripts are CDPATH-safe, vale-wrap.sh included: both of its cd sites are cleared,
the --config resolution and the directory-mirror walk, where an exported CDPATH would otherwise
print a decoy path into the -print0 stream and build the mirror from the decoy's files. The two
remaining bare cd calls take absolute paths, which CDPATH is never consulted for.

Impact

BREAKING: skill-audit and agent-audit no longer exist as invocable skills. kyberforge goes to
2.0.0 (catalog 0.4.7).

Check logic is unchanged: differential runs of the old and new validators across every skill and
agent produced byte-identical stdout, stderr and exit codes, and the reconstructed Python payloads
differ only in comments and the references/field-inventory.md -> agent-field-inventory.md rename.
One doctrine governs the tiers: exit 0 is audited and clean, exit 1 is audited with findings OR a
target present but unreadable, exit 2 is that nothing was audited at all. Edge paths DID change,
deliberately (full table in ADR-0025):
- a missing target exits 2 (never ran), not 1, under its own "does not exist" message; detection is
  by path shape, so a shape-matching path that is simply absent used to reach the validator and come
  back as a FAIL against a file that never existed;
- an unshaped target exits 2 under the generic "matches neither" message, and a directory with no
  SKILL.md under a third, distinct one -- three exit-2 messages, not one;
- a dangling symlink or a symlink loop stays exit 1: it is present but broken, which is a finding
  about the artifact rather than a usage error;
- a SKILL.md file path is audited as its skill directory instead of refused;
- a .md agent outside an agents/ directory is refused rather than audited;
- a missing script library, a missing python3, a missing PyYAML, and no argument at all each exit 2.
  validate-provenance.sh already exited 2 for the last two; validate.sh now matches it.

.pre-commit-hooks.yaml is a published contract consumed by external repos. Both hook IDs and both
files: regexes are unchanged; only entry: and description: moved.

scripts/check-vale-style-sync.sh (413), scripts/sync-vale-styles.sh (21),
tests/test-check-vale-style-sync.sh (797) and agent-audit/scripts/README.md (47) are deleted. The
checker made 17 assertions: 6 compared the two Vale copies and are moot; 10 are rehomed into
tests/test-vale-wrap.sh (case 0, cases 28-31, and the suite's Vale-absent skip); and the
cross-manifest files: agreement check, which selected hooks by entry: and so could not survive both
hooks sharing one, is ported as case 33 pairing hooks by id:. Cases 28, 30 and 33 carry mutation
self-tests; narrowing the local skill prefilter to 6 of 38 SKILL.md files now fails the suite.

Skills go 39 to 38. Pre-push goes 9 repo-authored hooks to 8.

ADR: 0025
BREAKING-CHANGE: the skill-audit and agent-audit skills are removed. Both flows are served by
  factory-audit, which auto-detects whether it was handed a skill directory or an agent file.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YR2CjVumUbEGWcMikcoXBD

docs/adr/0020-skill-description-and-body-context-contract.md

@@ -8,6 +8,23 @@ gates that hold them.
 
 **Status: accepted (2026-08-14).**
 
+**Amended by ADR-0025 (2026-09-15).** The contract, the tiers and every verdict rule below stand
+unchanged. What moved is the **number and location of the scripts that carry them**. This ADR names
+three: `scripts/skill-size-check.sh`, `skill-audit/scripts/validate.sh` and
+`agent-audit/scripts/validate.sh` — "all three validators" (Decision), "all three scripts"
+(Enforcement table footnote), "`scripts/skill-size-check.sh` and its two mirrored copies"
+(the `_add()` amendment). ADR-0025 merged the two audit skills, so there are now **two**: the root
+`scripts/skill-size-check.sh`, which still embeds the 1,061-line block between `BEGIN`/`END ADR-0020
+SHARED BOUNDARY RESOLVER` markers, and one plugin copy — extracted out of the merged validator into
+`plugins/kyberforge/.apm/skills/factory-audit/scripts/lib-boundary-resolver.sh` and sourced by
+`factory-audit`'s `validate.sh` and `validate-provenance.sh` rather than pasted into each. The
+Enforcement table's "constants mirrored in `skill-audit/scripts/validate.sh` and
+`agent-audit/scripts/validate.sh`" is one path now, `factory-audit/scripts/validate.sh`, which
+auto-detects the artifact type; the skills/agents columns are unaffected, since the merged validator
+applies the body tiers on the skill path only. The two copies must still stay byte-identical — a
+plugin script cannot source the root one, which is why a second copy exists at all. Read every
+"three" below as the count at the time of writing.
+
 ## Context
 
 Every `file:line` citation in this ADR is against the base commit the decision was taken on,
@@ -189,7 +206,8 @@ Agents take the same description gates — they are preloaded identically — an
 A skill body is loaded into the caller's context, competing with the live conversation; an agent body
 becomes the system prompt of a fresh context. The rationale for the 900-word FAIL does not transfer.
 
-That exemption is expressed in `agent-audit/scripts/validate.sh`, which has no body constant, and in
+That exemption is expressed in `agent-audit/scripts/validate.sh` (now `factory-audit`'s
+auto-detecting `validate.sh` on its agent path, see ADR-0025), which has no body constant, and in
 the `files:` pattern of the `skill-size-check` pre-commit hook, which is `SKILL.md`-only. It is *not*
 expressed in `scripts/skill-size-check.sh` itself, which measures whatever path it is handed —
 running it directly over `plugins/*/.apm/agents/*.agent.md` exits 1 with 900-word body FAILs on
@@ -201,7 +219,8 @@ file pattern, not by the script knowing the difference. Anyone widening that pat
 would silently enforce a gate this ADR declines to set.
 
 A plugin-scope agent is a single file with no sibling `references/` directory, so it cannot disclose
-to itself — it can only delegate to skills. `agent-audit` therefore gains a **delegation check**: an
+to itself — it can only delegate to skills. `agent-audit` (now `factory-audit`'s agent flow, see
+ADR-0025) therefore gains a **delegation check**: an
 agent body that restates a procedure owned by a skill it can invoke is a FAIL, with the fix being
 "invoke `<skill>` instead". Length falls out of delegation rather than being gated directly.
 
@@ -232,18 +251,20 @@ type of input they take should be **one skill with a dispatch table**. This catc
 one-or-two-file agent pair, per ADR-0005 and ADR-0016) and their overlap is in the improve flow
 rather than the core job.
 
-**DEFERRED — not implemented in the change that carries this ADR. Tracked as issue #101.** Both
-skills still exist separately, and this change made the split deeper rather than shallower: retrofit
+**DEFERRED when this ADR was written — not implemented in the change that carries it. Tracked as
+issue #101. IMPLEMENTED by ADR-0025 (2026-09-15), which merged the pair into `factory-audit` with a
+Step 0 dispatch and closed the deferral.** At the time of writing both
+skills still existed separately, and this change made the split deeper rather than shallower: retrofit
 to the dispatch pattern took `skill-audit` from 3 reference files to 7 and `agent-audit` from 4 to 8,
 and their two same-named `references/description-quality.md` files now differ on 100 of ~120 lines
 after normalising `skill`/`agent`, where before they were closer. It has kept deepening since: the
 #99 retrofit added `finding-criteria.md` to `skill-audit`, drawing it level with `agent-audit`. Both
 figures move with the next retrofit, so measure rather than quote —
-`ls plugins/kyberforge/.apm/skills/<name>/references/ | grep -c '\.md$'`. The merge stays the
+`ls plugins/kyberforge/.apm/skills/factory-audit/references/ | grep -c '\.md$'`. The merge stayed the
 decision; it reopens ADR-0008 (agent-audit's single-file invocation contract) and touches every call
-site in `skill-author`, `agent-author` and `forge`, which is why it is its own change and not a rider
-on this one. Recorded here rather than dropped, so the gap between the rule and the tree is deliberate
-and dated instead of discovered later.
+site in `skill-author`, `agent-author` and `forge`, which is why it was its own change and not a rider
+on this one. Recorded here rather than dropped, so the gap between the rule and the tree was deliberate
+and dated instead of discovered later — and ADR-0025 is where it was closed.
 
 ### Enforcement and rollout
 
@@ -266,7 +287,7 @@ which tier each rule is in, because the failure this ADR is most exposed to is a
 | description opener, composition notes in a description | skills, agents | prose pattern | `plugins/kyberforge/.apm/skills/*/assets/vale/styles/Kyberforge/` |
 | a Gotcha paraphrasing a body step | skills | **auditor judgment** | `references/body-discipline.md` |
 | dispatch at two or more mutually exclusive flows | skills | **auditor judgment** | `references/body-discipline.md` |
-| delegation: an agent body restating a skill's procedure | agents | **auditor judgment** | `agent-audit` |
+| delegation: an agent body restating a skill's procedure | agents | **auditor judgment** | `agent-audit` (now `factory-audit`'s agent flow, see ADR-0025) |
 | capability enumeration, restatement, trigger quality | skills, agents | **auditor judgment** | `references/description-quality.md` |
 
 The rows in bold are stated as FAILs in the Decision above and are FAILs an *auditor* issues. None of
@@ -399,16 +420,18 @@ over the same 39 files now reports 0 errors, 0 warnings and 0 suggestions, so
 independent of `skill-size-check`, so a new description can reintroduce it; `skill-size-check` does
 not cover the Vale half, and no `references/` file is linted by anything (`docs/spec/gates.md` has
 both causes, issue #117 tracks them). Re-derive rather than quote —*
-`bash plugins/kyberforge/.apm/skills/skill-audit/scripts/vale-wrap.sh plugins/*/.apm/skills/*/SKILL.md`.
+`bash plugins/kyberforge/.apm/skills/factory-audit/scripts/vale-wrap.sh plugins/*/.apm/skills/*/SKILL.md`
+*(path re-pointed by ADR-0025; the `skill-audit` copy this ADR originally named no longer exists).*
 
 **A ceiling does not produce an average.** If every author writes to the 400-character FAIL, the
 preload lands at 39 × 400 = 15,600 chars — a 33% cut off 23,427, not the ~50% intended. Writing to
 the 250-character SUGGESTION instead lands at 9,750, a 58% cut. The halving depends entirely on the
 250-character SUGGESTION tier being visible and respected. That tier works here in a way it does not
-elsewhere in this repo: `skill-audit` already reports `PASS (N suggestions)` as a first-class
+elsewhere in this repo: `skill-audit` (now `factory-audit`'s skill flow, see ADR-0025) already
+reports `PASS (N suggestions)` as a first-class
 outcome. This is explicitly **not** the failure ADR-0013 records — Vale warnings are invisible
-because vale's exit code keys on `error` alone, but these gates live in `validate.sh` and
-`skill-audit`, where a SUGGESTION reaches the report. Realistic landing is somewhere in that 33-58%
+because vale's exit code keys on `error` alone, but these gates live in `validate.sh` and the
+audit skill itself, where a SUGGESTION reaches the report. Realistic landing is somewhere in that 33-58%
 band, not a guaranteed 50%.
 
 **A word gate cannot detect the defect it is standing in for.** `git-commits` carries twelve Gotchas