refactor(kyberforge)!: merge skill-audit and agent-audit into factory-audit

Why

The two audit skills carried 1,724 lines of byte-identical duplication: the ADR-0020 boundary
resolver (1,061), vale-wrap.sh (526), the Vale style rules (44) and the Contributing-files parser
(93). Nothing shared them — they were held in sync by a 413-line pre-push gate and its 797-line
test suite. Sync-by-gate had already failed once: at 484357a the two parser copies drifted into
different spellings of the bullet loop while a docstring asserted they were identical. That drift
was behaviour-neutral and was re-unified by hand at 598a7c3, so the copies were identical at merge
time — but nothing had caught it, and the next drift need not be neutral.

Implementation Notes

Self-containment binds BETWEEN skills, not within one. The agentskills.io spec forbids reaching
across skill directories, which is why two separate skills needed embedded copies; two files inside
ONE skill may source a third. That is the whole reason the merge removes duplication rather than
relocating it.

The union of both bodies measured 1,532 words against BODY_MAX_WORDS=900, and only 211 of those
words were shared, so SKILL.md is a dispatch body. Step 0 resolves the flow from the target path
before any validation, and its table mirrors validate.sh's detection exactly: a directory holding
SKILL.md or a SKILL.md file (skill); a *.agent.md, or a .md directly under an agents/ directory
(agent); anything else stops without running a validator. Steps 1-3 live in
references/skill-flow.md and references/agent-flow.md, and gotchas that apply to one flow live in
that flow's file, since it is loaded on every invocation anyway. If validate.sh reports on the
other artifact type, the body restarts at Step 0.

Named factory-audit rather than forge-audit because forge is a live skill, and a family prefix that
matches a live sibling reads as ownership rather than membership.

The description carries one arrow per boundary target, because ADR-0020 resolves only the first
target after an arrow. It drops the quoted "audit this skill"-style phrases, which restated
"audited" in a second register (ADR-0020's duplicate-register rule). 241 characters, Gotchas 16%
of the body: no size SUGGESTIONs.

The boundary resolver stays embedded in two files rather than imported: a cache-installed plugin
cannot read outside its own directory, and the repo-root hook resolves via .pre-commit-hooks.yaml
where entry[0] is the only token pre-commit rewrites, so no single file is reachable by both.
tests/test-adr0020-contract.sh hashes both copies for byte-identity, and asserts validate.sh sources
the resolver and that no third copy exists.

The entry scripts classify the target from its resolved parent directory, so a bare agent filename
typed inside agents/ works; resolve SCRIPT_DIR CDPATH-safely; and exit 2 when a lib-*.sh is
missing, rather than dying with exit 1, the tier the flows relay as real findings.

The provenance run functions stash their findings code in KYBERFORGE_PROV_RC and
return 0, so validate-provenance.sh calls them UNTESTED. Testing a function's
status (`f || RC=$?`) disables errexit for its entire body, and no subshell or
`set -e` inside can re-arm it once the call sits in a condition context
(measured, both spellings). Their error paths use `exit`, which is unaffected
either way; this keeps errexit armed for anything added later.

Case 0's readability guard reads the file instead of asking `[[ -r ]]`. `-r` is
access(2), which answers yes for uid 0 even on a mode-000 file, and this repo's
dev environment is root -- so the guard could never fire where it exists to fire.
A read attempt is also the stricter question, catching EIO. This is the reasoning
scripts/check-vale-style-sync.sh carried before this commit deleted it; the
hazard did not go with it.

All three entry scripts are CDPATH-safe, vale-wrap.sh included: both of its cd sites are cleared,
the --config resolution and the directory-mirror walk, where an exported CDPATH would otherwise
print a decoy path into the -print0 stream and build the mirror from the decoy's files. The two
remaining bare cd calls take absolute paths, which CDPATH is never consulted for.

Impact

BREAKING: skill-audit and agent-audit no longer exist as invocable skills. kyberforge goes to
2.0.0 (catalog 0.4.7).

Check logic is unchanged: differential runs of the old and new validators across every skill and
agent produced byte-identical stdout, stderr and exit codes, and the reconstructed Python payloads
differ only in comments and the references/field-inventory.md -> agent-field-inventory.md rename.
One doctrine governs the tiers: exit 0 is audited and clean, exit 1 is audited with findings OR a
target present but unreadable, exit 2 is that nothing was audited at all. Edge paths DID change,
deliberately (full table in ADR-0025):
- a missing target exits 2 (never ran), not 1, under its own "does not exist" message; detection is
  by path shape, so a shape-matching path that is simply absent used to reach the validator and come
  back as a FAIL against a file that never existed;
- an unshaped target exits 2 under the generic "matches neither" message, and a directory with no
  SKILL.md under a third, distinct one -- three exit-2 messages, not one;
- a dangling symlink or a symlink loop stays exit 1: it is present but broken, which is a finding
  about the artifact rather than a usage error;
- a SKILL.md file path is audited as its skill directory instead of refused;
- a .md agent outside an agents/ directory is refused rather than audited;
- a missing script library, a missing python3, a missing PyYAML, and no argument at all each exit 2.
  validate-provenance.sh already exited 2 for the last two; validate.sh now matches it.

.pre-commit-hooks.yaml is a published contract consumed by external repos. Both hook IDs and both
files: regexes are unchanged; only entry: and description: moved.

scripts/check-vale-style-sync.sh (413), scripts/sync-vale-styles.sh (21),
tests/test-check-vale-style-sync.sh (797) and agent-audit/scripts/README.md (47) are deleted. The
checker made 17 assertions: 6 compared the two Vale copies and are moot; 10 are rehomed into
tests/test-vale-wrap.sh (case 0, cases 28-31, and the suite's Vale-absent skip); and the
cross-manifest files: agreement check, which selected hooks by entry: and so could not survive both
hooks sharing one, is ported as case 33 pairing hooks by id:. Cases 28, 30 and 33 carry mutation
self-tests; narrowing the local skill prefilter to 6 of 38 SKILL.md files now fails the suite.

Skills go 39 to 38. Pre-push goes 9 repo-authored hooks to 8.

ADR: 0025
BREAKING-CHANGE: the skill-audit and agent-audit skills are removed. Both flows are served by
  factory-audit, which auto-detects whether it was handed a skill directory or an agent file.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YR2CjVumUbEGWcMikcoXBD

plugins/kyberforge/.apm/skills/skill-author/SKILL.md

@@ -3,7 +3,7 @@ name: skill-author
 description: >
   Use when the user wants to create a new skill from scratch, or apply audit
   findings, grill output, eval results, or inline feedback to an existing one.
-  Not read-only review -> `skill-audit`. Not agent files -> `agent-author`.
+  Not read-only review -> `factory-audit`. Not agent files -> `agent-author`.
 allowed-tools: Bash Read Write Edit
 metadata:
   version: "1.0.2"
@@ -21,7 +21,7 @@ metadata:
 ## Gotchas
 
 - The word gates are two measurements, not two tiers of one rule: the 2,770-word / 500-line spec backstop counts the whole file, Step 3's gate the body alone. Never unify them.
-- Never spawn a subagent to audit or recheck your own work — run `/skill-audit` inline, in the same context as the edits. Clean-context recheck belongs to `/forge`'s outer loop, and a self-spawned subagent's worktree can be torn down by concurrent cleanup, destroying an uncommitted draft.
+- Never spawn a subagent to audit or recheck your own work — run `/factory-audit` inline, in the same context as the edits. Clean-context recheck belongs to `/forge`'s outer loop, and a self-spawned subagent's worktree can be torn down by concurrent cleanup, destroying an uncommitted draft.
 - Do not create new scripts unless a signal explicitly calls for it. Writing one from scratch requires out-of-scope transcript analysis — flag the opportunity as a suggestion instead.
 
 ## Step 1 — Dispatch
@@ -32,7 +32,7 @@ metadata:
 | Directory exists, at least one improvement signal present | Improve | `references/improve.md` |
 | Directory exists, no signals | Stop and ask | — |
 
-Signals: grill output, `/skill-audit` findings, inline feedback, eval results, session context describing what went wrong. With none, ask whether the user meant to create a new skill or has feedback to apply.
+Signals: grill output, `/factory-audit` findings, inline feedback, eval results, session context describing what went wrong. With none, ask whether the user meant to create a new skill or has feedback to apply.
 
 Read only the reference matching the resolved flow — each is self-contained. If the target sits inside a git worktree, capture `rtk git log --oneline -1` before touching the filesystem; Step 4 needs it.
 
@@ -47,7 +47,7 @@ Decide before writing any description: model-invoked or hand-invoked?
 
 Before writing or editing a description, or restructuring a body, read `references/contract.md` — the banned-content list, boundary form, include/exclude rubric and body patterns.
 
-Gates `/skill-audit` enforces in both flows:
+Gates `/factory-audit` enforces in both flows:
 
 - **Description** — a trigger clause, at most one capability clause, and a boundary clause shaped `Not <thing> -> <skill-name>` whose target resolves to a real skill or agent. 250 characters SUGGESTION, 400 FAIL, value only.
 - **Body** — decision procedure only: ordered steps, branches, gates, and which reference to load when. 600 words SUGGESTION, 900 FAIL, body only. At two or more mutually exclusive flows a dispatch table is mandatory and each flow gets its own self-contained `references/` file.
@@ -55,7 +55,7 @@ Gates `/skill-audit` enforces in both flows:
 
 ## Step 4 — Validate and close
 
-Run `/skill-audit` on the resolved skill directory; resolve every FAIL before reporting done. It checks name-to-directory match, placeholders, both size budgets, boundary-target resolution and script hygiene — do not hand-check those. Hand-check the one thing it misses: an empty body reports `PASS  SKILL.md body word count 0 (ADR-0020 target: 600)`, so confirm at least one non-empty section exists.
+Run `/factory-audit` on the resolved skill directory; resolve every FAIL before reporting done. It checks name-to-directory match, placeholders, both size budgets, boundary-target resolution and script hygiene — do not hand-check those. Hand-check the one thing it misses: an empty body reports `PASS  SKILL.md body word count 0 (ADR-0020 target: 600)`, so confirm at least one non-empty section exists.
 
 Bump `metadata.version`: the **minor** version on create (new skills start at `0.1.0`) and the **patch** version on improve.
 

plugins/kyberforge/.apm/skills/skill-author/references/contract.md

@@ -7,7 +7,7 @@ source_keys:
 
 # The description and body contract
 
-House contract. Every rule here is enforced by `/skill-audit` —
+House contract. Every rule here is enforced by `/factory-audit` —
 `scripts/validate.sh` for the counts and the boundary targets, the bundled Vale styles for the
 prose patterns, and its reference files for the judgment calls.
 
@@ -146,7 +146,7 @@ row's target exists on disk; each row pairs exactly one target with a condition
 evaluate from the request, never a literal slash invocation; one line after the table names the
 matched file as the only one to read; and the gates every branch needs sit in the body, not inside
 one flow's file. That last one is the property the `git-commits` v0.1.2 failure turned on, and it is
-the one a dispatch split is most likely to break. `skill-audit`'s `references/body-discipline.md`
+the one a dispatch split is most likely to break. `factory-audit`'s `references/skill-body-discipline.md`
 carries the audit-side form of the same exemption; the two lists are the same four properties, and
 an edit to either belongs in both.
 

plugins/kyberforge/.apm/skills/skill-author/references/create.md

@@ -28,8 +28,8 @@ Before touching the filesystem, verify you have:
 
 If any are missing, stop and ask the user before proceeding.
 
-**Requires `/skill-audit`** — used in `SKILL.md` Step 4 for final validation. Both skills ship in
-the kyberforge plugin and are co-installed. If `/skill-audit` is unavailable, stop and ask the
+**Requires `/factory-audit`** — used in `SKILL.md` Step 4 for final validation. Both skills ship in
+the kyberforge plugin and are co-installed. If `/factory-audit` is unavailable, stop and ask the
 user to install the kyberforge plugin before continuing.
 
 ## Package-intent gate
@@ -175,7 +175,7 @@ If a research `sources.md` is present in the conversation context:
    `- **Research doc:** <path>` where `<path>` is the relative path from the repo root to the
    plugin-level research sources file this entry was drawn from (e.g.
    `plugins/myplugin/docs/research/docs/<topic>/sources.md`). This field is required on every
-   entry — it makes the provenance chain explicit and is validated by `/skill-audit`.
+   entry — it makes the provenance chain explicit and is validated by `/factory-audit`.
 4. Add `source_keys` to the frontmatter of `SKILL.md` (under `metadata`) listing the slugs of
    sources that informed it.
 5. For each file in `references/` that was informed by research sources, add `source_keys`

plugins/kyberforge/.apm/skills/skill-author/references/deployment-modes.md

@@ -44,7 +44,7 @@ Use `${CLAUDE_PLUGIN_ROOT}` only in hook commands and `.mcp.json` configs — no
 
 ## Standalone mode
 
-Deployed directly to `~/.agents/skills/<name>/`. No plugin context, no env vars injected. All file references must resolve within the skill directory. Skill invocations (e.g. `/skill-audit`) work if the called skill is also installed.
+Deployed directly to `~/.agents/skills/<name>/`. No plugin context, no env vars injected. All file references must resolve within the skill directory. Skill invocations (e.g. `/factory-audit`) work if the called skill is also installed.
 
 ## Cross-tool portability
 

plugins/kyberforge/.apm/skills/skill-author/references/improve.md

@@ -16,12 +16,12 @@ Confirm the skill directory path exists and that at least one improvement signal
 conversation or a referenced file.
 
 If the skill directory is missing, ask for it. If no signals are present, stop: "This skill applies
-existing signals to a skill. For a blind review without signals, use `/skill-audit` instead."
+existing signals to a skill. For a blind review without signals, use `/factory-audit` instead."
 
 Signals can come from anywhere in the conversation or referenced files:
 
 - Grill session output (most common predecessor in the factory sequence)
-- `/skill-audit` findings (PASS/FAIL/SUGGESTION punch list)
+- `/factory-audit` findings (PASS/FAIL/SUGGESTION punch list)
 - Human feedback (feedback.json, inline in conversation, PR or issue comments)
 - Session context describing what went wrong
 

plugins/kyberforge/.apm/skills/skill-author/scripts/new-skill.sh

@@ -186,4 +186,4 @@ echo "  3. Add docs to references/ if needed (or delete the directory)" >&2
 echo "  4. Add resources to assets/ if needed (or delete the directory)" >&2
 echo "  5. Add tests to tests/ if the skill has scripts (or delete the directory)" >&2
 echo "  6. Populate references/sources.md with research sources, or delete it" >&2
-echo "  7. Validate: run /skill-audit on $TARGET" >&2
+echo "  7. Validate: run /factory-audit on $TARGET" >&2

plugins/kyberforge/.apm/skills/skill-author/tests/new-skill.bats

@@ -60,9 +60,9 @@ teardown() {
     assert [ -d "$DEST/my-tool-2" ]
 }
 
-@test "next-steps output references /skill-audit not validate.sh" {
+@test "next-steps output references /factory-audit not validate.sh" {
     run bash "$SCRIPT" my-tool "$DEST"
-    assert_output --partial "/skill-audit"
+    assert_output --partial "/factory-audit"
     refute_output --partial "validate.sh"
 }