From 92ba9abe7cf00075aa47ded065b71ed6aa3ad2d1 Mon Sep 17 00:00:00 2001 From: Defame1297 Date: Sun, 30 Aug 2026 17:45:56 +0000 Subject: [PATCH] fix(diagnose): restore skill-root-relative script path 00c1e6b (the ADR-0020 retrofit of diagnose) moved a bullet referencing scripts/hitl-loop.template.sh out of SKILL.md and into the new references/feedback-loops.md, and in the move flipped the correct skill-root-relative path into an incorrect parent-relative one (../scripts/...) -- despite that commit's own message claiming to fix "a script path that did not resolve." References in this skill are written relative to the skill root regardless of which file carries them, matching the convention used throughout SKILL.md. Found via an independent post-closure audit of issue #99; validated clean via skill-audit afterward. Refs #99 --- plugins/bin/.apm/skills/diagnose/references/feedback-loops.md | 2 +- plugins/bin/skills/diagnose/references/feedback-loops.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/bin/.apm/skills/diagnose/references/feedback-loops.md b/plugins/bin/.apm/skills/diagnose/references/feedback-loops.md index 899c95a..d3d83c2 100644 --- a/plugins/bin/.apm/skills/diagnose/references/feedback-loops.md +++ b/plugins/bin/.apm/skills/diagnose/references/feedback-loops.md @@ -13,7 +13,7 @@ A feedback loop is a fast, deterministic, agent-runnable pass/fail signal for th 7. **Property / fuzz loop.** If the bug is "sometimes wrong output", run 1000 random inputs and look for the failure mode. 8. **Bisection harness.** If the bug appeared between two known states (commit, dataset, version), automate "boot at state X, check, repeat" so you can `git bisect run` it. 9. **Differential loop.** Run the same input through old-version vs new-version (or two configs) and diff outputs. -10. **HITL bash script.** Last resort. If a human must click, drive _them_ with `../scripts/hitl-loop.template.sh` so the loop is still structured. Captured output feeds back to you. +10. **HITL bash script.** Last resort. If a human must click, drive _them_ with `scripts/hitl-loop.template.sh` so the loop is still structured. Captured output feeds back to you. ## Iterate on the loop itself diff --git a/plugins/bin/skills/diagnose/references/feedback-loops.md b/plugins/bin/skills/diagnose/references/feedback-loops.md index 899c95a..d3d83c2 100644 --- a/plugins/bin/skills/diagnose/references/feedback-loops.md +++ b/plugins/bin/skills/diagnose/references/feedback-loops.md @@ -13,7 +13,7 @@ A feedback loop is a fast, deterministic, agent-runnable pass/fail signal for th 7. **Property / fuzz loop.** If the bug is "sometimes wrong output", run 1000 random inputs and look for the failure mode. 8. **Bisection harness.** If the bug appeared between two known states (commit, dataset, version), automate "boot at state X, check, repeat" so you can `git bisect run` it. 9. **Differential loop.** Run the same input through old-version vs new-version (or two configs) and diff outputs. -10. **HITL bash script.** Last resort. If a human must click, drive _them_ with `../scripts/hitl-loop.template.sh` so the loop is still structured. Captured output feeds back to you. +10. **HITL bash script.** Last resort. If a human must click, drive _them_ with `scripts/hitl-loop.template.sh` so the loop is still structured. Captured output feeds back to you. ## Iterate on the loop itself