fix(lint): correct four Vale behaviours the skills described wrongly
Each of these would send a user down a path Vale does not support: Core options placed under a glob header are not scoped to that glob — Vale rejects them with E201, so the guidance to nest them produced a config that will not load. The built-in `Vale` style is compiled in, but Vale still requires StylesPath to exist on disk before it will run, so the "no StylesPath needed" shortcut fails. The MDX guidance was inverted: under `[formats] mdx = md` the mapping is what makes MDX lint at all, and it needs the mdx2vast prerequisite that was never mentioned. And a spelling rule's `ignore` paths resolve against StylesPath, not against the rule file's own directory, so the documented relative paths silently matched nothing.
This commit is contained in:
@@ -6,16 +6,17 @@ description: >
|
||||
as in "lint the docs", "check prose style", or "why is CI failing on the docs
|
||||
check". Not setting up Vale config or styles -> `vale-config`.
|
||||
metadata:
|
||||
version: "0.1.2"
|
||||
version: "0.1.3"
|
||||
category: lint
|
||||
source_keys:
|
||||
- context7-websites-vale-sh
|
||||
- house-vale-3-15-2-repro
|
||||
---
|
||||
|
||||
## Gotchas
|
||||
|
||||
- Vale's exit code keys off `error`-level alerts only — `warning` and `suggestion` alerts print and still exit `0`, and `MinAlertLevel`/`--minAlertLevel` filter what is displayed, never the exit code — no flag makes warnings fail. A rule that must gate CI or a commit hook has to be `level: error`. This is the most common way a Vale gate silently passes everything.
|
||||
- Check whether the target repo documents its own `vale` wrapper script (README, CONTRIBUTING, pre-commit config, `scripts/`) before calling the binary. Some projects wrap `vale` to work around real bugs — e.g. a scope that silently stops matching multi-line YAML block-scalar frontmatter — so bare `vale` skips whatever the wrapper fixes. Invoke the documented wrapper with the same arguments.
|
||||
- Check whether the target repo documents its own `vale` wrapper script (README, CONTRIBUTING, pre-commit config, `scripts/`) before calling the binary. Some projects wrap `vale` to work around real bugs — e.g. a `text.frontmatter.<key>` scope that silently stops matching multi-line values (`>` folded scalars, plain continuation lines and quoted multi-line scalars all go unmatched; a `|` literal block scalar still works) — so bare `vale` skips whatever the wrapper fixes. Invoke the documented wrapper with the same arguments.
|
||||
|
||||
## Running vale
|
||||
|
||||
@@ -34,20 +35,22 @@ Key flags:
|
||||
| `--no-exit` | Suppresses the nonzero exit that `error`-level alerts would otherwise cause; a no-op when no rule is `error`-level. Use in CI stages that should surface lint output without hard-failing the build. |
|
||||
| `--ignore-syntax` | Treats input as plain text, skipping format-aware parsing — use when a file's syntax-aware parser produces noisy or wrong results. |
|
||||
|
||||
`vale sync` downloads the packages/styles declared in `.vale.ini` — that's a one-time-per-change setup step (vale-config's territory), not part of a normal lint run. If a run behaves as though no styles are active, check `vale ls-config` to confirm what actually loaded before concluding it is a sync problem — an unrun `vale sync` is the usual cause, and not a `vale-run` problem.
|
||||
`vale sync` downloads the packages/styles declared in `.vale.ini` — that's a one-time-per-change setup step (vale-config's territory), not part of a normal lint run. If a run behaves as though no styles are active, check `vale ls-config` before concluding it is a sync problem — an unrun `vale sync` is the usual cause, and not a `vale-run` problem. `ls-config` resolves config files, styles and `StylesPath` search paths; it never enumerates rules, so it cannot tell you a given rule is live.
|
||||
|
||||
Prefer `--output=JSON` whenever the caller (a script, a CI step, another agent) needs to act on individual alerts rather than just get a pass/fail signal — `CLI` and `line` are for humans reading the terminal.
|
||||
|
||||
## Fixing false positives
|
||||
|
||||
Before writing any inline suppression markup (steps 2 and 3 below), read `references/troubleshooting.md` for your file's format: the markup is format-specific, and the wrong form suppresses nothing while Vale reports no error — the Markdown HTML-comment form is inert in an MDX file.
|
||||
Before writing any inline suppression markup (steps 2 and 3 below), read `references/troubleshooting.md`: the form follows the parser the config picks, not the file extension, and the wrong form suppresses nothing while Vale reports no error.
|
||||
|
||||
`.mdx` is the trap — the two parsers take opposite forms, so read `.vale.ini` first. Under `[formats] mdx = md` (what `vale-config` recommends) it is Markdown: `<!-- vale off -->` suppresses, `{/* vale off */}` does not. Without that mapping Vale takes the native MDX path, which needs the external `mdx2vast` binary (`npm install -g mdx2vast`); missing, the whole invocation dies — `E100 [lintMDX] ... mdx2vast not found`, exit 2 — leaving every other file in the run unlinted too.
|
||||
|
||||
Scope the fix as narrowly as possible, in this order:
|
||||
|
||||
1. **Mentioning banned phrasing rather than using it**: wrap it in backticks or a fenced code block. Vale skips code spans and fences, so no suppression is needed at all. Try this before any suppression markup.
|
||||
2. **One-off**: inline-suppress the specific text run with the format's `vale off`/`vale on` markup.
|
||||
3. **Recurring known-exception string, one rule**: disable that specific rule for that specific match inline (in Markdown, e.g. `<!-- vale Style.Redundancy["ACT test","OTHER"] = NO -->` ... `= YES`), rather than the whole rule.
|
||||
4. **Known project term failing spell check**: add it to the style's `ignore` list, not an inline suppression.
|
||||
4. **Known project term failing spell check**: add it to the style's `ignore` list, not an inline suppression — and put the listed file at the `StylesPath` root, because an `ignore` path that resolves nowhere is a silent no-op (`references/troubleshooting.md`).
|
||||
|
||||
Never disable a rule project-wide to fix one false positive — editing `.vale.ini`/`BasedOnStyles` is vale-config's job, and it silences the rule everywhere, not just the false-positive case.
|
||||
|
||||
|
||||
@@ -7,3 +7,11 @@
|
||||
- **Research doc:** plugins/lint/docs/research/docs/vale/sources.md
|
||||
- **Contributing files:** SKILL.md, references/troubleshooting.md
|
||||
- **Status:** `extracted`
|
||||
|
||||
## house-vale-3-15-2-repro
|
||||
|
||||
- **URL:** (house-verified — reproduced locally against the `vale` binary, not an external source)
|
||||
- **Description:** Behaviour of Vale 3.15.2 established by running it against purpose-built fixtures in this repo, where vale.sh documents nothing or documents it wrongly: `.mdx` has no built-in support and needs either `[formats] mdx = md` or an external `mdx2vast` binary (absent, the whole invocation exits 2 with `E100 [lintMDX]`), the inline-suppression form inverts between those two configurations, the `spelling` check's `ignore` paths resolve against `StylesPath` or the working directory but never against the rule file's own directory and fail silently when they resolve nowhere, `ls-config` reports styles and paths but never rules, and the `text.frontmatter.<key>` scope matrix across multi-line YAML forms.
|
||||
- **Research doc:** none — house-verified reproduction, not part of the plugin's research corpus (no `plugins/lint/docs/research/` topic file backs this entry)
|
||||
- **Contributing files:** SKILL.md, references/troubleshooting.md
|
||||
- **Status:** `extracted`
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
---
|
||||
source_keys:
|
||||
- context7-websites-vale-sh
|
||||
- house-vale-3-15-2-repro
|
||||
---
|
||||
|
||||
# Vale troubleshooting reference
|
||||
@@ -9,19 +10,68 @@ source_keys:
|
||||
|
||||
`vale ls-config` prints the fully-resolved, currently active configuration as JSON. Check that
|
||||
before rereading `.vale.ini` — what is written in the config file is not necessarily what is
|
||||
active, and the resolved output is the fastest way to see which styles and rules a run actually
|
||||
loaded.
|
||||
active, and the resolved output is the fastest way to see which config files, styles and
|
||||
`StylesPath` directories a run actually loaded.
|
||||
|
||||
It stops at styles. It does not enumerate rules, and neither does any other Vale 3.15.2
|
||||
subcommand — `ls-config`, `ls-dirs`, `ls-vars` and `ls-metrics` were each checked and none
|
||||
names the rule. Against a config
|
||||
whose custom rule was demonstrably firing on the target file, `ls-config` reported
|
||||
`"SBaseStyles": {"*.md": ["MyStyle"]}` and the two `StylesPath` search paths, but
|
||||
`"Checks": null`, `"SChecks": {"*.md": {}}` and `"RuleToLevel": {}` — the firing rule's own name
|
||||
appeared nowhere in the output. So `ls-config` answers "is this style loaded, and from where",
|
||||
not "is this rule live". For the latter, run Vale over a small fixture that should trigger the
|
||||
rule and see whether it alerts.
|
||||
|
||||
## Inline suppression syntax by format
|
||||
|
||||
Markdown uses HTML comments — the MDX `{/* */}` form does not suppress anything in a plain `.md` file:
|
||||
### Prerequisite: `.mdx` needs a decision before it lints at all
|
||||
|
||||
Vale 3.15.2 has no built-in MDX support. If `.vale.ini` does **not** map the extension, Vale takes
|
||||
the native MDX path and shells out to an external `mdx2vast` binary. Without it on `PATH` the run
|
||||
dies before linting anything:
|
||||
|
||||
```
|
||||
$ vale . # doc.md and doc.mdx both present, no [formats] mapping
|
||||
E100 [lintMDX] Runtime error
|
||||
|
||||
mdx2vast not found
|
||||
|
||||
Execution stopped with code 1.
|
||||
$ echo $?
|
||||
2
|
||||
```
|
||||
|
||||
That is the whole invocation, not just the `.mdx` file — the `.md` alongside it produced no output
|
||||
either. Fix it one of two ways, and the choice is not cosmetic because it also decides the
|
||||
suppression syntax:
|
||||
|
||||
| `.vale.ini` | Prerequisite | Parser | Suppression form that works |
|
||||
|---|---|---|---|
|
||||
| `[formats]` maps `mdx = md` (what `vale-config` recommends) | none | Markdown | `<!-- vale off -->` |
|
||||
| no `mdx` mapping (native MDX) | `npm install -g mdx2vast` | MDX | `{/* vale off */}` |
|
||||
|
||||
Key the markup to that config row, never to the file extension. Verified against Vale 3.15.2, same
|
||||
three fixtures under each config:
|
||||
|
||||
| File | Mapped `mdx = md` | Native MDX (`mdx2vast` installed) |
|
||||
|---|---|---|
|
||||
| no suppression (control) | alert, exit 1 | alert, exit 1 |
|
||||
| `<!-- vale off -->` | suppressed, exit 0 | `E100 ... failed to parse MDX: Unexpected character` `` `!` ``, exit 2 |
|
||||
| `{/* vale off */}` | **not suppressed**, exit 1 | suppressed, exit 0 |
|
||||
|
||||
Under the mapping the JSX comment is worse than inert: it is linted as prose, so
|
||||
`{/* vale Vale.Repetition = NO */}` produced three alerts where the un-suppressed file produced
|
||||
one — its own markup tripped the rule twice more.
|
||||
|
||||
Markdown, and `.mdx` mapped onto it — HTML comments:
|
||||
```markdown
|
||||
<!-- vale off -->
|
||||
This text will be ignored.
|
||||
<!-- vale on -->
|
||||
```
|
||||
|
||||
MDX:
|
||||
Native MDX only (no `[formats]` mapping, `mdx2vast` on `PATH`):
|
||||
```mdx
|
||||
{/* vale off */}
|
||||
This text will be ignored.
|
||||
@@ -46,7 +96,8 @@ This is some text ACT test
|
||||
<!-- vale Style.Redundancy["ACT test","OTHER"] = YES -->
|
||||
```
|
||||
|
||||
MDX:
|
||||
Native MDX only — under `[formats] mdx = md` an `.mdx` file takes the Markdown form above, and
|
||||
this one silences nothing:
|
||||
```mdx
|
||||
{/* vale Style.Redundancy["ACT test","OTHER"] = NO */}
|
||||
This is some text ACT test
|
||||
@@ -66,6 +117,36 @@ ignore:
|
||||
- ignore2.txt
|
||||
```
|
||||
|
||||
**Where the file goes, and why a wrong answer is invisible.** Each entry resolves against the
|
||||
`StylesPath` root, or against the working directory `vale` is invoked from. It does **not** resolve
|
||||
against the rule file's own directory — which is the natural reading of the YAML above, since the
|
||||
path sits inside the rule, and it is wrong. Verified against Vale 3.15.2 across four fresh trees,
|
||||
each with the same rule and the same unknown word:
|
||||
|
||||
| Where `ignore1.txt` was placed | Result |
|
||||
|---|---|
|
||||
| `<StylesPath>/ignore1.txt` | word ignored, exit 0 |
|
||||
| `./ignore1.txt` in the directory `vale` runs from | word ignored, exit 0 |
|
||||
| `<StylesPath>/<Style>/ignore1.txt`, beside the rule | word still flagged, exit 1 |
|
||||
| file absent entirely | word still flagged, exit 1 |
|
||||
|
||||
The two failing rows emit no warning, no error, and no diagnostic of any kind: the output is
|
||||
byte-identical to the same rule with the `ignore` key deleted. A misplaced ignore list looks exactly
|
||||
like a list that was read and did not contain the word.
|
||||
|
||||
Prefer the `StylesPath` root. The run-directory form is the fragile one — move the invocation and it
|
||||
silently stops working. Same tree, same file, only the working directory changed:
|
||||
|
||||
```
|
||||
$ cd project && vale doc.md # ignore1.txt at project root
|
||||
✔ 0 errors, 0 warnings and 0 suggestions in 1 file. # exit 0
|
||||
|
||||
$ cd /elsewhere && vale --config=project/.vale.ini project/doc.md
|
||||
1:5 error Did you really mean 'zzqwidget'? MyStyle.Spell # exit 1
|
||||
```
|
||||
|
||||
The `StylesPath` copy survives that move; the run-directory copy does not.
|
||||
|
||||
## Plain-text fallback
|
||||
|
||||
If a file's syntax-aware parsing produces noisy or incorrect results (an unsupported or malformed format), rerun with `--ignore-syntax` to treat it as plain text instead of relying on the format-specific parser.
|
||||
|
||||
Reference in New Issue
Block a user