Defame1297/holocron
0
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

docs: issue 0016 — skill implementation workflow grill

Browse Source 
Produces docs/notes/skill-implementation-workflow.md with agreed conventions
for all Chunk 3 skill issues (0017–0028). Key decisions:

- Per-skill process: source discovery (sub-agent) → source review with
  licence/security check (sub-agent) → conflict check vs constitution +
  factory principles (sub-agent) → synthesis grill → co-write iteratively
- Bootstrap: write-eval (hand-written) → write-skill (hand-written) →
  write-docs (first factory-authored, phase 2 of 0018) → everything else
- Upstream review changed from per-chunk-start to per-skill
- `when:` and `references:` frontmatter fields added to authoring standard
- Sub-agent usage prescribed as named steps in the workflow
- HITL: human reviewed and approved conventions

Updates: PRD implementation decisions; issues 0016–0028 with specific
acceptance criteria; docs/spec/overview.md; ROADMAP Chunk 3 housekeeping note
(bootstrap order, cadence, acceptance criteria status); CONTEXT.md Source field
(per-skill cadence, references: companion field); LESSONS.md with three patterns
from the grill session.

Post-grill additions (same session): Step 6 (session handoff) added to the
workflow; handoff section appended to issue 0016; handoff checklist item added
to Chunk 3 closure issue (0028).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Defame1297
2026-05-17 16:21:38 +00:00
parent a1f1f9ded8
commit c705a38809
19 changed files with 393 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
docs/issues/0017-factory-write-eval.md
View File

@@ -16,7 +16,7 @@ Build `write-eval` — the first factory meta-skill, bootstrapped with a hand-wr
- For this first issue: write-eval's own eval is hand-crafted (write-eval cannot produce its own eval before it exists)
- Origin: new skill; `source:` field populated only if upstream content is adopted (determine during implementation)
Process: upstream review → trigger description written and tested first → skill body → hand-write eval → behavioral test.
Process: follow `docs/notes/skill-implementation-workflow.md`. Bootstrap exception: steps 1–3 (source discovery, source review, conflict check) still apply; SKILL.md and eval.yaml are hand-written rather than factory-produced.
## Implementation notes
@@ -37,7 +37,14 @@ write-eval has no direct Pocock equivalent. Expect to synthesize from multiple u
- [ ] `install.sh` deploys `write-eval` to `~/.agents/skills/` (confirm idempotent re-run)
- [ ] **HITL:** human runs fresh-session behavioral test: invoke "write evals for this skill" and verify correct eval.yaml structure is produced
- [ ] **HITL:** human reviews hand-written eval.yaml for correctness before committing
- [ ] _(Further criteria to be refined after issue 0016 grill session)_
- [ ] Per-skill process followed: source discovery (sub-agent) → source review with licence/security check (sub-agent) → conflict check against constitution + factory principles (sub-agent) → synthesis grill → co-write iteratively
- [ ] Trigger description tested against explicit, implicit, and negative queries before body was written
- [ ] `when:` frontmatter field present
- [ ] `source:` field present only if upstream content adopted; absent if self-authored
- [ ] `references:` field present if external citations used; absent otherwise
- [ ] eval.yaml contains all 5 required test types: explicit trigger, implicit trigger, negative trigger, ≥2 deterministic output, ≥1 LLM-rubric quality
- [ ] Body ≤500 lines; XML tags used only if ≥3 logical sections and 500+ tokens
- [ ] `docs/spec/overview.md` updated to reflect `write-eval` deployed
## Blocked by