Defame1297/holocron
0
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

docs: issue 0016 — skill implementation workflow grill

Browse Source 
Produces docs/notes/skill-implementation-workflow.md with agreed conventions
for all Chunk 3 skill issues (0017–0028). Key decisions:

- Per-skill process: source discovery (sub-agent) → source review with
  licence/security check (sub-agent) → conflict check vs constitution +
  factory principles (sub-agent) → synthesis grill → co-write iteratively
- Bootstrap: write-eval (hand-written) → write-skill (hand-written) →
  write-docs (first factory-authored, phase 2 of 0018) → everything else
- Upstream review changed from per-chunk-start to per-skill
- `when:` and `references:` frontmatter fields added to authoring standard
- Sub-agent usage prescribed as named steps in the workflow
- HITL: human reviewed and approved conventions

Updates: PRD implementation decisions; issues 0016–0028 with specific
acceptance criteria; docs/spec/overview.md; ROADMAP Chunk 3 housekeeping note
(bootstrap order, cadence, acceptance criteria status); CONTEXT.md Source field
(per-skill cadence, references: companion field); LESSONS.md with three patterns
from the grill session.

Post-grill additions (same session): Step 6 (session handoff) added to the
workflow; handoff section appended to issue 0016; handoff checklist item added
to Chunk 3 closure issue (0028).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Defame1297
2026-05-17 16:21:38 +00:00
parent a1f1f9ded8
commit c705a38809
19 changed files with 393 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
docs/issues/0020-design-skills.md
View File

@@ -30,7 +30,7 @@ The 6 design phase skills. Four are refactors of existing Pocock placeholders; t
## Implementation notes
Follow the per-skill workflow defined in `docs/notes/skill-implementation-workflow.md` (produced by issue 0016).
Follow the per-skill workflow defined in `docs/notes/skill-implementation-workflow.md`.
**Known upstream sources to review for this category:**
- `mattpocock/skills` — original `grill-me`, `to-prd`, `to-issues`, `grill-with-docs` placeholders; review at current HEAD for improvements; record SHAs in `source:` for refactored skills
@@ -51,7 +51,14 @@ For new skills (`architecture-review`, `grill-lean`): search for prior art in th
- [ ] `install.sh` deploys all 6 to `~/.agents/skills/`
- [ ] **HITL:** human runs behavioral test per skill; output meets constraints
- [ ] **HITL:** human reviews each SKILL.md and eval before committing
- [ ] _(Further criteria to be refined after issue 0016 grill session)_
- [ ] Per-skill process followed for all 6 skills: source discovery (sub-agent) → source review with licence/security check (sub-agent) → conflict check against constitution + factory principles (sub-agent) → synthesis grill → co-write iteratively
- [ ] Trigger description for each skill tested against explicit, implicit, and negative queries before body written
- [ ] `when:` frontmatter field present in all SKILL.md files
- [ ] `source:` fields populated for all refactored Pocock skills; `references:` present if external citations used
- [ ] eval.yaml for each skill contains all 5 required test types
- [ ] Body ≤500 lines for each skill
- [ ] Conflict check run against constitution before synthesis grill; no unresolved HITL or data classification violations
- [ ] `docs/spec/overview.md` updated to reflect all 6 skills deployed
## Blocked by