From dd73e1548a7e7bca62bafd68afc36024510c5a69 Mon Sep 17 00:00:00 2001 From: Defame1297 Date: Sat, 27 Jun 2026 09:53:42 +0000 Subject: [PATCH] fix(skills): resolve audit findings in skill-audit and skill-author skill-audit description understated its coverage by omitting three audit dimensions (patterns, scripts, provenance); README carried the same stale list. skill-author had an unconditional reference trigger that should be conditional on whether a script is being added. Co-Authored-By: Claude Sonnet 4.6 --- plugins/kyberforge/skills/skill-audit/README.md | 2 +- plugins/kyberforge/skills/skill-audit/SKILL.md | 5 +++-- plugins/kyberforge/skills/skill-author/SKILL.md | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/plugins/kyberforge/skills/skill-audit/README.md b/plugins/kyberforge/skills/skill-audit/README.md index 740a638..83d0876 100644 --- a/plugins/kyberforge/skills/skill-audit/README.md +++ b/plugins/kyberforge/skills/skill-audit/README.md @@ -1,6 +1,6 @@ # skill-audit -Audit a skill directory against the agentskills.io specification. Runs structural validation then a qualitative review across description quality, body discipline, formatting, file structure, and internal consistency. +Audit a skill directory against the agentskills.io specification. Runs structural validation then a qualitative review across description quality, body discipline, patterns, formatting, file structure, scripts, and internal consistency, plus a provenance chain check. ## What it does diff --git a/plugins/kyberforge/skills/skill-audit/SKILL.md b/plugins/kyberforge/skills/skill-audit/SKILL.md index 5cc99a8..d6f3762 100644 --- a/plugins/kyberforge/skills/skill-audit/SKILL.md +++ b/plugins/kyberforge/skills/skill-audit/SKILL.md @@ -5,8 +5,9 @@ description: > "check if my skill follows best practices", "review my SKILL.md", or wants to know if a skill is ready to ship — even if they don't use the word "audit". Audits a skill directory against the agentskills.io specification — structural - checks plus qualitative review of description quality, body discipline, formatting, - file structure, and internal consistency. Produces a compact findings report + checks plus qualitative review of description quality, body discipline, patterns, + formatting, file structure, scripts, and internal consistency, plus a provenance + chain check. Produces a compact findings report (findings only, no PASS noise) with Why and Fix per finding, suitable for agent handoff to /skill-improve or human auditability. Do not use to fix application code bugs or perform general code review unrelated to skill quality. diff --git a/plugins/kyberforge/skills/skill-author/SKILL.md b/plugins/kyberforge/skills/skill-author/SKILL.md index 5f2c9bf..ee0bd99 100644 --- a/plugins/kyberforge/skills/skill-author/SKILL.md +++ b/plugins/kyberforge/skills/skill-author/SKILL.md @@ -167,7 +167,7 @@ Keep `SKILL.md` under 500 lines; 5,000 tokens is the recommended body budget. Wh Place executable scripts in `scripts/`. Critical rule: **no interactive prompts** — agents run non-interactive; blocking on TTY input hangs indefinitely. Accept all input via flags, env vars, or stdin. -Read `references/scripts.md` before writing any script — it covers the full contract: structured output, pinned versions, self-contained deps, idempotency, exit codes, dry-run, error messages, and output size limits. +If adding a script, read `references/scripts.md` first — it covers the full contract: structured output, pinned versions, self-contained deps, idempotency, exit codes, dry-run, error messages, and output size limits. If no scripts are needed, delete `scripts/README.md` and the `scripts/` directory.