From fc79acfa05ae7ee39620a64eb4018548e1ce3787 Mon Sep 17 00:00:00 2001 From: Defame1297 Date: Sun, 5 Jul 2026 12:46:05 +0000 Subject: [PATCH] fix(kyberforge): tighten skill-author checklist/phrasing/reference style Address round-2 independent-audit suggestions: single-item checklist misuse in the improve flow, inaccurate "before Step 1" phrasing, and an unbackticked cross-skill reference to kyberforge:forge. Refs #69, #71 --- plugins/kyberforge/skills/skill-author/SKILL.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/kyberforge/skills/skill-author/SKILL.md b/plugins/kyberforge/skills/skill-author/SKILL.md index c97f653..bc2f771 100644 --- a/plugins/kyberforge/skills/skill-author/SKILL.md +++ b/plugins/kyberforge/skills/skill-author/SKILL.md @@ -26,7 +26,7 @@ metadata: - Patching per symptom is the default failure mode. Three eval failures may all trace to one missing instruction — always identify the root cause before editing. - Do not create new scripts unless a signal explicitly calls for it. Writing scripts from scratch requires transcript analysis that is out of scope here; flag the opportunity as a suggestion instead. -- Never spawn a subagent to audit or recheck your own work during an authoring pass. Run `/skill-audit` yourself, inline, in the same context as the edits you just made. A *separate* independent recheck via a clean-context subagent is forge's outer-loop responsibility exclusively — delegating it inward here duplicates that layer and introduces a race: a stray self-spawned subagent can have its worktree torn down by concurrent cleanup, destroying an uncommitted draft before it was ever safe. +- Never spawn a subagent to audit or recheck your own work during an authoring pass. Run `/skill-audit` yourself, inline, in the same context as the edits you just made. A *separate* independent recheck via a clean-context subagent is the `kyberforge:forge` skill's outer-loop responsibility exclusively — delegating it inward here duplicates that layer and introduces a race: a stray self-spawned subagent can have its worktree torn down by concurrent cleanup, destroying an uncommitted draft before it was ever safe. ## Route @@ -234,7 +234,7 @@ Confirm the skill directory path exists and that at least one improvement signal If the skill dir is missing, ask for it. If no signals are present, stop: "This skill applies existing signals to a skill. For a blind review without signals, use `/skill-audit` instead." -- [ ] Capture `git log --oneline -1` now, before making any edits — Step 5 needs it to verify a real commit landed +Capture `git log --oneline -1` now, before making any edits — Step 5 needs it to verify a real commit landed. Signals can come from anywhere in the conversation or referenced files: - Grill session output (most common predecessor in the factory sequence) @@ -289,4 +289,4 @@ Run `/skill-audit` on the skill directory. Resolve any FAIL findings before cons If the skill is versioned (`metadata.version`), bump the **patch** version (e.g. `0.1.0` → `0.1.1`). -**Commit verification.** Capture `git log --oneline -1` before Step 1 and keep it. Once the audit is clean, run `git add` and `git commit` for the changed files — do not stop at staging. Then run `git log --oneline -1` again and confirm the hash changed from the one you captured at the start. A non-empty `git diff --stat` is not sufficient proof of completion: staged-but-uncommitted work isn't part of any commit and can be silently lost if the working tree is cleaned up before a commit lands. Only report the improvement as done once the hash has actually changed. +**Commit verification.** Capture `git log --oneline -1` at the start of Step 1 and keep it. Once the audit is clean, run `git add` and `git commit` for the changed files — do not stop at staging. Then run `git log --oneline -1` again and confirm the hash changed from the one you captured at the start. A non-empty `git diff --stat` is not sufficient proof of completion: staged-but-uncommitted work isn't part of any commit and can be silently lost if the working tree is cleaned up before a commit lands. Only report the improvement as done once the hash has actually changed.