From fe24f7d9001465996d5410b893afccc54426e553 Mon Sep 17 00:00:00 2001 From: Defame1297 Date: Sun, 5 Jul 2026 13:06:39 +0000 Subject: [PATCH] fix(kyberforge): close agent-author frontmatter-comment and audit-availability gaps Independent skill-audit found that agent-author's closing checklists never verified template comments were stripped from frontmatter (produces invalid YAML if left in), the Copilot field-exclusion checklist omitted two fields present in the authoritative list, and the improve flow had no agent-audit availability check unlike the create flow. --- plugins/kyberforge/skills/agent-author/SKILL.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/plugins/kyberforge/skills/agent-author/SKILL.md b/plugins/kyberforge/skills/agent-author/SKILL.md index dd77b24..967bbc9 100644 --- a/plugins/kyberforge/skills/agent-author/SKILL.md +++ b/plugins/kyberforge/skills/agent-author/SKILL.md @@ -181,14 +181,16 @@ Run this checklist before invoking the audit: - [ ] If plugin scope: no `hooks`, `mcpServers`, or `permissionMode` (silently ignored at plugin scope) - [ ] System prompt body present and non-empty - [ ] No `FILL IN:` placeholders remain +- [ ] No `` template comments remain in frontmatter **Copilot CLI file (`.agent.md`):** - [ ] File extension is `.agent.md` (not `.md`) - [ ] `name` field matches the filename stem (e.g. `name: my-agent` in `my-agent.agent.md`) - [ ] `description` field present -- [ ] No Claude Code-only fields (`maxTurns`, `isolation`, `memory`, `permissionMode`, `effort`) +- [ ] No Claude Code-only fields (`maxTurns`, `isolation`, `memory`, `permissionMode`, `effort`, `hooks`, `mcpServers`) - [ ] System prompt body present and non-empty - [ ] Body does not exceed 30,000 characters +- [ ] No `` template comments remain in frontmatter If the destination is inside a plugin directory, apply a **minor bump** to the `version` field in both `plugin.json` and `.claude-plugin/plugin.json` at the plugin root in the same edit pass (e.g. `1.0.4` → `1.1.0`). @@ -204,6 +206,8 @@ Confirm the agent files exist and at least one improvement signal is present in If no signals: "This skill applies existing signals to an agent. For a blind review, examine the files manually or run a grill session first." +Verify `kyberforge:agent-audit` is available — it ships with the kyberforge plugin and is co-installed with this skill. If unavailable, stop and tell the user to install the kyberforge plugin before continuing. + Capture `git log --oneline -1` now, before making any edits — Step 5 needs it to verify a real commit landed. **Partial state** — if one provider file exists but the other does not, scaffold the missing file first (run `bash scripts/new-agent.sh ` — the file-by-file no-op means only the missing file is created), then continue with the improve flow on both files.