From fe34daeed7df8cea89f33b6cfe2f36fa43380547 Mon Sep 17 00:00:00 2001 From: Defame1297 Date: Sat, 4 Jul 2026 11:29:20 +0000 Subject: [PATCH] fix(kyberforge): resolve agent-author audit findings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Corrects three FAIL findings from the skill-audit run: - Scope detection table in SKILL.md and references/scripts.md now lists all four plugin-marker variants the script actually checks (plugin.json, .claude-plugin/plugin.json, .plugin/plugin.json, .github/plugin/plugin.json) - assets/README.md copilot.agent.md description was wrong about field set; replaced with accurate CLI-format description noting excluded cloud/IDE fields and the Copilot tool aliases actually used. Also applies the SUGGESTION: moves the conditional reference (`If the destination is a plugin directory, read references/deployment-modes.md`) out of the ## Gotchas section body and into ## Route as a standalone line, immediately after ## Gotchas closes. INFO findings (source_keys frontmatter) were already present in both references/README.md and references/scripts.md — no change needed. Co-Authored-By: Claude Sonnet 4.6 Claude-Session: https://claude.ai/code/session_0147vXtL5sP6vorDdqXGJJU9 --- plugins/kyberforge/.claude-plugin/plugin.json | 2 +- plugins/kyberforge/plugin.json | 2 +- plugins/kyberforge/skills/agent-author/SKILL.md | 8 ++++---- plugins/kyberforge/skills/agent-author/assets/README.md | 2 +- .../kyberforge/skills/agent-author/references/scripts.md | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/plugins/kyberforge/.claude-plugin/plugin.json b/plugins/kyberforge/.claude-plugin/plugin.json index 70fd94c..0b25538 100644 --- a/plugins/kyberforge/.claude-plugin/plugin.json +++ b/plugins/kyberforge/.claude-plugin/plugin.json @@ -8,5 +8,5 @@ "keywords": [], "license": "MIT", "name": "kyberforge", - "version": "1.1.2" + "version": "1.1.3" } diff --git a/plugins/kyberforge/plugin.json b/plugins/kyberforge/plugin.json index eb08f9e..c2db21a 100644 --- a/plugins/kyberforge/plugin.json +++ b/plugins/kyberforge/plugin.json @@ -13,5 +13,5 @@ "skills": [ "skills/" ], - "version": "1.1.2" + "version": "1.1.3" } diff --git a/plugins/kyberforge/skills/agent-author/SKILL.md b/plugins/kyberforge/skills/agent-author/SKILL.md index d5480b8..6dea901 100644 --- a/plugins/kyberforge/skills/agent-author/SKILL.md +++ b/plugins/kyberforge/skills/agent-author/SKILL.md @@ -35,10 +35,10 @@ metadata: - Copilot has no `permissionMode`, `maxTurns`, `isolation`, or `memory` fields — do not include them in the Copilot file. - `model` resolution order for Claude Code: `CLAUDE_CODE_SUBAGENT_MODEL` env var → per-invocation parameter → frontmatter `model` → main session model. The frontmatter value is a low-priority default, not a guarantee. -If the destination is a plugin directory, read `references/deployment-modes.md`. - ## Route +If the destination is a plugin directory, read `references/deployment-modes.md`. + Determine which flow before touching the filesystem: - **Neither `.md` nor `.agent.md` exist at the target paths** → follow **Creating a new agent** @@ -77,8 +77,8 @@ bash scripts/new-agent.sh security-reviewer ~ ``` **Scope detection (script handles this automatically):** -- Root contains `plugin.json` → plugin scope → creates `/agents/.md` + `/agents/.agent.md` -- Root is a project directory (no `plugin.json`) → creates `/.claude/agents/.md` + `/.github/agents/.agent.md` +- Root contains `plugin.json`, `.claude-plugin/plugin.json`, `.plugin/plugin.json`, or `.github/plugin/plugin.json` → plugin scope → creates `/agents/.md` + `/agents/.agent.md` +- Root is a project directory (no plugin marker) → creates `/.claude/agents/.md` + `/.github/agents/.agent.md` - Root is `~` → creates `~/.claude/agents/.md` + `~/.copilot/agents/.agent.md` The script is file-by-file no-op — it skips any file that already exists. diff --git a/plugins/kyberforge/skills/agent-author/assets/README.md b/plugins/kyberforge/skills/agent-author/assets/README.md index 6a0f3fe..abdd42e 100644 --- a/plugins/kyberforge/skills/agent-author/assets/README.md +++ b/plugins/kyberforge/skills/agent-author/assets/README.md @@ -5,4 +5,4 @@ Annotated agent definition templates copied by `scripts/new-agent.sh` when scaffolding a new agent. - **`claude-code.md`** — Claude Code agent definition template. Includes all supported frontmatter fields (required and optional) with inline guidance comments and `FILL IN:` placeholders. Notes which fields are silently ignored for plugin agents. -- **`copilot.agent.md`** — Copilot CLI agent definition template. Uses Copilot-specific fields (`target`, `user-invocable`, `disable-model-invocation`, Copilot tool aliases). Explicitly excludes Claude Code-only fields. +- **`copilot.agent.md`** — Copilot CLI agent definition template (CLI format). Excludes cloud/IDE-only fields (`target`, `user-invocable`, `disable-model-invocation`, `mcp-servers`) and Claude Code-only fields. Uses Copilot tool aliases (`execute`, `read`, `edit`, `search`, `agent`, `web`). diff --git a/plugins/kyberforge/skills/agent-author/references/scripts.md b/plugins/kyberforge/skills/agent-author/references/scripts.md index cb9f019..337085d 100644 --- a/plugins/kyberforge/skills/agent-author/references/scripts.md +++ b/plugins/kyberforge/skills/agent-author/references/scripts.md @@ -24,7 +24,7 @@ Do not add additional substitution tokens unless you update both the template fi ## File placement -The script creates files at paths determined by scope detection (plugin / project / user). Scope is detected from the presence of `plugin.json` or `.claude-plugin/plugin.json` in the root directory. If scope detection logic changes, update the `new-agent.sh` usage comment and `SKILL.md` Step 1 scope detection table in the same pass. +The script creates files at paths determined by scope detection (plugin / project / user). Scope is detected from the presence of `plugin.json`, `.claude-plugin/plugin.json`, `.plugin/plugin.json`, or `.github/plugin/plugin.json` in the root directory. If scope detection logic changes, update the `new-agent.sh` usage comment and `SKILL.md` Step 1 scope detection table in the same pass. ## Error messages