Compare commits
15 Commits
1929ffd2da
...
v2.0.1
| Author | SHA1 | Date | |
|---|---|---|---|
| 68e08c2413 | |||
| d42f6368fe | |||
| c68e864159 | |||
| c7ba3d2ccf | |||
| 4d336bbf35 | |||
| 36596598ef | |||
| b1ea14df3e | |||
| de84d1b677 | |||
| 65bac15257 | |||
| b0ef503485 | |||
| bd2bf667c5 | |||
| ba7cec7672 | |||
| 56cc173f65 | |||
| b93af30750 | |||
| b9c7762463 |
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "holocron",
|
"name": "holocron",
|
||||||
"description": "AI development skills for Claude Code and GitHub Copilot CLI — factory, design, implement, review, and cross-cutting workflows.",
|
"description": "AI development skills for Claude Code and GitHub Copilot CLI — factory, design, implement, review, and cross-cutting workflows.",
|
||||||
"version": "0.4.2",
|
"version": "0.4.5",
|
||||||
"owner": {
|
"owner": {
|
||||||
"name": "Defame1297",
|
"name": "Defame1297",
|
||||||
"email": "defame1297@rkdr.net",
|
"email": "defame1297@rkdr.net",
|
||||||
@@ -17,22 +17,22 @@
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
"name": "bin",
|
"name": "bin",
|
||||||
"description": "A place for things to be binned",
|
"description": "Skills for everyday AI-assisted development work that is not tied to a single tool, forge or language, and has not yet been split into a focused plugin.",
|
||||||
"version": "1.1.3",
|
"version": "1.1.5",
|
||||||
"category": "Utilities",
|
"category": "Utilities",
|
||||||
"source": "./plugins/bin"
|
"source": "./plugins/bin"
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"name": "git",
|
"name": "git",
|
||||||
"description": "Skills for working with Git — conventional commits, branch management, pull requests, and feature flow.",
|
"description": "Skills and agents for working with a local Git clone over the git wire protocol, and for authoring and running the pre-commit hooks that guard it.",
|
||||||
"version": "1.3.3",
|
"version": "1.3.5",
|
||||||
"category": "Version Control",
|
"category": "Version Control",
|
||||||
"source": "./plugins/git"
|
"source": "./plugins/git"
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"name": "gitea",
|
"name": "gitea",
|
||||||
"description": "Skills for managing Gitea repositories — issues, pull requests, milestones, releases, and wikis.",
|
"description": "Skills and agents for working with a Gitea forge through its HTTP API — the forge's own objects, as distinct from the local git clone.",
|
||||||
"version": "1.3.4",
|
"version": "1.3.6",
|
||||||
"category": "Version Control",
|
"category": "Version Control",
|
||||||
"source": "./plugins/gitea"
|
"source": "./plugins/gitea"
|
||||||
},
|
},
|
||||||
|
|||||||
14
.github/plugin/marketplace.json
vendored
14
.github/plugin/marketplace.json
vendored
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "holocron",
|
"name": "holocron",
|
||||||
"description": "AI development skills for Claude Code and GitHub Copilot CLI — factory, design, implement, review, and cross-cutting workflows.",
|
"description": "AI development skills for Claude Code and GitHub Copilot CLI — factory, design, implement, review, and cross-cutting workflows.",
|
||||||
"version": "0.4.2",
|
"version": "0.4.5",
|
||||||
"owner": {
|
"owner": {
|
||||||
"name": "Defame1297",
|
"name": "Defame1297",
|
||||||
"email": "defame1297@rkdr.net",
|
"email": "defame1297@rkdr.net",
|
||||||
@@ -17,22 +17,22 @@
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
"name": "bin",
|
"name": "bin",
|
||||||
"description": "A place for things to be binned",
|
"description": "Skills for everyday AI-assisted development work that is not tied to a single tool, forge or language, and has not yet been split into a focused plugin.",
|
||||||
"version": "1.1.3",
|
"version": "1.1.5",
|
||||||
"category": "Utilities",
|
"category": "Utilities",
|
||||||
"source": "./plugins/bin"
|
"source": "./plugins/bin"
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"name": "git",
|
"name": "git",
|
||||||
"description": "Skills for working with Git — conventional commits, branch management, pull requests, and feature flow.",
|
"description": "Skills and agents for working with a local Git clone over the git wire protocol, and for authoring and running the pre-commit hooks that guard it.",
|
||||||
"version": "1.3.3",
|
"version": "1.3.5",
|
||||||
"category": "Version Control",
|
"category": "Version Control",
|
||||||
"source": "./plugins/git"
|
"source": "./plugins/git"
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"name": "gitea",
|
"name": "gitea",
|
||||||
"description": "Skills for managing Gitea repositories — issues, pull requests, milestones, releases, and wikis.",
|
"description": "Skills and agents for working with a Gitea forge through its HTTP API — the forge's own objects, as distinct from the local git clone.",
|
||||||
"version": "1.3.4",
|
"version": "1.3.6",
|
||||||
"category": "Version Control",
|
"category": "Version Control",
|
||||||
"source": "./plugins/gitea"
|
"source": "./plugins/gitea"
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -207,7 +207,7 @@ repos:
|
|||||||
# pre-commit prints nothing at all for a passing hook, so without this
|
# pre-commit prints nothing at all for a passing hook, so without this
|
||||||
# the opt-out reinstated exactly the silent vacuous pass the script was
|
# the opt-out reinstated exactly the silent vacuous pass the script was
|
||||||
# written to kill, one level up -- the run showed a bare `Passed` and
|
# written to kill, one level up -- the run showed a bare `Passed` and
|
||||||
# AGENTS.md's instruction to read that summary line was impossible to
|
# the documented instruction to read that summary line was impossible to
|
||||||
# follow in the one situation the opt-out exists for. The script's clean
|
# follow in the one situation the opt-out exists for. The script's clean
|
||||||
# output is a single line, so this costs one line per push.
|
# output is a single line, so this costs one line per push.
|
||||||
|
|
||||||
|
|||||||
13
AGENTS.md
13
AGENTS.md
@@ -27,28 +27,31 @@ This repo dogfoods its own plugins. Before shelling out, check whether a skill a
|
|||||||
- Vale prose linting → `vale-config` / `vale-run`
|
- Vale prose linting → `vale-config` / `vale-run`
|
||||||
- This repo's own AGENTS.md → `agentsmd-author` / `agentsmd-audit`
|
- This repo's own AGENTS.md → `agentsmd-author` / `agentsmd-audit`
|
||||||
|
|
||||||
Use the bare, **unnamespaced** names. The `<plugin>:` form (`gitea:gitea-prs`) also still resolves, because user-scope native installs were left enabled on purpose (ADR-0018) — a working namespaced call is not evidence that anything is broken and is not something to "fix". Prefer the bare name anyway: it is what `apm install` deploys, and what survives those user-scope installs eventually being converted.
|
Use the bare, **unnamespaced** names. That is what `apm install` deploys and the only form this repo's own install produces — a project skill has no plugin to prefix (ADR-0018). Whether the `<plugin>:` form (`gitea:gitea-prs`) also resolves depends on native plugin installs at user scope, outside this repo; write the bare name either way.
|
||||||
|
|
||||||
Fall back to raw shell only when no skill covers it.
|
Fall back to raw shell only when no skill covers it.
|
||||||
|
|
||||||
## Session rules
|
## Session rules
|
||||||
|
|
||||||
- **Do not add repo-owned keys to `.claude/settings.json`.** apm treats it as its own deployed artifact and `apm audit --ci` replays the install and diffs, so anything apm would not have written is permanent drift that fails the `apm-audit-ci` pre-push hook. A hook you want here is authored in `plugins/<name>/.apm/hooks/` and deployed by apm, never hand-written into that file. Machine-specific settings go in the gitignored `.claude/settings.local.json`; shared enforcement goes in `.pre-commit-config.yaml`.
|
- **Do not add repo-owned keys to `.claude/settings.json`.** apm treats it as its own deployed artifact and `apm audit --ci` replays the install and diffs, so anything apm would not have written is permanent drift that fails the `apm-audit-ci` pre-push hook. A hook you want here is authored in `plugins/<name>/.apm/hooks/` and deployed by apm, never hand-written into that file. The `SessionStart` entry already in it is exactly that: kyberforge authors it in `plugins/kyberforge/.apm/hooks/hooks.json` and apm merges it in, so it is apm's own output, it is what the replay expects, and it belongs in the commit — do not strip it (ADR-0019). Machine-specific settings go in the gitignored `.claude/settings.local.json`; shared enforcement goes in `.pre-commit-config.yaml`.
|
||||||
- **`apm.lock.yaml` turning up modified is expected, not a bug.** kyberforge's `SessionStart` hook runs `apm outdated` at startup and `apm update --yes` when something is behind, which rewrites the lock. Commit or discard it deliberately.
|
- **`apm.lock.yaml` turning up modified is expected, not a bug.** kyberforge's `SessionStart` hook runs `apm outdated` at startup and `apm update --yes` when something is behind, which rewrites the lock. Commit or discard it deliberately.
|
||||||
- **A `.apm/` edit is not live in this session until it is pushed.** The six dependencies resolve from the holocron remote, unpinned against the default branch. `apm install` deploys from the lock; `apm update` is what re-resolves refs.
|
- **A `.apm/` edit is not live in this session until it is pushed.** The six dependencies resolve from the holocron remote, unpinned against the default branch. `apm install` deploys from the lock; `apm update` is what re-resolves refs.
|
||||||
- **The ADR-0020 skill gates ship hot, with no baseline.** 26 of 39 descriptions and 9 of 39 bodies exceed their FAIL tier, and the `Kyberforge.CompositionNote` Vale rule fires 10 errors across `gitea-issues`, `gitea-labels-milestones`, `gitea-prs` and `gitea-workflow`. Editing any of those skills *for any reason* means retrofitting it to the contract first — a one-line fix cannot be committed until the skill complies. Deliberate; tracked as Gitea issue #99. `skill-size-check` will not warn you about the Vale half, so check both: `pre-commit run --all-files`.
|
- **The ADR-0020 skill gates ship hot, with no baseline.** 26 of 39 descriptions and 9 of 39 bodies exceed their FAIL tier, and the `Kyberforge.CompositionNote` Vale rule fires 10 errors across `gitea-issues`, `gitea-labels-milestones`, `gitea-prs` and `gitea-workflow`. Editing any of those skills *for any reason* means retrofitting it to the contract first — a one-line fix cannot be committed until the skill complies. Deliberate; tracked as Gitea issue #99. `skill-size-check` will not warn you about the Vale half, so check both: `pre-commit run --all-files`.
|
||||||
- **Run `bash tests/run-tests.sh` before considering any change done.**
|
- **Run `bash tests/run-tests.sh --strict` before considering any change done.** Keep the flag: without it a suite whose dependency is missing exits 77 and is counted SKIPPED rather than failed, so the run goes green having verified less than it claims.
|
||||||
- **Before pushing, run the whole gate locally:** `pre-commit run --hook-stage pre-push --all-files`. Pushing runs 14 repo-defined hooks, not just the test suite.
|
- **Before pushing, rehearse the gate locally:** `pre-commit run --hook-stage pre-push --all-files`. It runs the 14 pre-push hooks this repo authors itself plus pre-commit's 2 `meta` hooks, so it prints 16; `check-release-needed` passes without checking anything, because it needs a real push to `main`. `docs/spec/gates.md` reconciles both.
|
||||||
- **Pushing without a network** needs `SKIP=apm-marketplace-check,apm-pack-check-clean git push` — those two resolve a remote marketplace entry via `git ls-remote`. Skip only those two; the rest are real local checks, and adding one to `SKIP` disarms it silently.
|
- **Pushing without a network** needs `SKIP=apm-marketplace-check,apm-pack-check-clean git push` — those two resolve a remote marketplace entry via `git ls-remote`. Skip only those two; the rest are real local checks, and adding one to `SKIP` disarms it silently.
|
||||||
- **Author commits with `git-commits`** — it validates Conventional Commits, which `commit-msg` enforces.
|
- **Author commits with `git-commits`** — it validates Conventional Commits, which `commit-msg` enforces.
|
||||||
|
- **This repo and Gitea are the only source of truth.** All project state, decisions, and working conventions live here. Do not use an external memory system for this project — cached state diverges from the repo and you get a split brain. Before answering any design or architecture question, check `docs/adr/` for an existing decision.
|
||||||
|
|
||||||
## Key documents
|
## Key documents
|
||||||
|
|
||||||
Read `CONTEXT.md` at the start of every session.
|
Read `CONTEXT.md` at the start of every session — it is this repo's domain glossary, and the terms it defines are used unglossed everywhere else. It is not exhaustive: terms it does not carry are defined at their point of use, mostly in `docs/spec/`.
|
||||||
|
|
||||||
Read these on demand:
|
Read these on demand:
|
||||||
|
|
||||||
- `README.md` — prerequisites, install, and test commands
|
- `README.md` — prerequisites, install, and test commands
|
||||||
|
- `docs/VISION.md` — the phased roadmap and where this is going; read when a decision turns on product direction
|
||||||
|
- `LESSONS.md` — patterns that went wrong once; read before repeating a class of change that has burned the repo before
|
||||||
- `docs/spec/gates.md` — what each pre-commit and pre-push hook enforces and why; read when a gate fails or before changing hook config
|
- `docs/spec/gates.md` — what each pre-commit and pre-push hook enforces and why; read when a gate fails or before changing hook config
|
||||||
- `docs/spec/architecture.md` — directory structure, install pipeline, provider model
|
- `docs/spec/architecture.md` — directory structure, install pipeline, provider model
|
||||||
- `docs/adr/` — architectural decisions; read before answering design questions or proposing structural changes
|
- `docs/adr/` — architectural decisions; read before answering design questions or proposing structural changes
|
||||||
|
|||||||
256
CONTEXT.md
256
CONTEXT.md
@@ -1,106 +1,226 @@
|
|||||||
---
|
---
|
||||||
name: AI Development Repo
|
name: AI Development Repo
|
||||||
description: Domain language and decisions for the global AI development config repository
|
description: The domain language of the global AI development config repository
|
||||||
---
|
---
|
||||||
|
|
||||||
# Context
|
# AI Development Repo
|
||||||
|
|
||||||
## Principles
|
The bounded context of this repo is **how agent instructions are authored, packaged, distributed, and
|
||||||
|
kept small**. Terms here name concepts specific to that problem. Mechanics live elsewhere:
|
||||||
|
`docs/spec/architecture.md` for structure, `docs/spec/gates.md` for enforcement, `docs/adr/` for
|
||||||
|
decisions.
|
||||||
|
|
||||||
### CLAUDE.md index model
|
## Language
|
||||||
`AGENTS.md` is the source of always-on universal rules (provider-agnostic). `providers/claude-code/CLAUDE.md` is a thin adapter: it imports `~/.agents/AGENTS.md` via `@~/.agents/AGENTS.md` and appends Claude Code-specific additions (`@import` for governance.md, content index). Deployed to `~/.claude/CLAUDE.md` via `install.sh`. Context size is kept minimal — only what is needed every session is loaded upfront; detailed content is pulled on demand. See ADR-0003.
|
|
||||||
|
|
||||||
### Instruction file format
|
### Context cost
|
||||||
`core/instructions/<topic>.md` files are plain markdown — no frontmatter, no schema. The agent decides when to read each file based on task context and the content index label in `providers/claude-code/CLAUDE.md`. Frontmatter is deferred until there is evidence that agents are loading the wrong files in practice.
|
|
||||||
|
|
||||||
### Repo/gitea as source of truth
|
**Preload tax**:
|
||||||
All project state, decisions, context, and working conventions live in this repo or Gitea. External memory systems should not be used for this project — they create a split-brain risk where cached state diverges from the repo. At the start of every session, read `CLAUDE.md`, `CONTEXT.md`, and `docs/VISION.md`. Everything needed to orient is here.
|
The always-on context cost of every installed skill's `name` and `description`, charged from the
|
||||||
|
first token of every session whether the skill is invoked or not. Measurement method and current
|
||||||
|
figure: ADR-0020.
|
||||||
|
_Avoid_: context cost, token overhead
|
||||||
|
|
||||||
Before answering any design or architecture question, check for existing decisions: `docs/adr/` (hard architectural decisions).
|
**Skill context contract**:
|
||||||
|
The ADR-0020 authoring rules that hold the preload tax and body size down — a description carries a
|
||||||
|
trigger clause, at most one capability clause, and a boundary clause, and nothing else. Thresholds
|
||||||
|
and the target-resolution walk: `docs/spec/gates.md`.
|
||||||
|
_Avoid_: skill budget, size limit
|
||||||
|
|
||||||
## Glossary
|
**Dispatch body**:
|
||||||
|
The body pattern a skill with two or more mutually exclusive flows must use — the body carries only
|
||||||
|
the dispatch table and the gates common to every branch, and each flow lives in its own
|
||||||
|
self-contained `references/` file. Exemplar: `apm-workflow`.
|
||||||
|
_Avoid_: router body, thin body
|
||||||
|
|
||||||
### Management Application
|
**Hand-invoked skill**:
|
||||||
A separate product (separate repo) for browsing, editing, and configuring AI development configs through a proper product UI. Git is the persistence layer, invisible to the user. The app is repo-agnostic — it works with any git repo that follows these conventions. This repo is the canonical default content (the official starter). See `docs/VISION.md` for the phased roadmap.
|
A skill reached only by typing its slash command, declared `disable-model-invocation: true`. The host
|
||||||
|
withholds it from the model-visible listing entirely, so it pays no preload tax and its description
|
||||||
|
becomes human-facing text. Exemplar: `zoom-out`.
|
||||||
|
_Avoid_: manual skill, disabled skill
|
||||||
|
|
||||||
### Skills
|
**Delegation discipline**:
|
||||||
Reusable slash commands for AI coding tools, defined as `SKILL.md` files following the [Agent Skills open standard](https://agentskills.io). Authored at `plugins/<plugin-name>/.apm/skills/<skill-name>/SKILL.md` and reaching a host by one of two install paths: `apm install`, which deploys the skill directory to `.claude/skills/<skill-name>/` (this repo's own path — see "apm-consumed install"), or `claude plugin install <name>@<marketplace>`, which caches the whole plugin (still supported for external consumers). Skills are self-contained — they cannot reference files outside the plugin directory after install-time caching. The two paths name skills differently: apm deploys a plain project skill (`skill-audit`), a plugin install namespaces it (`kyberforge:skill-audit`).
|
The agent-side counterpart to the dispatch body. A plugin-scope agent is a single `.agent.md` file
|
||||||
|
with no sibling `references/` directory, so it cannot disclose to itself — it can only delegate to
|
||||||
|
skills. Its characteristic defect is therefore restatement, not length.
|
||||||
|
_Avoid_: agent hygiene
|
||||||
|
|
||||||
### Preload tax
|
### Distribution
|
||||||
The always-on context cost of every installed skill's `name` + `description`, which sit in the agent's context from the first token of every session whether or not the skill is invoked. Measured 2026-08-14 against base commit `f9b919d` at 23,427 chars (~5,900 tokens) across 39 skills, plus 1,325 chars for 4 agents. Method, so it can be re-run: sum `len(name) + len(description)` over each `plugins/*/.apm/skills/*/SKILL.md` frontmatter with `>` block scalars folded to the value the host loads, at ~4 characters per token. Non-routing frontmatter (`metadata.source_keys`, `category`, `version`) is **not** part of it — the model-visible skill listing carries only `name` and `description`, which supersedes `LESSONS.md:63` on this host. Bodies are not part of it either; they are charged on invocation.
|
|
||||||
|
|
||||||
### Skill context contract
|
**Skill**:
|
||||||
The authoring rules that hold the preload tax and body size down, set by ADR-0020. A description carries a trigger clause, at most one capability clause, and a boundary clause of the form `Not <thing> → <skill-name>` naming a resolvable target — nothing else. "Resolvable" is decided by walking up *from the file being checked* to an **authoring root** — the nearest ancestor holding `plugins/*/.apm/{skills,agents}`, falling back to the nearest `.git`, in two passes so a nested `.git` cannot outrank a real monorepo root. The universe is then every skill and agent under `<root>/plugins/*/` (sibling plugins resolve against each other, which is what a monorepo means), plus the checked file's own apm package and that package's own declared `dependencies.apm`. The **root** manifest's dependency list is never consulted, and no plugin here declares a cross-plugin apm dependency. Deployed `.claude/`/`.agents/` trees count only when there is no authoring root at all — the consumer case. The property this buys is that one commit gets one verdict: those trees are gitignored `apm install` output, so resolving through them made the same commit report 2 dangling targets on a developer machine and 6 on a fresh clone, which a gate shipping hot with no baseline cannot do. A `${BASH_SOURCE}`-relative repo root is the other half of the same defect and is gone — it leaked this repo's 39-skill universe into consumer repos running the hook through pre-commit. A *missing* boundary clause is a SUGGESTION rather than a failure, for skills and agents alike — some skills genuinely have no near-miss sibling. A *missing or empty description* is the opposite: a hard FAIL in all three validators, because a gate that merely declines to measure the one preloaded field reports green. Capability enumeration, output formats, and composition notes ("composes X rather than duplicating Y") belong in the body or `README.md`; a description that summarises workflow is a correctness hazard, not just a cost, because agents act on it instead of reading the body. Sizes are two-tier and sit *below* the agentskills.io spec limits, which stay unchanged as conformance backstops: description 250 SUGGESTION / 400 FAIL (spec 1,024); body 600 SUGGESTION / 900 FAIL (spec 2,770 words / 500 lines). Conflating the quality gate with the spec ceiling is what let `skill-author` and `agent-author` grow to within twelve words of 2,770.
|
A reusable slash command defined as a `SKILL.md` file following the
|
||||||
|
[Agent Skills open standard](https://agentskills.io), authored at
|
||||||
|
`plugins/<plugin>/.apm/skills/<skill>/SKILL.md`.
|
||||||
|
_Avoid_: command, prompt, macro
|
||||||
|
|
||||||
### Dispatch body
|
**Plugin**:
|
||||||
The body pattern a skill with two or more mutually exclusive flows must use: the body carries only the dispatch table and the gates common to every branch, and each flow lives in its own self-contained `references/` file. Named for `apm-workflow` (421-word body, 3,006 words of references), which arrived at it independently and is the repo's exemplar. Its absence was the characteristic defect at the time ADR-0020 was written: `skill-author` inlined both its create and improve flows, and `agent-author` carried 50-60 lines marked inapplicable by their own headers on any single run. Both were retrofitted to dispatch tables in the change that carries the ADR — `skill-author` went 2,623 body words to 595 and `agent-author` 2,582 to 616 — so they are now worked examples of the pattern rather than counter-examples of it. The 39-skill corpus at large is not: 9 bodies still exceed the 900-word FAIL (issue #99).
|
The deployable unit — one or more skills, agents, hooks, commands, and MCP servers bundled into a
|
||||||
|
single installable directory under `plugins/<name>/`, compiled from that plugin's `.apm/` source.
|
||||||
|
_Avoid_: package, bundle, module
|
||||||
|
|
||||||
### Hand-invoked skill
|
**apm package**:
|
||||||
A skill reached only by typing its slash command, declared with `disable-model-invocation: true`. The host withholds it from the model-visible skill listing entirely, so it pays no preload tax and its `description` becomes human-facing text rather than a trigger list. `zoom-out` is the worked example: apm passes the flag through verbatim to both install paths, and the skill is absent from the router while `/zoom-out` still works. Choosing model-invoked vs. hand-invoked is the first question `skill-author` asks, because it determines whether a description needs triggers at all.
|
The unit apm builds and installs — `plugins/<name>/apm.yml` plus the hand-authored
|
||||||
|
`plugins/<name>/.apm/` tree it compiles from (ADR-0015).
|
||||||
|
_Avoid_: plugin directory, source tree
|
||||||
|
|
||||||
### Delegation discipline
|
**Content mirror**:
|
||||||
The agent-side counterpart to the dispatch body. A plugin-scope agent is a single `.apm/agents/<name>.agent.md` file with no sibling `references/` directory, so it cannot disclose to itself — it can only delegate to skills. Its characteristic defect is therefore restatement, not length: an agent body that spells out a procedure a skill it can invoke already owns creates a second copy that drifts. `agent-audit` fails that, with the fix being "invoke `<skill>` instead". Agents take the same description gates as skills but no body word gate — a skill body competes with the caller's live conversation, an agent body becomes the system prompt of a fresh context.
|
The generated flat `skills/`, `agents/`, `commands/`, `instructions/`, `extensions/` directories and
|
||||||
|
merged `hooks/hooks.json` at a plugin root — also called the flat mirror — compiled from that
|
||||||
|
plugin's `.apm/` tree so hosts that convention-scan those paths discover the content (ADR-0017).
|
||||||
|
_Avoid_: generated copy, duplicate tree
|
||||||
|
|
||||||
### Plugin
|
**Output profile**:
|
||||||
The deployable unit in the plugin marketplace. A plugin bundles one or more skills, agents, hooks, prompts, MCP servers, and optionally a `bin/` directory into a single installable directory. In this repo, plugins live under `plugins/<name>/`, each with its own `apm.yml` + `.apm/{skills,agents,hooks,...}` — this is the authoring source of truth for the plugin's content (ADR-0015). Two categories of tracked output are compiled from that source, never hand-edited: `.claude-plugin/plugin.json` (Claude Code) and `.github/plugin/plugin.json` (Copilot CLI) via `apm pack`/`apm compile`; and, alongside them, a flat `agents/`, `skills/`, `commands/`, `instructions/`, `extensions/` directory mirror at the plugin root plus a merged hooks file at `hooks/hooks.json`, generated by `scripts/sync-plugin-content.sh` — Claude Code's and Copilot's installers convention-scan only these flat paths (`hooks/hooks.json` is the convention path for hooks specifically; a root-level `hooks.json` is scanned by nothing and is deleted as stale by a sync — see ADR-0017's 2026-08-14 amendment) and have no awareness of `.apm/` nesting at all, so this mirror is what actually makes `.apm/` content discoverable at install time (ADR-0017). Plugins are copied to a cache on install — they cannot reference files outside their own directory. Install a plugin with `claude plugin install <name>@<marketplace>`, or consume it as an apm dependency (see "apm-consumed install").
|
An `apm pack` target format for a generated *marketplace* manifest; apm has `claude`
|
||||||
|
(`.claude-plugin/marketplace.json`) and `codex` (the differently-shaped
|
||||||
|
`.agents/plugins/marketplace.json`), and none for `.github/plugin/marketplace.json` (Copilot CLI's
|
||||||
|
legacy path), which a sync script mirrors instead. Mechanics: `docs/spec/architecture.md`.
|
||||||
|
_Avoid_: build target, export format
|
||||||
|
|
||||||
### Plugin marketplace
|
**Plugin marketplace**:
|
||||||
A Git repository with a `marketplace.json` manifest listing installable plugins. No backend, registry, or SaaS required — the Git repo is the marketplace. This repo is the `holocron` marketplace. The manifest at `.claude-plugin/marketplace.json` (read by both Claude Code and Copilot CLI) is **compiled output** of `apm pack`, generated from the root `apm.yml`'s `marketplace:` block (owner, build/output config, versioning strategy, and the `packages:` list of installable plugins) — it is not hand-edited. See ADR-0015. `.github/plugin/marketplace.json` is Copilot CLI's legacy manifest path; apm has no output profile for it (only `claude` and `codex`, and `codex`'s is a differently-shaped file at `.agents/plugins/marketplace.json`), so `scripts/sync-marketplace-mirror.sh` keeps it byte-identical to `.claude-plugin/marketplace.json`, checked at pre-push. Each listed package's `source:` still points at that plugin's own `plugins/<name>/` root, not at an `apm pack` build artifact — which is why that root also carries the flat `agents/`/`skills/`/`commands/`/`hooks/hooks.json` content mirror described under "Plugin" (ADR-0017): without it, an install from this marketplace finds a valid manifest but no discoverable content.
|
A Git repository carrying a `marketplace.json` manifest that lists installable plugins. There is no
|
||||||
|
backend, registry, or SaaS — the Git repo is the marketplace.
|
||||||
|
_Avoid_: registry, store, catalogue
|
||||||
|
|
||||||
### apm-consumed install
|
**holocron**:
|
||||||
How this repo installs its own plugins, as of 2026-08-14: not `claude plugin install <name>@holocron`, but six `dependencies.apm` entries in the root `apm.yml`, each a `git:`/`path:` object against the holocron remote, deployed by `apm install` into `.claude/skills/` and `.claude/agents/`. Project scope only — apm installs nothing at user scope, so the switch is contained to this repo and any other repo opts in by declaring its own dependencies. The git+path object form is deliberate over the shorter `<name>@holocron` marketplace alias: an alias must first be registered with `apm marketplace add`, which writes to `~/.apm/marketplaces.json` (user scope, outside the repo), whereas the object form needs nothing beyond the committed manifest and so survives a fresh clone.
|
This repository, in its role as a plugin marketplace and as the remote the six plugin dependencies
|
||||||
|
resolve against.
|
||||||
|
_Avoid_: the marketplace, upstream
|
||||||
|
|
||||||
Four consequences, each load-bearing:
|
**apm-consumed install**:
|
||||||
- **Skills gain an unnamespaced name.** apm deploys plain project skills, so `git:git-commits` also answers to `git-commits`. The `<plugin>:` form has not stopped resolving here: `~/.claude.json` still enables `core`, `git`, `gitea`, `kyberforge`, and `lint` at user scope, which ADR-0018 left in place deliberately — converting them is a separate decision with a blast radius beyond this repo. Until it is taken, every skill is live under two names, which is the same "present twice under two names" outcome ADR-0018's own "Alternatives considered" rejected for *keeping both install paths* — reached here by leaving user scope alone rather than by adopting it as the install model. Write the bare name regardless: apm deploys it, and a repo consuming holocron through apm gets only that form. The namespaced form still resolves wherever holocron is installed natively, so cross-audience skill bodies should use the bare name.
|
How this repo installs its own plugins as of 2026-08-14 — six `dependencies.apm` entries in the root
|
||||||
- **apm owns `.claude/settings.json`.** `apm audit --ci` (an `apm-audit-ci` pre-push hook) replays the install into a scratch tree and diffs it against the worktree, so any key apm would not have written is permanent drift. Committed content is exactly `{"hooks": {}}`; repo-owned settings have nowhere to live in that file.
|
`apm.yml` deployed by `apm install`, rather than `claude plugin install <name>@holocron`. Its
|
||||||
- **Install output is gitignored.** `.claude/skills/`, `.claude/agents/`, and `apm_modules/` are all regenerated by `apm install`. `apm.lock.yaml` and the generated `.mcp.json` are committed. Committing the deployed skills would add a third mirror of the same content to the two ADR-0017 already governs.
|
consequences: ADR-0018.
|
||||||
- **Test discovery must skip `apm_modules/`.** It holds a full copy of every plugin, `.bats` files included; both `tests/run-bats.sh` and `tests/run-tests.sh` exclude it.
|
_Avoid_: apm install, dependency install
|
||||||
|
|
||||||
Dependencies are unpinned against the default branch, matching the `autoUpdate: true` the native marketplace install had. The practical cost is a round trip: an edit to `plugins/<name>/.apm/` is invisible locally until it is pushed and `apm install` re-runs, because the dependency resolves from the remote rather than from the working tree beside it.
|
**Provenance chain**:
|
||||||
|
The three-stage traceability record linking a skill back to its research inputs: `/research` produces
|
||||||
|
topic docs and a `sources.md`; the author skill records which sources informed which files in
|
||||||
|
`references/sources.md` and `source_keys` frontmatter; `skill-audit` validates the chain is complete
|
||||||
|
and internally consistent.
|
||||||
|
_Avoid_: sources, citations, attribution
|
||||||
|
|
||||||
### HITL (human-in-the-loop)
|
### Governance
|
||||||
Agent pauses before a consequential action; human approves before execution. Required for irreversible or high-stakes actions (architecture changes, production deployments, security configuration). The agent drafts the change plan and waits — it does not proceed autonomously. Contrast with HOTL.
|
|
||||||
|
|
||||||
### HOTL (human-on-the-loop)
|
**HITL** (human-in-the-loop):
|
||||||
Agent acts; human monitors and can intervene after the fact. Acceptable for low-stakes, bounded, reversible actions where the cost of pausing for approval exceeds the blast radius of an error. The distinction between HITL and HOTL must be explicit and documented — defaulting to HOTL for convenience is not acceptable.
|
The agent pauses before a consequential action and a human approves before execution. Required for
|
||||||
|
irreversible or high-stakes actions — architecture changes, production deployments, security
|
||||||
|
configuration.
|
||||||
|
_Avoid_: manual approval, gated action
|
||||||
|
|
||||||
### Sycophancy
|
**HOTL** (human-on-the-loop):
|
||||||
The failure mode where RLHF-trained models prioritise approval over accuracy. Treated as a first-class reliability risk: models change correct answers to wrong ones under user pressure in a majority of observed cases, then persist in the wrong answer. Designing against sycophancy is an explicit obligation, not a quality-of-life concern. Countermeasures: explicit pushback resistance instructions, prompting for dissent, cross-validating against independent sources. Never interpret AI agreement as AI accuracy.
|
The agent acts and a human monitors, able to intervene after the fact. Acceptable only for
|
||||||
|
low-stakes, bounded, reversible actions where the cost of pausing exceeds the blast radius of an
|
||||||
|
error.
|
||||||
|
_Avoid_: autonomous, unsupervised
|
||||||
|
|
||||||
### AGENTS.md
|
**Sycophancy**:
|
||||||
The provider-agnostic always-on instruction entry point. Two files:
|
The failure mode where an RLHF-trained model prioritises approval over accuracy — changing a correct
|
||||||
- **Repo-level `AGENTS.md`** — instructions for agents working inside this repo (structure, key rules); imported by repo `CLAUDE.md` via `@AGENTS.md`.
|
answer to a wrong one under user pressure, then persisting in the wrong answer. Treated here as a
|
||||||
- **Global `core/AGENTS.md`** — Communication and Behavior rules that apply across all projects; deployed to `~/.agents/AGENTS.md`; imported by `~/.claude/CLAUDE.md` via `@~/.agents/AGENTS.md`.
|
first-class reliability risk, not a quality-of-life concern.
|
||||||
|
_Avoid_: agreeableness, people-pleasing
|
||||||
|
|
||||||
Contains always-on rules in plain markdown with no provider-specific syntax (no `@import`). Provider-specific files (`CLAUDE.md`) are thin adapters that import the relevant `AGENTS.md` and add only Claude Code-specific syntax. This pattern means a single source of truth can serve multiple providers without duplication. See ADR-0003.
|
### Documents
|
||||||
|
|
||||||
### Skill composition
|
**AGENTS.md**:
|
||||||
A skill calling another skill by name to delegate a sub-task. The calling skill focuses on the orchestration decision ("when to do X"); the called skill owns the mechanics ("how to do X"). Established compositions: `grill-me` calls `write-adr` when a decision crystallises; `implement-feature` calls `tdd` as its implementation methodology; `forge` calls `grill-with-docs` to refine intent, classifies the target artifact type (skill / agent / plugin / marketplace entry), then routes to the matching `*-author` skill — which owns its own create/improve logic and, where applicable, its own inline audit closeout (`skill-author` runs `/skill-audit`, `agent-author` runs `kyberforge:agent-audit`, both in the same context as the authoring work). Reserve `forge` for genuinely undecided "which artifact type is this" questions — an already-fully-specified corrective edit (exact file, line, and fix already known) should call the target author skill directly instead (`skill-author`, `apm-workflow`, `agentsmd-author`, etc.); routing a known fix through `forge`'s grill-and-classify layer adds unnecessary indirection and, in practice, has been observed to lose track of hard constraints handed down the chain (e.g. "don't commit yet," "edit in this worktree") because each hop re-derives instructions from a shorter brief. `forge` additionally runs its own independent recheck after a skill/agent route finishes: a clean-context subagent (not forked, no inherited context) re-runs the same audit skill against the finished artifact, as a distinct verification layer from the author skill's inline audit — the two can share blind spots since the inline audit runs in the same context as the work it checks. If the clean audit surfaces any unresolved finding, `forge` loops — re-invoke the author skill to resolve it, re-run the clean audit — until the clean audit comes back with nothing unresolved; only then is the route done. `plugin-author` and `marketplace-author` had no audit counterpart and got no recheck; their terminal check was `claude plugin validate`. Both were deprecated per ADR-0015, superseded by `apm-workflow`, and deleted entirely once issue #90 landed.
|
The provider-agnostic always-on instruction file, in plain markdown with no provider-specific syntax
|
||||||
|
(ADR-0003). Two exist: repo-level, and the global `core/AGENTS.md` deployed to `~/.agents/AGENTS.md`.
|
||||||
|
_Avoid_: instructions file, system prompt
|
||||||
|
|
||||||
### Provider-agnostic issue tracker
|
**Thin adapter**:
|
||||||
Skills and workflows reference "linked issue" generically rather than a specific provider. Gitea is the canonical issue tracker for this repo (see ADR-0007). "Issue" is the cross-provider term (GitHub, GitLab, Gitea all use it).
|
A provider-specific instruction file (`CLAUDE.md`, `.cursor/rules/*.mdc`, `copilot-instructions.md`)
|
||||||
|
that imports its `AGENTS.md` and adds only that provider's syntax, carrying no original always-on
|
||||||
|
content of its own (ADR-0002, ADR-0003).
|
||||||
|
_Avoid_: wrapper, shim, provider file
|
||||||
|
|
||||||
### Provenance chain
|
**LESSONS.md**:
|
||||||
The three-stage traceability record linking a skill back to its research inputs: (1) `/research` produces topic docs and a `sources.md` in `plugins/<plugin>/docs/research/docs/<topic>/`; (2) `/skill-author` reads those docs and records which sources informed which skill files in `references/sources.md` (including a `Research doc:` back-pointer to the upstream research file) and `source_keys` frontmatter on `SKILL.md` and `references/*.md`; (3) `skill-audit` validates the chain is complete and internally consistent via `validate-provenance.sh`. A skill with research input but no `references/sources.md`, or with `source_keys` that don't match `references/sources.md` slugs, has a broken provenance chain.
|
The long-loop feedback log for patterns observed across sessions, at the repo root.
|
||||||
|
_Avoid_: changelog, retro, postmortem
|
||||||
|
|
||||||
### Bidirectional reference principle
|
**Management Application**:
|
||||||
Files that reference other files should declare those references explicitly. The referencing file carries the forward reference (e.g. content index in `CLAUDE.md`, `references:` in frontmatter). The referenced file carries a `when:` field describing when it is loaded. Both sides should agree — divergence signals staleness. The reverse map ("what files reference this file?") is derived by a reference scanner script, not maintained manually. This principle applies to instruction files, skills, and workflow documents.
|
A separate product in a separate repo for browsing, editing, and configuring AI development configs
|
||||||
|
through a product UI, with Git as an invisible persistence layer. Repo-agnostic; this repo is its
|
||||||
|
canonical default content. Roadmap: `docs/VISION.md`.
|
||||||
|
_Avoid_: the UI, the dashboard, the app
|
||||||
|
|
||||||
### agentsmd-author / agentsmd-audit
|
### Quality
|
||||||
A skill pair in the `core` plugin for writing, updating, and reviewing a repo's `AGENTS.md` file(s) — the generic open-standard file (see the `AGENTS.md` entry above), including this repo's own. `agentsmd-author` creates/updates AGENTS.md content, supports nested monorepo placement (per the standard's nearest-file-wins precedence), and closes out by invoking `agentsmd-audit` inline. `agentsmd-audit` runs a single combined pass checking three mandatory baselines: secrets/credentials (governance.md hard prohibition — AGENTS.md is committed content), structural completeness (common-sections checklist from the agents.md spec), and accuracy/drift (do referenced commands and paths actually resolve against the repo). `agentsmd-audit` never inspects provider adapter files (see `provider-adapter-author`) — its scope is AGENTS.md content only. Chosen over folding this into `kyberforge` because kyberforge's scope is meta-tooling for the holocron marketplace itself, not generic target-repo documentation; `core` is the intended home for cross-cutting, repo-agnostic utility skills.
|
|
||||||
|
|
||||||
### provider-adapter-author
|
**Skill composition**:
|
||||||
A companion skill (`core` plugin) that detects a target repo's provider-specific instruction file (`CLAUDE.md`, `.cursor/rules/*.mdc`, `copilot-instructions.md`, etc.) and, where it duplicates content AGENTS.md should own, converts it into a thin adapter that imports AGENTS.md — mirroring this repo's own ADR-0002/ADR-0003 two-tier adapter pattern. Self-validates via its own bundled deterministic script (`scripts/validate-adapter.sh`: checks for an import reference, no duplicated headings, size threshold) rather than a separate paired audit skill — the check is mechanical, so a script suffices per governance.md's "prefer deterministic code for repeatable tasks." `agentsmd-author` calls this skill via skill composition when it detects an existing provider file with overlapping content.
|
A skill calling another skill by name to delegate a sub-task — the caller owns the orchestration
|
||||||
|
decision ("when to do X"), the callee owns the mechanics ("how to do X").
|
||||||
|
_Avoid_: chaining, nesting, sub-skill
|
||||||
|
|
||||||
### lint plugin
|
**Vale audit prefilter**:
|
||||||
A standalone, repo-agnostic plugin (`plugins/lint/`) for configuring and running linters — not scoped to kyberforge's own meta-tooling. First linter is Vale (prose style linting), split into two skills per the git/gitea per-concern pattern: `vale-config` (setup — `.vale.ini`, `StylesPath`, styles) and `vale-run` (invoke Vale, interpret/report findings). A `lint-runner` agent composes these for isolated-context lint sweeps; it is report-only **by instruction, not by capability** — its body states "You never edit files" and "Do not edit, fix, or rewrite any flagged content", but nothing enforces that. It previously carried `tools: Bash, Read, Grep, Glob`, which withheld `Edit` outright; plugin-scope APM agents cannot express a `tools:` field at all (ADR-0016 — `apm compile` copies frontmatter verbatim to both Claude Code and Copilot, whose `tools:` vocabularies are incompatible, so a value correct for one harness is wrong for the other), so `plugins/lint/.apm/agents/lint-runner.agent.md` now declares only `name`/`description`/`source_keys` and inherits every tool, `Edit` included. ADR-0016 accepted this loss of enforcement knowingly; the restriction survives as prose the agent is expected to follow. Vale's research docs (`docs/research/docs/vale/`) moved from `plugins/kyberforge/` to `plugins/lint/` to keep the provenance chain same-plugin.
|
The deterministic Vale pass that runs ahead of `skill-audit`/`agent-audit`'s Description dimension,
|
||||||
|
so LLM judgment is spent only on what a pattern cannot catch. Mechanics: `docs/spec/gates.md`.
|
||||||
|
_Avoid_: linting, style check
|
||||||
|
|
||||||
### Vale audit prefilter (skill-audit / agent-audit)
|
**Authoring root**:
|
||||||
Wiring Vale as a deterministic prefilter for `skill-audit`/`agent-audit`'s Description dimension (ADR motivation: issue #84) is repo-specific, not part of the generic `lint` plugin, so it doesn't live in `plugins/lint/` — but per ADR-0014 it also doesn't live at the repo root anymore. Two copies live inside `plugins/kyberforge/`, one per skill, since a plugin's cache-install only copies each skill's own files (no cross-skill sharing): `plugins/kyberforge/.apm/skills/agent-audit/assets/vale/` is canonical (`.vale.ini` plus a custom `Kyberforge` style covering description-opener banning ("This skill/agent..."), vague-capability wording ("helps with", "utilize", ...), and generic "see references/ for details" padding — and a `KyberforgeCopilot` style scoped only to `.agent.md` files for the Copilot-only "Use proactively has no effect" check), and `plugins/kyberforge/.apm/skills/skill-audit/assets/vale/` is a smaller duplicate (`Kyberforge` only, scoped to `SKILL.md`) kept in sync by `scripts/check-vale-style-sync.sh` (pre-push). A root-level `.pre-commit-hooks.yaml` exposes both copies (plus `skill-size-check`) so any external repo can enforce the same rules via `repo: <this-repo-url>, rev: <tag>` in its own `.pre-commit-config.yaml` — pre-commit clones the pinned rev into its own cache, independent of whether Claude Code or the `kyberforge` plugin is installed at all, and the same mechanism covers CI (`pre-commit run --all-files`). This repo's own `vale-audit-prefilter-skill`/`-agent` pre-commit hooks consume the identical plugin-bundled copies via `repo: local` (not a third root copy, and not a pinned self-reference — a pinned self-reference would lint working-tree edits against the last tagged release rather than the change being made). Every rule is `level: error` and every alert is a FAIL — no ignorable tier, same as shellcheck, the test suite, and conventional-pre-commit. Graded severities do not work here: Vale's exit code keys on `error` alerts alone, so `warning`/`suggestion` rules exit 0 and pre-commit swallows the output of a passing hook, leaving them invisible and blocking nothing. `MinAlertLevel` and `--minAlertLevel` are correspondingly absent from `.vale.ini` and the hook, being no-ops under this model. Vale covers the pattern-matchable sub-checks named in issue #84 (imperative opener, vague filler, `Use proactively`, generic reference-pointer padding) plus, per ADR-0013, one body-wide prose-pattern check ("There is/are" sentence openers) — everything else about body discipline (defaults-vs-menus, why-rationale, non-pattern-matchable judgment calls), near-miss exclusion strength, and control calibration stays LLM judgment.
|
The directory a gate resolves against — the nearest ancestor of the file being checked holding
|
||||||
|
`plugins/*/.apm/skills` or `plugins/*/.apm/agents`, falling back to the nearest ancestor holding
|
||||||
|
`.git`. The walk: `docs/spec/gates.md`.
|
||||||
|
_Avoid_: repo root, project root
|
||||||
|
|
||||||
Both skills' Step 1, and the `vale-audit-prefilter-skill`/`-agent` pre-commit hooks, call each copy's own `scripts/vale-wrap.sh` rather than `vale` directly — a workaround for a confirmed Vale 3.15.2 limitation (see `vale-config`'s Gotchas): `text.frontmatter.description` silently stops matching on most — not all — multi-line descriptions. Verified by reproduction, not assumed: `>` folded scalars, plain (unquoted) continuation lines, and single- or double-quoted multi-line scalars all yield 0 alerts and exit 0 on a deliberately-bad fixture, while a `|` literal block spanning the same 2+ lines lints normally (alerts fire, exit 1). The wrapper flattens those three broken forms to one physical line in a scratch copy (padding with blank lines so every other line number is unchanged) before handing off to real `vale`; `|` literal blocks and single-line descriptions pass through untouched, already linting correctly. The plain and quoted forms previously passed silently — unflattened and unmatched — so a bad description in either sailed through the prefilter. Handed no `--config` at all, the wrapper falls back to its own sibling `assets/vale/.vale.ini`, located from `${BASH_SOURCE[0]}` rather than from the cwd — which is why both manifests' `entry:` is now the bare script path with no argument after it. pre-commit prefixes only `entry[0]` with the hook-repo clone path (`cmd = (prefix.path(cmd[0]), *cmd[1:])`), so every later argument resolves against the *consuming* repo's root: a `--config` in `.pre-commit-hooks.yaml` pointed at a path no consumer has and hard-failed every external run with `E100 [--config] Runtime error`. `.pre-commit-config.yaml` drops the argument too, deliberately keeping the two entries identical — the local `repo: local` hook resolved its `--config` correctly only because the consuming repo *was* this repo, and that divergence is why three review rounds exercised a path no external consumer takes and missed the defect. An explicit `--config` still wins, in all three argv forms (`--config X`, `--config=/abs`, `--config=rel`), and a relative one still resolves against the caller's cwd, matching bare `vale`, not the repo root. Both audit skills' Step 1 now passes no `--config` either: it resolves the script relative to the skill's own directory so the call works from an installed plugin cache, but a relative `--config` alongside it would still resolve against the cwd, yielding `E100 Runtime error ... does not exist` and exit 2 — which both skills' fallback misreads as "vale unavailable" and silently downgrades to full LLM judgment. `tests/test-vale-wrap.sh` regression-tests this against skill-audit's copy specifically (its fixtures are all `SKILL.md`-shaped, and only skill-audit's `.vale.ini` has that glob section). Each `.vale.ini`'s section globs are path-agnostic (`[**/SKILL.md]` for skill-audit's copy; `[**/agents/*.md]`/`[**/*.agent.md]` for agent-audit's) and do no scoping on their own: Vale's `*` crosses `/`. Scoping comes from each pre-commit hook's own `files:` regex and from the audit skills passing one explicit file per invocation. The two manifests scope differently on purpose: this repo's `.pre-commit-config.yaml` pins its own layout — `^plugins/[^/]+/\.apm/skills/[^/]+/SKILL\.md$` for `-skill`, `^plugins/[^/]+/\.apm/agents/[^/]+\.agent\.md$` for `-agent` — while the shipped `.pre-commit-hooks.yaml` stays layout-agnostic for external consumers whose skills live anywhere, using `(^|/)SKILL\.md$` and `(^|/)agents/[^/]+\.md$|\.agent\.md$`. Both manifests split the prefilter into two hooks precisely because one combined hook pointed at only one copy would silently 0-file-skip the other file type. A `SKILL.md` outside `plugins/` (e.g. project-scope `.claude/skills/foo/SKILL.md`) still matches `[**/SKILL.md]` and gets linted normally — the globs constrain filename shape, not location. Vale reports 0 files only when the path it is handed matches no glob section at all: a differently-named file, or a directory argument holding nothing that matches. That run prints `✔ 0 errors ... in 0 files.` and exits 0, indistinguishable from a clean pass, so both audits treat a 0-file Vale run as NOT RUN and fall back to full LLM judgment.
|
**Near-miss**:
|
||||||
|
A query that shares keywords with this skill but needs a different one — and, by extension, the
|
||||||
|
sibling that would wrongly answer it; boundary clauses exist to exclude genuine near-misses rather
|
||||||
|
than to enumerate siblings. Detail: `skill-audit/references/description-quality.md`.
|
||||||
|
_Avoid_: overlap, similar skill
|
||||||
|
|
||||||
This scope expands per ADR-0013: one cherry-picked low-noise `write-good`/`alex` rule landed in `styles/Kyberforge`, `Kyberforge.SentenceOpenerThereIs` (22 held-out hits, both in-corpus hits clean rewrites, zero suppressions). A second, `Kyberforge.VagueQualifier`, was cherry-picked and then deleted: 2 hits across the skill/agent corpus as it stood at the time of that measurement (2026-08-08, before the `.apm/` restructure), one marginal and one an unfixable false positive (`caveman/SKILL.md` quotes `of course` as an example of filler — a mention, not a use) that forced the repo's only Vale suppression comments. A third, `Kyberforge.CompositionNote`, landed with ADR-0020 and bans architecture and composition prose from a description; it is `level: error` like the rest, and it currently fires 10 times across `gitea-issues`, `gitea-labels-milestones`, `gitea-prs` and `gitea-workflow`, so `pre-commit run --all-files` is red on prose as well as on size until issue #99 lands. Also new is a sibling pre-commit hook, `skill-size-check` (`scripts/skill-size-check.sh`), which carries **two independent gate families that must not be conflated** (see "Skill context contract"). The agentskills.io spec backstop is `MAX_LINES=500` and `MAX_WORDS=2770`, both inclusive and both counting the **whole file including frontmatter** (2,770 is a word-count proxy for the 5,000-token limit, calibrated to the densest prose measured in this repo — 1.81 tokens per word — so even a worst-case `SKILL.md` at the ceiling stays under 5,000 tokens; it is not a percentile of the corpus). ADR-0020 adds a context budget measured differently: description characters 250 SUGGESTION / 400 FAIL, **body-only** words 600 SUGGESTION / 900 FAIL, plus deterministic checks that every boundary routing target resolves, that a body's named `references/<file>.md` all exist, and — SUGGESTION-tier — that a boundary clause is present at all, that `## Gotchas` holds at most five entries, and that it stays under 25% of the body. `skill-audit/scripts/validate.sh` and `agent-audit/scripts/validate.sh` hold their own copies of the shared constants and `tests/test-skill-size-check.sh` asserts the copies agree, so a `SKILL.md` can no longer pass its own audit yet be blocked by the commit hook. Agents take the description gates and no body word gate. `python3` **and PyYAML** are hard requirements — the earlier hand-rolled frontmatter fallback is gone, because a fallback that silently mis-parses a scalar shape reports a vacuous pass. Scoped to `^plugins/[^/]+/\.apm/skills/[^/]+/SKILL\.md$` only, same as `vale-audit-prefilter-skill`, so it never lints `docs/research/examples/` reference skills. It's also exposed in the root-level `.pre-commit-hooks.yaml` as `kyberforge-skill-size-check` — it has no external asset dependency, so it needed no relocation, only exposure to external consumers. File scope (`SKILL.md` + agent files) and enforcement model (rules land directly in `styles/Kyberforge`, blocking immediately, no trial tier) stay unchanged; governance.md/CONTROLS.md were evaluated and excluded as rule sources (nothing prose-pattern-matchable to mine). House convention: banned phrasing that must be mentioned rather than used goes in backticks or a fenced code block — Vale skips code spans and fences, so no suppression is needed; inline `<!-- vale Rule = NO -->` (HTML-comment form; the MDX `{/* */}` form does not work in plain Markdown) is the fallback only where backticking is impossible.
|
**Vacuous green**:
|
||||||
|
A check that reports success because it measured nothing — zero files scanned, an unparsed value read
|
||||||
|
as empty, a conditional branch that never armed.
|
||||||
|
_Avoid_: false pass, clean run
|
||||||
|
|
||||||
### LESSONS.md
|
**Issue**:
|
||||||
Long-loop feedback log for patterns observed across sessions. Three or more entries on the same pattern graduate to the relevant standing file (e.g. a coding convention, a governance rule). Updated by the session-handoff skill or directly by the human. Lives at the repo root.
|
The cross-provider term for a tracked unit of work. Gitea is this repo's canonical tracker
|
||||||
|
(ADR-0007), but skills say "linked issue" generically rather than naming a provider.
|
||||||
|
_Avoid_: ticket, card, task
|
||||||
|
|
||||||
|
## Relationships
|
||||||
|
|
||||||
|
- A **Plugin** bundles one or more **Skills** and agents; a **Plugin marketplace** lists **Plugins**;
|
||||||
|
**holocron** is this repo wearing that hat.
|
||||||
|
- Every model-invocable **Skill** pays the **Preload tax**. A **Hand-invoked skill** does not — which
|
||||||
|
is the first question to settle when authoring one.
|
||||||
|
- The **Skill context contract** bounds both the **Preload tax** (description) and the body.
|
||||||
|
A **Dispatch body** is how a skill stays inside it; **Delegation discipline** is how an agent does.
|
||||||
|
- **AGENTS.md** is the source of always-on rules; a **Thin adapter** imports it and originates
|
||||||
|
nothing.
|
||||||
|
- **Skill composition** is the caller/callee split. `forge` routes a genuinely *undecided* artifact
|
||||||
|
type to the matching author skill — an already-specified fix (file, line, and change known) calls
|
||||||
|
that author skill directly, because each routing hop re-derives instructions from a shorter brief
|
||||||
|
and has been observed to drop hard constraints handed down the chain.
|
||||||
|
- **HITL** and **HOTL** are exclusive per action class, and the choice must be explicit and
|
||||||
|
documented. **Sycophancy** is why HOTL is not the safe default.
|
||||||
|
- A **Skill** built on research carries a **Provenance chain**; `skill-audit` fails it when broken.
|
||||||
|
- **LESSONS.md** feeds the standing files: three or more entries on one pattern graduate the pattern
|
||||||
|
into the relevant standing document.
|
||||||
|
|
||||||
|
## Example dialogue
|
||||||
|
|
||||||
|
> **Dev:** "This one only fires when someone types the slash command. Does its description still need
|
||||||
|
> trigger words?"
|
||||||
|
> **Maintainer:** "No — that's a **hand-invoked skill**. The host withholds it from the model-visible
|
||||||
|
> listing, so it pays no **preload tax** at all and the description is human-facing text."
|
||||||
|
> **Dev:** "Then the body can be as long as it needs to be?"
|
||||||
|
> **Maintainer:** "Different budget. The **skill context contract** gates the body whether or not the
|
||||||
|
> skill is model-invoked — the description competes with every other skill's description, the body
|
||||||
|
> competes with the caller's live conversation. Four mutually exclusive flows means a **dispatch
|
||||||
|
> body**: table in `SKILL.md`, one `references/` file per flow."
|
||||||
|
> **Dev:** "And if I split it into an agent instead?"
|
||||||
|
> **Maintainer:** "Then you're in **delegation discipline** territory. An agent has no `references/`
|
||||||
|
> to disclose to, so the failure mode flips — it stops being length and starts being restatement of
|
||||||
|
> a procedure some skill already owns."
|
||||||
|
|
||||||
|
## Flagged ambiguities
|
||||||
|
|
||||||
|
- "skill" was used for both the authored `SKILL.md` under `plugins/<name>/.apm/skills/` and the
|
||||||
|
deployed copy under `.claude/skills/` — resolved: the authoring source is the **Skill**; the
|
||||||
|
deployed copy is gitignored `apm install` output and is never edited.
|
||||||
|
- Skills can answer to two names, bare (`gitea-prs`) and namespaced (`gitea:gitea-prs`), depending on
|
||||||
|
whether a native install exists at user scope alongside the apm one (ADR-0018) — resolved: write
|
||||||
|
the bare name, which is the only form `apm install` produces.
|
||||||
|
- "context" means both the model's live token window (the **Preload tax** sense) and the bounded
|
||||||
|
domain this file describes — resolved: unqualified "context" in this repo means the token window.
|
||||||
|
- "audit" was used for both an author skill's inline closeout and `forge`'s independent
|
||||||
|
clean-context recheck — resolved: these are two distinct layers, kept separate precisely because
|
||||||
|
an audit running in the same context as the work it checks shares that work's blind spots.
|
||||||
|
|||||||
@@ -1,8 +1,8 @@
|
|||||||
# Lessons
|
# Lessons
|
||||||
|
|
||||||
Patterns observed during development of this repo. Three or more entries on the same pattern → promote to CONTEXT.md (or the relevant instruction file) as a standing rule.
|
Patterns observed during development of this repo. Three or more entries on the same pattern → promote to `docs/spec/architecture.md` (or the relevant instruction file) as a standing rule.
|
||||||
|
|
||||||
**Graduation rule:** When three or more entries cover the same pattern, the human reviews and promotes it to the appropriate standing location: `CONTEXT.md` for domain-level principles, `core/instructions/coding.md` for coding conventions, `core/instructions/testing.md` for testing conventions, or `core/instructions/subagent-orchestration.md` for delegation conventions. Those four are the whole set — `core/instructions/` holds `coding.md`, `governance.md`, `subagent-orchestration.md` and `testing.md`, and nothing else. Git conventions have no standing file of their own: promote them to `core/instructions/coding.md`, or create a new instruction file deliberately rather than assuming one exists. The graduated entries are marked `[graduated → target file]` rather than deleted (audit trail).
|
**Graduation rule:** When three or more entries cover the same pattern, the human reviews and promotes it to the appropriate standing location: `docs/spec/architecture.md` for structural and domain-level principles — `CONTEXT.md` is not a destination, its `## Principles` section was deleted and what was there now sits under that file's "AGENTS.md pattern" and "Reference conventions" headings — `core/instructions/coding.md` for coding conventions, `core/instructions/testing.md` for testing conventions, or `core/instructions/subagent-orchestration.md` for delegation conventions. Those four are the whole set — `core/instructions/` holds `coding.md`, `governance.md`, `subagent-orchestration.md` and `testing.md`, and nothing else. Git conventions have no standing file of their own: promote them to `core/instructions/coding.md`, or create a new instruction file deliberately rather than assuming one exists. The graduated entries are marked `[graduated → target file]` rather than deleted (audit trail).
|
||||||
|
|
||||||
**Who writes here:** The session-handoff skill (Chunk 3) prompts LESSONS.md extraction before closing a session. The human may also write directly.
|
**Who writes here:** The session-handoff skill (Chunk 3) prompts LESSONS.md extraction before closing a session. The human may also write directly.
|
||||||
|
|
||||||
@@ -26,7 +26,7 @@ Issue files frequently referenced "the workflow defined in `docs/notes/skill-imp
|
|||||||
|
|
||||||
The repo CLAUDE.md instructs agents to read CONTEXT.md at session start, but agents skip this in practice — defaulting to reading only what's directly relevant to the immediate prompt (e.g. the skills folder). The governance.md works because `@import` is technically enforced by Claude Code. Fix: (1) add `@CONTEXT.md` to repo CLAUDE.md using `@import` to make it always-loaded; (2) add a "Key decisions" section to CONTEXT.md with one-line resolved-ADR summaries so locked choices are always in context.
|
The repo CLAUDE.md instructs agents to read CONTEXT.md at session start, but agents skip this in practice — defaulting to reading only what's directly relevant to the immediate prompt (e.g. the skills folder). The governance.md works because `@import` is technically enforced by Claude Code. Fix: (1) add `@CONTEXT.md` to repo CLAUDE.md using `@import` to make it always-loaded; (2) add a "Key decisions" section to CONTEXT.md with one-line resolved-ADR summaries so locked choices are always in context.
|
||||||
|
|
||||||
**Status (2026-08-14): neither part landed.** Root `CLAUDE.md` imports `@AGENTS.md` only — no `@CONTEXT.md` — and `CONTEXT.md` has no "Key decisions" section. The behavioral hope this entry diagnosed is still the only mechanism in place: `AGENTS.md` carries the line "Read CONTEXT.md at the start of every session in this repo," which is loaded but is itself an instruction, not an import. The proposal above is open work, not a record of a completed change.
|
**Status (2026-08-14): neither part landed.** Root `CLAUDE.md` imports `@AGENTS.md` only — no `@CONTEXT.md` — and `CONTEXT.md` has no "Key decisions" section. The behavioral hope this entry diagnosed is still the only mechanism in place: `AGENTS.md` carries the line "Read `CONTEXT.md` at the start of every session," which is loaded but is itself an instruction, not an import. The proposal above is open work, not a record of a completed change.
|
||||||
|
|
||||||
## 2026-05-17 — Instruction rules lose to RLHF defaults without specificity
|
## 2026-05-17 — Instruction rules lose to RLHF defaults without specificity
|
||||||
|
|
||||||
|
|||||||
19
README.md
19
README.md
@@ -8,7 +8,7 @@ Content ships as six installable plugins, each an apm (Agent Package Manager) pa
|
|||||||
|
|
||||||
| Path | What it holds |
|
| Path | What it holds |
|
||||||
| --- | --- |
|
| --- | --- |
|
||||||
| `plugins/` | Six apm packages — `bin`, `core`, `git`, `gitea`, `kyberforge`, `lint` — each carrying skills, agents, hooks, MCP servers, and bundled assets |
|
| `plugins/` | Six apm packages — `bin`, `core`, `git`, `gitea`, `kyberforge`, `lint` — each carrying skills, and where relevant agents, hooks, MCP servers, and bundled assets |
|
||||||
| `providers/claude-code/` | Claude Code adapter, deployed to `~/.claude/` via `scripts/install.sh` |
|
| `providers/claude-code/` | Claude Code adapter, deployed to `~/.claude/` via `scripts/install.sh` |
|
||||||
| `core/` | Provider-agnostic always-on content — `core/AGENTS.md` and `core/instructions/` |
|
| `core/` | Provider-agnostic always-on content — `core/AGENTS.md` and `core/instructions/` |
|
||||||
| `docs/` | Specs (`docs/spec/`), architectural decisions (`docs/adr/`), governance, research, and notes |
|
| `docs/` | Specs (`docs/spec/`), architectural decisions (`docs/adr/`), governance, research, and notes |
|
||||||
@@ -18,11 +18,11 @@ Content ships as six installable plugins, each an apm (Agent Package Manager) pa
|
|||||||
The six plugins:
|
The six plugins:
|
||||||
|
|
||||||
- **kyberforge** — skills and agents for creating, maintaining, and managing a Claude Code / Copilot CLI plugin marketplace
|
- **kyberforge** — skills and agents for creating, maintaining, and managing a Claude Code / Copilot CLI plugin marketplace
|
||||||
- **git** — conventional commits, branch management, pull requests, feature flow
|
- **git** — conventional commits, branches, history, submodules, worktrees, remotes, pre-commit hook authoring and running (`pc-author` / `pc-run`), and an interactive router (`git-workflow`)
|
||||||
- **gitea** — issues, pull requests, milestones, releases, wikis
|
- **gitea** — issues, pull requests, labels, milestones, releases, branches, files, and an interactive router (`gitea-workflow`)
|
||||||
- **core** — authoring and auditing a repo's `AGENTS.md` and the provider adapter files that defer to it
|
- **core** — authoring and auditing a repo's `AGENTS.md` and the provider adapter files that defer to it
|
||||||
- **lint** — configuring and running linters
|
- **lint** — configuring and running linters
|
||||||
- **bin** — a place for things to be binned
|
- **bin** — cross-cutting workflow skills not yet split into a focused plugin: research, documentation, TDD, prototyping, triage, diagnosis, architecture review, requirement grilling, compressed output (`caveman`), and re-orienting mid-task (`zoom-out`)
|
||||||
|
|
||||||
## Prerequisites
|
## Prerequisites
|
||||||
|
|
||||||
@@ -50,12 +50,12 @@ Run these in order, from the repo root.
|
|||||||
apm install
|
apm install
|
||||||
|
|
||||||
# 2. Install the git hooks — all three stages
|
# 2. Install the git hooks — all three stages
|
||||||
# (use the `pc-run` skill, which knows the stage wiring)
|
pre-commit install -t pre-commit -t commit-msg -t pre-push
|
||||||
```
|
```
|
||||||
|
|
||||||
**`apm install`** deploys the six plugins into `.claude/skills/` and `.claude/agents/`. Both are gitignored install output, *not* authoring source — `plugins/<name>/.apm/` remains the only place to edit. It needs the network, materializes `apm_modules/` (which stays gitignored), and also configures the `obsidian` MCP server into the repo's `.mcp.json`.
|
**`apm install`** deploys the six plugins into `.claude/skills/` and `.claude/agents/`. Both are gitignored install output, *not* authoring source — `plugins/<name>/.apm/` remains the only place to edit. It needs the network, materializes `apm_modules/` (which stays gitignored), and also configures the `obsidian` MCP server into the repo's `.mcp.json`.
|
||||||
|
|
||||||
**Git hooks** go in via the `pc-run` skill, wiring **all three stages**. This repo's `.pre-commit-config.yaml` has no `default_install_hook_types`, so a plain `pre-commit install` silently skips `commit-msg` (Conventional Commits) and `pre-push` (the full gate).
|
**Git hooks** must be wired for **all three stages**. This repo's `.pre-commit-config.yaml` has no `default_install_hook_types`, so a plain `pre-commit install` silently skips `commit-msg` (Conventional Commits) and `pre-push` (the full gate) — the `-t` flags above are not optional. The `pc-run` skill handles this and the troubleshooting around it, if you would rather not remember the flags.
|
||||||
|
|
||||||
## Keeping the install current
|
## Keeping the install current
|
||||||
|
|
||||||
@@ -81,12 +81,17 @@ A suite that exits 77 because a dependency is missing is reported as SKIPPED and
|
|||||||
|
|
||||||
## Before pushing
|
## Before pushing
|
||||||
|
|
||||||
Run the whole pre-push gate locally in one command:
|
Run the pre-push gate locally in one command:
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
pre-commit run --hook-stage pre-push --all-files
|
pre-commit run --hook-stage pre-push --all-files
|
||||||
```
|
```
|
||||||
|
|
||||||
|
One caveat: `check-release-needed` is a silent no-op under this invocation. It exits 0 unless
|
||||||
|
`PRE_COMMIT_REMOTE_BRANCH` is `refs/heads/main`, and pre-commit exports that only from the real
|
||||||
|
pre-push git hook during an actual `git push` — so the hook reports `Passed` having checked nothing.
|
||||||
|
Every other pre-push hook does run.
|
||||||
|
|
||||||
See [`docs/spec/gates.md`](docs/spec/gates.md) for what each hook enforces and why.
|
See [`docs/spec/gates.md`](docs/spec/gates.md) for what each hook enforces and why.
|
||||||
|
|
||||||
**Offline?** Exactly two pre-push hooks need the network, because root `apm.yml`'s marketplace contains one remote package entry that must be resolved with `git ls-remote`:
|
**Offline?** Exactly two pre-push hooks need the network, because root `apm.yml`'s marketplace contains one remote package entry that must be resolved with `git ls-remote`:
|
||||||
|
|||||||
16
apm.yml
16
apm.yml
@@ -1,5 +1,5 @@
|
|||||||
name: holocron
|
name: holocron
|
||||||
version: 0.4.2
|
version: 0.4.5
|
||||||
description: AI development skills for Claude Code and GitHub Copilot CLI — factory, design, implement, review, and cross-cutting workflows.
|
description: AI development skills for Claude Code and GitHub Copilot CLI — factory, design, implement, review, and cross-cutting workflows.
|
||||||
license: MIT
|
license: MIT
|
||||||
|
|
||||||
@@ -52,7 +52,7 @@ marketplace:
|
|||||||
# top-level apm.yml description:/version: above are NOT inherited into the
|
# top-level apm.yml description:/version: above are NOT inherited into the
|
||||||
# compiled output despite being used elsewhere (e.g. by `apm audit`).
|
# compiled output despite being used elsewhere (e.g. by `apm audit`).
|
||||||
description: AI development skills for Claude Code and GitHub Copilot CLI — factory, design, implement, review, and cross-cutting workflows.
|
description: AI development skills for Claude Code and GitHub Copilot CLI — factory, design, implement, review, and cross-cutting workflows.
|
||||||
version: 0.4.2
|
version: 0.4.5
|
||||||
owner:
|
owner:
|
||||||
name: Defame1297
|
name: Defame1297
|
||||||
email: defame1297@rkdr.net
|
email: defame1297@rkdr.net
|
||||||
@@ -83,21 +83,21 @@ marketplace:
|
|||||||
category: Developer Tools
|
category: Developer Tools
|
||||||
|
|
||||||
- name: bin
|
- name: bin
|
||||||
description: A place for things to be binned
|
description: Skills for everyday AI-assisted development work that is not tied to a single tool, forge or language, and has not yet been split into a focused plugin.
|
||||||
source: ./plugins/bin
|
source: ./plugins/bin
|
||||||
version: 1.1.3
|
version: 1.1.5
|
||||||
category: Utilities
|
category: Utilities
|
||||||
|
|
||||||
- name: git
|
- name: git
|
||||||
description: Skills for working with Git — conventional commits, branch management, pull requests, and feature flow.
|
description: Skills and agents for working with a local Git clone over the git wire protocol, and for authoring and running the pre-commit hooks that guard it.
|
||||||
source: ./plugins/git
|
source: ./plugins/git
|
||||||
version: 1.3.3
|
version: 1.3.5
|
||||||
category: Version Control
|
category: Version Control
|
||||||
|
|
||||||
- name: gitea
|
- name: gitea
|
||||||
description: Skills for managing Gitea repositories — issues, pull requests, milestones, releases, and wikis.
|
description: Skills and agents for working with a Gitea forge through its HTTP API — the forge's own objects, as distinct from the local git clone.
|
||||||
source: ./plugins/gitea
|
source: ./plugins/gitea
|
||||||
version: 1.3.4
|
version: 1.3.6
|
||||||
category: Version Control
|
category: Version Control
|
||||||
|
|
||||||
- name: core
|
- name: core
|
||||||
|
|||||||
@@ -18,4 +18,4 @@ Three alternatives were rejected. Keeping the file-based fallback adds code comp
|
|||||||
|
|
||||||
The file-based model also had a structural weakness: issues in `docs/issues/` were invisible from the Gitea UI, making it impossible to track work, assign milestones, or filter by label without opening the repo locally. Gitea provides all of that natively.
|
The file-based model also had a structural weakness: issues in `docs/issues/` were invisible from the Gitea UI, making it impossible to track work, assign milestones, or filter by label without opening the repo locally. Gitea provides all of that natively.
|
||||||
|
|
||||||
The "Provider-agnostic issue tracker" glossary entry in CONTEXT.md is updated in the same workstream to remove the file-based phase framing. The `providers/gitea/` adapter path described in ADR-0011 was never implemented — Gitea integration runs entirely via MCP, not a provider adapter.
|
The "Provider-agnostic issue tracker" glossary entry in CONTEXT.md is updated in the same workstream to remove the file-based phase framing. (Amended 2026-08-17: the CONTEXT.md trim renamed that entry to **Issue**; it still records Gitea as this repo's canonical tracker and still tells skills to say "linked issue" generically.) The `providers/gitea/` adapter path described in ADR-0011 was never implemented — Gitea integration runs entirely via MCP, not a provider adapter.
|
||||||
|
|||||||
@@ -9,6 +9,12 @@ deferred PR #85 review item to broaden that coverage, retroactively captures #84
|
|||||||
(since it was never recorded as a decision in its own right), and layers the expansion on top
|
(since it was never recorded as a decision in its own right), and layers the expansion on top
|
||||||
without reversing or weakening the original four rules.
|
without reversing or weakening the original four rules.
|
||||||
|
|
||||||
|
**2026-08-17 amendment.** The CONTEXT.md section named above no longer holds that documentation.
|
||||||
|
CONTEXT.md was cut back to a glossary and the prefilter's mechanics — the two-copy style layout,
|
||||||
|
`vale-wrap.sh`, the `--config` argv defect, the rule inventory, and the 0-files-means-NOT-RUN
|
||||||
|
fallback — moved to `docs/spec/gates.md`. Read that file, not CONTEXT.md, for the harness itself;
|
||||||
|
this ADR still owns the scope decision.
|
||||||
|
|
||||||
**File scope stays the same.** `SKILL.md` plus agent files (`**/agents/*.md`,
|
**File scope stays the same.** `SKILL.md` plus agent files (`**/agents/*.md`,
|
||||||
`**/*.agent.md`) only — matching the existing prefilter's globs. Skill-level
|
`**/*.agent.md`) only — matching the existing prefilter's globs. Skill-level
|
||||||
`README.md` files and `plugin.json` manifests are not added: README.md files are navigational, not
|
`README.md` files and `plugin.json` manifests are not added: README.md files are navigational, not
|
||||||
|
|||||||
@@ -56,6 +56,10 @@ new hand-maintained manifest format.
|
|||||||
that work through to merge.
|
that work through to merge.
|
||||||
- `CONTEXT.md`'s "Plugin"/"Plugin marketplace" glossary entries were rewritten in issue #90 to
|
- `CONTEXT.md`'s "Plugin"/"Plugin marketplace" glossary entries were rewritten in issue #90 to
|
||||||
describe the compiled-output model directly, rather than carrying a forward-pointer to this ADR.
|
describe the compiled-output model directly, rather than carrying a forward-pointer to this ADR.
|
||||||
|
Superseded 2026-08-17: CONTEXT.md was cut back to one-line definitions, and the compiled-output
|
||||||
|
model is now described in `docs/spec/architecture.md`. The same trim deleted the "lint plugin"
|
||||||
|
entry cited under Considered options below; that pointer now reads `docs/spec/architecture.md`'s
|
||||||
|
plugin scope table, which carries the repo-agnostic-versus-marketplace-specific argument.
|
||||||
|
|
||||||
## Considered options
|
## Considered options
|
||||||
|
|
||||||
@@ -66,7 +70,7 @@ maintenance in place unchanged.
|
|||||||
|
|
||||||
**New standalone `plugins/apm/` plugin (rejected).** `plugins/lint/` was split out of `kyberforge`
|
**New standalone `plugins/apm/` plugin (rejected).** `plugins/lint/` was split out of `kyberforge`
|
||||||
specifically because Vale tooling is generic and repo-agnostic, not holocron-marketplace-specific
|
specifically because Vale tooling is generic and repo-agnostic, not holocron-marketplace-specific
|
||||||
(see `CONTEXT.md`'s "lint plugin" entry) — the same argument applies to a generic `apm` CLI
|
(see `docs/spec/architecture.md`'s plugin scope table) — the same argument applies to a generic `apm` CLI
|
||||||
wrapper. The shipped `apm-install`/`apm-workflow` skills are, in fact, generic, repo-agnostic APM
|
wrapper. The shipped `apm-install`/`apm-workflow` skills are, in fact, generic, repo-agnostic APM
|
||||||
CLI documentation with no holocron-specific content, so a standalone `plugins/apm/` would have
|
CLI documentation with no holocron-specific content, so a standalone `plugins/apm/` would have
|
||||||
been a defensible split on artifact content alone. Rejected anyway, in favor of `kyberforge`,
|
been a defensible split on artifact content alone. Rejected anyway, in favor of `kyberforge`,
|
||||||
|
|||||||
@@ -329,7 +329,9 @@ mirror does carry, and is reported.
|
|||||||
stands; this ADR fixes the second, previously-unverified half.
|
stands; this ADR fixes the second, previously-unverified half.
|
||||||
- `CONTEXT.md`'s "Plugin" and "Plugin marketplace" glossary entries are updated to describe the
|
- `CONTEXT.md`'s "Plugin" and "Plugin marketplace" glossary entries are updated to describe the
|
||||||
flat mirror as a second compiled-output category, alongside the existing
|
flat mirror as a second compiled-output category, alongside the existing
|
||||||
`.claude-plugin/plugin.json`/`marketplace.json` description.
|
`.claude-plugin/plugin.json`/`marketplace.json` description. Superseded 2026-08-17: CONTEXT.md was
|
||||||
|
cut back to one-line definitions and no longer describes either compiled-output category;
|
||||||
|
`docs/spec/architecture.md` is where the mirror is documented.
|
||||||
- A future apm release that ships a native `.apm/`-aware plugin.json compiler (closing this gap
|
- A future apm release that ships a native `.apm/`-aware plugin.json compiler (closing this gap
|
||||||
upstream) would let `sync-plugin-content.sh` and its drift gate be deleted outright — nothing in
|
upstream) would let `sync-plugin-content.sh` and its drift gate be deleted outright — nothing in
|
||||||
this ADR's decision depends on the flat mirror existing beyond satisfying the current installer's
|
this ADR's decision depends on the flat mirror existing beyond satisfying the current installer's
|
||||||
|
|||||||
@@ -59,7 +59,9 @@ answers to `git-commits` and `kyberforge:skill-audit` to `skill-audit`. This is
|
|||||||
a project skill has no plugin to prefix. `AGENTS.md` and `CONTEXT.md` are updated to name the bare
|
a project skill has no plugin to prefix. `AGENTS.md` and `CONTEXT.md` are updated to name the bare
|
||||||
form, which is what apm deploys and the only form a repo consuming holocron through apm gets.
|
form, which is what apm deploys and the only form a repo consuming holocron through apm gets.
|
||||||
|
|
||||||
**Correction (2026-08-14): the namespaced form did not stop resolving.** An earlier revision of
|
**Correction (2026-08-14): the namespaced form did not stop resolving.** *Superseded by the
|
||||||
|
2026-08-17 correction below: the machine state this cites is no longer present. Both are kept
|
||||||
|
because the pair is the finding — read neither as current.* An earlier revision of
|
||||||
this consequence said every `<plugin>:<skill>` reference "was stale the moment the switch landed",
|
this consequence said every `<plugin>:<skill>` reference "was stale the moment the switch landed",
|
||||||
and `AGENTS.md`/`CONTEXT.md` were written to match. That contradicts the "User scope is untouched,
|
and `AGENTS.md`/`CONTEXT.md` were written to match. That contradicts the "User scope is untouched,
|
||||||
deliberately" consequence below, and the contradiction resolves against it: `~/.claude.json` still
|
deliberately" consequence below, and the contradiction resolves against it: `~/.claude.json` still
|
||||||
@@ -72,6 +74,20 @@ survives those user-scope installs eventually being converted, and the namespace
|
|||||||
resolves for anyone installing holocron natively, so skill bodies written for both audiences
|
resolves for anyone installing holocron natively, so skill bodies written for both audiences
|
||||||
should name the bare skill.
|
should name the bare skill.
|
||||||
|
|
||||||
|
**Correction (2026-08-17): the evidence under the correction above is gone, and the claim goes with
|
||||||
|
it — not to its opposite.** Observed on this machine: `~/.claude/plugins/installed_plugins.json` is
|
||||||
|
`{"version": 2, "plugins": {}}`; there is no `enabledPlugins` key anywhere in `~/.claude.json`
|
||||||
|
(`grep -c enabledPlugins` returns 0); `~/.apm/marketplaces.json` is `{"marketplaces": []}`. The
|
||||||
|
`holocron` entry in `~/.claude/plugins/known_marketplaces.json` survives, but a registered
|
||||||
|
marketplace is not an installed plugin. So the user-scope installs the 2026-08-14 correction cited
|
||||||
|
are not there, and neither is the state the *original* consequence described before it. The claim
|
||||||
|
about the namespaced form has now been written twice off two different observations of the same
|
||||||
|
machine, and this ADR has already reversed itself once on it. That is the finding: the fact is
|
||||||
|
machine state, not a property of this decision, and it changes without any commit. No instruction
|
||||||
|
file — `AGENTS.md`, `CONTEXT.md`, or a skill body — should assert either way whether
|
||||||
|
`<plugin>:<skill>` resolves. The rule that survives every observation is the one that was always the
|
||||||
|
actionable half: write the bare name, because it is the only form `apm install` produces.
|
||||||
|
|
||||||
**apm owns `.claude/settings.json`.** (ADR-0019 supersedes the "exactly `{"hooks": {}}`" claim
|
**apm owns `.claude/settings.json`.** (ADR-0019 supersedes the "exactly `{"hooks": {}}`" claim
|
||||||
below — once a package ships a hook, apm merges it into that file and the merged entry is apm's own
|
below — once a package ships a hook, apm merges it into that file and the merged entry is apm's own
|
||||||
output. The rule that nothing repo-authored goes in the file is unchanged.) `apm audit --ci` replays the install into a scratch tree and
|
output. The rule that nothing repo-authored goes in the file is unchanged.) `apm audit --ci` replays the install into a scratch tree and
|
||||||
@@ -117,10 +133,11 @@ pinned `resolved_commit` in `apm.lock.yaml` and does not re-resolve refs (`apm i
|
|||||||
documents this explicitly — "does NOT refresh refs; use 'apm update' for that"). Running it after a
|
documents this explicitly — "does NOT refresh refs; use 'apm update' for that"). Running it after a
|
||||||
merge redeploys the same content and reports success.
|
merge redeploys the same content and reports success.
|
||||||
|
|
||||||
**User scope is untouched, deliberately.** `bin@holocron`, `gitea@holocron`, and a stale
|
**User scope is untouched, deliberately.** This decision changed project scope only; whatever is
|
||||||
`hello-world@holocron` remain natively installed at user scope, and every project other than this
|
natively installed at user scope was left alone, and converting it is a separate decision with a
|
||||||
one still resolves its skills that way. Converting them is a separate decision with a blast radius
|
blast radius beyond this repo. The specific inventory this paragraph used to name
|
||||||
beyond this repo.
|
(`bin@holocron`, `gitea@holocron`, a stale `hello-world@holocron`) is machine state and is stale —
|
||||||
|
see the 2026-08-17 correction above. The decision recorded here is unaffected by what that state is.
|
||||||
|
|
||||||
## Alternatives considered
|
## Alternatives considered
|
||||||
|
|
||||||
|
|||||||
227
docs/adr/0021-plugin-descriptions-state-a-domain-boundary.md
Normal file
227
docs/adr/0021-plugin-descriptions-state-a-domain-boundary.md
Normal file
@@ -0,0 +1,227 @@
|
|||||||
|
# A plugin's published description states its domain boundary and never enumerates its skills
|
||||||
|
|
||||||
|
Three of this repo's six plugins publish a `description` that lists the skills they ship. That style
|
||||||
|
has now failed three times in four days, the third time inside the correction for the second. It is
|
||||||
|
enforced by nothing, it obliges a marketplace release on every skill addition, and it was never
|
||||||
|
applied to the other three plugins. This ADR retires it: a published description says what the
|
||||||
|
plugin is *for*, and the inventory lives where an inventory can be read off the tree.
|
||||||
|
|
||||||
|
**Status: accepted (2026-08-17).**
|
||||||
|
|
||||||
|
## Context
|
||||||
|
|
||||||
|
A plugin's published description is one string authored twice — in `plugins/<name>/apm.yml` and in
|
||||||
|
the matching `marketplace.packages[]` entry of the root `apm.yml` — and compiled into four generated
|
||||||
|
files per plugin edit: the plugin's `.claude-plugin/plugin.json` and `.github/plugin/plugin.json`,
|
||||||
|
plus the repo-wide `.claude-plugin/marketplace.json` and its `.github/plugin/marketplace.json`
|
||||||
|
mirror. (`.agents/plugins/marketplace.json`, apm's codex profile, carries no per-package
|
||||||
|
`description` or `version` at all and is unaffected.) It is the only text a consumer sees in a marketplace listing before
|
||||||
|
installing. It is **not** a SKILL.md `description`: it is never preloaded into an agent's context and
|
||||||
|
routes nothing at runtime. ADR-0020 governs that other artifact; this one governs this one. The
|
||||||
|
overlap is a finding, not a scope: ADR-0020 established that capability enumeration in a description
|
||||||
|
is "a correctness hazard, not only a token cost". The hazard at this layer is different — staleness
|
||||||
|
in published metadata rather than an agent shortcutting the body — but the enumeration is the same
|
||||||
|
construct and it fails the same way.
|
||||||
|
|
||||||
|
Measured at `de84d1b`, the branch tip before this change. Each figure is reproducible from the tree:
|
||||||
|
skill counts are `ls plugins/<name>/.apm/skills/ | wc -l`, description text is
|
||||||
|
`plugins/<name>/apm.yml`.
|
||||||
|
|
||||||
|
| Plugin | Style | Skills | Items enumerated | Skills named | Unnamed |
|
||||||
|
|---|---|---|---|---|---|
|
||||||
|
| `bin` | enumeration | 11 | 8 | 9 | `caveman`, `zoom-out` |
|
||||||
|
| `git` | enumeration | 9 | 8 | 8 | `git-workflow` |
|
||||||
|
| `gitea` | enumeration | 7 | 7 | 6 | `gitea-workflow` |
|
||||||
|
| `core` | boundary | 3 | — | — | — |
|
||||||
|
| `kyberforge` | boundary | 7 | — | — | — |
|
||||||
|
| `lint` | boundary | 2 | — | — | — |
|
||||||
|
|
||||||
|
Three failures, in order.
|
||||||
|
|
||||||
|
**`bb9158d` (2026-08-14) — `core`'s description described `bin`.** The text it deleted read
|
||||||
|
"Cross-cutting utility skills for everyday AI-assisted coding — triage, diagnosis, architecture
|
||||||
|
review, and session navigation." All four items are real skills and not one of them is `core`'s:
|
||||||
|
they are `bin`'s `triage`, `diagnose`, `improve-codebase-architecture` and `zoom-out`. `core` ships
|
||||||
|
`agentsmd-author`, `agentsmd-audit` and `provider-adapter-author`, and the published description
|
||||||
|
named none of them.
|
||||||
|
|
||||||
|
This is the failure the whole style was later adopted against, and it is worth being exact about
|
||||||
|
what it was, because the record has been read the other way twice since. It was **wrong content**,
|
||||||
|
not an incomplete list. The description was a syntactically perfect, complete, four-item enumeration
|
||||||
|
of a real skill set; it just belonged to a different plugin. Enumerating harder could not have caught
|
||||||
|
it, and a gate that asked "does every enumerated item exist as a skill?" would have passed it — all
|
||||||
|
four did exist. `bb9158d`'s own fix went the other direction: it replaced the enumeration with a
|
||||||
|
domain boundary, and `core` has needed no correction since. The precedent set by that commit was
|
||||||
|
therefore *boundary*, and the two commits below cite it while doing the opposite.
|
||||||
|
|
||||||
|
**`65bac15` (2026-08-17) — `git` advertised `gitea`'s domain, `gitea` advertised a skill that does
|
||||||
|
not exist.** `git` read "conventional commits, branch management, pull requests, and feature flow";
|
||||||
|
pull requests reach the forge over HTTP and are `gitea`'s, which is the exact boundary
|
||||||
|
`docs/spec/architecture.md` draws between the two plugins. `gitea` read "issues, pull requests,
|
||||||
|
milestones, releases, and wikis"; `grep -ri wiki plugins/gitea/.apm/` returns nothing and no wiki
|
||||||
|
skill has ever existed. Both were repaired by re-enumerating.
|
||||||
|
|
||||||
|
**`de84d1b` (2026-08-17) — the re-enumeration was itself incomplete.** `bin`'s "A place for things to
|
||||||
|
be binned" was replaced with an eight-item list over eleven skills; `caveman` and `zoom-out` are
|
||||||
|
absent. `zoom-out` is the same skill `bb9158d` had called "session navigation" three days earlier
|
||||||
|
while deleting it from the wrong plugin's description — named when it was in the wrong place,
|
||||||
|
unnamed once it was in the right one. And the miss is not confined to `bin`: `git-workflow` is
|
||||||
|
unnamed in `git`'s corrected description, though `65bac15`'s own commit message states it was added
|
||||||
|
("omitting pc-author/pc-run, git-submodules and git-workflow"), and `gitea-workflow` is unnamed in
|
||||||
|
`gitea`'s. Across the three plugins, 23 of 27 skills are named at the third attempt.
|
||||||
|
|
||||||
|
**Nothing checks any of this.** `scripts/check-manifests.sh` does not contain the string
|
||||||
|
`description`. The three ADR-0020 validators (`scripts/skill-size-check.sh` and skill-audit's and
|
||||||
|
agent-audit's `validate.sh`) gate on SKILL.md and agent frontmatter; they do open `apm.yml`, but only
|
||||||
|
to read `dependencies.apm` when resolving the boundary-target universe — none of them reads the
|
||||||
|
`description:` key, and their hook globs match `SKILL.md` and `*.agent.md` only. `apm audit --ci`,
|
||||||
|
`apm pack --check-clean` and `scripts/sync-plugin-content.sh --check --all` all compare compiled
|
||||||
|
output against `apm.yml`, so their entire job is to propagate whatever the description says into
|
||||||
|
those four files byte-for-byte and confirm they match. The `wiki` claim passed every one of the fourteen pre-push hooks, every day it
|
||||||
|
was published.
|
||||||
|
|
||||||
|
**And the obligation is unbounded.** Under enumeration, adding one skill to `bin`, `git` or `gitea`
|
||||||
|
means editing two copies of a prose string on top of the version bumps and regeneration any skill
|
||||||
|
addition already owes under this repo's release policy
|
||||||
|
(`plugins/kyberforge/.apm/skills/apm-workflow/references/marketplace.md`). The bumps are not the
|
||||||
|
marginal cost — the prose edit is, and it is the half nothing checks. A skill *rename* triggers the
|
||||||
|
same, for a string no consumer can tell went stale. 27 of the repo's 39 skills sat behind
|
||||||
|
a description carrying that obligation; the other 12 did not, and their three plugins have generated
|
||||||
|
no defect of this class.
|
||||||
|
|
||||||
|
### Scope
|
||||||
|
|
||||||
|
This decision covers the six plugins this repo authors. The root marketplace also lists
|
||||||
|
`mattpocock-skills`, a third-party package whose description is not this repo's to write; its entry
|
||||||
|
is out of scope and is left as published upstream.
|
||||||
|
|
||||||
|
## Decision
|
||||||
|
|
||||||
|
**A plugin's published `description` states the plugin's domain boundary. It does not enumerate the
|
||||||
|
skills the plugin ships, by name or by paraphrase.**
|
||||||
|
|
||||||
|
- The boundary answers "what kind of work belongs to this plugin, and where is its edge against its
|
||||||
|
nearest sibling" — the question a consumer deciding whether to install is actually asking. It is
|
||||||
|
stable under skill addition, rename and removal, which is the entire point: an artifact that does
|
||||||
|
not change when the tree changes cannot go stale against it.
|
||||||
|
- **The boundary must cover everything the plugin actually ships.** A boundary drawn narrower than
|
||||||
|
the contents is the same defect as an incomplete enumeration, one level up, and it is the specific
|
||||||
|
risk in this change. `git` carries `pc-author` and `pc-run`, which are not git operations at all;
|
||||||
|
"Skills for working with Git" silently drops them, so the boundary names the pre-commit hooks
|
||||||
|
explicitly rather than trusting a reader to file them under Git.
|
||||||
|
- The two copies — package `apm.yml` and the root `marketplace.packages[]` entry — stay identical.
|
||||||
|
This is already the rule in practice and both prior corrections state why: the root entry is what
|
||||||
|
reaches the compiled marketplace, so fixing only the package manifest leaves it half-propagated.
|
||||||
|
- The three descriptions, rewritten here, with `core`/`kyberforge`/`lint` shown for register:
|
||||||
|
|
||||||
|
| Plugin | Published description | Chars |
|
||||||
|
|---|---|---|
|
||||||
|
| `bin` | Skills for everyday AI-assisted development work that is not tied to a single tool, forge or language, and has not yet been split into a focused plugin. | 152 |
|
||||||
|
| `git` | Skills and agents for working with a local Git clone over the git wire protocol, and for authoring and running the pre-commit hooks that guard it. | 146 |
|
||||||
|
| `gitea` | Skills and agents for working with a Gitea forge through its HTTP API — the forge's own objects, as distinct from the local git clone. | 134 |
|
||||||
|
| `core` | *(unchanged)* Skills for authoring and auditing a repo's AGENTS.md and the provider adapter files that defer to it. | 101 |
|
||||||
|
| `kyberforge` | *(unchanged)* Skills and agents for creating, maintaining, and managing a Claude Code / Copilot CLI plugin marketplace. | 105 |
|
||||||
|
| `lint` | *(unchanged)* Skills and agents for configuring and running linters. | 54 |
|
||||||
|
|
||||||
|
- **No gate is added.** This is a deliberate omission and the reasoning is below, not an item left
|
||||||
|
for later.
|
||||||
|
|
||||||
|
### Why no gate
|
||||||
|
|
||||||
|
The check enumeration would need — "every skill directory appears in the description" — was writable
|
||||||
|
in principle and was never written, including by the two commits that corrected an enumeration by
|
||||||
|
enumerating again and had every reason to. It is also only half a check: it
|
||||||
|
catches a skill missing from the list, and it cannot catch `wiki`, because "this noun does not name
|
||||||
|
any skill" requires a vocabulary of permissible non-skill nouns that no one is going to maintain.
|
||||||
|
Under a boundary there is no correspondence left to check, which is the property being bought.
|
||||||
|
|
||||||
|
What survives un-gated is `bb9158d`'s actual failure: a boundary that is simply wrong about its
|
||||||
|
plugin. That was never machine-checkable in either style — the text was a well-formed description of
|
||||||
|
a real plugin — and it is caught by the same review that has to happen when a published,
|
||||||
|
consumer-facing string is edited at all. A gate that would catch it needs a declared per-plugin
|
||||||
|
skill-to-boundary mapping for the description to be checked against, which is a second artifact
|
||||||
|
requiring exactly the per-skill maintenance this ADR exists to delete, relocated one file over.
|
||||||
|
|
||||||
|
Two cheap partial gates were considered and rejected in the same breath. Forbidding a comma-separated
|
||||||
|
run of three or more noun phrases is a prose heuristic that fires on `lint`'s perfectly good
|
||||||
|
"configuring and running linters" class of sentence. Forbidding any string matching a skill directory
|
||||||
|
name under `plugins/<name>/.apm/skills/` bans legitimate boundary vocabulary — `git-branches` exists,
|
||||||
|
and a `git` boundary has every right to say "branches". Both would be believed, and both would be
|
||||||
|
wrong, which ADR-0020 already records as worse than no gate.
|
||||||
|
|
||||||
|
## Considered options
|
||||||
|
|
||||||
|
**Keep enumeration and gate it.** The only option that makes the current style safe. Rejected on the
|
||||||
|
three grounds above: the check is one-directional, it cannot see an invented capability, and it makes
|
||||||
|
a marketplace release the consequence of adding a directory. It also hard-couples published consumer
|
||||||
|
copy to internal directory names, so a skill rename becomes a version bump on the plugin and on the
|
||||||
|
marketplace.
|
||||||
|
|
||||||
|
**Enumerate consistently across all six plugins**, on the grounds that the real defect is the split
|
||||||
|
style. Rejected: it takes an obligation that has produced three failures on three plugins and applies
|
||||||
|
it to six. The measured outcome of the most recent attempt to enumerate carefully, with the defect
|
||||||
|
fresh and two prior commits as precedent, is four skills unnamed.
|
||||||
|
|
||||||
|
**Cap the description length**, mirroring ADR-0020's 250/400-character tiers, on the theory that a
|
||||||
|
short description has no room to enumerate. Rejected because length does not measure correspondence:
|
||||||
|
`gitea`'s failing description was 96 characters and asserted a skill that has never existed, while
|
||||||
|
`bin`'s 176-character enumeration is under the same cap. All six descriptions here, before and after,
|
||||||
|
sit inside ADR-0020's tiers; the tier would have been silent through all three failures.
|
||||||
|
|
||||||
|
**Delete the description to a bare name.** Rejected: apm's Claude marketplace mapper emits
|
||||||
|
`description` into `marketplace.json`, and it is the only prose a consumer sees before installing.
|
||||||
|
|
||||||
|
**Point the description at the plugin's `README.md`.** Rejected: a marketplace listing renders a
|
||||||
|
string, not a link — and the README's own plugin list carries the same enumeration with the same
|
||||||
|
staleness, so this relocates the defect rather than fixing it.
|
||||||
|
|
||||||
|
## Consequences
|
||||||
|
|
||||||
|
**Three descriptions are rewritten and the compiled output regenerated.** Eight generated files
|
||||||
|
change: `plugins/{bin,git,gitea}/.claude-plugin/plugin.json`,
|
||||||
|
`plugins/{bin,git,gitea}/.github/plugin/plugin.json`, `.claude-plugin/marketplace.json` and its
|
||||||
|
byte-identical `.github/plugin/marketplace.json` mirror. `.agents/plugins/marketplace.json` (the
|
||||||
|
codex profile) is unchanged and correctly so — it carries no per-package `description` or `version`
|
||||||
|
field at all, only `name`, `source`, `policy` and `category`.
|
||||||
|
|
||||||
|
**Version bumps, all PATCH under the `per_package` strategy:** `bin` 1.1.4 → 1.1.5, `git` 1.3.4 →
|
||||||
|
1.3.5, `gitea` 1.3.5 → 1.3.6, `marketplace.version` 0.4.4 → 0.4.5.
|
||||||
|
|
||||||
|
**The root `apm.yml` top-level `version:` is restored to lockstep with `marketplace.version`,
|
||||||
|
0.4.2 → 0.4.5.** These two fields have moved together in every commit that has ever touched root
|
||||||
|
`apm.yml` — 0.3.2, 0.3.3, 0.3.4, 0.4.0, 0.4.1, 0.4.2 in both — until `65bac15` and
|
||||||
|
`de84d1b` on this branch bumped `marketplace.version` to 0.4.3 and then 0.4.4 while leaving the
|
||||||
|
top-level field at 0.4.2. Lockstep is not folklore: it is stated at
|
||||||
|
`plugins/kyberforge/.apm/skills/apm-workflow/references/marketplace.md`. This is a defect, not a
|
||||||
|
style: `apm.yml`'s comment inside the marketplace block records that the top-level `version:` is not inherited into the compiled output
|
||||||
|
"despite being used elsewhere (e.g. by `apm audit`)", so the field is live and was silently two
|
||||||
|
releases behind what the marketplace published. Closed here rather than tracked, because the
|
||||||
|
correction is one line and the drift is three days old.
|
||||||
|
|
||||||
|
**`docs/spec/architecture.md`'s plugin table is unchanged and stays a routing table.** It answers
|
||||||
|
"where does a new skill go" for someone working *inside* this repo; the published description answers
|
||||||
|
"should I install this" for someone outside it. The two now read similarly, and that is not
|
||||||
|
duplication to collapse — they have different readers and different lifecycles, and the table already
|
||||||
|
says so in its own preamble ("These are routing boundaries, not inventories"). One caveat for whoever
|
||||||
|
next edits that page: its closing sentence sends a reader to the published description "for what a
|
||||||
|
consumer actually gets", which was true against an enumeration and is now a pointer to a second
|
||||||
|
boundary statement. Neither artifact carries an inventory after this change, so that sentence was
|
||||||
|
rewritten in the same branch to point at `plugins/<name>/.apm/skills/` and `README.md` instead.
|
||||||
|
|
||||||
|
**`README.md`'s plugin bullet list becomes the only place an inventory lives, and it still
|
||||||
|
enumerates.** That is deliberate, but it makes the list load-bearing in a way it was not before, so
|
||||||
|
its `bin`, `git` and `gitea` bullets were completed in the same branch to name every skill those
|
||||||
|
plugins ship. This ADR does not otherwise extend to it: a README is a hand-read document where a
|
||||||
|
list of what you get is the useful thing, it is not compiled into four files, and a stale line in it
|
||||||
|
costs a reader a moment rather than misrepresenting a published package. The tradeoff that makes
|
||||||
|
enumeration wrong in a marketplace manifest is precisely the one that makes it fine there.
|
||||||
|
|
||||||
|
**Nothing in the ADR-0020 gate set changes.** Its character and word tiers, its Vale rules and its
|
||||||
|
three validators all read `SKILL.md` and `*.agent.md` frontmatter; none of them opens an `apm.yml`.
|
||||||
|
The two contracts are adjacent and independent, and a future author retrofitting a skill under
|
||||||
|
issue #99 is not touched by this ADR.
|
||||||
|
|
||||||
|
**The failure mode this leaves open is a wrong boundary, and it is un-gated by design.** If a fourth
|
||||||
|
failure of this class occurs it will be a description that describes the wrong plugin — `bb9158d`'s
|
||||||
|
shape, the one enumeration never addressed. That is the trigger to revisit, and the thing to build
|
||||||
|
then is a declared skill-to-boundary mapping, not a return to enumeration.
|
||||||
@@ -21,11 +21,26 @@ project repo (local overrides)
|
|||||||
|
|
||||||
Skills are **not** deployed by `install.sh`. They are distributed as plugins and installed separately — in this repo by `apm install` against the `dependencies.apm` entries in the root `apm.yml`, which lands them in `.claude/skills/` and `.claude/agents/` (ADR-0018); elsewhere by `claude plugin install <name>@holocron`.
|
Skills are **not** deployed by `install.sh`. They are distributed as plugins and installed separately — in this repo by `apm install` against the `dependencies.apm` entries in the root `apm.yml`, which lands them in `.claude/skills/` and `.claude/agents/` (ADR-0018); elsewhere by `claude plugin install <name>@holocron`.
|
||||||
|
|
||||||
`~/.claude/CLAUDE.md` is a thin adapter, not a content source. It imports `~/.agents/AGENTS.md` (always-on rules) and `governance.md` (always-on governance), then lists the content index. All always-on content lives in `AGENTS.md` files so other providers can import the same source without duplication.
|
`~/.claude/CLAUDE.md` is a thin adapter, not a content source. It imports `~/.agents/AGENTS.md` (always-on rules) and `governance.md` (always-on governance) and carries nothing else — the content index of on-demand instruction files sits in `core/AGENTS.md`, deployed to `~/.agents/AGENTS.md` and imported by it. All always-on content lives in `AGENTS.md` files so other providers can import the same source without duplication.
|
||||||
|
|
||||||
## Plugin model
|
## Plugin model
|
||||||
|
|
||||||
Skills, agents, MCP servers, and hooks are distributed as self-contained plugin units under `plugins/`, installed independently — via `apm install` here, or `claude plugin install <name>@holocron` for a host consuming the marketplace natively (ADR-0018). Each plugin is an **apm package**: `plugins/<name>/apm.yml` plus a hand-authored `plugins/<name>/.apm/{skills,agents,hooks,commands,instructions,extensions}/` tree (ADR-0015). There is no hand-maintained `plugin.json` — every manifest and every host-visible content directory is compiled from that source.
|
Skills, agents, MCP servers, and hooks are distributed as self-contained plugin units under `plugins/`, installed independently — via `apm install` here, or `claude plugin install <name>@holocron` for a host consuming the marketplace natively (ADR-0018). Self-contained is a hard constraint, not a description: a plugin is copied to a cache on install, so nothing inside it may reference a file outside its own directory. That is why the Vale styles are duplicated across two skills rather than shared (ADR-0014), and why ADR-0020's constants are copied into three validators rather than sourced from one. Each plugin is an **apm package**: `plugins/<name>/apm.yml` plus a hand-authored `plugins/<name>/.apm/{skills,agents,hooks,commands,instructions,extensions}/` tree (ADR-0015). There is no hand-maintained `plugin.json` — every manifest and every host-visible content directory is compiled from that source.
|
||||||
|
|
||||||
|
Which plugin a new skill belongs in follows from what each one is scoped to. The boundary that matters most in practice is `core` vs `kyberforge`: `core` is the home for cross-cutting, repo-agnostic utility skills that a consumer would want against *their* repo, while `kyberforge` is meta-tooling for the holocron marketplace itself. A skill that authors a target repo's `AGENTS.md` is `core`; a skill that audits a `SKILL.md` against this marketplace's contract is `kyberforge`.
|
||||||
|
|
||||||
|
The second boundary worth stating is `git` vs `gitea`, because both own things called branches and both touch pull requests: `git` is whatever works over the git wire protocol against a local clone, `gitea` is whatever goes through the forge's HTTP API. That is why `git-branches` and `gitea-branches` both exist and are not duplicates.
|
||||||
|
|
||||||
|
These are routing boundaries, not inventories — they answer "where does a new skill go", so they deliberately do not enumerate what each plugin ships today. The plugin's published `description` in its `apm.yml` states the same boundary for a consumer deciding whether to install (ADR-0021); neither carries an inventory. For what a plugin ships today, read `plugins/<name>/.apm/skills/` or the plugin list in `README.md`.
|
||||||
|
|
||||||
|
| Plugin | Scope |
|
||||||
|
|---|---|
|
||||||
|
| `core` | Authoring and auditing a repo's `AGENTS.md` and the provider adapter files that defer to it |
|
||||||
|
| `git` | Git operations and git hook tooling — anything driven over the git wire protocol against a local clone, plus the pre-commit hooks that guard it |
|
||||||
|
| `gitea` | Anything reached through the Gitea HTTP API rather than the git wire protocol — the forge's own objects |
|
||||||
|
| `kyberforge` | Creating and maintaining a Claude Code / Copilot CLI plugin marketplace — this repo's own meta-tooling |
|
||||||
|
| `lint` | Configuring and running linters against a target repo; repo-agnostic, first linter is Vale |
|
||||||
|
| `bin` | Unsorted skills that have not earned a home yet |
|
||||||
|
|
||||||
Two compilers produce the plugin roots you see in the tree:
|
Two compilers produce the plugin roots you see in the tree:
|
||||||
|
|
||||||
@@ -40,6 +55,8 @@ That immunity is positional, not by filename. Anything placed *inside* a mirrore
|
|||||||
|
|
||||||
`core/instructions/governance.md` is the always-on governance instruction file. Unlike the on-demand instruction files in the content index, governance.md is loaded into every Claude session via `@import` in `providers/claude-code/CLAUDE.md`. This is a technical guarantee, not a behavioural instruction — `@import` causes Claude Code to expand and load the file at launch, before any interaction begins.
|
`core/instructions/governance.md` is the always-on governance instruction file. Unlike the on-demand instruction files in the content index, governance.md is loaded into every Claude session via `@import` in `providers/claude-code/CLAUDE.md`. This is a technical guarantee, not a behavioural instruction — `@import` causes Claude Code to expand and load the file at launch, before any interaction begins.
|
||||||
|
|
||||||
|
Those on-demand files are plain markdown — no frontmatter, no schema. The agent decides when to read each one from task context and the content index label alone. Frontmatter is deferred until there is evidence that agents are loading the wrong files in practice; it is a deliberate deferral, not an oversight to close.
|
||||||
|
|
||||||
The governance layer has two phases:
|
The governance layer has two phases:
|
||||||
- **Phase 1** (complete): instruction and documentation layer — `governance.md` loaded via `@import`; `docs/ai-constitution.md` and `docs/wiki/HUMANS.md` as human-facing reference; `CONTEXT.md` extended with governance domain language.
|
- **Phase 1** (complete): instruction and documentation layer — `governance.md` loaded via `@import`; `docs/ai-constitution.md` and `docs/wiki/HUMANS.md` as human-facing reference; `CONTEXT.md` extended with governance domain language.
|
||||||
- **Phase 2** (planned): deterministic enforcement layer — pre-commit hooks, CI gates, secret scanning, licence scanning. Specified in `docs/research/governance_principles/CONTROLS.md`.
|
- **Phase 2** (planned): deterministic enforcement layer — pre-commit hooks, CI gates, secret scanning, licence scanning. Specified in `docs/research/governance_principles/CONTROLS.md`.
|
||||||
@@ -57,10 +74,14 @@ This repo also has a `CLAUDE.md` at its root — the Claude Code entry point for
|
|||||||
|
|
||||||
`CONTEXT.md` is therefore **not** always-loaded. `AGENTS.md` instructs agents to read it at session start, which is a behavioural instruction, not an `@import` guarantee — `LESSONS.md`'s 2026-05-17 entry proposed adding the import and it was never applied. Treat that entry as open work rather than a record of a landed change.
|
`CONTEXT.md` is therefore **not** always-loaded. `AGENTS.md` instructs agents to read it at session start, which is a behavioural instruction, not an `@import` guarantee — `LESSONS.md`'s 2026-05-17 entry proposed adding the import and it was never applied. Treat that entry as open work rather than a record of a landed change.
|
||||||
|
|
||||||
|
## Reference conventions
|
||||||
|
|
||||||
|
The stated convention is that files referencing other files declare those references explicitly: the referencing file carries the forward reference (the content index in `core/AGENTS.md`, `references:` in frontmatter), the referenced file carries a `when:` field describing when it is loaded, and divergence between the two signals staleness. It is aspirational, not a description of the repo today — no file under `core/instructions/` carries frontmatter at all, `when:` appears in exactly one of the 39 `SKILL.md` sources under `plugins/*/.apm/skills/`, and the reference scanner script meant to derive the reverse map ("what files reference this file?") does not exist; `docs/notes/skill-implementation-workflow.md` still lists it as unbuilt work. Treat it as intent for instruction files, skills, and workflow documents, not as a rule the repo enforces.
|
||||||
|
|
||||||
## Provider model
|
## Provider model
|
||||||
|
|
||||||
`core/` is never tool-specific. `providers/` is never shared. When adding a new provider, write an adapter in `providers/<name>/` that translates core content into the tool's expected format and location. The core content itself does not change.
|
`core/` is never tool-specific. `providers/` is never shared. When adding a new provider, write an adapter in `providers/<name>/` that translates core content into the tool's expected format and location. The core content itself does not change.
|
||||||
|
|
||||||
## Architectural decisions
|
## Architectural decisions
|
||||||
|
|
||||||
Key hard-to-reverse decisions are recorded as ADRs in `docs/adr/`. There is no index file — the directory holds 20 numbered ADRs whose filenames state their decision, so `ls docs/adr/` is the index. Read a superseding ADR before the one it supersedes: ADR-0015 (apm as the authoring source of truth) supersedes ADR-0001 and moots ADR-0006, ADR-0017 corrects ADR-0015's host-discovery gap, and ADR-0019 supersedes one claim in ADR-0018 (that `.claude/settings.json`'s committed content is exactly `{"hooks": {}}`) while keeping the rule behind it. Entry points for the structure described on this page: ADR-0002 (two-tier CLAUDE.md), ADR-0003 (AGENTS.md as the provider-agnostic entry point), ADR-0015 and ADR-0017 (the two compilers behind the plugin roots).
|
Key hard-to-reverse decisions are recorded as ADRs in `docs/adr/`. There is no index file — the directory holds numbered ADRs whose filenames state their decision, so `ls docs/adr/` is the index. Read a superseding ADR before the one it supersedes: ADR-0015 (apm as the authoring source of truth) supersedes ADR-0001 and moots ADR-0006, ADR-0017 corrects ADR-0015's host-discovery gap, and ADR-0019 supersedes one claim in ADR-0018 (that `.claude/settings.json`'s committed content is exactly `{"hooks": {}}`) while keeping the rule behind it. Entry points for the structure described on this page: ADR-0002 (two-tier CLAUDE.md), ADR-0003 (AGENTS.md as the provider-agnostic entry point), ADR-0015 and ADR-0017 (the two compilers behind the plugin roots).
|
||||||
|
|||||||
@@ -14,7 +14,7 @@ of the oddities documented here are load-bearing and have already been re-litiga
|
|||||||
| Command | Scope |
|
| Command | Scope |
|
||||||
|---|---|
|
|---|---|
|
||||||
| `pre-commit run --all-files` | the commit-stage hooks |
|
| `pre-commit run --all-files` | the commit-stage hooks |
|
||||||
| `pre-commit run --hook-stage pre-push --all-files` | the whole push gate, one command |
|
| `pre-commit run --hook-stage pre-push --all-files` | the push gate, one command — with one caveat below |
|
||||||
| `pre-commit run skill-size-check --all-files` | just the ADR-0020 size/context gates |
|
| `pre-commit run skill-size-check --all-files` | just the ADR-0020 size/context gates |
|
||||||
|
|
||||||
Install hooks via `pc-run`, wiring **all three stages**. This repo's `.pre-commit-config.yaml` has no
|
Install hooks via `pc-run`, wiring **all three stages**. This repo's `.pre-commit-config.yaml` has no
|
||||||
@@ -23,11 +23,22 @@ and `pre-push` (everything below).
|
|||||||
|
|
||||||
The pre-push command reports **16** hooks, not 14. The extra two are pre-commit's own `meta` hooks,
|
The pre-push command reports **16** hooks, not 14. The extra two are pre-commit's own `meta` hooks,
|
||||||
`check-hooks-apply` and `check-useless-excludes`: they declare no `stages:`, so they run at every
|
`check-hooks-apply` and `check-useless-excludes`: they declare no `stages:`, so they run at every
|
||||||
stage including this one. Fourteen is the count of repo-defined pre-push hooks.
|
stage including this one. Both are declared in this repo's `.pre-commit-config.yaml` like everything
|
||||||
|
else — what separates them is `repo: meta` (pre-commit's own built-ins) from `repo: local`. Fourteen
|
||||||
|
is the count of hooks this repo authors itself.
|
||||||
|
|
||||||
|
**The caveat: one of those 14 is a silent no-op under that invocation.**
|
||||||
|
`check-release-needed` exits 0 immediately unless `PRE_COMMIT_REMOTE_BRANCH` equals
|
||||||
|
`refs/heads/main`, and pre-commit exports that variable only from the real pre-push git hook during
|
||||||
|
an actual `git push`. Running the stage by hand — or from a CI runner — therefore reports it
|
||||||
|
`Passed` having checked nothing. That is by design for feature branches — pushing WIP must not be
|
||||||
|
blocked on cutting a premature tag — but it means `--hook-stage pre-push --all-files` is a full
|
||||||
|
rehearsal of 13 hooks and a skip of the fourteenth. The script's own header records the same gap for
|
||||||
|
a PR merged through Gitea's merge button, where no local push happens at all.
|
||||||
|
|
||||||
## The pre-push gate
|
## The pre-push gate
|
||||||
|
|
||||||
Fourteen hooks, in config order.
|
Fourteen hooks, grouped below by what they guard rather than by the order `.pre-commit-config.yaml` declares them in.
|
||||||
|
|
||||||
**Core checks**
|
**Core checks**
|
||||||
|
|
||||||
@@ -74,7 +85,7 @@ drift in generated text.
|
|||||||
|
|
||||||
| Hook | Guards |
|
| Hook | Guards |
|
||||||
|---|---|
|
|---|---|
|
||||||
| `check-release-needed` | on push to `main` only — fails if files exposed via `.pre-commit-hooks.yaml` changed since the last tag |
|
| `check-release-needed` | on a real `git push` to `main` only — fails if files exposed via `.pre-commit-hooks.yaml` changed since the last tag. A no-op everywhere else, including under `pre-commit run --hook-stage pre-push` (see [the caveat above](#running-the-gates)) |
|
||||||
|
|
||||||
Four of these shell out to `apm`: `apm-marketplace-check`, `apm-audit-ci`, `apm-pack-check-clean`,
|
Four of these shell out to `apm`: `apm-marketplace-check`, `apm-audit-ci`, `apm-pack-check-clean`,
|
||||||
and `check-plugin-content-sync` (via `scripts/sync-plugin-content.sh`, which wraps `apm pack`). The
|
and `check-plugin-content-sync` (via `scripts/sync-plugin-content.sh`, which wraps `apm pack`). The
|
||||||
@@ -87,7 +98,10 @@ loudly (`Error: jq is required but not installed`).
|
|||||||
## Skill and agent context gates (ADR-0020)
|
## Skill and agent context gates (ADR-0020)
|
||||||
|
|
||||||
The `skill-size-check` pre-commit hook, scoped to `^plugins/[^/]+/\.apm/skills/[^/]+/SKILL\.md$`,
|
The `skill-size-check` pre-commit hook, scoped to `^plugins/[^/]+/\.apm/skills/[^/]+/SKILL\.md$`,
|
||||||
runs `scripts/skill-size-check.sh`.
|
runs `scripts/skill-size-check.sh`. That scope means it never lints the
|
||||||
|
`plugins/kyberforge/docs/research/examples/` reference skills. It is also shipped to external repos
|
||||||
|
as `kyberforge-skill-size-check` (see
|
||||||
|
[External consumers](#external-consumers-the-root-pre-commit-hooksyaml)).
|
||||||
|
|
||||||
### Two independent gate families, neither replaced the other
|
### Two independent gate families, neither replaced the other
|
||||||
|
|
||||||
@@ -105,14 +119,13 @@ runs `scripts/skill-size-check.sh`.
|
|||||||
| `description` characters | 250 | 400 | the YAML-**folded** value |
|
| `description` characters | 250 | 400 | the YAML-**folded** value |
|
||||||
| body words | 600 | 900 | **body only** — everything after the frontmatter's closing `---` |
|
| body words | 600 | 900 | **body only** — everything after the frontmatter's closing `---` |
|
||||||
|
|
||||||
Plus three hard FAILs with no suggestion tier:
|
Plus two hard FAILs with no suggestion tier:
|
||||||
|
|
||||||
- **A missing, valueless or `null` `description:`.** Not a skip. The description is the one field
|
- **A missing, valueless or `null` `description:`.** Not a skip. The description is the one field
|
||||||
preloaded into every session, so a gate that declines to measure it reports green. (This is not
|
preloaded into every session, so a gate that declines to measure it reports green. (This is not
|
||||||
hypothetical: `description:` with no value followed by `model: sonnet` let a line regex capture the
|
hypothetical: `description:` with no value followed by `model: sonnet` let a line regex capture the
|
||||||
*next* key, which looked non-empty, so the "missing or empty" branch never fired and every gate
|
*next* key, which looked non-empty, so the "missing or empty" branch never fired and every gate
|
||||||
below early-returned on the genuinely empty folded value — exit 0, zero output, on a blocking gate.)
|
below early-returned on the genuinely empty folded value — exit 0, zero output, on a blocking gate.)
|
||||||
- **Every boundary-clause routing target must resolve** to a real skill or agent.
|
|
||||||
- **Every `references/<file>.md` a body names must exist** on disk. A dispatch table pointing at a
|
- **Every `references/<file>.md` a body names must exist** on disk. A dispatch table pointing at a
|
||||||
file that was never written is a silently dead branch, and nothing else in the gate/audit/vale
|
file that was never written is a silently dead branch, and nothing else in the gate/audit/vale
|
||||||
stack notices it.
|
stack notices it.
|
||||||
@@ -120,6 +133,35 @@ Plus three hard FAILs with no suggestion tier:
|
|||||||
A file can sit well inside one family and fail the other. 2,770 whole-file words is a conformance
|
A file can sit well inside one family and fail the other. 2,770 whole-file words is a conformance
|
||||||
backstop; 900 body-only words is a quality gate. Conflating them is what produced the current state.
|
backstop; 900 body-only words is a quality gate. Conflating them is what produced the current state.
|
||||||
|
|
||||||
|
### An unresolved routing target is not automatically a FAIL
|
||||||
|
|
||||||
|
A boundary-clause target that resolves to no skill or agent has **three** possible verdicts, not one
|
||||||
|
(`unresolved_targets()` in `scripts/skill-size-check.sh`):
|
||||||
|
|
||||||
|
| Verdict | When |
|
||||||
|
|---|---|
|
||||||
|
| **SUGGESTION** — the default | the target does not resolve and neither promotion condition below holds |
|
||||||
|
| **blocking ERROR** | the target is **terminal** (not a compound modifier) **and** either written in route notation (`/name` for any name; `-> name` only when the name is hyphenated — see the gap below) **or** corroborated by another target in the same sentence that *does* resolve |
|
||||||
|
| **INFO, "DID NOT RUN"** | no skill universe could be determined for the path at all — the targets are named and left unchecked, exit 0 |
|
||||||
|
|
||||||
|
The default is deliberately soft because a hyphenated word in a boundary clause is as likely to be a
|
||||||
|
tool, a file format or an English compound as a route: "pre-commit hooks" is prose about a tool and
|
||||||
|
never reaches the check at all, being a compound modifier rather than a terminal name. The
|
||||||
|
SUGGESTION text says how to opt in — write it as `/name` or `-> name` and it gets checked properly.
|
||||||
|
|
||||||
|
**Known gap: the arrow form only works for hyphenated names.** Target extraction is built on
|
||||||
|
`NAME_HYPH` (`scripts/skill-size-check.sh:543`), which requires at least one hyphen, and
|
||||||
|
`ARROW_BOUNDARY` (`:561`) inherits that. So `-> gitea-prs` is extracted and checked, while
|
||||||
|
`-> triage` is not extracted at all — no ERROR, no SUGGESTION, exit 0. The unicode arrow `→` is not
|
||||||
|
recognised in either case. This makes the SUGGESTION's own advice unsafe for a single-word skill:
|
||||||
|
taking it silences the finding rather than checking it. `/name` has no such restriction and is the
|
||||||
|
form to prefer. Tracked as a defect; `tests/test-adr0020-targets.sh` has one arrow case and its
|
||||||
|
target happens to be hyphenated, so nothing currently covers this.
|
||||||
|
|
||||||
|
Corroboration is what makes the soft default safe: a sentence whose *other* target resolves is
|
||||||
|
demonstrably a routing sentence, so a sibling that does not resolve is a typo rather than a noun, and
|
||||||
|
gets promoted.
|
||||||
|
|
||||||
### Target resolution walk
|
### Target resolution walk
|
||||||
|
|
||||||
Resolution walks up **from the file being checked** — never from the script's own location. Deriving
|
Resolution walks up **from the file being checked** — never from the script's own location. Deriving
|
||||||
@@ -174,10 +216,13 @@ Three more, deterministic to measure but judgment to act on:
|
|||||||
The hook is declared `verbose: true` so the SUGGESTION tier is audible. pre-commit prints nothing at
|
The hook is declared `verbose: true` so the SUGGESTION tier is audible. pre-commit prints nothing at
|
||||||
all for a passing hook, and a SUGGESTION deliberately does not fail — without verbose every
|
all for a passing hook, and a SUGGESTION deliberately does not fail — without verbose every
|
||||||
suggestion is swallowed, which is exactly the invisibility ADR-0013 records for Vale warnings.
|
suggestion is swallowed, which is exactly the invisibility ADR-0013 records for Vale warnings.
|
||||||
ADR-0020's arithmetic depends on it: writing to the 400-char FAIL lands the preload at 39 × 400 =
|
ADR-0020's preload arithmetic depends on it: writing to the 400-char FAIL delivers roughly half the
|
||||||
15,600 chars (a 33% cut off 23,427); writing to the 250-char SUGGESTION lands at 9,750 (58%). The
|
cut that writing to the 250-char SUGGESTION does, so the intended saving depends entirely on that
|
||||||
halving depends entirely on that tier being visible. It costs nothing on a clean file — the script
|
tier being visible. The numbers, and the measurement method behind them, are not restated here —
|
||||||
prints only findings.
|
they live in ADR-0020's Consequences section, under "A ceiling does not produce an average", whose
|
||||||
|
figures are pinned to the base commit the decision was taken on (`f9b919d`). Quoting them here would
|
||||||
|
just create a second copy to go stale. It costs nothing on a clean file — the script prints only
|
||||||
|
findings.
|
||||||
|
|
||||||
### Duplicated constants
|
### Duplicated constants
|
||||||
|
|
||||||
@@ -279,6 +324,81 @@ is needed: the `Kyberforge` styles are **committed** under
|
|||||||
`plugins/kyberforge/.apm/skills/{skill-audit,agent-audit}/assets/vale/styles/`, not downloaded
|
`plugins/kyberforge/.apm/skills/{skill-audit,agent-audit}/assets/vale/styles/`, not downloaded
|
||||||
packages (ADR-0014).
|
packages (ADR-0014).
|
||||||
|
|
||||||
|
### Two copies, one canonical
|
||||||
|
|
||||||
|
Wiring Vale as a deterministic prefilter for `skill-audit`/`agent-audit`'s Description dimension
|
||||||
|
(motivation: issue #84) is repo-specific, not part of the generic `lint` plugin, so it does not live
|
||||||
|
in `plugins/lint/` — and per ADR-0014 it no longer lives at the repo root either. It lives **twice**,
|
||||||
|
one copy per skill, both under `plugins/kyberforge/.apm/skills/`:
|
||||||
|
|
||||||
|
| Copy | Styles | `.vale.ini` sections |
|
||||||
|
|---|---|---|
|
||||||
|
| `agent-audit/assets/vale/` — **canonical** | `Kyberforge`, `KyberforgeCopilot` | `[**/agents/*.md]`, `[**/*.agent.md]` |
|
||||||
|
| `skill-audit/assets/vale/` — smaller duplicate | `Kyberforge` | `[**/SKILL.md]` |
|
||||||
|
|
||||||
|
Duplicated rather than shared because a plugin's cache-install copies only each skill's own files —
|
||||||
|
there is no cross-skill sharing to point at. `check-vale-style-sync` at pre-push is what keeps them
|
||||||
|
from drifting; `KyberforgeCopilot` is the one deliberate inequality, being scoped only to `.agent.md`
|
||||||
|
files for the Copilot-only "`Use proactively` has no effect" check.
|
||||||
|
|
||||||
|
### What Vale owns, and what stays LLM judgment
|
||||||
|
|
||||||
|
Eleven rule files across the two copies, six distinct rules:
|
||||||
|
|
||||||
|
| Rule | Vale scope | Bans | From |
|
||||||
|
|---|---|---|---|
|
||||||
|
| `Kyberforge.DescriptionOpener` | `text.frontmatter.description` | non-imperative openers ("This skill/agent…") | issue #84 |
|
||||||
|
| `Kyberforge.VagueWording` | `text.frontmatter.description` | vague capability wording ("helps with", "utilize", …) | issue #84 |
|
||||||
|
| `Kyberforge.PaddingPhrase` | `text` | generic "see `references/` for details" padding | issue #84 |
|
||||||
|
| `KyberforgeCopilot.ProactivePhrase` | `text.frontmatter.description` | `Use proactively` (no effect in Copilot) | issue #84 |
|
||||||
|
| `Kyberforge.SentenceOpenerThereIs` | `sentence` | "There is/are" sentence openers | ADR-0013 |
|
||||||
|
| `Kyberforge.CompositionNote` | `text.frontmatter.description` | architecture and composition prose in a description | ADR-0020 |
|
||||||
|
|
||||||
|
Vale covers the **pattern-matchable** sub-checks named in issue #84 plus, per ADR-0013, one
|
||||||
|
cherry-picked body-wide prose-pattern rule. Everything else stays LLM judgment: defaults-vs-menus,
|
||||||
|
why-rationale, the non-pattern-matchable body-discipline calls, near-miss exclusion strength, and
|
||||||
|
control calibration. New rules land directly in `styles/Kyberforge` and block immediately — there is
|
||||||
|
no trial tier.
|
||||||
|
|
||||||
|
The cherry-pick record, so it is not re-litigated:
|
||||||
|
|
||||||
|
- `Kyberforge.SentenceOpenerThereIs` **landed** — 22 held-out hits, both in-corpus hits clean
|
||||||
|
rewrites, zero suppressions needed.
|
||||||
|
- `Kyberforge.VagueQualifier` was cherry-picked and then **deleted**. 2 hits across the corpus as it
|
||||||
|
stood on 2026-08-08 (before the `.apm/` restructure): one marginal, and one unfixable false
|
||||||
|
positive — `caveman/SKILL.md` quotes `of course` as an example of filler, a mention rather than a
|
||||||
|
use — which forced the repo's only Vale suppression comments.
|
||||||
|
- `governance.md` and `CONTROLS.md` were evaluated as rule sources and **excluded**: nothing
|
||||||
|
prose-pattern-matchable to mine.
|
||||||
|
|
||||||
|
### Why every rule is `level: error`
|
||||||
|
|
||||||
|
Every alert is a FAIL, with no ignorable tier — same all-or-nothing model as shellcheck, the test
|
||||||
|
suite, and conventional-pre-commit. Graded severities do not work here: **Vale's exit code keys on
|
||||||
|
`error` alerts alone**, so a `warning` or `suggestion` rule exits 0, and pre-commit swallows a
|
||||||
|
passing hook's output. Such a rule would be invisible and would block nothing.
|
||||||
|
|
||||||
|
`MinAlertLevel` and `--minAlertLevel` are correspondingly **absent** from both `.vale.ini` files and
|
||||||
|
from the hook definitions. Under this model they are no-ops; adding one is not a missing knob.
|
||||||
|
|
||||||
|
The `verbose: true` escape hatch that makes `skill-size-check`'s SUGGESTION tier audible has no
|
||||||
|
analogue here — Vale has no tier to make audible.
|
||||||
|
|
||||||
|
### External consumers: the root `.pre-commit-hooks.yaml`
|
||||||
|
|
||||||
|
The root `.pre-commit-hooks.yaml` exposes both Vale copies (`kyberforge-vale-audit-skill`,
|
||||||
|
`kyberforge-vale-audit-agent`) plus `kyberforge-skill-size-check`, so any external repo can enforce
|
||||||
|
the same rules with `repo: <this-repo-url>, rev: <tag>` in its own `.pre-commit-config.yaml`.
|
||||||
|
pre-commit clones the pinned rev into its own cache, independent of whether Claude Code or the
|
||||||
|
`kyberforge` plugin is installed at all; the same mechanism covers CI via `pre-commit run
|
||||||
|
--all-files`. `skill-size-check` has no external asset dependency, so it needed no relocation under
|
||||||
|
ADR-0014 — only exposure.
|
||||||
|
|
||||||
|
This repo's own `vale-audit-prefilter-skill` / `-agent` hooks consume the **identical**
|
||||||
|
plugin-bundled copies via `repo: local`. Deliberately not a third root copy, and deliberately **not a
|
||||||
|
pinned self-reference** — a pinned self-reference would lint working-tree edits against the last
|
||||||
|
tagged release rather than against the change being made.
|
||||||
|
|
||||||
### Pre-commit
|
### Pre-commit
|
||||||
|
|
||||||
Two prefilter hooks, with `.apm/`-scoped `files:` patterns:
|
Two prefilter hooks, with `.apm/`-scoped `files:` patterns:
|
||||||
@@ -292,6 +412,92 @@ Only the **authoring source** triggers them. A `SKILL.md` in the generated flat
|
|||||||
neither pattern, so prose findings surface only when you edit the file you are supposed to be
|
neither pattern, so prose findings surface only when you edit the file you are supposed to be
|
||||||
editing. Without the binary the hooks fail with a bare "command not found" and no install pointer.
|
editing. Without the binary the hooks fail with a bare "command not found" and no install pointer.
|
||||||
|
|
||||||
|
**Two hooks, not one combined hook.** Both manifests split the prefilter in two precisely because a
|
||||||
|
single hook can point at only one copy, and that copy would silently 0-file-skip the other file
|
||||||
|
shape (see [A 0-file Vale run is NOT RUN](#a-0-file-vale-run-is-not-run)).
|
||||||
|
|
||||||
|
### The `.vale.ini` globs do no scoping
|
||||||
|
|
||||||
|
Each `.vale.ini`'s section globs are **path-agnostic** — `[**/SKILL.md]` for skill-audit's copy,
|
||||||
|
`[**/agents/*.md]` and `[**/*.agent.md]` for agent-audit's — and constrain filename *shape*, not
|
||||||
|
location: Vale's `*` crosses `/`. A `SKILL.md` outside `plugins/` (a project-scope
|
||||||
|
`.claude/skills/foo/SKILL.md`, say) still matches `[**/SKILL.md]` and gets linted normally.
|
||||||
|
|
||||||
|
All scoping therefore comes from the pre-commit hook's own `files:` regex and from the audit skills
|
||||||
|
passing one explicit file per invocation. The two manifests scope **differently on purpose**:
|
||||||
|
|
||||||
|
| Manifest | `-skill` | `-agent` |
|
||||||
|
|---|---|---|
|
||||||
|
| `.pre-commit-config.yaml` (pins this repo's layout) | `^plugins/[^/]+/\.apm/skills/[^/]+/SKILL\.md$` | `^plugins/[^/]+/\.apm/agents/[^/]+\.agent\.md$` |
|
||||||
|
| `.pre-commit-hooks.yaml` (layout-agnostic for consumers) | `(^\|/)SKILL\.md$` | `(^\|/)agents/[^/]+\.md$\|\.agent\.md$` |
|
||||||
|
|
||||||
|
Narrowing a `.vale.ini` glob to a `plugins/`-shaped path to "tighten" it breaks the consumer case,
|
||||||
|
and `check-vale-style-sync`'s probe set is built to catch exactly that.
|
||||||
|
|
||||||
|
### `vale-wrap.sh`, never bare `vale`
|
||||||
|
|
||||||
|
Both audit skills' Step 1 and both pre-commit hooks call **each copy's own**
|
||||||
|
`scripts/vale-wrap.sh`, not `vale`. It works around a confirmed **Vale 3.15.2** limitation:
|
||||||
|
`text.frontmatter.description` silently stops matching on most — not all — multi-line descriptions.
|
||||||
|
|
||||||
|
Verified by reproduction on a deliberately-bad fixture, not assumed:
|
||||||
|
|
||||||
|
| Description scalar spanning 2+ lines | Vale's behaviour |
|
||||||
|
|---|---|
|
||||||
|
| `>` folded block | 0 alerts, exit 0 — **broken** |
|
||||||
|
| plain (unquoted) continuation lines | 0 alerts, exit 0 — **broken** |
|
||||||
|
| single- or double-quoted, wrapped | 0 alerts, exit 0 — **broken** |
|
||||||
|
| `\|` literal block | alerts fire, exit 1 — lints normally |
|
||||||
|
|
||||||
|
The wrapper flattens the three broken forms to a single-line scalar in a scratch copy — or, for the
|
||||||
|
rare value no inline scalar can spell verbatim, a `|-` block with one content line — padding with
|
||||||
|
blank lines so **every other line number is unchanged**. `|` literal blocks and single-line
|
||||||
|
descriptions pass through untouched. Most descriptions in this repo are `>` blocks, so before the
|
||||||
|
wrapper a bad description in any of the three broken forms sailed straight through the prefilter.
|
||||||
|
|
||||||
|
### The `--config` argv defect
|
||||||
|
|
||||||
|
Handed **no `--config` at all**, the wrapper falls back to its own sibling `assets/vale/.vale.ini`,
|
||||||
|
located from `${BASH_SOURCE[0]}` rather than from the cwd. That is why both manifests' `entry:` is
|
||||||
|
now the bare script path with **no argument after it**.
|
||||||
|
|
||||||
|
pre-commit prefixes only `entry[0]` with the hook-repo clone path (`cmd = (prefix.path(cmd[0]),
|
||||||
|
*cmd[1:])`), so every later argument resolves against the **consuming** repo's root. A `--config` in
|
||||||
|
`.pre-commit-hooks.yaml` therefore pointed at a path no consumer has and hard-failed every external
|
||||||
|
run with `E100 [--config] Runtime error`.
|
||||||
|
|
||||||
|
`.pre-commit-config.yaml` drops the argument too, deliberately keeping the two entries identical.
|
||||||
|
The local `repo: local` hook resolved its `--config` correctly only because the consuming repo *was*
|
||||||
|
this repo — and that divergence is why three review rounds exercised a path no external consumer
|
||||||
|
takes and missed the defect. **Do not reintroduce a `--config` to either manifest to make the local
|
||||||
|
run "explicit".**
|
||||||
|
|
||||||
|
An explicit `--config` from any other caller still wins, in all three argv forms (`--config X`,
|
||||||
|
`--config=/abs`, `--config=rel`), and a relative one resolves against the caller's cwd — matching
|
||||||
|
bare `vale`, not the repo root.
|
||||||
|
|
||||||
|
Both audit skills' Step 1 passes no `--config` either. Step 1 resolves the script relative to the
|
||||||
|
skill's own directory so the call works from an installed plugin cache; a relative `--config`
|
||||||
|
alongside it would resolve against the cwd instead, yielding `E100 Runtime error … does not exist`
|
||||||
|
and exit 2 — which both skills' fallback misreads as "vale unavailable" and silently downgrades to
|
||||||
|
full LLM judgment.
|
||||||
|
|
||||||
|
`tests/test-vale-wrap.sh` regression-tests this against **skill-audit's** copy specifically: its
|
||||||
|
fixtures are all `SKILL.md`-shaped, and only skill-audit's `.vale.ini` carries that glob section.
|
||||||
|
|
||||||
|
### A 0-file Vale run is NOT RUN
|
||||||
|
|
||||||
|
Vale reports 0 files only when the path it is handed matches **no glob section at all** — a
|
||||||
|
differently-named file, or a directory argument holding nothing that matches. That run prints
|
||||||
|
|
||||||
|
```
|
||||||
|
✔ 0 errors ... in 0 files.
|
||||||
|
```
|
||||||
|
|
||||||
|
and exits 0, indistinguishable from a clean pass. Both audits therefore treat a 0-file Vale run as
|
||||||
|
**NOT RUN** and fall back to full LLM judgment rather than reporting the Description dimension
|
||||||
|
clean.
|
||||||
|
|
||||||
### Pre-push
|
### Pre-push
|
||||||
|
|
||||||
`vale` is a **pre-push** dependency too, not only pre-commit. `check-vale-style-sync` runs **six
|
`vale` is a **pre-push** dependency too, not only pre-commit. `check-vale-style-sync` runs **six
|
||||||
@@ -314,6 +520,16 @@ Use it only on a machine that genuinely cannot install `vale`, and read that lin
|
|||||||
was not checked", not as a pass. The hook is `verbose: true` for exactly that reason — its clean
|
was not checked", not as a pass. The hook is `verbose: true` for exactly that reason — its clean
|
||||||
output is a single line, so it costs one line per push.
|
output is a single line, so it costs one line per push.
|
||||||
|
|
||||||
|
### Mentioning banned phrasing without tripping the rule
|
||||||
|
|
||||||
|
House convention: banned phrasing that must be **mentioned** rather than used goes in backticks or a
|
||||||
|
fenced code block. Vale skips code spans and fences, so no suppression is needed — which is why this
|
||||||
|
document quotes `Use proactively` and "There is/are" the way it does.
|
||||||
|
|
||||||
|
Inline `<!-- vale Rule = NO -->` is the fallback **only** where backticking is impossible. Use the
|
||||||
|
HTML-comment form; the MDX `{/* */}` form does not work in plain Markdown. The one time a rule forced
|
||||||
|
suppression comments, the rule was deleted instead (see the `VagueQualifier` entry above).
|
||||||
|
|
||||||
## Tests
|
## Tests
|
||||||
|
|
||||||
```
|
```
|
||||||
@@ -464,8 +680,10 @@ remote *before* any network call, so it does not join the pair above.
|
|||||||
enforcement table (deterministic vs. auditor judgment), and every rejected alternative
|
enforcement table (deterministic vs. auditor judgment), and every rejected alternative
|
||||||
- `docs/adr/0019-session-start-hook-keeps-the-apm-install-current.md` — the `SessionStart` hook, the
|
- `docs/adr/0019-session-start-hook-keeps-the-apm-install-current.md` — the `SessionStart` hook, the
|
||||||
executable-trust gate, and the version-pinned allow key
|
executable-trust gate, and the version-pinned allow key
|
||||||
- `docs/adr/0017` / `0015` / `0014` — plugin content sync, apm-generated manifests, committed Vale
|
- `docs/adr/0017-plugin-content-mirror-bridges-apm-to-host-discovery.md`,
|
||||||
styles
|
`docs/adr/0015-apm-replaces-plugin-marketplace-authoring.md`,
|
||||||
|
`docs/adr/0014-vale-prefilter-ships-from-the-plugin.md` — plugin content sync, apm-generated
|
||||||
|
manifests, committed Vale styles
|
||||||
- `docs/spec/architecture.md` — directory structure, install pipeline, what is generated and what is
|
- `docs/spec/architecture.md` — directory structure, install pipeline, what is generated and what is
|
||||||
hand-authored
|
hand-authored
|
||||||
- `.pre-commit-config.yaml` — the hooks themselves, with inline rationale comments
|
- `.pre-commit-config.yaml` — the hooks themselves, with inline rationale comments
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "bin",
|
"name": "bin",
|
||||||
"version": "1.1.3",
|
"version": "1.1.5",
|
||||||
"description": "A place for things to be binned",
|
"description": "Skills for everyday AI-assisted development work that is not tied to a single tool, forge or language, and has not yet been split into a focused plugin.",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Defame1297",
|
"name": "Defame1297",
|
||||||
"email": "defame1297@rkdr.net",
|
"email": "defame1297@rkdr.net",
|
||||||
|
|||||||
4
plugins/bin/.github/plugin/plugin.json
vendored
4
plugins/bin/.github/plugin/plugin.json
vendored
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "bin",
|
"name": "bin",
|
||||||
"version": "1.1.3",
|
"version": "1.1.5",
|
||||||
"description": "A place for things to be binned",
|
"description": "Skills for everyday AI-assisted development work that is not tied to a single tool, forge or language, and has not yet been split into a focused plugin.",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Defame1297",
|
"name": "Defame1297",
|
||||||
"email": "defame1297@rkdr.net",
|
"email": "defame1297@rkdr.net",
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
name: bin
|
name: bin
|
||||||
version: 1.1.3
|
version: 1.1.5
|
||||||
description: A place for things to be binned
|
description: Skills for everyday AI-assisted development work that is not tied to a single tool, forge or language, and has not yet been split into a focused plugin.
|
||||||
author:
|
author:
|
||||||
name: Defame1297
|
name: Defame1297
|
||||||
email: defame1297@rkdr.net
|
email: defame1297@rkdr.net
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "git",
|
"name": "git",
|
||||||
"version": "1.3.3",
|
"version": "1.3.5",
|
||||||
"description": "Skills for working with Git \u2014 conventional commits, branch management, pull requests, and feature flow.",
|
"description": "Skills and agents for working with a local Git clone over the git wire protocol, and for authoring and running the pre-commit hooks that guard it.",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Defame1297",
|
"name": "Defame1297",
|
||||||
"email": "defame1297@rkdr.net",
|
"email": "defame1297@rkdr.net",
|
||||||
|
|||||||
4
plugins/git/.github/plugin/plugin.json
vendored
4
plugins/git/.github/plugin/plugin.json
vendored
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "git",
|
"name": "git",
|
||||||
"version": "1.3.3",
|
"version": "1.3.5",
|
||||||
"description": "Skills for working with Git \u2014 conventional commits, branch management, pull requests, and feature flow.",
|
"description": "Skills and agents for working with a local Git clone over the git wire protocol, and for authoring and running the pre-commit hooks that guard it.",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Defame1297",
|
"name": "Defame1297",
|
||||||
"email": "defame1297@rkdr.net",
|
"email": "defame1297@rkdr.net",
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
name: git
|
name: git
|
||||||
version: 1.3.3
|
version: 1.3.5
|
||||||
description: Skills for working with Git — conventional commits, branch management, pull requests, and feature flow.
|
description: Skills and agents for working with a local Git clone over the git wire protocol, and for authoring and running the pre-commit hooks that guard it.
|
||||||
author:
|
author:
|
||||||
name: Defame1297
|
name: Defame1297
|
||||||
email: defame1297@rkdr.net
|
email: defame1297@rkdr.net
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "gitea",
|
"name": "gitea",
|
||||||
"version": "1.3.4",
|
"version": "1.3.6",
|
||||||
"description": "Skills for managing Gitea repositories \u2014 issues, pull requests, milestones, releases, and wikis.",
|
"description": "Skills and agents for working with a Gitea forge through its HTTP API \u2014 the forge's own objects, as distinct from the local git clone.",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Defame1297",
|
"name": "Defame1297",
|
||||||
"email": "defame1297@rkdr.net",
|
"email": "defame1297@rkdr.net",
|
||||||
|
|||||||
4
plugins/gitea/.github/plugin/plugin.json
vendored
4
plugins/gitea/.github/plugin/plugin.json
vendored
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "gitea",
|
"name": "gitea",
|
||||||
"version": "1.3.4",
|
"version": "1.3.6",
|
||||||
"description": "Skills for managing Gitea repositories \u2014 issues, pull requests, milestones, releases, and wikis.",
|
"description": "Skills and agents for working with a Gitea forge through its HTTP API \u2014 the forge's own objects, as distinct from the local git clone.",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Defame1297",
|
"name": "Defame1297",
|
||||||
"email": "defame1297@rkdr.net",
|
"email": "defame1297@rkdr.net",
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
name: gitea
|
name: gitea
|
||||||
version: 1.3.4
|
version: 1.3.6
|
||||||
description: Skills for managing Gitea repositories — issues, pull requests, milestones, releases, and wikis.
|
description: Skills and agents for working with a Gitea forge through its HTTP API — the forge's own objects, as distinct from the local git clone.
|
||||||
author:
|
author:
|
||||||
name: Defame1297
|
name: Defame1297
|
||||||
email: defame1297@rkdr.net
|
email: defame1297@rkdr.net
|
||||||
|
|||||||
@@ -127,8 +127,8 @@ for ini in "$SKILL_INI" "$AGENT_INI"; do
|
|||||||
err "$rel_ini has no section whose BasedOnStyles names Kyberforge — every rule the audit prefilters on lives in that style"
|
err "$rel_ini has no section whose BasedOnStyles names Kyberforge — every rule the audit prefilters on lives in that style"
|
||||||
fi
|
fi
|
||||||
# Per-rule overrides are the third way to retire a rule without touching a
|
# Per-rule overrides are the third way to retire a rule without touching a
|
||||||
# style file or a glob. CONTEXT.md's "Vale audit prefilter" entry: "Every rule
|
# style file or a glob. Per ADR-0013, every rule is `level: error` and every
|
||||||
# is `level: error` and every alert is a FAIL — no ignorable tier". Vale's exit
|
# alert is a FAIL — there is no ignorable tier. Vale's exit
|
||||||
# code keys on `error` alerts alone, so any override that leaves a rule at
|
# code keys on `error` alerts alone, so any override that leaves a rule at
|
||||||
# anything other than `error` still lints the file, still exits 0, and still
|
# anything other than `error` still lints the file, still exits 0, and still
|
||||||
# shows `Passed` in pre-commit. The glob probe below cannot backstop this: it
|
# shows `Passed` in pre-commit. The glob probe below cannot backstop this: it
|
||||||
@@ -175,9 +175,10 @@ for ini in "$SKILL_INI" "$AGENT_INI"; do
|
|||||||
fi
|
fi
|
||||||
done
|
done
|
||||||
|
|
||||||
# KyberforgeCopilot is agent-audit's alone — CONTEXT.md describes it as "scoped
|
# KyberforgeCopilot is agent-audit's alone — ADR-0013 scopes it to `.agent.md`
|
||||||
# only to `.agent.md` files for the Copilot-only 'Use proactively has no effect'
|
# files only, for the Copilot-only 'Use proactively has no effect' check, and
|
||||||
# check". The loop above deliberately asserts only `Kyberforge`, since
|
# records that it must not be extended to `.md` files. The loop above
|
||||||
|
# deliberately asserts only `Kyberforge`, since
|
||||||
# skill-audit's copy legitimately has no Copilot style, so dropping
|
# skill-audit's copy legitimately has no Copilot style, so dropping
|
||||||
# `, KyberforgeCopilot` from agent-audit's `[**/*.agent.md]` section unloaded the
|
# `, KyberforgeCopilot` from agent-audit's `[**/*.agent.md]` section unloaded the
|
||||||
# whole style silently: no glob broke, the styles/ diff above stayed clean (the
|
# whole style silently: no glob broke, the styles/ diff above stayed clean (the
|
||||||
@@ -353,10 +354,10 @@ while IFS='|' read -r skill rel scope; do
|
|||||||
# `.pre-commit-config.yaml`'s regex correctly no longer matches it and that's
|
# `.pre-commit-config.yaml`'s regex correctly no longer matches it and that's
|
||||||
# not drift. `demo.agent.md` is the real, current shape and is `shared`.
|
# not drift. `demo.agent.md` is the real, current shape and is `shared`.
|
||||||
#
|
#
|
||||||
# The two `.claude/`-prefixed probes carry the location-independence CONTEXT.md
|
# The two `.claude/`-prefixed probes carry the location-independence property: a
|
||||||
# asserts: "A `SKILL.md` outside `plugins/` (e.g. project-scope
|
# `SKILL.md` outside `plugins/` (e.g. project-scope
|
||||||
# `.claude/skills/foo/SKILL.md`) still matches `[**/SKILL.md]` and gets linted
|
# `.claude/skills/foo/SKILL.md`) still matches `[**/SKILL.md]` and gets linted
|
||||||
# normally — the globs constrain filename shape, not location." Every other
|
# normally — the globs constrain filename shape, not location. Every other
|
||||||
# probe here starts with `plugins/`, so narrowing a glob to a `plugins/`-shaped
|
# probe here starts with `plugins/`, so narrowing a glob to a `plugins/`-shaped
|
||||||
# path (`[**/SKILL.md]` -> `[**/.apm/skills/*/SKILL.md]`) left all of them
|
# path (`[**/SKILL.md]` -> `[**/.apm/skills/*/SKILL.md]`) left all of them
|
||||||
# matching while the project-scope shape started linting as `0 errors ... in 0
|
# matching while the project-scope shape started linting as `0 errors ... in 0
|
||||||
|
|||||||
@@ -6,7 +6,7 @@ set -euo pipefail
|
|||||||
# that same file at .claude-plugin/marketplace.json directly, but also has a legacy
|
# that same file at .claude-plugin/marketplace.json directly, but also has a legacy
|
||||||
# convention path at .github/plugin/marketplace.json (see
|
# convention path at .github/plugin/marketplace.json (see
|
||||||
# plugins/kyberforge/docs/research/docs/github-copilot-plugins/marketplace.md) -- and
|
# plugins/kyberforge/docs/research/docs/github-copilot-plugins/marketplace.md) -- and
|
||||||
# CONTEXT.md documents that path as a mirror of the Claude output, not a separate apm
|
# that path is a mirror of the Claude output, not a separate apm
|
||||||
# output profile (apm only ships "claude" and "codex" mappers; codex writes a
|
# output profile (apm only ships "claude" and "codex" mappers; codex writes a
|
||||||
# differently-shaped file to .agents/plugins/marketplace.json, not this path). This
|
# differently-shaped file to .agents/plugins/marketplace.json, not this path). This
|
||||||
# script keeps that legacy mirror byte-identical to .claude-plugin/marketplace.json
|
# script keeps that legacy mirror byte-identical to .claude-plugin/marketplace.json
|
||||||
@@ -60,7 +60,19 @@ fi
|
|||||||
if [[ "$CHECK" -eq 1 ]]; then
|
if [[ "$CHECK" -eq 1 ]]; then
|
||||||
if [[ ! -f "$DST" ]] || ! diff -q "$SRC" "$DST" >/dev/null 2>&1; then
|
if [[ ! -f "$DST" ]] || ! diff -q "$SRC" "$DST" >/dev/null 2>&1; then
|
||||||
echo "DRIFT $DST: out of sync with .claude-plugin/marketplace.json" >&2
|
echo "DRIFT $DST: out of sync with .claude-plugin/marketplace.json" >&2
|
||||||
echo "Fix: bash scripts/sync-marketplace-mirror.sh" >&2
|
# The runnable command gets a line to ITSELF, and the rationale gets its own
|
||||||
|
# echo. It was one line -- `Fix: bash scripts/sync-marketplace-mirror.sh --
|
||||||
|
# apm ships no output profile...` -- which put the prose after `--`, the
|
||||||
|
# POSIX end-of-options marker, so copy-pasting the Fix line ran this script
|
||||||
|
# with ~24 stray argv entries: `${1:-}` was `--` (so CHECK stayed 0 and no
|
||||||
|
# shift happened), `[[ $# -eq 0 ]]` failed, and the tool meant to fix the
|
||||||
|
# drift answered with its own usage error and exit 1. The backticks around
|
||||||
|
# `apm pack` made it worse: the paste also command-substituted a real
|
||||||
|
# `apm pack` run before the script was even reached. Hence plain quotes
|
||||||
|
# below too. Keep the command alone on its line.
|
||||||
|
echo "Fix: run, from the repository root:" >&2
|
||||||
|
echo " bash scripts/sync-marketplace-mirror.sh" >&2
|
||||||
|
echo "Note: apm ships no output profile targeting this path, so 'apm pack' does not refresh it. Expecting it to is exactly the drift this script and its pre-push hook exist to prevent." >&2
|
||||||
exit 1
|
exit 1
|
||||||
fi
|
fi
|
||||||
exit 0
|
exit 0
|
||||||
|
|||||||
@@ -13,11 +13,13 @@
|
|||||||
# dev binary, the other 15 suites still tell you something, and turning that
|
# dev binary, the other 15 suites still tell you something, and turning that
|
||||||
# into a red run would just train people to ignore red.
|
# into a red run would just train people to ignore red.
|
||||||
# * as a GATE (the run-tests pre-push hook): a skip is a SETUP ERROR, not a
|
# * as a GATE (the run-tests pre-push hook): a skip is a SETUP ERROR, not a
|
||||||
# legitimate state. AGENTS.md documents vale, apm and jq as required pre-push
|
# legitimate state. README.md's Prerequisites table documents vale, apm and
|
||||||
# dependencies, so a suite that cannot run on the machine doing the pushing
|
# python3/PyYAML -- the dependencies these suites actually guard on -- as
|
||||||
# means the machine is misconfigured -- and pre-commit prints NOTHING for a
|
# required pre-push, so a suite that cannot run on the machine doing the
|
||||||
# passing hook, so the skip list below is swallowed entirely. On a vale-less
|
# pushing means the machine is misconfigured -- and
|
||||||
# PATH that silently shipped a green gate having verified 15 of 17 suites.
|
# pre-commit prints NOTHING for a passing hook, so the skip list below is
|
||||||
|
# swallowed entirely. On a vale-less PATH that once silently shipped a
|
||||||
|
# green gate having verified 15 of the 17 suites that existed then.
|
||||||
# Exactly the vacuous-pass class the rest of this file exists to close.
|
# Exactly the vacuous-pass class the rest of this file exists to close.
|
||||||
#
|
#
|
||||||
# Deliberately its own switch, NOT folded into
|
# Deliberately its own switch, NOT folded into
|
||||||
@@ -258,7 +260,7 @@ fi
|
|||||||
# here (not just referenced) because this block goes to stderr and is what a
|
# here (not just referenced) because this block goes to stderr and is what a
|
||||||
# pre-push reader actually gets handed.
|
# pre-push reader actually gets handed.
|
||||||
if [[ "$STRICT" == true && ${#SKIPPED[@]} -gt 0 ]]; then
|
if [[ "$STRICT" == true && ${#SKIPPED[@]} -gt 0 ]]; then
|
||||||
echo "Error: --strict and ${#SKIPPED[@]} suite(s) skipped. Run as a gate, a skip is a SETUP ERROR on this machine, not a legitimate state: AGENTS.md documents vale, apm and jq as required pre-push dependencies, so every suite is expected to be runnable here. Install what each suite names below and re-run; do not skip the hook." >&2
|
echo "Error: --strict and ${#SKIPPED[@]} suite(s) skipped. Run as a gate, a skip is a SETUP ERROR on this machine, not a legitimate state: README.md's Prerequisites table documents vale, apm and python3/PyYAML — what these suites guard on — as required pre-push dependencies, so every suite is expected to be runnable here. Install what each suite names below and re-run; do not skip the hook." >&2
|
||||||
sidx=0
|
sidx=0
|
||||||
for s in ${SKIPPED[@]+"${SKIPPED[@]}"}; do
|
for s in ${SKIPPED[@]+"${SKIPPED[@]}"}; do
|
||||||
echo " $s" >&2
|
echo " $s" >&2
|
||||||
|
|||||||
@@ -457,8 +457,8 @@ fi
|
|||||||
|
|
||||||
# --- 9b. Exits 1 when a per-rule override leaves a rule at anything but error ---
|
# --- 9b. Exits 1 when a per-rule override leaves a rule at anything but error ---
|
||||||
# The third way to switch a rule off without touching a style file or a glob.
|
# The third way to switch a rule off without touching a style file or a glob.
|
||||||
# CONTEXT.md's "Vale audit prefilter" entry: "Every rule is `level: error` and
|
# Per ADR-0013, every rule is `level: error` and every alert is a FAIL -- there
|
||||||
# every alert is a FAIL -- no ignorable tier". Vale's exit code keys on `error`
|
# is no ignorable tier. Vale's exit code keys on `error`
|
||||||
# alerts alone, so any such override leaves the glob intact, the styles
|
# alerts alone, so any such override leaves the glob intact, the styles
|
||||||
# byte-identical, and the run at `0 errors`, exit 0, `Passed`.
|
# byte-identical, and the run at `0 errors`, exit 0, `Passed`.
|
||||||
#
|
#
|
||||||
@@ -553,9 +553,9 @@ fi
|
|||||||
# equality check applies, and case 10's probe still passed because it keys on a
|
# equality check applies, and case 10's probe still passed because it keys on a
|
||||||
# Kyberforge alert. Verified dead by probing a `.agent.md` carrying
|
# Kyberforge alert. Verified dead by probing a `.agent.md` carrying
|
||||||
# "Use proactively": 0 alerts under the broken config, KyberforgeCopilot.
|
# "Use proactively": 0 alerts under the broken config, KyberforgeCopilot.
|
||||||
# ProactivePhrase under the shipped one. CONTEXT.md describes the style as
|
# ProactivePhrase under the shipped one. ADR-0013 scopes the style to
|
||||||
# "scoped only to `.agent.md` files for the Copilot-only 'Use proactively has
|
# `.agent.md` files only, for the Copilot-only 'Use proactively has no effect'
|
||||||
# no effect' check", so shipping it unloaded is drift.
|
# check, so shipping it unloaded is drift.
|
||||||
echo ""
|
echo ""
|
||||||
echo "--- exits 1 when the shipped KyberforgeCopilot style is named by no BasedOnStyles ---"
|
echo "--- exits 1 when the shipped KyberforgeCopilot style is named by no BasedOnStyles ---"
|
||||||
FIXTURE11C="$(make_fixture)"
|
FIXTURE11C="$(make_fixture)"
|
||||||
@@ -609,9 +609,9 @@ fi
|
|||||||
# still matched all of them and the check passed -- while a project-scope
|
# still matched all of them and the check passed -- while a project-scope
|
||||||
# `.claude/skills/foo/SKILL.md` started linting as `0 errors ... in 0 files`,
|
# `.claude/skills/foo/SKILL.md` started linting as `0 errors ... in 0 files`,
|
||||||
# exit 0, hook `Passed`: the exact failure the script's own header comment says
|
# exit 0, hook `Passed`: the exact failure the script's own header comment says
|
||||||
# it exists to catch. CONTEXT.md: "A `SKILL.md` outside `plugins/` (e.g.
|
# it exists to catch. A `SKILL.md` outside `plugins/` (e.g. project-scope
|
||||||
# project-scope `.claude/skills/foo/SKILL.md`) still matches `[**/SKILL.md]` and
|
# `.claude/skills/foo/SKILL.md`) still matches `[**/SKILL.md]` and gets linted
|
||||||
# gets linted normally -- the globs constrain filename shape, not location."
|
# normally -- the globs constrain filename shape, not location.
|
||||||
# These narrowings are still valid glob syntax and break no `plugins/`-shaped
|
# These narrowings are still valid glob syntax and break no `plugins/`-shaped
|
||||||
# file, so only a non-`plugins/` probe path catches them.
|
# file, so only a non-`plugins/` probe path catches them.
|
||||||
echo ""
|
echo ""
|
||||||
|
|||||||
@@ -392,10 +392,11 @@ fi
|
|||||||
|
|
||||||
# --- 10. --strict turns a skip into a failure, and names the suite AND the reason ---
|
# --- 10. --strict turns a skip into a failure, and names the suite AND the reason ---
|
||||||
# Graceful skipping is right for an ad-hoc run and wrong for a gate. At pre-push a
|
# Graceful skipping is right for an ad-hoc run and wrong for a gate. At pre-push a
|
||||||
# suite exiting 77 means a dependency AGENTS.md documents as required is missing
|
# suite exiting 77 means a dependency README.md's Prerequisites table documents
|
||||||
# on the pushing machine -- and pre-commit prints nothing at all for a passing
|
# as required is missing on the pushing machine -- and pre-commit prints nothing
|
||||||
# hook, so the skip list this script writes to stdout was swallowed whole. A
|
# at all for a passing hook, so the skip list this script writes to stdout was
|
||||||
# vale-less PATH shipped a green gate having verified 15 of 17 suites.
|
# swallowed whole. A vale-less PATH once shipped a green gate having verified
|
||||||
|
# 15 of the 17 suites that existed then.
|
||||||
#
|
#
|
||||||
# The reason is asserted, not just the name: "something was skipped" leaves the
|
# The reason is asserted, not just the name: "something was skipped" leaves the
|
||||||
# reader with no idea which binary to install, which is most of why the swallowed
|
# reader with no idea which binary to install, which is most of why the swallowed
|
||||||
|
|||||||
@@ -451,8 +451,11 @@ fi
|
|||||||
# cover anything new: it omitted scripts/lib/batch-run.sh — the shared runner
|
# cover anything new: it omitted scripts/lib/batch-run.sh — the shared runner
|
||||||
# this branch introduced, whose own header (batch-run.sh:9-11) documents it as
|
# this branch introduced, whose own header (batch-run.sh:9-11) documents it as
|
||||||
# bash-3.2-safe — along with four other scripts/*.sh. Deriving the list means a
|
# bash-3.2-safe — along with four other scripts/*.sh. Deriving the list means a
|
||||||
# new script is covered the moment it lands. AGENTS.md names bash 3.2 as an
|
# new script is covered the moment it lands. The script headers name bash 3.2 as
|
||||||
# explicit repo target, so the scope is four globs, each floor-asserted below:
|
# an explicit repo target -- scripts/lib/batch-run.sh:10 ("all three callers are
|
||||||
|
# explicitly bash-3.2-safe") and providers/claude-code/statusline-command.sh:100
|
||||||
|
# ("macOS's system bash, and an explicit repo target") -- so the scope is four
|
||||||
|
# globs, each floor-asserted below:
|
||||||
# - scripts/**/*.sh — repo tooling and pre-commit hook scripts
|
# - scripts/**/*.sh — repo tooling and pre-commit hook scripts
|
||||||
# - tests/*.sh — the runners and every regression test
|
# - tests/*.sh — the runners and every regression test
|
||||||
# - plugins/*/.apm/**/*.sh — the scripts plugins ship to users
|
# - plugins/*/.apm/**/*.sh — the scripts plugins ship to users
|
||||||
|
|||||||
Reference in New Issue
Block a user