Defame1297/holocron
0
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

refactor(kyberforge): merge skill-audit + agent-audit, and address the author-pair duplication #101

New Issue
Closed
opened 2026-08-14 19:39:47 +00:00 by Claude · 1 comment
Claude commented 2026-08-14 19:39:47 +00:00
Collaborator
Copy Link

Two structural findings from the ADR-0020 grill, both concerning kyberforge's own skills.

Merge skill-audit + agent-audit (decided in ADR-0020). They meet the merge criterion: substantial shared content, they name each other as near-misses, and they differ only in the type of input file. Shared today:

  • a 103-word verbatim identical paragraph (skill-audit/SKILL.md:44 ≡ agent-audit/SKILL.md:49)
  • an identical finding block (skill-audit:134-136 ≡ agent-audit:105-107) and the same 6-variant ## Result block
  • a byte-identical 526-line vale-wrap.sh and 4 of 5 identical Vale style YAMLs
  • two same-named references/description-quality.md files that have already drifted into independently-worded versions

Merging collapses those to single copies and removes 1,845 chars of mutually-excluding description from the preload. The merged skill uses the ADR-0020 dispatch pattern: dispatch table + shared gates in the body, references/skill.md and references/agent.md per branch. This reopens ADR-0008 (agent-audit's single-file invocation contract) — supersede or amend it as part of this work. Note skill-author and agent-author both invoke their audit inline as a closing step, and forge re-runs them in a clean-context subagent; those call sites need updating.

Author-pair duplication stays un-gated. ADR-0020 deliberately excludes skill-author + agent-author from the merge rule, so this survives:

  • the commit-verification argument in 4 near-copies (skill-author/SKILL.md:241, :306, agent-author/SKILL.md:214, :259) with wording already drifted between them
  • root-cause grouping in 4 copies
  • the entire "Improving an existing X" flow structurally cloned (5 identical step names, same order)
  • the apm.yml walk-up rule restated 6 times across 5 files, with citation-path drift between docs/research/docs/... and plugins/kyberforge/docs/research/docs/...

Cache isolation makes these copies unavoidable (skill-audit/SKILL.md:95 forbids cross-skill references; LESSONS.md:107 records why), so the options are a sync gate — generalising scripts/check-vale-style-sync.sh to cover shared prose — or continued drift. Decide which.

Also in scope: agent-author/references/scripts.md is orphaned (43 lines, zero mentions in SKILL.md), and skill-author/skill-audit lack the references/README.md and scripts/README.md that skill-audit/SKILL.md:119 requires of the skills they audit.

Reference: docs/adr/0020-skill-description-and-body-context-contract.md (committed on branch refactor/trim-skills-agents-context).

Two structural findings from the ADR-0020 grill, both concerning kyberforge's own skills. **Merge `skill-audit` + `agent-audit` (decided in ADR-0020).** They meet the merge criterion: substantial shared content, they name each other as near-misses, and they differ only in the type of input file. Shared today: - a **103-word verbatim identical** paragraph (`skill-audit/SKILL.md:44` ≡ `agent-audit/SKILL.md:49`) - an identical finding block (`skill-audit:134-136` ≡ `agent-audit:105-107`) and the same 6-variant `## Result` block - a **byte-identical 526-line `vale-wrap.sh`** and 4 of 5 identical Vale style YAMLs - two same-named `references/description-quality.md` files that have **already drifted** into independently-worded versions Merging collapses those to single copies and removes 1,845 chars of mutually-excluding description from the preload. The merged skill uses the ADR-0020 dispatch pattern: dispatch table + shared gates in the body, `references/skill.md` and `references/agent.md` per branch. This reopens **ADR-0008** (agent-audit's single-file invocation contract) — supersede or amend it as part of this work. Note `skill-author` and `agent-author` both invoke their audit inline as a closing step, and `forge` re-runs them in a clean-context subagent; those call sites need updating. **Author-pair duplication stays un-gated.** ADR-0020 deliberately excludes `skill-author` + `agent-author` from the merge rule, so this survives: - the commit-verification argument in 4 near-copies (`skill-author/SKILL.md:241`, `:306`, `agent-author/SKILL.md:214`, `:259`) with wording already drifted between them - root-cause grouping in 4 copies - the entire "Improving an existing X" flow structurally cloned (5 identical step names, same order) - the `apm.yml` walk-up rule restated 6 times across 5 files, with citation-path drift between `docs/research/docs/...` and `plugins/kyberforge/docs/research/docs/...` Cache isolation makes these copies unavoidable (`skill-audit/SKILL.md:95` forbids cross-skill references; `LESSONS.md:107` records why), so the options are a sync gate — generalising `scripts/check-vale-style-sync.sh` to cover shared prose — or continued drift. Decide which. Also in scope: `agent-author/references/scripts.md` is **orphaned** (43 lines, zero mentions in SKILL.md), and `skill-author`/`skill-audit` lack the `references/README.md` and `scripts/README.md` that `skill-audit/SKILL.md:119` requires of the skills they audit. --- Reference: `docs/adr/0020-skill-description-and-body-context-contract.md` (committed on branch `refactor/trim-skills-agents-context`).
Claude added this to the Skills & Agents milestone 2026-08-14 19:39:47 +00:00
Claude added the Kind/Enhancement
Priority
Medium
3
 labels 2026-08-14 19:39:47 +00:00
Claude commented 2026-09-16 15:12:49 +00:00
Author
Collaborator
Copy Link

Resolved on branch docs/simplification-audit, not yet merged:

  • The merge: skill-audit and agent-audit are merged into factory-audit (commit 620f20b, ADR-0025), and the call sites in skill-author, agent-author and forge are updated. kyberforge moves to 2.0.0.
  • The author-pair duplication: simplification audit finding 15 measured it and refuted it, so no sync gate is needed. check-vale-style-sync.sh was removed, because a single factory-audit/assets/vale/ copy leaves nothing to sync.

This issue should close when that branch's PR merges (Closes #101).

Resolved on branch `docs/simplification-audit`, not yet merged: - **The merge:** `skill-audit` and `agent-audit` are merged into `factory-audit` (commit 620f20b, ADR-0025), and the call sites in `skill-author`, `agent-author` and `forge` are updated. kyberforge moves to 2.0.0. - **The author-pair duplication:** simplification audit finding 15 measured it and refuted it, so no sync gate is needed. `check-vale-style-sync.sh` was removed, because a single `factory-audit/assets/vale/` copy leaves nothing to sync. This issue should close when that branch's PR merges (`Closes #101`).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Kind/Enhancement
Priority
Medium
3
Milestone
No items
No Milestone Skills & Agents
Projects
Clear projects
No project
Assignees
Clear assignees
Claude renovate-bot Defame1297
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Defame1297/holocron#101
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?