feat(kyberforge): merge skill-write and skill-improve into skill-author #5
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
Standalone issue — justified by ADR-0013 (
docs/adr/0013-skill-author-merge.md).The kyberforge plugin ships a factory trio:
skill-write(create from scratch),skill-improve(apply signals to existing),skill-audit(read-only review). Two problems drive this merge:../paths on install. The spec explicitly prohibits cross-skill file sharing. As the agentskills.io spec evolves and governance rules are added, each change would require updating two skills with no enforcement. The maintenance surface compounds.The fix: merge into
skill-author. One set of authoring standards, one set of scripts, one place for future governance rules.Acceptance criteria (EARS)
skill-authorSHALL follow the create flow: scaffold → fill in SKILL.md → add scripts (if needed) → add references/assets/tests (if needed) → validate with/skill-audit.skill-authorSHALL follow the improve flow: verify inputs → gather and group signals by root cause → announce planned changes → apply changes → validate with/skill-audit.skill-authorSHALL ask the user to clarify intent before proceeding.scripts/new-skill.shSHALL be present inskill-authorand produce identical scaffold output to its predecessor inskill-write.skill-authorSHALL pass/skill-auditwith no FAIL findings.plugins/kyberforge/skills/skill-write/andplugins/kyberforge/skills/skill-improve/SHALL be deleted.plugins/kyberforge/skills/README.mdSHALL reflect the factory duo (skill-author+skill-audit) with no stale references toskill-writeorskill-improve.Brownfield delta
Note:
skill-auditis unchanged. Its report footer references/skill-improve— that reference is now stale but is deferred to a follow-on issue.Design notes
Mode detection (AC1–AC3)
The
## Routesection at the top of the body handles detection. Logic:"No improvement signals found. Did you mean to create a new skill, or do you have feedback to apply?"Signals include: grill session output,
/skill-auditfindings, inline user feedback, session context describing failures. No explicit--modeflag needed for human invocation. When refactored to a subagent later, a--mode create|improveoverride can be added as an escape hatch.SKILL.md structure
The two sections are self-contained. The
## Routesection directs the agent to the right one. No conditional branching inside steps.Frontmatter note
allowed-toolsis the union of both predecessor skills:Bash Read Write Edit.skill-writehadBash Read Write;skill-improvehadBash Read Write Edit.scripts/new-skill.sh
Copy verbatim from
skill-write/scripts/new-skill.sh. After copying, check for any hardcoded references toskill-writeinside the script (path strings, comments, help text) and update them toskill-author.README.md
Write a fresh README for
skill-author. The predecessor READMEs in skill-write and skill-improve can serve as a template for the file table format, but the content should reflect the merged skill's actual files.Task checklist
plugins/kyberforge/skills/skill-write/SKILL.mdandskill-improve/SKILL.mdin full before writing anythingplugins/kyberforge/skills/skill-write/scripts/new-skill.shto identify anyskill-write-specific strings that need updatingplugins/kyberforge/skills/skill-author/viabash plugins/kyberforge/skills/skill-write/scripts/new-skill.sh skill-author plugins/kyberforge/skills/— this gives the scaffold; then overwrite SKILL.md with the merged contentskill-author/SKILL.mdfollowing the structure in Design Notes abovereferences/deployment-modes.mdandreferences/scripts.mdfromskill-write/references/toskill-author/references/assets/templates/fromskill-write/assets/toskill-author/assets/scripts/new-skill.shfromskill-write/scripts/toskill-author/scripts/; update any internalskill-writereferencestests/new-skill.batsandtests/README.mdfromskill-write/tests/toskill-author/tests/skill-author/README.mdwith an accurate file table/skill-auditonplugins/kyberforge/skills/skill-author/— resolve all FAILsplugins/kyberforge/skills/README.md: factory trio → factory duoplugins/kyberforge/skills/skill-write/plugins/kyberforge/skills/skill-improve/~/.claude/skills/symlinks (if installed) still resolve —skill-authormust be present,skill-writeandskill-improvemust be absentSession handoff notes
mainbranch; no branch was createdskill-authorname was chosen overskill-forge(kyberforge branding) andskill-craftfor clarity in isolation —/skill-authoris self-describing without plugin context--mode create|improve) is explicitly deferred — add it when the subagent refactor happens, not nowreferences/body-discipline.mdandreferences/description-quality.mdover time. A follow-on issue should align them. Deferred by user decision.Progress update
Completed
skill-write/SKILL.mdandskill-improve/SKILL.mdin fullscripts/new-skill.shto identifyskill-write-specific stringsplugins/kyberforge/skills/skill-author/vianew-skill.shscaffoldskill-author/SKILL.mdfollowing the structure in Design Notes — Gotchas → Route → Creating a new skill → Improving an existing skillreferences/deployment-modes.mdandreferences/scripts.mdfromskill-write/references/assets/templates/fromskill-write/assets/scripts/new-skill.sh; updated internalskill-writereference toskill-authortests/new-skill.batsskill-author/tests/README.mdwith correct bats path (skill-author/tests/)skill-author/README.mdwith accurate file tableplugins/kyberforge/skills/README.md:/write-skill→/skill-author+/skill-auditDeferred (user decision)
/skill-auditonplugins/kyberforge/skills/skill-author/— skipped at user request; run to close AC5plugins/kyberforge/skills/skill-write/— skipped at user requestplugins/kyberforge/skills/skill-improve/— skipped at user requestNotes
skill-authoris already live — it appeared in the available skills list immediately after SKILL.md was writtenallowed-toolsis the union of both predecessors:Bash Read Write Edit(AC implied by Design Notes)scripts/,references/, andassets/were removed since all three directories now have actual contentProgress update
Newly completed since last update
/skill-auditonplugins/kyberforge/skills/skill-author/— PASS, no findings (AC5 ✅)Self-containedas explicit rule in Step 3a193ccc—feat(kyberforge): add skill-author, merging skill-write and skill-improveStill deferred
plugins/kyberforge/skills/skill-write/(AC6)plugins/kyberforge/skills/skill-improve/(AC6)Progress update
Completed since last update
namefield format constraints (1–64 chars, lowercase+numbers+hyphens, no leading/trailing/consecutive hyphens)## Patternsreferences/scripts.mdreferences/scripts.md(error messages, dry-run/confirm pairing, output size, idempotency, exit codes)README.mdrow, updatedreferences/scripts.mddescription/skill-audit(fresh subagent, no prior context) — PASS, no findings (one suggestion: near-miss routing conflict with still-present skill-write and skill-improve — deferred to AC6)7ec34dd—fix(kyberforge): improve skill-author based on spec validation and auditDeferred
plugins/kyberforge/skills/skill-write/(AC6)plugins/kyberforge/skills/skill-improve/(AC6)Notes
AC6 complete.
skill-write/andskill-improve/deleted in8b26245.Also applied two skill-audit findings to
skill-authorin252741a:references/scripts.mdnew-skill.shredirected to stderr per scripts.md contractAll 147 CI tests pass.