fix(factory): embed lessons from #63 into gitea and kyberforge skills #65

Claude · 2026-07-05T09:36:27Z

Claude commented

2026-07-05 09:36:27 +00:00

Summary

Follow-up to #63 / #64. While closing out that fix, kyberforge:forge was used to review what should be embedded into skills/agents so the same gaps don't recur. Two independent fixes, one commit each:

fix(gitea): correct issue auto-close gotcha, drop unused tool

The gotcha claimed Gitea never auto-closes issues on merge. Empirically wrong: PR #64 auto-closed #63 because it was a regular (non-squash) merge and one of its commits had Fixes #63 in its own message — Gitea parses closing keywords in commit messages landing on the default branch. Only squash merges (this skill's own pr merge default) are unreliable for this. Gotcha rewritten with the real mechanism and cross-referenced from the pr merge dispatch step.
Dropped mcp__gitea__search_issues from allowed-tools — no dispatch route calls it (caught by an independent skill-audit pass).
bin plugin version 1.0.4 → 1.0.5.

fix(kyberforge): broaden audit self-triggers, plug factory gaps

During the #63 fix, agent-author/agent-audit were hand-edited directly (bypassing skill-author), so they never got their own inline audit — that gap was only caught because forge was invoked afterward to ask about it. skill-audit and agent-audit descriptions now explicitly trigger on "hand-edited a skill/agent file outside the author skill," so this self-triggers next time without needing forge.
plugin-author gains a Gotchas bullet on claude plugin validate --strict auto-discovering every .md under agents/ regardless of manifest declarations (ADR-0010) — anyone scaffolding a plugin with a non-agent file in agents/ would hit the same bug #63 fixed.
Two independent bugs an audit pass caught in agent-audit: validate-provenance.sh --help didn't document its own exit code 2, and the SKILL.md description undercounted its audit dimensions (five named vs. six actually reported in Step 3).
kyberforge plugin version 1.2.0 → 1.2.2.

Every touched skill (gitea, plugin-author, skill-audit, agent-audit) passed an independent clean-context skill-audit re-run before being considered done, with two rounds of fix-and-recheck for gitea and agent-audit.

Test plan

Independent clean-context skill-audit pass on all four touched skills — all PASS (2 with harmless pre-existing INFOs)
Pre-push hooks (test suite, plugin manifest checks, plugin validation, marketplace validation) pass

🤖 Generated with Claude Code

## Summary Follow-up to #63 / #64. While closing out that fix, `kyberforge:forge` was used to review what should be embedded into skills/agents so the same gaps don't recur. Two independent fixes, one commit each: **`fix(gitea): correct issue auto-close gotcha, drop unused tool`** - The gotcha claimed Gitea never auto-closes issues on merge. Empirically wrong: PR #64 auto-closed #63 because it was a regular (non-squash) merge and one of its commits had `Fixes #63` in its own message — Gitea parses closing keywords in commit messages landing on the default branch. Only squash merges (this skill's own `pr merge` default) are unreliable for this. Gotcha rewritten with the real mechanism and cross-referenced from the `pr merge` dispatch step. - Dropped `mcp__gitea__search_issues` from `allowed-tools` — no dispatch route calls it (caught by an independent skill-audit pass). - `bin` plugin version 1.0.4 → 1.0.5. **`fix(kyberforge): broaden audit self-triggers, plug factory gaps`** - During the #63 fix, `agent-author`/`agent-audit` were hand-edited directly (bypassing `skill-author`), so they never got their own inline audit — that gap was only caught because `forge` was invoked afterward to ask about it. `skill-audit` and `agent-audit` descriptions now explicitly trigger on "hand-edited a skill/agent file outside the author skill," so this self-triggers next time without needing forge. - `plugin-author` gains a Gotchas bullet on `claude plugin validate --strict` auto-discovering every `.md` under `agents/` regardless of manifest declarations (ADR-0010) — anyone scaffolding a plugin with a non-agent file in `agents/` would hit the same bug #63 fixed. - Two independent bugs an audit pass caught in `agent-audit`: `validate-provenance.sh --help` didn't document its own exit code 2, and the SKILL.md description undercounted its audit dimensions (five named vs. six actually reported in Step 3). - `kyberforge` plugin version 1.2.0 → 1.2.2. Every touched skill (gitea, plugin-author, skill-audit, agent-audit) passed an independent clean-context `skill-audit` re-run before being considered done, with two rounds of fix-and-recheck for gitea and agent-audit. ## Test plan - [x] Independent clean-context `skill-audit` pass on all four touched skills — all PASS (2 with harmless pre-existing INFOs) - [x] Pre-push hooks (test suite, plugin manifest checks, plugin validation, marketplace validation) pass 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Claude added 2 commits 2026-07-05 09:36:27 +00:00

fix(gitea): correct issue auto-close gotcha, drop unused tool f21a1427f5

The gotcha claimed Gitea never auto-closes issues on merge. Confirmed
empirically (issue #63 / PR #64) that a regular merge preserving an
original commit's closing keyword does auto-close — only squash merges
(this skill's default) are unreliable. Also drops search_issues from
allowed-tools since no dispatch route calls it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

fix(kyberforge): broaden audit self-triggers, plug factory gaps 642e4fd142

skill-audit/agent-audit now proactively trigger after a skill/agent
file is hand-edited outside skill-author/agent-author, not just on
explicit request — closing a gap from this session where a fork's
direct edits to agent-author/agent-audit shipped without their own
inline audit until forge was invoked to check afterward.

Also: plugin-author gains a gotcha on claude plugin validate --strict
auto-discovering every .md under agents/ regardless of manifest
declarations (ADR-0010); agent-audit's dimension count and
validate-provenance.sh's --help now match actual behavior.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Defame1297 approved these changes 2026-07-05 09:38:32 +00:00

Defame1297 merged commit 828e79535f into main

2026-07-05 09:38:49 +00:00

Defame1297 deleted branch chore/factory-lessons-from-63

2026-07-05 09:38:49 +00:00

Defame1297 referenced this issue from a commit

2026-07-05 09:38:50 +00:00

Merge pull request 'fix(factory): embed lessons from #63 into gitea and kyberforge skills' (#65) from chore/factory-lessons-from-63 into main

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Defame1297/holocron#65