Defame1297/holocron
0
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Build agents/skills to execute marketplace→APM conversion #88

New Issue
Closed
opened 2026-08-10 17:03:03 +00:00 by Claude · 2 comments
Claude commented 2026-08-10 17:03:03 +00:00
Collaborator
Copy Link

Convert this repo's plugin/marketplace authoring model from hand-maintained .claude-plugin/marketplace.json + per-plugin plugin.json to Microsoft APM (apm.yml + .apm/) as the source of truth — an outright replacement of the authoring layer, not an overlay. The plugins/<name>/ monorepo-hybrid directory layout survives; .claude-plugin/marketplace.json and per-provider plugin.json files become compiled output (apm compile/apm pack), extensible to non-Claude providers (Copilot, Gemini, Codex) without hand-maintaining separate manifests.

Research: plugins/kyberforge/docs/research/docs/microsoft-apm/. Decision record: see the ADR superseding ADR-0001 (linked via comment once written).

This issue is scoped to ONE thing: build the apm CLI operational tooling — install, configure, run, compile, audit — as three new artifacts in kyberforge:

  • apm-install (skill) — apm binary install + apm runtime setup|list|status|remove
  • apm-workflow (skill) — human-facing dispatch over configure/scaffold (apm.yml authoring, apm plugin init), marketplace (apm marketplace init|check|package add|add), compile/pack/publish, audit/validate (apm audit, apm marketplace check) — one reference file per concern, dispatched like gitea-issues
  • apm-orchestrate (agent) — deterministic counterpart to apm-workflow, for subagent-dispatched multi-plugin work when the real conversion is executed

Explicitly out of scope (tracked separately):

  • Adapting plugin-author/marketplace-author/skill-author/agent-author/forge's routing to author .apm/-native content — #89
  • Actually translating the existing plugins into apm.yml + .apm/ and running the real conversion — #90

Acceptance criteria: all three artifacts authored via forge, pass skill-audit/agent-audit, internally consistent with the microsoft-apm research docs. No live apm CLI smoke test required — deferred to when these skills are used for the real conversion.

Convert this repo's plugin/marketplace authoring model from hand-maintained `.claude-plugin/marketplace.json` + per-plugin `plugin.json` to Microsoft APM (`apm.yml` + `.apm/`) as the source of truth — an outright replacement of the authoring layer, not an overlay. The `plugins/<name>/` monorepo-hybrid directory layout survives; `.claude-plugin/marketplace.json` and per-provider `plugin.json` files become **compiled output** (`apm compile`/`apm pack`), extensible to non-Claude providers (Copilot, Gemini, Codex) without hand-maintaining separate manifests. Research: `plugins/kyberforge/docs/research/docs/microsoft-apm/`. Decision record: see the ADR superseding ADR-0001 (linked via comment once written). **This issue is scoped to ONE thing**: build the `apm` CLI *operational* tooling — install, configure, run, compile, audit — as three new artifacts in `kyberforge`: - `apm-install` (skill) — `apm` binary install + `apm runtime setup|list|status|remove` - `apm-workflow` (skill) — human-facing dispatch over configure/scaffold (`apm.yml` authoring, `apm plugin init`), marketplace (`apm marketplace init|check|package add|add`), compile/pack/publish, audit/validate (`apm audit`, `apm marketplace check`) — one reference file per concern, dispatched like `gitea-issues` - `apm-orchestrate` (agent) — deterministic counterpart to `apm-workflow`, for subagent-dispatched multi-plugin work when the real conversion is executed **Explicitly out of scope** (tracked separately): - Adapting `plugin-author`/`marketplace-author`/`skill-author`/`agent-author`/`forge`'s routing to author `.apm/`-native content — #89 - Actually translating the existing plugins into `apm.yml` + `.apm/` and running the real conversion — #90 **Acceptance criteria**: all three artifacts authored via `forge`, pass `skill-audit`/`agent-audit`, internally consistent with the `microsoft-apm` research docs. No live `apm` CLI smoke test required — deferred to when these skills are used for the real conversion.
Claude added the Kind/Feature label 2026-08-10 17:03:03 +00:00
Defame1297 added this to the Kyberforge basics milestone 2026-08-10 17:05:31 +00:00
Claude commented 2026-08-10 17:42:45 +00:00
Author
Collaborator
Copy Link

Decision record: ADR-0015 (docs/adr/0015-apm-replaces-plugin-marketplace-authoring.md, commit 0e421ac on feat/88-marketplace-apm-conversion) — replaces the plugin/marketplace authoring model with Microsoft APM outright, supersedes ADR-0001. See issues #89 (adapt authoring skills/forge) and #90 (execute the real conversion) for deferred follow-up work.

Decision record: ADR-0015 (`docs/adr/0015-apm-replaces-plugin-marketplace-authoring.md`, commit 0e421ac on `feat/88-marketplace-apm-conversion`) — replaces the plugin/marketplace authoring model with Microsoft APM outright, supersedes ADR-0001. See issues #89 (adapt authoring skills/forge) and #90 (execute the real conversion) for deferred follow-up work.
Claude commented 2026-08-10 18:33:39 +00:00
Author
Collaborator
Copy Link

Ran a full multi-agent PR review (/code-review high) against PR #91, which implements this issue's three artifacts. Posted 10 inline findings there: https://git.dev.rkdr.net/Defame1297/holocron/pulls/91#issuecomment-1419

Summary — all documentation-level (the diff is all markdown, no executable code), grouped:

  1. ADR-0015 contradicts itself on when ADR-0001 is actually superseded: the Decision section states it present-tense ("this directly supersedes ADR-0001"), the Consequences section says it's conditional on issue #90 executing. Also: the stated rationale for not making this a standalone plugin ("specific to this repo's conversion, not a generic toolkit") doesn't match what shipped — apm-install/apm-workflow are fully generic, repo-agnostic APM docs.
  2. apm-orchestrate's operation vocabulary is ungrounded — compile-manifest-check, add-package, add-marketplace don't map to any documented apm-workflow CLI verb or research doc anywhere (verified by grep). This directly undercuts the PR's own acceptance criterion of being "internally consistent with the microsoft-apm research docs."
  3. A Hard Rule in apm-orchestrate.md can never fire — it governs apm.yml content the orchestrator writes/edits, but the agent only has Bash, Read tools and its own Scope says it delegates manifest writes. Dead safety text.
  4. apm-orchestrate.md and apm-orchestrate.agent.md (the Copilot pair) have already drifted on the Output contract — one has an explicit error-code enum, the other only prose.
  5. apm-workflow's reference docs largely duplicate the research docs (two sources of truth), and marketplace.md's release step recommends raw git shell instead of this repo's own git-commits/git-remotes skills.
  6. CONTEXT.md and ADR-0001 get no forward-pointer to ADR-0015 despite the ADR claiming they're affected — an agent consulting them directly (mandated at session start per AGENTS.md) has no signal a change is pending.

Recommend treating (1) and (3) as should-fix before merge; the rest are consistency/maintainability notes. None block on correctness of the actual CLI operation logic since none was tested live (deferred to #89/#90 per the PR's own test plan).

Ran a full multi-agent PR review (`/code-review high`) against PR #91, which implements this issue's three artifacts. Posted 10 inline findings there: https://git.dev.rkdr.net/Defame1297/holocron/pulls/91#issuecomment-1419 Summary — all documentation-level (the diff is all markdown, no executable code), grouped: 1. **ADR-0015 contradicts itself** on when ADR-0001 is actually superseded: the Decision section states it present-tense ("this directly supersedes ADR-0001"), the Consequences section says it's conditional on issue #90 executing. Also: the stated rationale for not making this a standalone plugin ("specific to this repo's conversion, not a generic toolkit") doesn't match what shipped — apm-install/apm-workflow are fully generic, repo-agnostic APM docs. 2. **apm-orchestrate's operation vocabulary is ungrounded** — `compile-manifest-check`, `add-package`, `add-marketplace` don't map to any documented apm-workflow CLI verb or research doc anywhere (verified by grep). This directly undercuts the PR's own acceptance criterion of being "internally consistent with the microsoft-apm research docs." 3. **A Hard Rule in apm-orchestrate.md can never fire** — it governs apm.yml content the orchestrator writes/edits, but the agent only has `Bash, Read` tools and its own Scope says it delegates manifest writes. Dead safety text. 4. **apm-orchestrate.md and apm-orchestrate.agent.md (the Copilot pair) have already drifted** on the Output contract — one has an explicit error-code enum, the other only prose. 5. **apm-workflow's reference docs largely duplicate the research docs** (two sources of truth), and marketplace.md's release step recommends raw git shell instead of this repo's own git-commits/git-remotes skills. 6. **CONTEXT.md and ADR-0001 get no forward-pointer to ADR-0015** despite the ADR claiming they're affected — an agent consulting them directly (mandated at session start per AGENTS.md) has no signal a change is pending. Recommend treating (1) and (3) as should-fix before merge; the rest are consistency/maintainability notes. None block on correctness of the actual CLI operation logic since none was tested live (deferred to #89/#90 per the PR's own test plan).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Kind/Feature
Milestone
No items
No Milestone Kyberforge basics
Projects
Clear projects
No project
Assignees
Clear assignees
Claude renovate-bot Defame1297
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Defame1297/holocron#88
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?