refactor!: carry out the simplification audit across gates, tests, plugins and docs #135
@@ -6,7 +6,7 @@ description: >
|
|||||||
Not read-only review -> `factory-audit`. Not skills -> `skill-author`.
|
Not read-only review -> `factory-audit`. Not skills -> `skill-author`.
|
||||||
allowed-tools: Bash Read Write Edit
|
allowed-tools: Bash Read Write Edit
|
||||||
metadata:
|
metadata:
|
||||||
version: "1.0.2"
|
version: "1.0.3"
|
||||||
category: factory
|
category: factory
|
||||||
source_keys:
|
source_keys:
|
||||||
- context7-websites-code-claude
|
- context7-websites-code-claude
|
||||||
|
|||||||
@@ -29,7 +29,8 @@ A description carries exactly three things:
|
|||||||
3. **Boundary clause** — form: `Not <thing> -> <name>.` Add one only where a near-miss agent or
|
3. **Boundary clause** — form: `Not <thing> -> <name>.` Add one only where a near-miss agent or
|
||||||
skill could steal delegations.
|
skill could steal delegations.
|
||||||
|
|
||||||
Banned from a description; move it to the body or to `README.md`:
|
Banned from a description; move it to the body — an agent is a single file with no `references/`
|
||||||
|
directory to move it to:
|
||||||
|
|
||||||
- Capability enumeration or feature lists
|
- Capability enumeration or feature lists
|
||||||
- Per-scope emission mechanics — which files the author skill writes at which scope changes no
|
- Per-scope emission mechanics — which files the author skill writes at which scope changes no
|
||||||
|
|||||||
@@ -7,7 +7,7 @@ description: >
|
|||||||
fixes -> agent-author.
|
fixes -> agent-author.
|
||||||
allowed-tools: Bash Read
|
allowed-tools: Bash Read
|
||||||
metadata:
|
metadata:
|
||||||
version: "1.0.1"
|
version: "1.0.2"
|
||||||
category: factory
|
category: factory
|
||||||
source_keys:
|
source_keys:
|
||||||
- agentskills-home
|
- agentskills-home
|
||||||
|
|||||||
@@ -44,7 +44,8 @@ A plugin-scope agent is a single `.apm/agents/<name>.agent.md` file with no sibl
|
|||||||
directory. It cannot progressively disclose to itself — it can only delegate to skills. So a
|
directory. It cannot progressively disclose to itself — it can only delegate to skills. So a
|
||||||
procedure spelled out in an agent body that a skill the agent invokes already owns is not a
|
procedure spelled out in an agent body that a skill the agent invokes already owns is not a
|
||||||
shortcut: it is a second copy of that procedure, and the second copy drifts. This is the
|
shortcut: it is a second copy of that procedure, and the second copy drifts. This is the
|
||||||
characteristic agent defect, the way a stale README row is the characteristic skill defect.
|
characteristic agent defect, the way a `SKILL.md` naming a `references/` file that is not there is
|
||||||
|
the characteristic skill defect.
|
||||||
|
|
||||||
**An agent body that restates a procedure owned by a skill it can invoke is a FAIL.** The Fix is
|
**An agent body that restates a procedure owned by a skill it can invoke is a FAIL.** The Fix is
|
||||||
always the same shape: invoke `<skill>` instead.
|
always the same shape: invoke `<skill>` instead.
|
||||||
|
|||||||
@@ -46,7 +46,7 @@ A model-invoked description carries exactly three things:
|
|||||||
instead") is only a SUGGESTION unless a second target in the same sentence resolves. Take the
|
instead") is only a SUGGESTION unless a second target in the same sentence resolves. Take the
|
||||||
script's tier as given and report it once, under Structure.
|
script's tier as given and report it once, under Structure.
|
||||||
|
|
||||||
Everything else belongs in the body or in `README.md`.
|
Everything else belongs in the body or in a `references/` file.
|
||||||
|
|
||||||
## Indirect triggers — conditional, never blanket
|
## Indirect triggers — conditional, never blanket
|
||||||
|
|
||||||
|
|||||||
@@ -6,7 +6,7 @@ description: >
|
|||||||
Not read-only review -> `factory-audit`. Not agent files -> `agent-author`.
|
Not read-only review -> `factory-audit`. Not agent files -> `agent-author`.
|
||||||
allowed-tools: Bash Read Write Edit
|
allowed-tools: Bash Read Write Edit
|
||||||
metadata:
|
metadata:
|
||||||
version: "1.0.3"
|
version: "1.0.4"
|
||||||
category: factory
|
category: factory
|
||||||
source_keys:
|
source_keys:
|
||||||
- agentskills-home
|
- agentskills-home
|
||||||
|
|||||||
@@ -7,9 +7,9 @@ source_keys:
|
|||||||
|
|
||||||
# The description and body contract
|
# The description and body contract
|
||||||
|
|
||||||
House contract. Every rule here is enforced by `/factory-audit` —
|
House contract. Every rule here is enforced by `/factory-audit` — the counts and the boundary
|
||||||
`scripts/validate.sh` for the counts and the boundary targets, the bundled Vale styles for the
|
targets by `factory-audit`'s `scripts/validate.sh`, the prose patterns by the Vale styles it
|
||||||
prose patterns, and its reference files for the judgment calls.
|
bundles, the judgment calls by its reference files.
|
||||||
|
|
||||||
## Why the budget exists
|
## Why the budget exists
|
||||||
|
|
||||||
@@ -28,10 +28,11 @@ A description carries exactly three things:
|
|||||||
Focus on user intent, not the skill's internal mechanics.
|
Focus on user intent, not the skill's internal mechanics.
|
||||||
2. **At most one capability clause** — what it does, one clause, no enumeration. Be specific
|
2. **At most one capability clause** — what it does, one clause, no enumeration. Be specific
|
||||||
("parses and validates OpenAPI specs", not "helps with APIs").
|
("parses and validates OpenAPI specs", not "helps with APIs").
|
||||||
3. **Boundary clause** — form: `Not <thing> -> <skill-name>.` Add one only where a near-miss skill
|
3. **Boundary clause** — form: `Not <thing> -> <skill-name>.` Write one per genuine near-miss
|
||||||
could steal activations.
|
skill that could steal activations: at least one, not exactly one — `git-remotes` carries
|
||||||
|
four. What is banned is a clause invented for a skill that was never going to compete.
|
||||||
|
|
||||||
Banned from a description; move it to the body or to `README.md`:
|
Banned from a description; move it to the body or to a `references/` file:
|
||||||
|
|
||||||
- Capability enumeration or feature lists
|
- Capability enumeration or feature lists
|
||||||
- Output-format detail ("Produces a compact findings report with Why and Fix per finding")
|
- Output-format detail ("Produces a compact findings report with Why and Fix per finding")
|
||||||
|
|||||||
@@ -58,7 +58,7 @@ Then proceed — edits are reversible via git, no approval checkpoint needed.
|
|||||||
## Step 4 — Apply changes
|
## Step 4 — Apply changes
|
||||||
|
|
||||||
Edit any file in the skill directory that the signals point to: SKILL.md, `scripts/`,
|
Edit any file in the skill directory that the signals point to: SKILL.md, `scripts/`,
|
||||||
`references/`, `assets/`, `tests/`, README.md.
|
`references/`, `assets/`, `tests/`.
|
||||||
|
|
||||||
**Generalize, do not patch.** Find the underlying gap, not the specific example that failed. A fix
|
**Generalize, do not patch.** Find the underlying gap, not the specific example that failed. A fix
|
||||||
scoped only to the test cases you have seen will overfit and perform worse on new inputs.
|
scoped only to the test cases you have seen will overfit and perform worse on new inputs.
|
||||||
@@ -89,6 +89,16 @@ order, stopping once the gate clears; the order puts the cuts that lose the leas
|
|||||||
|
|
||||||
Still over after all four means the skill does two jobs: split it rather than compressing prose.
|
Still over after all four means the skill does two jobs: split it rather than compressing prose.
|
||||||
|
|
||||||
|
**Re-cite what moved.** After content moves between files, update `references/sources.md`'s
|
||||||
|
`Contributing files` for every slug whose content moved, and drop any file the edit deleted.
|
||||||
|
`factory-audit`'s `scripts/validate-provenance.sh` exits 0 on exactly that drift, so a stale
|
||||||
|
provenance claim ships unless you fix it here.
|
||||||
|
|
||||||
|
**Re-check every relocated gate's reachability.** A Gotcha or gate moved out of the body into one
|
||||||
|
flow's `references/` file is invisible to every other branch, and the word counts improve either
|
||||||
|
way. For each one you move, list the flows that need it: it belongs in one flow's file only when
|
||||||
|
exactly one flow reaches it, otherwise in the body's common-gates section.
|
||||||
|
|
||||||
If a signal points to a script or reference file, edit that file directly rather than adding a
|
If a signal points to a script or reference file, edit that file directly rather than adding a
|
||||||
workaround in SKILL.md.
|
workaround in SKILL.md.
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user