feat(kyberforge): add instructions-author skill for .apm/instructions files #154

Open
Claude wants to merge 3 commits from feat/148-instructions-author into main
pull from: feat/148-instructions-author
Collaborator

Summary

  • New instructions-author skill (v0.1.0): scaffolds and revises .apm/instructions/*.instructions.md via scripts/new-instructions.sh, a minimal template, and create/improve flows.
  • Verification recipe (references/verify.md) uses a real apm compile --dry-run plus a throwaway-package install, because apm compile --validate always exits 0 and hides the missing-description, missing-applyTo and empty-body warnings.
  • Gotchas demonstrated in bats against real apm 0.28.0: Claude Code drops description; an unquoted applyTo installs with no paths: (loads in every session); compile writes no CLAUDE.md once rules are installed.
  • Wiring: forge routing row (+ author-routes.md, version-bump.md), one-line pointer in apm-workflow/references/compile.md, and ADR-0022 patch bumps for forge (1.0.3) and apm-workflow (1.0.2).
  • Research docs for the primitive (schema, target mapping, gotchas, sources) added earlier on this branch.
  • Versions: kyberforge 2.0.2 -> 2.1.0, catalog 0.5.2 (root apm.yml, executables.allow key, marketplace.json).

Notes

  • factory-audit has no instructions flow yet (#151), so forge's clean-context rerun is skipped for instructions files; stated in author-routes.md.
  • apm-workflow/references/compile.md line 66 (empty apm compile exits 1) looks stale for 0.28.0; left untouched as out of scope.

Test plan

  • factory-audit on instructions-author: validate, provenance and Vale clean; qualitative review resolved
  • scripts/skill-size-check.sh (ADR-0020 budgets)
  • apm audit --ci and apm pack --check-clean
  • Full bats suite: 440 tests, 0 failures
  • Pre-push hooks pass

Fixes #148

🤖 Generated with Claude Code

https://claude.ai/code/session_01KkT7RSDwDbmrM9T34b6sTi

## Summary - New `instructions-author` skill (v0.1.0): scaffolds and revises `.apm/instructions/*.instructions.md` via `scripts/new-instructions.sh`, a minimal template, and create/improve flows. - Verification recipe (`references/verify.md`) uses a real `apm compile --dry-run` plus a throwaway-package install, because `apm compile --validate` always exits 0 and hides the missing-`description`, missing-`applyTo` and empty-body warnings. - Gotchas demonstrated in bats against real apm 0.28.0: Claude Code drops `description`; an unquoted `applyTo` installs with no `paths:` (loads in every session); compile writes no `CLAUDE.md` once rules are installed. - Wiring: `forge` routing row (+ `author-routes.md`, `version-bump.md`), one-line pointer in `apm-workflow/references/compile.md`, and ADR-0022 patch bumps for `forge` (1.0.3) and `apm-workflow` (1.0.2). - Research docs for the primitive (schema, target mapping, gotchas, sources) added earlier on this branch. - Versions: kyberforge 2.0.2 -> 2.1.0, catalog 0.5.2 (root `apm.yml`, `executables.allow` key, `marketplace.json`). ## Notes - `factory-audit` has no instructions flow yet (#151), so forge's clean-context rerun is skipped for instructions files; stated in `author-routes.md`. - `apm-workflow/references/compile.md` line 66 (empty `apm compile` exits 1) looks stale for 0.28.0; left untouched as out of scope. ## Test plan - [x] `factory-audit` on `instructions-author`: validate, provenance and Vale clean; qualitative review resolved - [x] `scripts/skill-size-check.sh` (ADR-0020 budgets) - [x] `apm audit --ci` and `apm pack --check-clean` - [x] Full bats suite: 440 tests, 0 failures - [x] Pre-push hooks pass Fixes #148 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01KkT7RSDwDbmrM9T34b6sTi
Claude added 3 commits 2026-10-01 07:09:51 +00:00
The existing schema doc covered only Claude and Copilot and called missing
description and empty content errors when apm 0.28.0 only warns. Rewrite it
with the applyTo grammar and add per-target compile/install mapping and a
gotchas doc (unquoted globs, install-vs-compile discovery, dedup and
overwrite behaviour), all verified against the apm 0.28.0 binary.

Refs: #148

Co-Authored-By: Claude Code <[email protected]>
Claude-Session: https://claude.ai/code/session_01KkT7RSDwDbmrM9T34b6sTi
Scaffolds and revises apm instructions files, with a throwaway-package
verification recipe because `apm compile --validate` always exits 0 and
Claude Code drops `description`. Routed from forge and linked from
apm-workflow's compile reference. Bumps kyberforge to 2.1.0 and the catalog
to 0.5.2.

Fixes #148

Co-Authored-By: Claude Code <[email protected]>
Claude-Session: https://claude.ai/code/session_01KkT7RSDwDbmrM9T34b6sTi
ADR-0022 requires a metadata.version raise on every changed skill; the
routing row and compile pointer added for instructions-author touched both.

Refs #148

Co-Authored-By: Claude Code <[email protected]>
Claude-Session: https://claude.ai/code/session_01KkT7RSDwDbmrM9T34b6sTi
This pull request doesn't have enough required approvals yet. 0 of 1 approvals granted from users or teams on the allowlist.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/148-instructions-author:feat/148-instructions-author
git checkout feat/148-instructions-author
Sign in to join this conversation.