Defame1297/holocron
0
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

feat(kyberforge): retarget forge skills to author/audit APM content #93

Merged
Defame1297 merged 14 commits from feat/89-apm-native-authoring into main 2026-08-12 11:48:50 +00:00
Conversation 6 Commits 14 Files Changed 34 +31 -1
2 changed files with 31 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ffebdc6584 - Show all commits

8
plugins/kyberforge/skills/agent-audit/scripts/validate.sh
View File

@@ -147,16 +147,22 @@ def find_apm_package_root(apm_yml_path):
return False
def detect_scope(start_dir):
Claude commented 2026-08-11 18:57:32 +00:00
Review
Copy Link

Misclassifies legacy plugin.json-only plugins. detect_scope() no longer recognizes plugin.json (only apm.yml), so existing plugin.json-only plugins are misclassified as project scope with the wrong counterpart path.

Reproduced: validate.sh plugins/kyberforge/agents/apm-orchestrate.md — a real, correctly-paired agent in this very plugin — fails with FAIL counterpart file not found: .github/agents/apm-orchestrate.agent.md, even though the real counterpart sits right next to it.

**Misclassifies legacy plugin.json-only plugins.** `detect_scope()` no longer recognizes `plugin.json` (only `apm.yml`), so existing plugin.json-only plugins are misclassified as project scope with the wrong counterpart path. Reproduced: `validate.sh plugins/kyberforge/agents/apm-orchestrate.md` — a real, correctly-paired agent in this very plugin — fails with `FAIL counterpart file not found: .github/agents/apm-orchestrate.agent.md`, even though the real counterpart sits right next to it.
home = os.path.expanduser('~')
current = os.path.abspath(start_dir)
while True:
apm_yml = os.path.join(current, 'apm.yml')
if os.path.isfile(apm_yml) and find_apm_package_root(apm_yml):
return 'plugin', current
# $HOME is the user-scope boundary — checked before the .git test
# below, so a dotfiles-managed $HOME (yadm, chezmoi bare-repo, etc.)
# can't shadow user scope by being its own .git repo.
if current == home:
return 'user', home
if os.path.isdir(os.path.join(current, '.git')):
return 'project', current
parent = os.path.dirname(current)
if parent == current:
return 'user', os.path.expanduser('~')
return 'user', home
current = parent
agent_dir = os.path.dirname(agent_file)

24
plugins/kyberforge/skills/agent-audit/tests/validate.bats
View File

@@ -68,6 +68,30 @@ EOF
refute_output --partial "FAIL"
}
@test "user scope: \$HOME being a dotfiles .git repo does not shadow user scope" {
local fake_home="$TMPDIR/fakehome"
mkdir -p "$fake_home/.git" "$fake_home/.claude/agents" "$fake_home/.copilot/agents"
cat > "$fake_home/.claude/agents/my-agent.md" <<EOF
---
name: my-agent
description: A valid agent description.
---
You are a test agent. When invoked, do the thing.
EOF
cat > "$fake_home/.copilot/agents/my-agent.agent.md" <<EOF
---
name: my-agent
description: A valid agent description.
---
You are a test agent. When invoked, do the thing.
EOF
run env HOME="$fake_home" bash "$SCRIPT" "$fake_home/.claude/agents/my-agent.md"
assert_success
refute_output --partial "FAIL"
}
@test "--help exits 0 and shows Usage:" {
run bash "$SCRIPT" --help
assert_success