Correct the hashes left by the branch rewrite (467bbd7 ->620f20b, 4059cb4 ->ffcbed6), annotatea8cd5e8andc59e4bfas reachable only through the598a7c3squash, strike the case 33 claims that4de5b6bmade stale, and re-measure the section 1 table, the gates.md length and the ADR share atbaa2f5d. Add section 12 for the final seven-reviewer round. Move the record under docs/notes/, alongside the repo's other closed decision records, and update ADR-0024's pointer to it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
183 KiB
Simplification audit
Status: complete (2026-09-16). Every finding is closed at its own note except 22, deferred with
bin. See §7's status notes for the closing summary. This document is now a record; do not reopen it for new work — file an issue instead.
Date: 2026-09-10. Read-only analysis; nothing has been changed. Purpose: a hand-off for deciding what to remove, merge, and shrink. Findings are ranked by payoff within each area; effort is S/M/L. Claims were independently re-verified against the repo by a clean reviewer; corrections have been applied.
Assumptions agreed before analysis: anything is on the table, Claude Code and Copilot CLI both stay supported, findings are ranked with effort.
Counting convention: line counts are hand-edited .apm/ source unless marked "incl. mirror". Every .apm/ file has a byte-identical generated copy at the plugin root, so plugin cuts count double in the repo total.
Superseded (2026-09-14): the mirror is gone (commit
718c79a, ADR-0024). "incl. mirror" totals below are historical. Measured against the 2026-09-10 baseline (9eb8bc7), what remains live varies by plugin — 44% to 71%, not a uniform ~70%:
Plugin Baseline (incl. mirror) At a6434e0Live kyberforge 44,568 31,432 70.5% git 9,889 6,045 61.1% gitea 6,047 3,471 57.4% core 3,873 2,355 60.8% lint 1,558 923 59.2% bin 4,704 2,075 44.1% Across all six the baseline was 70,639 lines and 46,301 remain (65.5%). The mirror was 20,061 of those lines, so mirror deletion alone would have left ~71.6%; everything below that line is source the other findings cut, which is why bin — where findings 10, 12, and 13 landed hardest — is the outlier. (Counted as tracked lines under
plugins/<name>/at9eb8bc7and ata6434e0.)Re-measured (2026-09-14, at
a6434e0): the right-hand column originally read 31,473 / 6,050 / 3,471 / 2,360 / 923 / 2,083 = 46,360 and was labelled "Today" against "the current working tree". It did not reconcile to its own commit's tree — at061bb3d, where it was written, the six plugins measured 31,435 / 6,048 / 3,474 / 2,358 / 926 / 2,087 = 46,328 — and "the current working tree" is a basis that goes stale silently. Re-counted ata6434e0and the column now names its SHA. The baseline column is confirmed exact against9eb8bc7. Commits after061bb3d(c96ca9c, which deleted the six plugin-root.mcp.jsonfiles) account for most of the remaining drift.
Re-derived (2026-09-16, at HEAD on
docs/simplification-audit): the 2026-09-15 notes recording finding 14's merge (→467bbd7620f20b, ADR-0025) and the pipefail fix (→4059cb4ffcbed6) were written without correcting the headlines they annotate, so this pass re-counted every figure those two commits could have moved and corrected each in place above and below. Everything re-measured here came from a command run at HEAD —git ls-files,wc -l,grep -c, andbash tests/run-tests.sh --strict— never from an earlier note. What moved: finding 2 (two surviving sync gates → one), the.pre-commit-config.yamlhook counts (27/9 → 26/8, then back to 27/9 — see the correction at the end of this note), the skill census (39 → 38 and everything derived from it), finding 11's validator andsources.mdfigures, finding 16's whole numeric basis, and the staleskill-audit/,agent-audit/andformatting-and-scripts.mdpaths in findings 18, 19 and 33. §1's three rows re-measured:469→ 471 tracked files (465→ 467 regular plus the 4 submodule gitlinks) /74,594→ 75,441 lines (pinned toc07ca07; see the note below);plugins/46,106 (62%)→ 46,127 (61%); the 38SKILL.mdbodies 2,409 (5.2% of plugin lines); enforcement20→tests/test-*.shtotalling 10,189 lines21→ 19 totalling 10,088 attests/test-*.shtotalling 10,608 linesbaa2f5d, the two runners 502 (run-tests.sh283 +run-bats.sh219), andscripts/2,901→ 3,139; kyberforge's validator scripts and their bats tests5,861→ 5,876 + 6,015 (the merge deduplicated scripts and left the test corpus larger, not smaller —git ls-files 'plugins/kyberforge/.apm/skills/*/scripts/*.sh'and.../tests/*.bats).run-tests.sh --strictreports20 passed, 0 skipped, 0 failed→21 passed, 0 skipped, 0 failed→ 19 passed, 0 skipped, 0 failed atbaa2f5d(4de5b6bdeleted two suites).Re-measured (2026-09-16, at
c07ca07): commit8451169addedcheck-skill-version-bump— a pre-push hook,scripts/check-skill-version-bump.sh(238 lines) andtests/test-skill-version-bump.sh(410) — after the figures above were taken, so each was one short..pre-commit-config.yamlnow has 27- id:entries and 9stages: [pre-push](grep -c -- "- id:";grep -c "stages: \[pre-push\]"), all nine repo-authored. The struck figures are replaced from these commands. They were run against the working tree, and every figure reproduces exactly from the committed tree atc07ca07:git ls-files | wc -l;catover every non-gitlink tracked path| wc -l;git ls-files plugins | xargs cat | wc -l;git ls-files scripts | xargs wc -l(no untracked files underscripts/);ls tests/test-*.sh | wc -landcat tests/test-*.sh | wc -l;bash tests/run-tests.sh --strict. The earlier 469 / 74,594 / 46,106 did not reproduce exactly at8451169^either (469 / 74,638 / 46,121), so they were taken at an earlier commit than this note's "at HEAD" says. Re-checked and unchanged, so left alone:docs/research/inside plugins (19,030) and repo-leveldocs/research/+docs/notes/(4,488). Not re-measured, and still carrying their last stated basis: the preload-tax and commit-share rows, §2's timings, and the per-plugin table in the note above.Pinned (2026-09-16, review round): the tracked-lines total is a moving figure, and this file moves it:
b426460changed only this audit and took the committed total from 75,441 to 75,461. So the figure stays pinned to a commit instead of being chased. Atc07ca07the committed tree has 471 paths (git ls-tree -r), 75,441 lines (every blob,git cat-file -p … | wc -l), and 46,127 lines underplugins/(61%). The 38SKILL.mdbodies there total 2,409 lines. Atc07ca07the working-tree method above gives the same numbers, because nothing else was uncommitted. Thescripts/,tests/and runner figures in the note above also reproduce atc07ca07, and atb426460too, since that commit changed no other file.
Reviewed (2026-09-14): commits
718c79aandd2480b8were put through a five-agent review. Result: zero skill, agent or hook regressions — 39 skills before and after, all gates passing, and both hook removals (validate-plugins,check-plugin-content-sync) genuinely moot rather than merely unenforced. One real functional regression was found — MCP propagation to consumers, broken by the same commit's manifest deletion; see finding 37 — along with the numeric and bookkeeping drift in this document's own 2026-09-14 notes, corrected in place above and below.
Reviewed again (2026-09-16): the grill commits (
8451169throughb426460) went through a second review round. Its dispositions are in §11.
1. The shape of the problem
| Measure | Value |
|---|---|
| Tracked files / lines | c07ca07)baa2f5d) |
Lines in plugins/ |
baa2f5d) |
Of which the SKILL.md files a model actually loads |
baa2f5d) |
Generated flat mirror files (byte copies of .apm/) |
~ |
docs/research/ vendored inside plugins |
~19,000 lines, nothing executable reads it |
Repo-level docs/research/ + docs/notes/ |
4,500 lines, 47% of all prose words, 6 of 11 research files linked only from each other |
Enforcement: hook entries in .pre-commit-config.yaml / pre-push hooks |
baa2f5d; see the note below) |
Enforcement: tests/*.sh + runners + scripts/ |
4b17703)baa2f5d) |
| Validator scripts inside kyberforge (+ their bats tests) | baa2f5d) |
| Preload tax (39 skill names + descriptions) | 10,987 chars, ~2,750 tokens per session |
| Commits since 2026-05-10 / share touching hook, test, gate, vale, or sync | 447 / ~25% |
Corrected then done (2026-09-14): the mirror row's figure was wrong. The true mirror was 213 files / 20,061 lines, not 263 / ~22,000 — the original count swept in files that were never mirror output. All 213 were deleted in commit
718c79aondocs/simplification-audit(245 files changed, 298 insertions, 22,602 deletions across the whole change), so the row is now zero. The enforcement row is stale on both halves — it was correct at the 2026-09-10 baseline (9eb8bc7: 33- id:entries, 14 repo-authored pre-push hooks), but.pre-commit-config.yamltoday has27 entries and 9→stages: [pre-push]26 entries and 8→stages: [pre-push]27 entries and 9→ 26 entries and 8stages: [pre-push]stages: [pre-push](→467bbd7620f20bremovedcheck-vale-style-syncwith finding 14's merge;8451169then addedcheck-skill-version-bump;4de5b6bthen removedcheck-release-needed; re-measured 2026-09-16 at4b17703withgrep -c -- "- id:"andgrep -c "stages: \[pre-push\]"on.pre-commit-config.yaml). Like for like that is 14 →9→8→9→ 8 repo-authored pre-push hooks. The stage reports11→10→11→ 10, because the 2 pre-commitmetahooks also run there — a different counting basis; see the corrected §3 target, which states it the same way.
Re-measured (2026-09-14, at
a6434e0): this table is a dated snapshot corrected in place, not a live figure — every arrow above reads "baseline (2026-09-10,9eb8bc7) → value at the stated commit". Three further rows were still carrying baseline values afterd2480b8/061bb3dcorrected their neighbours, and are now corrected ata6434e0:
- Tracked files / lines: 475 / 73,073 (475 is
git ls-files | wc -l: 471 regular files plus 4 submodule gitlinks —docs/wiki,tests/bats,tests/test_helper/bats-assert,tests/test_helper/bats-support, whose own contents are not counted).- Lines in
plugins/: 46,301, which is 63% of 73,073, not 69%.- The 39
SKILL.mdbodies: 2,509 lines. That is now 5.4% of plugin lines rather than "under 4%" — the share rose because the denominator shrank faster than the payload, which is the whole point of the audit.- Enforcement scripts and tests: 20
tests/test-*.shtotalling 9,123 lines, the two runners 490 (run-tests.sh281 +run-bats.sh209), andscripts/3,308.Re-checked and still accurate at
a6434e0, so left alone:docs/research/inside plugins (19,030), repo-leveldocs/research/+docs/notes/(4,488), kyberforge validators + their bats tests (6,849 + 5,256). The hook-entry row is superseded by the paragraph above. Not re-measured: the preload-tax row (10,987 chars) and the commit-share row — the commit count alone has moved to 476 since 2026-05-10, and that row was always a moving figure.
The pattern across every area is the same: the payload (skill bodies, rules, decisions) is small and the scaffolding around it (mirrors, research dumps, sync gates, tests of tests, justification prose) is 10 to 30 times larger. A quarter of all commits have gone into maintaining the scaffolding.
2. Measured baseline: hooks and tests
Measured on this machine, clean tree, all hooks passing. pre-commit run --all-files per stage. Figures below are the 2026-09-10 measurement; rows struck through were deleted on 2026-09-14 (commit 718c79a) and their times no longer apply.
| Gate | Wall time |
|---|---|
| Full pre-push stage (everything below, sequential) | ~5 min 10 s |
run-tests (26 bash suites + 351 bats tests) |
276 s |
apm-audit-ci (7 manifests) |
12.2 s |
validate-plugins (6 × claude plugin validate) |
|
check-plugin-content-sync |
|
apm-pack-check-clean |
3.1 s |
| Other 9 pre-push hooks combined | 7.6 s |
| Full pre-commit stage, all files | 18.2 s |
run-tests is 90% of the wall time. Every push pays it in full: the runner has no change detection and the config sets always_run: true. apm-audit-ci is the second-slowest hook; per its own comment block its earlier description overclaimed, and what it verifies today is that seven manifests parse and the lockfile exists.
Where the 276 s goes (each suite run alone, sequential):
| Suite | Time | Note |
|---|---|---|
test-sync-plugin-content.sh |
14 temp trees, 2 git init, repeated apm pack |
|
| all 351 bats tests (10 files, kyberforge and core validators) | 64 s | mostly validate.sh / validate-provenance.sh fixtures |
test-adr0020-differential.sh |
29 s | 12 assertions; re-runs two validators over the live corpus and a fixture tree |
test-check-vale-style-sync.sh |
guards a byte-identical copy | |
test-vale-wrap.sh |
14 s | |
test-adr0020-frontmatter.sh + -targets.sh |
25 s | |
| Remaining 20 suites | 36 s | 12 of them run in under 2 s each |
Five suites account for 215 s of 276 s. Three of those five (sync-plugin-content, vale-style-sync, adr0020-differential) test tooling that findings 2, 7, and 14 propose to delete or shrink, so the fastest path to a quick pre-push is removing the duplication those tests guard rather than optimising the tests.
Also struck (2026-09-15):
test-check-vale-style-sync.sh(25 s) went with thecheck-vale-style-synchook in finding 14's merge (ADR-0025). Measured at HEAD:tests/holds 19test-*.shsuites andtests/run-tests.shreports19 passed, 0 skipped, 0 failed. (Later the same day, the pipefail-race fix addedtests/test-no-pipefail-early-exit-grep.sh, making it 20. That suite is a static scan and runs in well under a second, so the timing arithmetic here is unaffected.) Same basis as the note below — arithmetic on the 2026-09-10 baseline minus the struck rows, not a fresh timing run.
Done (2026-09-14): see commit
718c79aondocs/simplification-audit. The three struck-through rows are gone:test-sync-plugin-content.sh(83 s, 1,289 lines, 92 cases),check-plugin-content-sync(4.5 s) andvalidate-plugins(4.9 s). Expected, not re-measured: roughly 92 s comes off every push (83 + 4.5 + 4.9 = 92.4 s) (~83 s of it out ofrun-tests, which loses its single slowest suite), on the arithmetic of the 2026-09-10 figures alone. The remaining rows have not been re-timed since, so treat every number in this section as the 2026-09-10 baseline minus those three, not as a fresh measurement.
3. Enforcement layer: hooks, tests, scripts
This is the area you named as hardest to understand and slowest. Root cause: most pre-push hooks exist to keep two copies of something in sync, or to re-validate what another hook already validates.
-
Six hooks validate overlapping sets of the same manifests.
check-manifests,validate-plugins,validate-marketplace,apm-pack-check-clean,apm-marketplace-check,apm-audit-ci.Keep the twoclaude plugin validatehooks plusapm-pack-check-clean.Deletecheck-manifests(282 lines + 771 test lines; itslib/marketplace-plugins.shstays becausesync-plugin-content.shsources it).apm-audit-cispends 12 s confirming that manifestsapm packalready parses do parse; drop or keep on that basis.Move the network-dependentEffort S.apm-marketplace-checkto a release checklist.Done (2026-09-12): see commit
e647f14ondocs/simplification-audit. Deleted thecheck-manifestspre-commit hook entry,scripts/check-manifests.sh(282 lines), andtests/test-check-manifests.sh(771 lines); keptscripts/lib/marketplace-plugins.sh, still sourced bysync-plugin-content.sh. Updated the now-stalecheck-manifests.shmentions inREADME.mdanddocs/spec/gates.md(hook table row and hook counts). Theapm-audit-ciandapm-marketplace-checkdecisions in this finding remain open — out of scope for this change. Grilled and closed (2026-09-14):apm-audit-ci— already resolved before this audit was written:.pre-commit-config.yaml's own comment block (added in commita155af6, months before this audit) already rebuts the "overclaimed description" complaint and gives a dated, verified justification for what the hook still checks. Keep, no action.apm-marketplace-check— its stated purpose ("the only hook that checks remote package references rather than local-source paths") is void: finding 35 (commit568ca74) already removed the only remote package entry, so everymarketplace.packages[]entry is now a local./plugins/<name>path and the hook is pure overlap withapm-pack-check-clean. Removed the hook entry, and corrected the now-stale "does NOT join apm-marketplace-check ... on the offline SKIP= list" comment onapm-audit-ci(there is no offline skip list any more — every pre-push hook already passes offline perREADME.md). UpdatedREADME.md(tool table, "Offline?" section) anddocs/spec/gates.md(hook table, hook counts 13→11 self-authored / 15→13 total, the "Three of these shell out to apm" paragraph, and the "Pushing without a network" section) accordingly. Verified:apm audit --cistill passes per-plugin, and the pre-push hook count now matches.pre-commit-config.yaml. Corrected and closed (2026-09-14, ata6434e0): two things above went stale within hours of being written, and the finding was never given a marker.- "Keep the two
claude plugin validatehooks" is void.718c79a(ADR-0024) deletedvalidate-plugins— the ADR's own reasoning is thatclaude plugin validatereads manifests only and could never detect the empty-content defect it was credited with guarding, and with the per-plugin manifests gone it has nothing left to read. Onlyvalidate-marketplacesurvives, over the one manifest this repo still ships (.claude-plugin/marketplace.json). Of the six hooks this finding named, three now exist:validate-marketplace,apm-pack-check-clean,apm-audit-ci. Verified against.pre-commit-config.yaml:27→- id:entries, 9 withstages: [pre-push]26→- id:entries, 8 withstages: [pre-push]27→ 26- id:entries, 9 withstages: [pre-push]- id:entries, 8 withstages: [pre-push](re-measured 2026-09-16 at4b17703;8451169addedcheck-skill-version-bump, then4de5b6bremovedcheck-release-needed), novalidate-pluginsentry. - The gates.md figures above ("13→11 self-authored / 15→13 total") were correct for
0dffff3and are no longer current.718c79aremoved two more pre-push hooks after that commit, anddocs/spec/gates.md:24read 11 reported / 9 self-authored when this note was written; finding 14's merge has since removedcheck-vale-style-sync, and itnow reads 10 reported / 8 self-authored→ read 10 reported / 8 self-authored until8451169addedcheck-skill-version-bump; atb426460gates.md:24-28read 11 reported / 9 self-authored again, and since4de5b6bremovedcheck-release-neededit reads 10 reported / 8 self-authored (checked at4b17703). Read the count from that file, not from this note.
Marked
[x]: all three of this finding's decisions are resolved —check-manifestsdeleted (e647f14),apm-audit-cikept on the grill above,apm-marketplace-checkremoved (0dffff3). - "Keep the two
-
Fourtwo→ one surviving "keep two copies in sync" gate:1,100 script lines + 1,600 test lines778 script lines + 1,079 test lines→ 381 script lines + 297 test lines. Each one is a symptom of duplication that could be removed instead of guarded:Re-measured (2026-09-16, at HEAD):
→467bbd7620f20bdeletedcheck-vale-style-syncwith finding 14's merge, so the "two" above is now one —check-scope-walkup-sync, at 381 script lines (wc -l scripts/check-scope-walkup-sync.sh) and 297 test lines (wc -l tests/test-check-scope-walkup-sync.sh). Both grew sincea6434e0, where they measured 365 + 282. Readingcheck-executables-allow-syncinto the group as the note below does makes it two gates, 603 + 540 (222 + 243 for that one, unchanged). Re-measured (2026-09-14, ata6434e0): two of the four are gone —check-marketplace-mirror-syncdeleted in0dffff3(2c below) and, though it was never in this finding's own count,check-plugin-content-syncin718c79a. The two that survive arecheck-vale-style-sync(413 script + 797 test) andcheck-scope-walkup-sync(365 + 282);check-executables-allow-syncalso survives, shrunk to 222 + 243 (2d below), and counts as the third if that gate is read as part of this group rather than as its own item. Two-gate total 778 + 1,079; three-gate total 1,000 + 1,322. The per-bullet script and test figures below are all still exact at this commit exceptcheck-executables-allow-sync's "474 lines", which 2d already corrects.Done (2026-09-15,check-vale-style-sync: 413 lines + 798 test lines guarding a byte-identical 526-linevale-wrap.shand style directory copied between skill-audit and agent-audit. About 350 of its lines run Vale glob probes against the hook file patterns. Disappears if the two audit skills merge (finding 14); the probes belong intest-vale-wrap.sh.→467bbd7620f20b) — hook, script and test all deleted; see the settled note below for the corrected probe arithmetic.check-scope-walkup-sync:365→ 381 lines (plus 297 test lines; re-measured 2026-09-16 at HEAD) cross-checking four independent ports of the same package-root walk-up. Disappears if the ports share one scriptor the skills merge— the second half is refuted below, and the first is unreachable.Grilled, held (2026-09-14): both of the above are gated on findings 14/15 (merging skill-audit+agent-audit and skill-author+agent-author), deliberately held for a separate session rather than decided here. Correction for that session: the audit's §8 grouping is wrong — these merges don't need ADR-0012 revisited (that ADR governs the unrelated
coreplugin's threeagentsmd-*skills). The actual constraint is ADR-0014 (no-cross-skill file sharing on plugin cache-install), and merging sidesteps it rather than requiring it be reversed. The open question for that session is a design one — a shared skill'sdescriptioncarrying both skill- and agent-audit trigger phrases — not an ADR supersession. ADR-0012 revisit is needed only for finding 24. Settled (2026-09-15) — split verdict, and the first bullet held in full. Finding 14 landed asfactory-audit(ADR-0025).check-vale-style-syncis deleted, hook, script and test, exactly as the first bullet predicted — and its probes were rehomed intotest-vale-wrap.sh, as cases 28-30 (case 31 carries the override allowlist), so both halves of that bullet are closed.docs/spec/gates.mdrecords the rehoming, not an open gap. (Updated later on 2026-09-15.) The one assertion this note used to call still uncovered — cross-manifest agreement between.pre-commit-hooks.yaml's and.pre-commit-config.yaml'sfiles:regexes —is now ported as case 33, which pairs the hooks by→ was ported as case 33, and case 33 was deleted withid:.pre-commit-hooks.yamlin4de5b6b(finding 36), so there is no second manifest left to agree with. Case 32 covers the separate zero-match question. It was a real gap while it lasted: narrowing the local skill hook to^plugins/kyberforge/left 6 of 38 skills prefiltered and the suite green.bash tests/test-vale-wrap.shnow reports→61 passed, 0 failed63 passed, 0 failed(it was 56 before cases 0 and 33 and the Part B mutation self-tests; 61 on 2026-09-15, and 63 once case 34 — the static.vale.inistyle-load check — landed on 2026-09-16. Without vale on PATH it reports 19 and exits 77, up from 17). The bullet's "about 350 of its lines run Vale glob probes" overstates the probe half: ata5962bathe script is 413 lines, of which the.vale.inicoverage section is 332 (67..398) and the machinery that actually invokes vale against a probe path is 204 (195..398). The balance of that section isStylesPath,BasedOnStylesand per-rule-override greps — text assertions, not probes. (Its test file is 797 lines, as the note above says, not the 798 the bullet carries.)check-scope-walkup-syncstays, and the second bullet's "or the skills merge" is wrong: two of its four walk-up ports are in the author skills (new-agent.sh,new-skill.sh), which this merge does not touch, and the audit-side pair is Python against the author-side pair's Bash, so the gate can never degrade into a text diff. Full reasoning in §10's 2026-09-15 note. Finding 15 would not remove it either.check-marketplace-mirror-sync: guards.github/plugin/marketplace.json. The script header calls it Copilot's legacy convention path and says Copilot also accepts the Claude path; the vendored Copilot docs list it as primary. Verify against current Copilot CLI before deleting hook, script, test, and mirror file.Grilled and done (2026-09-14): verified against GitHub's current Copilot CLI plugin docs (not the vendored copy, which risked drift). Copilot CLI's marketplace discovery checks paths in order —
marketplace.json,.plugin/marketplace.json,.github/plugin/marketplace.json,.claude-plugin/marketplace.json— falling through to whichever exists first..claude-plugin/marketplace.json(apm's ownclaudeoutput) already satisfies that chain's last step, so the dedicated.github/plugin/marketplace.jsonmirror bought Copilot users its preferred discovery path rather than a required one. Decided against reopening ADR-0018 (native install for both Claude Code and Copilot CLI stays supported) to justify this — the deletion holds either way, since Copilot's own fallback covers it. Deleted.github/plugin/marketplace.json,scripts/sync-marketplace-mirror.sh(81 lines),tests/test-sync-marketplace-mirror.sh(304 lines), and thecheck-marketplace-mirror-syncpre-push hook; removed the dangling references to the deleted script inscripts/sync-plugin-content.shandtests/test-sync-plugin-content.sh(both had comments citing its reasoning by name), and updateddocs/spec/architecture.md's description of the marketplace-manifest compile step.tests/test-sync-plugin-content.sh(92 cases) still passes in full.Correction (2026-09-14, later the same day): the parenthetical "Decided against reopening ADR-0018 (native install for both Claude Code and Copilot CLI stays supported) to justify this" was true when written and is now the opposite of the repo's decision.
718c79alanded ADR-0024 hours later and dropped native install support outright, for both hosts. The note is left standing as the record of what was decided at0dffff3; read the parenthetical as historical. The deletion itself still holds, and holds more strongly — the file was removed on the grounds that Copilot's own fallback covers it, and ADR-0024 removed the content that fallback would have led to, so the mirror file would now be a discovery path to nothing. See the §8 Copilot bullet, corrected on the same point.check-executables-allow-sync: 474 lines to assert one string equals kyberforge's version. A six-line grep, or drop it (the failure mode is visible and recoverable).Corrected then partially done (2026-09-13): see commit
1b01e25ondocs/simplification-audit. Independent re-verification found "drop it" unsafe — ADR-0019's own Consequences section calls this failure mode silent and says a silent-staleness failure here is worse than the duplication the other gates catch, directly contradicting the finding's "visible and recoverable" claim. The hook stays. Shrunkscripts/check-executables-allow-sync.sh231 → 222 lines by deduplicating two comment blocks that re-derived ADR-0019's own reasoning inline, replacing them with a pointer at the ADR. The dual-reader design (PyYAML plus a hand-rolled fallback, so a missing PyYAML can't silently skip the check) was found to be load-bearing, not redundant, and left intact; test file unchanged (behavior unaffected). All 23 test cases and the live pre-push hook run still pass. Effort S each, M for the walk-up.
Closed (2026-09-16). Every bullet is settled:
check-vale-style-syncwent with finding 14,check-marketplace-mirror-syncwith 2c, andcheck-executables-allow-syncwas kept and shrunk (2d).check-scope-walkup-syncstays: finding 14 left its four ports at four (see §10), and finding 15 was refuted, so the author-side pair will not merge either. The "held" note above is resolved by those two outcomes. -
Tests of the test harness: 1,090 lines testing 475 lines.
test-run-tests.shandtest-run-bats.shdefend "green either way" holes that exist only because the runners hand-roll TAP parsing and set-equality checks. Replace both runners with about 40 lines (bats -r pluginsplus a parallelfind | xargsovertest-*.sh) and delete the meta-tests.lib/batch-run.shstays;both runners source it. Effort M.sync-plugin-content.shsources itNot proceeding (2026-09-13): premise doesn't hold. A full read of both runners and both meta-tests found the "TAP-parsing/set-equality" logic is regression coverage for specific past incidents — a
BATS_FILE_FLOORhardcode once let deleted test files vanish silently ("155 tests, 0 failures" with 11 tests missing); a missing/brokenrun-bats.shused to make the whole bats suite disappear with a green summary; a formatter change once reported "0 tests, 0 failures" as a pass. Replacing the runners as specified would delete exactly the guards against that failure class. No changes made. Re-scoping this would mean deciding, guard by guard, which are still worth keeping — a design decision, not a mechanical cleanup. Rationale corrected, decision unchanged (2026-09-14, ata6434e0): the stated reasonlib/batch-run.shsurvives was void —sync-plugin-content.shwas deleted in718c79a. The conclusion is unaffected:batch-run.sh(90 lines) is sourced bytests/run-tests.sh:185andtests/run-bats.sh:138, and copied into fixture trees bytests/test-run-tests.sh:51andtests/test-run-bats.sh:49. Since the finding is not proceeding, both runners stay and keep sourcing it, so nothing is orphaned. Note the knock-on if this is ever re-scoped: with the sync script gone, "replace both runners" would leavebatch-run.shwith no caller at all, which the original wording assumed it could not. Headline figures re-measured: the meta-tests are 1,090 lines (675 + 415, as stated) against 490 runner lines, not 475 — the runners grew from 273 + 202 at the9eb8bc7baseline. (Both runners andbatch-run.shwere under concurrent edit when this was measured; figures are as ofa6434e0.) -
skill-frontmatteris a 62-line bash script inlined in YAML with its own 366-line test.skill-size-check.shalready parses the same frontmatter with PyYAML. Fold it in (about 15 Python lines), delete the inline hook, its test, and the 79 lines ingates.mdarguing for the split. Effort S.Done (2026-09-12): see commit
c8a7c9eondocs/simplification-audit. Added a ~20-line required-frontmatter check (name,description,metadata.versionas three-part semver) toscripts/skill-size-check.sh, reusing the YAML mappingdescription_value()already parses. Removed the inlineskill-frontmatterhook (~80 lines) from.pre-commit-config.yamland deletedtests/test-skill-frontmatter.sh(366 lines). Removed the 79-line "the other hook on that scope" discussion fromdocs/spec/gates.mdand its now-dangling cross-reference, replacing both with a one-line note of the fold; updated the pre-push hook counts there. Updated fixture builders intests/test-skill-size-check.sh,tests/test-adr0020-body-checks.sh,tests/test-adr0020-targets.sh,tests/test-adr0020-differential.sh, andtests/test-vale-hooks-consumer.shto carry validmetadata.versionso the new check doesn't spuriously fail existing fixtures. -
skill-size-check.shhas six test files totalling 3,589 lines for one 1,497-line script, split by ADR section rather than behaviour.test-adr0020-differential.shis 452 lines for 12 assertions. Merge to two files. Effort M.Not proceeding (2026-09-14): premise doesn't hold, in the same way finding 3's did not. The six suites are not split by ADR section — they are split by failure class, and five of the six headers name the incident they guard. (The exception is
tests/test-skill-size-check.sh, whose header names no incident: it describes the two gate families the script must not conflate and flags the constant-agreement block as the load-bearing part.)test-adr0020-contract.shdefends structural claims that "each one fails silently": that the resolver block copied verbatim into three scripts has not drifted, that both interpreter preflights still exist, thatverbose: trueis still set on the hook (the entire delivery mechanism for the SUGGESTION tier). It records that thevalidate-provenance.shpair "had already drifted" once.test-adr0020-differential.shcompares verdicts betweenskill-size-check.shandvalidate.shon real files, and its header states that constant-agreement is "necessary but demonstrably not sufficient — a previous review found the two scripts disagreeing on real files while every constant matched perfectly", with two ceilings excluded "until a real divergence shipped behind the exclusion". The suites also do not cover the same scripts:contractreachesvalidate-provenance.sh(tests/test-adr0020-contract.sh:115-116byte-compares both copies of it). Merging by subject would delete exactly the guards against silent drift between hand-duplicated validators. Re-measured at HEAD: 3,619 lines across six suites against a 1,517-line script, not 3,589/1,497. That ratio is the cost of the duplication, not an independent defect — it is deleted by finding 16, which removes the thing being differentially compared. #5 is downstream of #16 and should be reconsidered only after it. The one salvageable part is a performance change, not a coverage change:test-adr0020-differential.shspends 29 s of every push re-running two validators over the live corpus, and could be sped up with no coverage loss. That is a different finding than the one written here.Salvage closed (2026-09-16, grill): not proceeding. Timed one suite at a time on this 4-core machine,
test-adr0020-differential.shtakes 34.3 s of 213 s total suite time, behind bats (70.7 s) and ahead oftest-vale-wrap.sh(29.4 s). Its cost is about 90 validator runs, one after another, at 0.1–0.15 s each. Even deleting it outright would take at most 34 s off a pre-push measured at 3.5–5 min, and insiderun-testsa parallel rewrite would compete for the same four cores, so a standalone speed-up is too small to be worth another change to a regression suite. Pre-pushrun-testswall time is a separate question; the human decided (2026-09-16) not to track it. -
Prose-grep tests.test-governance-layer.shandtest-instructions-and-docs.sh(583 lines) grep markdown for phrases, including a one-shot "issue 0015 refactor incomplete" assertion made permanent and an assertion thatdocs/notes/exists. Delete both.check-apm-agents-valid.sh(161 + 264 test lines→ 167 + 282, re-measured 2026-09-16 at HEAD) is a loop plus fail-closed guards aroundvalidate.sh; it folds into the merged audit skill's own tests (finding 14). Effort S.Done (2026-09-12): see commit
5f9f2b3ondocs/simplification-audit. Deletedtests/test-governance-layer.sh(270 lines) andtests/test-instructions-and-docs.sh(313 lines); no other file referenced either.check-apm-agents-valid.shwas left untouched — its fate is tied to the separate, out-of-scope skill-merge finding 14. Closed (2026-09-16):check-apm-agents-validstays as a repo-level hook; the fold is not proceeding. Finding 14 landed and left it in place, updated to callfactory-audit'svalidate.sh. It cannot fold into the skill's own tests: it validates this repo'splugins/*/.apm/agents/*.agent.mdfiles, which exist only here, while a skill'stests/ship to every consumer (§9) and must run on fixtures. Its reason to exist — the validator had never run against the artifacts it governs — is unchanged. 167 script + 282 test lines, re-measured at HEAD. -
check-plugin-content-sync.shis 813 lines wrappingapm pack, with a 1,291-line test. The mirror itself must stay (Claude Code marketplace installs need flat directories), and the script does real work a baregit diffwould lose: it stripstests/from the mirror, regenerates bothplugin.jsonfiles withmcpServersreinjected, and packs into a scratch copy so--checknever mutates. Even so, 2,100 lines for that is disproportionate; target a third. Effort M.Superseded then done (2026-09-14): see commit
718c79aondocs/simplification-audit. The recommendation ("target a third") is void, not met — the §8 question it depended on was settled the other way. Answering "apm-only" (ADR-0024) removed the mirror's reason to exist, and with the mirror gone the script guarded nothing, so the whole thing was deleted rather than shrunk:scripts/sync-plugin-content.sh(813 lines),tests/test-sync-plugin-content.sh(1,289 lines — the finding said 1,291), thecheck-plugin-content-syncpre-push hook, andscripts/lib/marketplace-plugins.sh(86 lines, whose only consumer was the sync script, and which finding 1 had explicitly kept alive for it).validate-pluginswent with them, and the twelve per-pluginplugin.jsonmanifests the script regenerated. The finding's own premise — "the mirror itself must stay" — is what turned out to be wrong. -
docs/spec/gates.md(1,048 lines) is roughly 15% "what is enforced" and 85% post-mortems of defects already fixed and pinned by tests. The 60-line hook table is the useful part. Target 200 lines. The same applies to the 106 comment lines in.pre-commit-config.yamland toscripts/, where 8 of 15 files are 40 to 60% comments. Effort M.Partially done (2026-09-13): see commit
a35f5e8ondocs/simplification-audit. The 85%-post-mortem characterization was stale — the file had already shrunk to 966 lines by other findings, and most of what remained is load-bearing "why this design" rationale cited by ADRs and tests, not dead incident narration. Cut only the two genuinely stale passages: a reproduction paragraph carrying explicitly outdated numbers, and a retrofit-process narrative superseded by current state — a 36-line cut, 966 → 930 as measured at commita35f5e8. Those two figures describe that commit only, not the file:718c79aand later findings have editedgates.mdagain, so read its current length from the file rather than quoting a number here..pre-commit-config.yaml's comments were left untouched; on inspection they're compact constraint notes, not filler. Target of 200 lines not reached and not recommended — would require deleting content the file itself flags as load-bearing.Closed (2026-09-16, grill): done to the extent recommended. The
gates.mdcut ina35f5e8stands; the 200-line target stays rejected (the file is1,113 lines at HEAD→1,164 lines at HEAD (→ 1,137 lines atb426460)baa2f5d,wc -l docs/spec/gates.md, grown by later findings' sections, and read on demand only). The tests target below is struck:findings 3, 5 and 16 each found dense suites to be named-incident regression coverage→ findings 3 and 5 each found dense test suites to be named-incident regression coverage, and finding 16 found the same of dense validator code, whose comments are an incident log. Any future cut to a test suite is its own finding and starts by reading that suite's header.
Proposed target. Pre-push 14 hooks to 6: run-tests, validate-plugins, validate-marketplace, apm-pack-check-clean, check-plugin-content-sync, check-release-needed.
Corrected (2026-09-14): two of the six named targets no longer exist —
validate-pluginsandcheck-plugin-content-syncwere deleted in commit718c79a(finding 7, ADR-0024). Actual state today: 9 repo-authored pre-push hooks —run-tests,check-executables-allow-sync,apm-audit-ci,check-apm-agents-valid,apm-pack-check-clean,check-vale-style-sync,check-scope-walkup-sync,check-release-needed,validate-marketplace— plus the 2 pre-commitmetahooks that also run at this stage, so 11 are reported at pre-push.validate-marketplacewas kept: the rootmarketplace:block inapm.ymland the root.claude-plugin/marketplace.jsonstay, because apm's own marketplace consumers read that same catalogue and<name>@holocronshort names depend on it. (That manifest is the only tracked file under.claude-plugin/—git ls-files .claude-pluginreturns it alone. The sibling.claude-plugin/plugin.jsonis a localapm packbyproduct, has never been tracked on any branch, and is ignored at.gitignore:59; it was not "kept", because it was never there.)
Superseded count (2026-09-15): finding 14 deleted
check-vale-style-syncwith the merge intofactory-audit(ADR-0025), so pre-pushis now→ was 8 repo-authored hooks (10 reported). The dated note above is the state on 2026-09-14; see finding 14's note for the correction.Superseded count (2026-09-16, at HEAD
b426460):8451169addedcheck-skill-version-bump(finding 33), so pre-push is 9 repo-authored hooks (11 reported) — the eight above plus that one. Measured withgrep -c "stages: \[pre-push\]" .pre-commit-config.yaml.Superseded count (2026-09-16, at
4de5b6b):4de5b6bremovedcheck-release-needed(finding 36), so pre-push is 8 repo-authored hooks (10 reported) — the nine above minus that one. Measured the same way.
Pre-commit stays roughly as is minus skill-frontmatter, and minus check-ast once finding 9 removes the only .py files. Tests 26 files to about 10 (12,400 to about 5,000 lines). Keep bats and its three submodules; the 351 bats tests ship inside plugins and are the right tool there. Do not port the bash suites to bats; delete them instead. Struck (2026-09-16, grill): see finding 8's closing note — the suites are regression coverage (findings 3 and 5; finding 16 found the same of the validators they test).
Re-measured (2026-09-14, at
a6434e0): the tests target was stated against the 2026-09-10 baseline and both its numbers are stale.tests/now holds 20test-*.shsuites totalling 9,123 lines (plus the two runners, 490). Six suites have gone since the baseline:test-check-manifests.sh(e647f14),test-skill-frontmatter.sh(c8a7c9e),test-governance-layer.shandtest-instructions-and-docs.sh(5f9f2b3),test-sync-marketplace-mirror.sh(0dffff3),test-sync-plugin-content.sh(718c79a).Restated on the same basis the target is 20 files to about 10, 9,123 to about 5,000 lines— struck (2026-09-16): the target itself is withdrawn (see the struck sentence above); for the record,tests/holds 19 suites totalling 10,000 lines at4b17703, after4de5b6bdeletedtest-check-release-needed.shandtest-vale-hooks-consumer.sh. Finding 9'scheck-astclause is moot anyway, since finding 9 is not proceeding.
4. Plugins
The shared pattern: per-skill README.md files no model reads, a docs/research/ dump per plugin, a sources.md provenance chain with its own validator, and reference files that restate man pages.
4.1 Cross-plugin (apply everywhere)
-
Delete
docs/research/from every plugin (~19,000 lines). kyberforge's alone is 14,143 lines, 32% of the plugin, and about 8,900 of those are vendored third-party content (Anthropicskill-creatorincluding a 1,325-lineviewer.htmland ten.pyfiles, obra/superpowers, mattpocock). The rest is copied tool documentation. The gitea references explicitly say the research doc "has a known history of drifting from the deployed server". Everyapm.ymlusesincludes: auto; whether the directory ships to consumers needs one check. Keep upstream URLs in one line per plugin README; git history keeps the rest. Check obra/superpowers licence if anything is retained. Goes together with finding 11: 32sources.mdfiles carry "Research doc" paths into these directories. Effort S.Decision (2026-09-12): Keep.
docs/research/is retained on purpose — it's read by agents doing work sourced from those docs. Not proceeding. -
Delete per-skillREADME.mdandreferences/README.md(48 files, 1,574 lines). They restate the SKILL.md in narrative form. The pre-commit config itself notes a skill README "is consumer-facing prose that no agent ever loads". Keep one plugin-level README with one line per skill. Requires dropping the README criterion inskill-audit/references/file-structure.mdand the README step innew-skill.sh. Effort S.
Done (2026-09-12): see commit
edcc57condocs/simplification-audit. Deleted the 48 per-skill/reference READMEs plus 2 scaffold templates; dropped the README criterion fromskill-audit'sfile-structure.mdandfinding-criteria.mdand the README-generation step fromnew-skill.sh; updatednew-skill.batsto match. Plugin-root READMEs were kept, not part of this finding.
-
Drop the provenance chain:
sources.md,source_keysfrontmatter,validate-provenance.sh. 32 plugin and skillsources.mdfiles (about 1,300 lines) plus 9 research indexes, 216 source files withsource_keys,two copies of the validator (1,198 and 632 lines)→ one validator, 2,171 lines across four files, with ten checks, and125 bats tests→ 138 bats tests exist to track which upstream informed which file. Git blame and a URL in the README do the same job. This is more code than the content it tracks. Effort M (touchesskill-audit, both validator copies→factory-audit, its one provenance validator, two repo tests, and every skill's frontmatter).Re-measured (2026-09-16, at HEAD): ADR-0025 merged the two copies, so the "two copies" arithmetic throughout this finding and its note below no longer resolves. The provenance validator is now
factory-audit/scripts/validate-provenance.sh(320) +lib-provenance-skill.sh(1,145) +lib-provenance-agent.sh(572) +lib-contributing-files.sh(134) = 2,171 lines (wc -lon the four), against 3,209 bats lines (validate-provenance-skill.bats2,062 +validate-provenance-agent.bats1,147) carrying 138 cases (grep -c '^@test'). Note this is more than the 1,198 + 632 = 1,830 the finding counted, not less: the merge deduplicated the resolver and the Contributing-files parser, not the per-mode provenance checks, and the shared entry script added the exit-tier and library guards described indocs/spec/gates.md. Thesources.mdcensus also moved: 45 files / 1,756 lines — 27 skillreferences/sources.md(1,207), 13 research indexes (435), 4 plugin-root (100), 1 scaffold template (14). The note below's 46 / 1,752 swept indocs/adr/0013-vale-harness-scope-and-rule-sources.md, which matchessources\.md$and is not one. Imbalance at HEAD: 5,380 validator+bats lines against 1,756 of metadata, 3.1:1 — worse than the 2.6:1 below, on the same direction of argument. Verified (2026-09-14, at HEAD062ca47): direction defensible, two scope figures wrong, and blocked on a decision the finding never poses. Thesources.mdcensus below is exact, and so are the finding's own validator and bats figures (1,198 / 632 lines, 125 bats tests); the scope errors are narrower than an earlier revision of this note claimed.Corrected figures: 46
sources.mdfiles / 1,752 lines in three distinct classes — 29 skillreferences/sources.md(1,217 lines), 13 research indexes (435), 4 plugin-root files (100, ADR-0010). The finding does not double-count: it states two disjoint classes additively ("32 plugin and skillsources.mdfiles (about 1,300 lines) plus 9 research indexes"), and that plugin-and-skill subtotal is really 33 files / 1,317 lines, matching its "about 1,300" exactly — had the 32 swept in the research indexes the figure would have been ~1,750. Its real errors there are an off-by-one (32 should be 33) and an omission: it missed the 4 vendored example indexes underkyberforge/docs/research/examples/skill-write/, so 9 should be 13. Carriers ofsource_keysin YAML frontmatter: 196 — 168 at column 0 and 28 nested two spaces undermetadata:— so the finding's 216 is closer to the truth than it looks. (219 files merely mention the string. A naive^[[:space:]]*source_keys:grep returns 200, but 4 of those are heredoc or fixture text rather than frontmatter: bothvalidate-provenance.batscopies,scripts/check-scope-walkup-sync.sh, and a fenced example inplugins/bin/.apm/skills/research/references/file-format.md.) Checks: 16 across the two copies (skill-audit 0–9, agent-audit 0–5), not ten. Validator line counts (1,198 / 632) and 125 bats tests are exact."Touches every skill's frontmatter" is roughly right.
28 of the 39 real skills carry→ 27 of the 38 (re-measured 2026-09-16 at HEAD; the audit-pair merge took one carrier skill with it), nested undersource_keysin frontmattermetadata:— seeplugins/git/.apm/skills/git-commits/SKILL.md:10-17, wheremetadata:→source_keys:carries four slugs. (44→ 43 tracked files match*SKILL.md; subtractskill-author/assets/templates/SKILL.mdand the 4 vendored underkyberforge/docs/research/examples/skill-write/, leaving39→ 38 real skills.) The 11 without it are exactly theplugins/bin/skills. Check 2 in the skill-side validator (SKILL.mdsource_keys→ slug insources.md) is correspondingly live, not dead code:parse_source_keys()atplugins/kyberforge/.apm/skills/factory-audit/scripts/lib-provenance-skill.sh:277-305handles both spellings explicitly — the metadata-nested branch at:292, the top-level branch at:295, and a docstring that says "handles metadata.source_keys and top-level" — check 2 at:712runs against all28→ 27 carrier skills, every one of which has areferences/sources.md, and bats pins it atplugins/kyberforge/.apm/skills/factory-audit/tests/validate-provenance-skill.bats:222("FAIL: source_keys slug in SKILL.md not present as H2 in sources.md") and→:1337:1338(a BOM must not silently disable check 2). (Paths and line numbers re-derived at HEAD: ADR-0025's merge moved this code out ofskill-audit/scripts/validate-provenance.shinto the shared skill-side library, so the figures this note carried at062ca47—:242-270,:257,:260,:766,:1313— no longer resolve.) The imbalance the finding names is real and worse than claimed:4,641 validator+bats lines against 1,752 of metadata, a 2.6:1 ratio→ 5,380 against 1,756, a 3.1:1 ratio (re-measured 2026-09-16 at HEAD; see the note under the headline).Omitted entirely: the chain has a producer.
plugins/bin/.apm/skills/research/specifies thesources.md+source_keys:output format, andplugins/bin/evals/research/research/eval.yamlcarries three criteria asserting it. This is the blocking decision: doesresearchkeep emittingsources.md? If yes, the chain is not dropped — only unenforced, and the finding collapses to "delete the validators." If no, the research skill's output contract and its evals need redesigning.Also breaks:
check-scope-walkup-syncloses one of four walk-up ports (the hook exists because three scripts drifted);tests/test-adr0020-contract.shloses its parser byte-identity assertion;tests/test-check-scope-walkup-sync.shmust re-base its fixture; ADR-0010 is superseded outright and ADR-0009/0016 need amending (field-inventory.md's allowlist data line carriessource_keys).LESSONS.md:73records this validator as the only thing that catches a skill authored outsideskill-author— a failure that "recurred twice in one session" — so "git blame + a README URL do the same job" is false for the one thing the chain demonstrably catches. Side effect: 55 reference files have frontmatter containing onlysource_keys:, leaving empty---\n---blocks to delete.Effort L, not M (about
6,393→ 7,136 lines deleted across 242 files: the4,641→ 5,380 validator and bats lines plus the1,752→ 1,756 ofsources.mdmeasured above, across 196source_keyscarriers and46→ 45sources.mdfiles. An earlier revision of this note said ~4,600 lines across ~230 files, which was internally inconsistent — 4,600 is validator-plus-bats only and silently drops thesources.mdthis same note measures, and ~230 inherited a carrier count of 172 that missed everymetadata:-nested file.) Smaller alternative worth considering: scope the drop to the skill half only (1,217 lines, 1,198-line validator, 82 tests→ 1,207 lines of skillsources.md, the 1,145-linelib-provenance-skill.sh, 87 tests, re-measured 2026-09-16 at HEAD) and leave the ADR-0010 plugin-root half alone — no ADR supersession needed.Decision (2026-09-16): Not proceeding — the human declined this finding. The provenance chain (
sources.md,source_keys:,validate-provenance.sh) stays, andresearchkeeps producing it. This also answers §8's provenance question. -
Strip ADR and changelog narration from model-facing files.ADR-0020is cited in 3 of 7 kyberforge SKILL.md files and 16 references; ADR-0023 is cited inline 21 times in the git plugin. Examples: "was the old house rule and ADR-0020 deleted it", "were removed per ADR-0015 once issue #90 landed", "this file previously recordedlist_issuesas having neither atypenor amilestonesparameter".skill-author/references/retrofit.md(197 lines) is a one-time migration guide; it is loaded fromimprove.mdand listed insources.md, so remove those in the same change. These belong in git history or the ADR, not in context. Effort S.
Done (2026-09-12): see commit
edcc57condocs/simplification-audit. Historical narration stripped from kyberforge (ADR-0020) and git (ADR-0023) skill content;retrofit.mddeleted along with its load-step andsources.mdentries. Caught in review: someADR-0023tags were not narration but thecheck-rtk-prefixhook's required opt-out marker for intentionally-bare git commands — those 12 were restored, not left stripped.
State repeated boilerplate once or delete it. A near-identical "Resolve owner and repo" block in 5 of 7 gitea skills; 404-masks-403 in 6 files; manual pagination in 7; main/master refusal in 9 git files; the "use the project's domain glossary, respect ADRs" paragraph in 5 bin skills. Three git skills define three different structured-result JSON shapes whose only consumer isgit-orchestrate(finding 19). Effort S.Done (2026-09-12): see commit
6cfc357. Trimmed each repeated instance in place — same meaning, fewer words — rather than extracting to a shared file (blocked by the one-file-per-skill install constraint, ADR-0014): the "Resolve owner and repo" block across 5gitea-*skills, the 404-masks-403 note across 6 gitea files, the manual-pagination explanation across 8 gitea files, the main/master force-push refusal across 7 git plugin files (some with multiple internal restatements), and the domain-glossary/ADR paragraph across 5binskills. This was a trim-in-place pass, not a merge: the cross-skill duplication itself remains and is coupled to the (out-of-scope) skill-merge findings 19/20. Left the three git skills' structured-result JSON shapes untouched, as directed. Verified no regressions withscripts/skill-size-check.sh(pre/post diff) andclaude plugin validateon both plugins.
4.2 kyberforge (290 files, 44,568 lines incl. mirror; the 7 SKILL.md bodies are 333 lines, under 1%)
-
Mergeskill-audit+agent-auditinto oneauditskill (removes about 3,300 lines and two pre-push hooks).vale-wrap.shis byte-identical in both; five Vale rules byte-identical (agent-audit carries one extra, so it is the superset);validate.shshares a 1,061-line boundary-target resolver block that diffs as zero lines; SKILL.md steps 1, 3, 4 and the gotchas are the same text. Each copy is hard-wired to one mode, so the merged script needs a path switch. The duplication exists because a plugin-cache install copies only each skill's own files (the rule ADR-0014 follows), so a script cannot be shared across skills; merging the skills is the only way to remove the copy. Effort M.Done (2026-09-15), with three of its claims corrected. Merged into
factory-audit, notaudit— the name states the domain (the artifact factory's own output) rather than the verb. Seedocs/adr/0025-skill-audit-and-agent-audit-merge-into-factory-audit.md. The repo goes from 39 skills to 38. Entry scripts arescripts/validate.sh,scripts/validate-provenance.shandscripts/vale-wrap.sh. Only the first two auto-detect the artifact type they were handed and dispatch to a per-type library.vale-wrap.shdoes not and never did: it is byte-identical to both pre-merge copies (diffclean against each ata5962ba) and names neitherSKILL.mdnor.agent.mdanywhere in its 526 lines. Its scoping comes from outside it — the.vale.iniglob sections and thefiles:regexes of the two hooks that call it.- Yield: 2,934 lines and ONE pre-push hook, not ~3,300 and two. The hook is
check-vale-style-sync, deleted with its script (413 lines) andtests/test-check-vale-style-sync.sh(797). They did not exist only to diff the two now-merged Vale copies — an earlier revision of this bullet said so and it was wrong, as this document's own ":104" measurement already implied. The script has 17 assertion sites (13errcalls and 4 hard-fail exits; ADR-0025 maps each one). Only 6 are genuinely moot: two diffed the copies and four guarded the script's ability to locate them. 10 were rehomed intotests/test-vale-wrap.sh: case 0 (config loads), cases 28–30 (glob probes, style loading, Copilot scoping), case 31 (override allowlist) and the suite-level exit 77. 1, the cross-manifestfiles:drift check,is ported as case 33, pairing hooks by→ was ported as case 33 and later deleted with its second manifest inid:since both now share oneentry:4de5b6b(finding 36). (Corrected later on 2026-09-15.) An earlier revision of this bullet said 18 / 6 / 11 / 1. It called the cross-manifest check knowingly dropped and "seven of them stronger". None of that survives a recount. Two text greps became behavioural Vale probes, not seven, and case 32 alone never covered the narrowing that case 33 now catches.check-scope-walkup-syncsurvives; see the §10 correction below for why. Pre-push goes 9 repo-authored hooks to 8 (11 reported to 10). The rest of the saving is the second embedded resolver (1,061), the secondvale-wrap.sh(526), the secondassets/vale/styles/Kyberforge/copy (44), and the Contributing-files parser embedded in bothvalidate-provenance.shcopies (93). 413 + 797 + 1,061 + 526 + 44 + 93 = 2,934, which is the headline. An earlier revision of this bullet listed 413 + 797 + 526 + 48 + 1,061 = 2,845: it dropped the 93-line parser outright, and its 48 for the Vale copy is the five byte-identical style rules (13 + 7 + 7 + 7 + 10 = 44) plus skill-audit's 4-line.vale.ini. ADR-0025 counts 44 on purpose — the two.vale.inifiles were deliberately not identical (agent-audit's carried the extra[**/*.agent.md]section and theKyberforgeCopilotstyle), so that file is a deleted file rather than a removed duplicate, and folding it in would make the headline 2,938. All six figures measured ata5962ba. - "Each copy is hard-wired to one mode" was false, and it is the claim that made this look like a bigger win than it is. The two
validate.shfiles are not one script parameterised per mode: outside the shared 1,061-line resolver they hold 1,293 lines between them (616 skill-side, 677 agent-side) and share 91 of those. That 91 is ADR-0025's figure and it is exactly reproducible: strip the marked resolver block from each copy ata5962ba(115..1175skill-side,189..1249agent-side, 1,061 lines each), then take the size of the intersection of the two distinct raw line sets — 510 distinct lines skill-side, 530 agent-side, 91 in common. An earlier revision of this bullet said "about 115", which matches no counting rule that has been reproduced: dropping blank lines gives 90 and dropping comments as well gives 64. The merged validator dispatches on artifact type over two largely independent bodies of checks; it does not collapse them. - The §8 blocker was a non-issue. The design question held open there — whether one
descriptioncould carry both skills' trigger sets without breaching the ADR-0020 ceiling — was answered against the 400-character FAIL, which the merged description clears. Read the number from the shipped file, not from a draft. (Corrected later on 2026-09-15.) The shipped description is 241 characters, inside the 250-character SUGGESTION target, andbash scripts/skill-size-check.sh plugins/kyberforge/.apm/skills/factory-audit/SKILL.mdprints nothing for it. A first cut shipped at 319 and accepted the SUGGESTION as the cost of carrying both artifact types' trigger phrases. That reasoning was wrong. The quoted phrases (audit this skill,review my SKILL.md,audit this agent,review my agent file) restated the "skill directory or agent definition audited" trigger in a second register, which ADR-0020 makes a FAIL. Removing them, and keeping both boundary arrows, gives 241. An earlier "241" in this document and ADR-0025's "240" came from a hypothetical single-arrow draft that was never reproduced. That today's figure is also 241 is a coincidence, not a confirmation of it. The real ceiling was the other one: a single body covering both artifact types ran past the 900-word body FAIL. Solved the way ADR-0020 prescribes — a dispatch body that routes to per-type references, with the 16 per-type reference files namespacedskill-*andagent-*(plus the sharedsources.md).
Finding 18 was deliberately kept out of scope. Its re-scoped remainder is prose trimming inside these same files and would have made the merge diff unreviewable; it stays open against
factory-audit's files.Since closed (2026-09-16, grill): finding 18 is no longer open — it closed as not proceeding; see its own closing note.
- Yield: 2,934 lines and ONE pre-push hook, not ~3,300 and two. The hook is
-
Mergeskill-author+agent-authorlikewise.contract.mdshares most of its Description section;new-skill.shandnew-agent.shimplement the same package-root walk-up with different mode names; step 1 dispatch tables and step 3 gates are near-identical. Keep the agent scope logic (plugin vs project/user) as its own reference. Effort M.Refuted (2026-09-16, at HEAD
14248e0). The overlap is about 150–180 lines, not "most" of anything, and ADR-0020's exclusion of the pair holds on measurement. Measured as distinct non-blank lines common to both skills, raw and then withskill/agentnormalised to one token:SKILL.md13–14 of 45 / 46;references/contract.md36–37 of 205 / 126;references/improve.md14–15 of 65 / 64;references/create.md9–10 of 138 / 68; every other reference ≤12. The scripts share 48 lines (new-skill.sh189,new-agent.sh303, counts include blanks), mostly the package-root walk-up and itsapm.ymltype:matcher; the two bats suites share 15 (209 / 349). Reproduce withcomm -12 <(grep -v '^\s*$' A | sort -u) <(grep -v '^\s*$' B | sort -u) | wc -l, run fromplugins/kyberforge/.apm/skills/against eachskill-author/Xandagent-author/Xpair.- "
contract.mdshares most of its Description section" overstates it. The shared span is the three-part shape, the banned-content list, the length gate and the boundary-target resolution rules — 36 lines against files of 205 and 126. - "Step 1 dispatch tables and step 3 gates are near-identical" is true only of those two steps. Step 2 differs completely (invocation axis vs. scope resolution), Step 3's body gate is a word budget in one and a delegation check in the other, and Step 4 bumps
metadata.versionin one and the packageapm.ymlversionin the other. - This is the opposite shape to finding 14. There the copies were byte-identical — a 1,061-line resolver, a 526-line
vale-wrap.sh, identical style rules — and merging removed 2,934 lines. Here the skills emit different artifacts (a skill directory vs. a one-file or two-file agent, ADR-0005 / ADR-0016), so a merge would put two unrelated scaffolds, two scripts and two test suites behind one dispatch step to save about 150 lines and one router entry. - It would not retire
check-scope-walkup-sync. Merging takes the gate's four walk-up ports to three; the gate stays (see §10).
Not proceeding. ADR-0020's rejected alternative and ADR-0025 point 7 now carry this measurement. The remaining overlap is unguarded; ADR-0020 names a text-sync gate as the only option for this pair, and 36 lines of shared Description prose do not justify one.
- "
-
Cut the validators by an order of magnitude.
validate.shis 1,677 lines of bash with embedded Python, ported twice;skill-size-check.shis 1,497. Target about 200 lines total: frontmatter present, size ceilings, boundary targets resolve. The 526-linevale-wrap.shexists to work around folded>scalars in descriptions; writing descriptions as|literal blocks removes the folding problem, but the wrapper is also the exported hook entry in.pre-commit-hooks.yamland carries the NOT RUN guard the audits depend on, so it shrinks rather than disappears. This is where the real complexity lives and is the item most worth discussing. Effort L.Refuted (2026-09-14, at HEAD
062ca47). Finding 16 has no independent content — its only safe saving belongs to finding 14.Re-measured (2026-09-16, at HEAD) — the basis of every figure below changed when ADR-0025 landed; the refutation is unaffected. There are no longer three validators or two
vale-wrap.shcopies. The headline's "ported twice" is void, and its1,677and526no longer name anything. At HEAD:scripts/skill-size-check.shis 1,522 (the note below's 1,517 was correct ata6434e0);factory-audit's validator is 2,663 lines across four files (validate.sh255 +lib-checks-skill.sh621 +lib-checks-agent.sh683 +lib-boundary-resolver.sh1,104);vale-wrap.shis 535, one copy. Validator total 4,185, of which the resolver is 2,165 (the 1,061-line block still embedded inskill-size-check.sh, pluslib-boundary-resolver.sh's 1,104 — the same 1,061 block wrapped in 43 lines of library preamble, which is why the byte-identity test compares the block and not the files). So the resolver is now 52% of validator lines, not 65%, and 2,020 lines remain once it is excised, not 1,749. Tests: the six repo suites overskill-size-check.share 3,907 (was 3,619) and the two in-skill validator bats files 2,248 (validate-skill.bats1,029 +validate-agent.bats1,219), for 6,155, not 5,506. The 200-line target is off by the same order of magnitude it was. (All figureswc -l; the resolver block byawk '/BEGIN ADR-0020 SHARED BOUNDARY RESOLVER/,/END .../'.)The three validators are not three implementations. They contain one block, 1,061 lines, byte-identical in all three, delimited by
# ===== BEGIN/END ADR-0020 SHARED BOUNDARY RESOLVER =====and hashed bytests/test-adr0020-contract.sh. So 3,183 of 4,932 validator lines (65%) are that block × 3, and what is left once the resolver is excised is 1,749 lines across all three — 1,580 non-blank, 992 with comments and blanks both stripped. The duplication is forced by the self-containment constraint, which is why merging is the lever and shrinking is not.Corrected figures:
skill-size-check.shis 1,517. The finding's 1,497 was correct when written —git show 9eb8bc7:scripts/skill-size-check.shis 1,497 lines, and9eb8bc7(2026-09-10) is this audit's own first commit. It went stale two days after, atc8a7c9e(2026-09-12), the commit that foldedskill-frontmatterin — which is why the finding's "frontmatter present" target is now work already done, not why its number was wrong. agent-audit'svalidate.shis 1,738, a superset, not a 1,677-line port.vale-wrap.sh526 × 2 is exact.The 200-line target is off by an order of magnitude. The resolver's executable core alone, every comment and blank stripped, is 549 lines (of its 1,061: 411 comment, 101 blank) — 2.7× the whole proposed budget, before any of the three scripts' own diagnostics. Counting call sites to
error/fail,suggestandinfo, those number 23 inskill-size-check.sh, 31 in skill-audit'svalidate.shand 38 in agent-audit's. ADR-0020 mandates 10 deterministic gates — its Enforcement table has 15 content rows: 10deterministic, 1prose pattern, 4auditor judgment— and explicitly warns against "a rule filed under 'Enforcement' that no validator implements". 5,506 lines of tests guard these scripts: the six repo suites overskill-size-check.sh(3,619) plus the two in-skillvalidate.bats(965 + 922). Realistic floor with prose intact and duplication removed: ~2,600–2,900; comment-stripped and fully merged, ~1,100–1,200.The comment volume is an incident log, not filler — 26 verbatim failing input strings and four filed issues (#99, #107, #108, #110). Samples: deriving the skill universe from
$BASH_SOURCE"leaked holocron's 39-skill universe into every consumer repo"; a worktree namedfeature[2]turned a glob into a character class and "silently disabled the gate tree-wide";description:followed bymodel: sonnet"exited 0 with zero output on a BLOCKING pre-push gate"; a 550-char description with a 1,000-word body "exited 0 behind a BOM". Exactly one clause argues for speculative retention and flags itself as unexercised. Same pattern as findings 3, 5 and 24.The
vale-wraphalf is wrong on its conclusion.|literal blocks do fix the folding case — the script says so and deliberately no-ops on them — but the wrapper handles four affected scalar forms (folded>, bare plain, double- and single-quoted continuation lines), and 277 of its 526 lines are argv handling unrelated to folding (cwd-relative absolutization, theis_builtin_outputguard, scratch-tree mirroring, path relativization), each with its own incident record. Decisively,.pre-commit-hooks.yamlexports these hooks to external consumer repos whose scalar style this repo cannot dictate. Converting the 40 in-repo descriptions to|is a fine independent change; it does not shrink the wrapper.Where the savings actually are: merge skill-audit + agent-audit (finding 14) →
−1,587 lines→ landed 2026-09-15 at −2,934 lines, zero coverage loss. A second option — sourcing the resolver intoscripts/skill-size-check.shrather than embedding it (−1,061) — is technically possible but couples the root hook to plugin layout and dismantles the byte-identity contract test's design; needs a decision, not an assumption.Decided and done (2026-09-16, grill;
ef27c97). The coupling objection went away with finding 36:4de5b6bretired.pre-commit-hooks.yaml, soskill-size-check.shruns only inside this repo, where the plugin path always exists. The hook now sourcesfactory-audit/scripts/lib-boundary-resolver.shand fails closed without it.scripts/skill-size-check.shwent from 1,524 to 509 lines (wc -l, −1,015), and the change is −957 lines net across 9 files. The hook's stdout, stderr and exit code are identical before and after over every corpusSKILL.mdand the 26 differential-suite fixtures. The contract test's byte-identity hash became single-copy assertions (27 → 29 passes), and ADR-0020 and ADR-0025 carry dated amendments. -
Fold
forgeandapm-install.forgeis a four-row routing table plus 207 lines of references explaining fork vs inline; it should be 25 lines with no references.apm-install(53 lines + 17-line sources) becomes a sixth dispatch row inapm-workflow. Effort S.
Decision (2026-09-16): Not proceeding — the human declined this finding.
forgeandapm-installstay as separate skills.
- Delete prose the model already knows. "Valid characters: lowercase letters, numbers, hyphens"; what pipx does and PEP 668; "code blocks carry a language tag"; "data to stdout, diagnostics to stderr". Ironically
body-discipline.mdinstructs auditors not to include "concepts the agent already knows". Effort S.Re-scoped and folded into finding 22 (2026-09-14). All four named examples were located, and they are four different classes of thing — only one is what the finding describes:
Example Location What it actually is "Code blocks carry a language tag" →skill-audit/references/formatting-and-scripts.md:19factory-audit/references/skill-formatting-and-scripts.md:19An audit criterion "Data to stdout, diagnostics to stderr" same file, line 39 An audit criterion "Valid characters: lowercase letters…" skill-author/assets/templates/SKILL.md:7A scaffold comment emitted into new skills by new-skill.sh; never loaded as model contextpipx / PEP 668 apm-install/SKILL.md:35-36,skill-author/references/scripts.mdGeneric tool prose — the only true positive Three exemptions agreed, which is what re-scopes the finding:
- Audit criteria are exempt.
→body-discipline.md:14factory-audit/references/skill-body-discipline.md:14frames the rule as "Would the agent get this wrong without this instruction?" — an auditor would, because the criterion is what it reports against. Cutting criteria is a redesign of what→skill-auditfactory-auditchecks, which belongs with finding 14.Repointed (2026-09-16, at HEAD): ADR-0025's merge both moved the directory and renamed the file (
references/formatting-and-scripts.md→references/skill-formatting-and-scripts.md), so the two citations above were doubly stale. Line 19 and line 39 still land on the two criteria named, andskill-body-discipline.md:14still carries the core test — verified withsed -n. Per finding 14's note, finding 18 stays open againstfactory-audit's files, so these are repointed, not struck. (Since closed, 2026-09-16 grill — see the closing note at the end of this finding. The repointed citations stay as the record.) assets/templates/is exempt. Scaffold output, not context.- Sourced restatement of a spec this repo's own artifacts are built to is exempt.
skill-author/references/scripts.mdcarriessource_keys: agentskills-using-scriptsand deliberately restates the agentskills.io spec — the contract every skill here is written against, so the restatement governs this repo's artifacts and has to be in front of the author.source_keys:alone is not the test, and cannot be:conventional-commits-spec.mdandbisect.mdboth carry it too, and finding 20 recommends reducing both to a pointer plus the house delta. The decidable line is what the content governs — a spec this repo's artifacts must satisfy (agentskills.io) is exempt; documentation of an external tool the model already has (Conventional Commits,git bisect) is not. Grounding, stated honestly: findings 9 and 26 closed as "Keep — vendored upstream content is intentional", but both closed over thedocs/research/anddocs/notes/directories, not over skillreferences/*.md; extending them toscripts.mdis this note's inference, not a recorded decision. (An earlier revision added "finding 11 re-decides this content's status anyway" — withdrawn: finding 11 proposes dropping the provenance metadata and validators, not the sourced prose.)
What remains is unsourced explanatory prose in skill bodies and non-criteria references — roughly 30–60 lines across kyberforge, where
apm-install/SKILL.mdyields about one clause. Too small to stand alone, and the same class of writing as finding 22 with a larger surface and no sourced-content conflict. Merged into finding 22 under these exemptions; not a separate work item. Safety note established while scoping:validate-provenance.shis not a pre-push gate (the only.pre-commit-config.yamlreference ischeck-scope-walkup-sync, over the walk-up port) and validatessources.mdstructure, never line-level traceability — so trimming sourced prose trips no gate provided frontmatter andsources.mdare left intact. Loose end in the fold, stated so it is not lost: finding 22's total is computed over fivebinskills (1,018 lines) and its implementation sizing names two agents, neither touching kyberforge — so these 30–60 lines sit outside the scope finding 22 states. Track them there as a separate line item with its own estimate; they are not covered by "bin: strip generic process theatre" as written.Closed (2026-09-16, grill): not proceeding. Finding 22 is deferred with
bin, and the folded kyberforge remainder (30–60 thin lines) is too small to stand alone, as the note above already says. It would also bring no skill under budget — a judgment made at the grill, not a figure the note above states. - Audit criteria are exempt.
4.3 git and gitea (153 + 93 files, 9,889 + 6,047 lines incl. mirror; source 3,288 + 2,286)
-
Delete the two router skills and two orchestrate agents (309 lines + 195 reference lines). No skill invokes them as a step; they appear only in boundary clauses (
AGENTS.md,git-worktrees,gitea-issues,gitea-prs) and as worked examples inagent-audit references→factory-audit'sreferences/agent-body-and-delegation.mdandreferences/agent-description-quality.md(repointed 2026-09-16 at HEAD; ADR-0025 moved them), all of which must change in the same commit orskill-size-checkfails on the dangling target. Claude Code already routes on descriptions. The chain today isgit-workflowstep 5 invokesgit-orchestrate, whose step 5 invokesgit-commits, which runsrtk git commit: three hops. Both agents exceed 900 words; ADR-0020 deliberately sets no agent body gate. Effort S.Not proceeding (2026-09-13): premise doesn't hold. There are no separate "router skills" — only two
.agent.mdfiles.git-orchestrateis not a dangling boundary-clause reference; it'sgit-workflowstep 5's actual execution backend (documented both directions), so deleting it breaksgit-workflow's only execution path rather than tidying an orphan.gitea-orchestrateis intentional per ADR-0011 (agent-facing counterpart for agent callers) even thoughgitea-workflowdoesn't call it. A third, undocumented instance of the same pattern (apm-orchestrate) exists and isn't addressed by this finding. The four boundary-clause locations named above don't actually reference either agent. No changes made. This needs the "short discussion" §7 bucket 2 implies, not a mechanical delete. -
Collapse git 7 skills to 1; gitea 7 to 2. Git references are man-page restatement:
git-log-format.md(242 lines listing%H,%ar),conventional-commits-spec.md(170 lines),worktrees.md(178),merging.mdexplaining fast-forward. Roughly 60% of the plugin is generic. The genuinely house-specific content fits in about 150 lines: thertkrule and ADR-0023 exceptions, main/master refusal,--no-verify, the-i --autosquash2.39.5 trap,--force-with-lease --force-if-includes, bisect exit codes, submodule push ordering, the detached-HEAD worktree trap. Gitea is more legitimately specific (MCP schema quirks:tree_sha,withLines, silent drops on PR create,per_page20 vs 30, 404 means 403) and splits naturally intogitea-tracker(issues, PRs, labels, milestones) andgitea-repo(branches, files, releases). Risk: one description must carry all trigger phrases; keep a dispatch table at the top of the body. Keeppc-authorandpc-run(finding 38). Effort M.Refuted as specified (2026-09-14, at HEAD
062ca47). The routing concern is not a risk to mitigate — it is a blocking gate failure.What holds: skill counts (git 7
git-*+pc-*, gitea 7); the four named git reference files at their stated sizes (git-log-format.md242,conventional-commits-spec.md170,worktrees.md178;merging.mdis 31, among the smallest). "Roughly 60% generic" holds at the top of its range — two independent methods give 54–60%. Gitea being "more legitimately specific" holds and is understated: gitea is ~72% house-specific, the inverse of git, with ~50 MCP quirks beyond the five named (nomethod:"close"onissue_write;draft:trueis literally a"WIP:"title prefix; no update tool for releases exists at all;replace_labelsclears unlisted labels; org-label methods takeorgnotowner). Note commit6cfc357(finding 13) touched none of the four named files, so its trim does not deflate this evidence.The 150-line target fails on the finding's own arithmetic. 60% generic of 1,891 non-
sources.mdlines leaves 756 house-specific; an independent full read puts the floor at ~918. Off by 5–6×. The house-specific list is also not exhaustive — it misses the rest of the ADR-0023 bare-gitexceptions (~23 sites across nine files, which collapse to about ten distinct documented reasons, not one per site: the fourgit log -Llines share one reason, the four--word-difflines another, the twogit diff --name-*lines a third — the genuinely distinct ones includegit branch --list's phantom*line,stash popswallowing the conflict report,stash listprintingNo stasheswhere git prints nothing, and the inner$(git config remote.origin.url)substitution, where output rewriting would poison a remote URL), a second version trap (worktree add --orphanneeds 2.42+, exits 129 on 2.39.5),commit-template.md(66 lines, wholly house), three specified JSON result shapes across the six skills that carry an output section (git-commits/SKILL.md:54,git-remotes:48,git-branches:61) plus the request schema ingit-branches/references/orchestrator-contract.md, and every cross-skill dispatch clause. Conversely one item on the list is misfiled: bisect exit codes restategit bisect run's own docs (bisect.mdis ~97% generic).Git 7→1 is uncommittable. Measured against
skill-size-check's FAIL tiers: description 1,950 chars = 4.9× the 400 ceiling, body 3,381 words = 3.8× the 900 ceiling, and the plugin is already at 492 of 500 whole-file lines. The finding's own mitigation — "keep a dispatch table at the top of the body" — adds body words to a budget already 3.8× over, and ADR-0020 makes stating the same trigger in two registers a FAIL in its own right. The smallest existing git description is 214 chars for one domain.Gitea 7→2 fails the same gate and puts a seam through the commonest workflow. Both halves FAIL the description ceiling:
gitea-tracker(issues + PRs + labels/milestones) sums to 991 chars,gitea-repo(branches + files + releases) to 989 — 2.5× the 400 ceiling, measured asskill-size-check'sdescription_value()measures it (YAML-folded, whitespace-collapsed). The proposal also silently dropsgitea-workflow, a seventh skill it never places, so "7→2" is really 7→2-plus-a-deletion.gitea-repowould carry 20 of 32 MCP tools across three unrelated families. And the structural objection: the split puts a hard cross-skill boundary through the commonest real workflow — edit-a-file-then-open-a-PR landsgitea-filesandgitea-prson opposite sides of thetracker/reposeam, forcing the same duplicate-or-reach-across choice ADR-0011 rejected the 5-skill option for, at a different seam. What this is not: blocked by ADR-0011's reasoning. An earlier revision argued that ADR-0011 rejected a 5-skill split andgitea-tracker"bundles strictly more", so it is rejected a fortiori — withdrawn, the premise is false. ADR-0011's stated reason is that bundling labels undergitea-issues"forc[es]gitea-prsto either duplicate the guide or reach intogitea-issues'references/— breaking the self-contained skill boundary": an objection to a boundary being crossed, not to bundle size.gitea-trackerputs issues, PRs, labels and milestones in one skill, so there is no boundary to cross and no guide to duplicate. What remains of ADR-0011 here is procedural: reversing the recorded 7-skill split needs a superseding ADR. Merging concatenates; it does not compress.Interaction with rejected finding 19, unacknowledged: collapsing git to one skill absorbs
git-workflowitself — one of the seven — so its 8-row Domains table would route to itself, and leavesgit-orchestratea dispatcher with exactly one target, its contract vacuous. Finding 19 was rejected for doing less than this, mechanically.Blast radius if ever revisited: 68 backticked references to git skill names, 99 to gitea names under
plugins/. Only the ones in aSKILL.mdare boundary targetsskill-size-checkresolves and FAILs on if dangling — itsfiles:regex is^plugins/[^/]+/\.apm/skills/[^/]+/SKILL\.md$, so it opens nothing else — and that is 35 of the 68 git mentions and 26 of the 99 gitea ones. The remaining 33 and 73 live inreferences/*.md, the two orchestrate agents (10 and 23 on their own), the plugin READMEs, kyberforge's audit and author references, and twovalidate.shcopies — none of which this gate opens: they still have to be rewritten by hand, but they fail no hook. PlusAGENTS.md:16,18,README.md:21-22,CONTEXT.md:168(usesgitea-prsas the naming exemplar),architecture.md:34(usesgit-branchesvsgitea-branchesas the canonical boundary example), and ADRs 0011, 0020, 0021, 0022, 0023. Two false alarms not worth chasing:tests/test-check-rtk-prefix.sh:97reads from a pinned historical SHA, andscripts/check-rtk-prefix.sh's mention is in a comment.Salvageable independently, ~230 lines:
conventional-commits-spec.md(~98% generic) andbisect.md(~97%) are the only two files where the generic-restatement thesis fully holds — reduce each to a pointer plus the house delta. Also worth a finding-13-style trim-in-place: the issue-vs-PR disambiguation duplicated across 4 gitea files. Neither needs a merge.Closed (2026-09-16, grill): not proceeding, salvage included. Both files are loaded on demand only (
git-commits/SKILL.md:46,git-history/SKILL.md:33), and exactly when the agent needs the precise rules; replacing them with a URL pointer trades a local, deterministic answer for a network fetch mid-commit.bisect.mdis not ~97% generic — every command carries thertkprefix (ADR-0023).conventional-commits-spec.mdcarries the commitlint 11-type set the repo'sconventional-pre-commithook enforces. The gitea issue-vs-PR duplication is forced by the no-cross-skill-sharing rule (§9). The saving would be repo lines, not context tokens, at the price of a version bump per file. -
Deleteconfig.example.json/.claude/plugins/git/config.json. Read by two steps, written by nothing. Default to GitHub Flow with the existingdevelop/release/*inference. Effort S.Done (2026-09-12): see commit
f5e4d0d. Deletedplugins/git/config.example.json(the runtime.claude/plugins/git/config.jsonwas never a tracked file). Removed the config-read step fromgit-orchestrate's Process and fromgit-branches' Step 1, leaving the existing default-inference logic (GitHub Flow, with Gitflow inferred from adevelop/release/*branch) as the sole path; updatedgit-workflow's description of the orchestrator's behaviour to match. Dropped the now-danglingapplied_configfield fromgit-orchestrate's output shape and theconfig.example.jsonexample fromdocs/spec/architecture.md.
4.4 bin, core, lint (88 + 49 + 31 files incl. mirror)
-
bin: strip generic process theatre.
write-docsis 109 lines, mostly form-filling sections plus a 15-line source provenance block; its rules fit in 25 lines.tddis about 70% textbook (RED/GREEN diagram, "good tests are integration-style", five thin references restating textbook design advice).diagnose40%,prototype50% (pixel-level UI switcher spec),grill-with-docs35%. Keep the opinionated parts: "no horizontal slicing", "no phase 2 without a loop",[DEBUG-xxxx]tags, "never infer the output path", the triage state machine. Effort M.Verified (2026-09-14, at HEAD
062ca47): percentages inflated 3–4×, target set wrong, but a real and better defect found. This finding also now carries finding 18's re-scoped remainder (unsourced explanatory prose only — audit criteria,assets/templates/and sourced spec restatement are exempt; see finding 18).Corrected percentages, by a stated method (a line counts generic only if it states a general SE principle with no repo-specific term, no named house convention, and would survive unchanged in any textbook):
diagnose~10–15%, not 40%.prototype~13%, not 50% — and its?variant=switcher spec is a prescriptive house convention (floating bar, arrow keys,NODE_ENVgating), not theatre.grill-with-docs~10%, not 35%.tdd~25% in the body, ~53% only at directory scope, not 70%. On the "RED/GREEN diagram" the finding names for deletion:tdd/SKILL.mdhas three diagrams, so the name is ambiguous. The horizontal-vs-vertical block (:36-46, whose own rows are labelledRED:/GREEN:) is the clearest statement of the skill's central opinion and should stay; the two literalRED:/GREEN:loop blocks at:71-74and:82-85are what the finding most plausibly means, and those two are textbook and go — eight lines with their fences. So the rebuttal stands only for the horizontal-vs-vertical block; it is an eight-line cut either way, not a case against the skill's one original diagram.write-docsis exactly 109 lines ✓, but "its rules fit in 25 lines" is wrong — the Process section alone is 17 lines of real content; floor is ~55–60.Two of five keep-list items name skills this finding never targets — "never infer the output path" is
research/SKILL.md:25, the triage state machine is intriage. And the target set does not match the repo's own over-budget list:skill-size-checkflags sixbinskills; this finding names two that pass clean (prototype,grill-with-docs) and misses three that are over —improve-codebase-architecture(730w + 316-char desc),research(703w),triage(712w).The real defect, which "form-filling sections" understates:
write-docsis 54% restatement. 431 of the 801 body words the gate counts (skill-size-checkreports 801; the 775 an earlier revision used omits the heading words the gate includes). Constraints (126w), When-to-use (110w), Failure handling (104w) and Self-check (91w) each restate the Process section or the description. Measured claim by claim, the repetition is wider than "four claims four times": the Reader-Testing scoping rule appears five times (lines 63/80/88/96/107); file approval before reading four (58/68/93/103); the delta summary four (62/78/87/106); stage-skip logging four (59/72/94/104); "every claim traceable, never invent behaviour" four (34/57/101/102); show-the-full-section-before-gating three (60/76/105).contract.md:119explicitly forbids this: "Exclude: Restatements of the description — it is already in context." It is also the corpus's only outlier frontmatter — the soleSKILL.mdof the 39 real skills carryingwhen:,updated:orsource:(44 files are namedSKILL.mdunderplugins/; 1 is a template underskill-author/assets/templates/and 4 are vendored underkyberforge/docs/research/examples/skill-write/, the same 39architecture.md:82states).Realistic total ~150–180 lines of 1,018 (15–18%), itemised so it adds up:
tdd's three textbook references 74 lines (refactoring.md10 — a Fowler smell list;deep-modules.md33 — self-declared "From 'A Philosophy of Software Design'";interface-design.md31 — generic DI advice), whereimprove-codebase-architecturealready carries richer house-specific treatments of both concepts;write-docs109 → ~58, so ~51;tdd's body at ~25% generic, ~25;diagnose~15. That sums to ~165. The three textbook references are ~45% of the cut, not the ~75% an earlier revision claimed — 74 of ~165.prototypeandgrill-with-docscontribute nothing, per the scope recommendation below, and finding 18's folded kyberforge remainder (30–60 lines) sits outside this 1,018-line denominator.Coupling — the important caution. This corpus has already been through two trim passes, and the last one broke two of these five targets the same way. PR #129 (
598a7c3) records: "prototypeandvale-configdeleted rules outright that survived nowhere." This finding proposes redoing that operation onprototypeanddiagnose. Recommend droppingprototypeandgrill-with-docsfrom scope entirely — both pass every gate and both have prior-regression history. Also: deleting areferences/*.mdnamed in a body is a hard ERROR (skill-size-check.sh:1265), sotdd's reference deletions and its SKILL.md relinks must land in one commit;improve-codebase-architecture/SKILL.md:77,79hard-namegrill-with-docs'scontext-format.mdandadr-format.mdby path, so neither can be renamed; and shrinkingwrite-docsfalsifies live comments atskill-size-check.sh:64,596,tests/test-adr0020-targets.sh:592andarchitecture.md:82. Unlike finding 23'scaveman/zoom-out, none of these five is cited as a convention exemplar anywhere.Sizing if implemented: two parallelizable agents over disjoint files — A on
write-docs(self-contained, no references), B ontdd(reference deletion + same-commit relink, ERROR-gated, cannot be split).diagnoseis ~15 lines, too small for its own agent.Deferred (2026-09-16, grill). The human is excluding
binfrom this audit: its skills are "binned for a reason" and will be fixed or relocated as a separate piece of work. Nothing in this finding is executed here; the itemised ~165-line estimate above is the starting point for that work.binis still covered by the version-bump gate (finding 33) until then. -
bin: merge
grill-meintogrill-with-docs.grill-meis 16 lines and a subset of the docs flow;grill-with-docscreatesCONTEXT.mdwhen missing, so the merged skill needs a no-write opt-out.caveman(50 lines) andzoom-out(9) are hand-invoked prompts rather than workflow skills; they are also the repo'sdisable-model-invocationexemplars inCONTEXT.md,contract.md, ADR-0020, ADR-0021, andgates.md, andinstall.shhas no path for~/.claude/commands/, so moving them means picking a new exemplar.improve-codebase-architecturedefines its glossary twice (inline and inlanguage.md; the README documents the split as intentional). Effort S.
Decision (2026-09-16): Not proceeding — the human declined this finding.
grill-meandgrill-with-docsstay separate.
-
core:
provider-adapter-authoris a 1,200-line wrapper around one instruction ("replace duplicated lines with@AGENTS.md, keep provider-specific lines"): a 496-line validator with a 519-line bats suite for a check that is a grep.agentsmd-authoralready callsagentsmd-auditas mandatory closeout, and both route toprovider-adapter-authorin boundary clauses that must change with it. Target: oneagentsmdskill with an audit mode, adapter conversion as a step, validator about 40 lines. Needs an ADR-0012 revisit. Effort L.Refuted (2026-09-14, at HEAD
062ca47). Not deferred — the target fails the repo's own gate before any judgment call is reached, so the ADR-0012 §8 question is moot for this finding.The merge is arithmetically impossible as specified. Body word counts:
agentsmd-author485 +agentsmd-audit361 +provider-adapter-author514 = 1,360 words againstBODY_MAX_WORDS=900(ADR-0020 hard FAIL). Descriptions: 251 + 275 + 280 = 806 chars into a field capped at 400. Relocating the overflow intoreferences/is PR #129's named anti-goal, and issue #117 records thatreferences/is where neither the size gate nor Vale looks.Both factual anchors describe a validator that no longer exists.
scripts/validate-adapter.shwas 141 lines at birth (6fd6876) and in that form was approximately a grep — which is why it shipped two recorded defects:a8cd5e8(reachable from no branch: its change reachedmainsquashed into598a7c3, #129; a UTF-8 BOM hid the import line, so aCLAUDE.mdwhose first line was@AGENTS.mdfailed with "no reference to AGENTS.md" and was told to add the line already in front of it) and issue #115 (c59e4bf, which is only onrescued/parse-bullet-contributing-files; its change reachedmainin the same598a7c3squash: the--no-import-syntaxflag was a proven no-op — "both branches reduce to the same expression"). 141 → 496 is the fix for those. "Validator about 40 lines" targets below the version whose defects are on the record. Line counts otherwise exact: validator 496, bats 519 — but "1,200-line wrapper" is 1,164, of which the wrapper is 52; 1,015 are validator + tests (1,071 with the two READMEs, 28 each), and the remaining 41 arereferences/.Coverage given up by a 40-line validator: ~67% of the 42-test suite. 20 tests sit under explicit
Q1–Q5headers — Q1 inert fenced/indented/HTML-comment regions (5), Q2 valid-UTF-8-but-not-UTF-8 encodings (4), Q3 exists-but-unreadable (1), Q4 path resolution (4), Q5 pointer-vs-mention (6); 8 more are hardening, so 28 of 42. Every one was proven non-vacuous by deliberate mutation under PR #129. Representative guards: a ```-fenced@AGENTS.md"exited 0";@NOTAGENTS.mdcounted as an import for want of a path-segment boundary;"AGENTS.md" in lnpassed "Do NOT read AGENTS.md; it is obsolete."; BOM-less UTF-16LE decodes as valid UTF-8 and produced a false diagnosis; exit 2/3 split from 1 "because the skill's closeout tells the agent to fix every non-zero exit by editing the provider file, which for a mistyped flag edits the wrong file forever".The self-containment constraint does not support this finding the way it supports 14/15 — there is no cross-skill duplication here to merge away.
agentsmd-audit's three scripts share essentially nothing withvalidate-adapter.sh(noread_text, no BOM handling, no NUL check; they exit 1 on usage errors). Merging would expose that they are unhardened — costing lines, not saving them.Two further blockers if it were ever revisited: the merge dissolves
agentsmd-author's standing prohibition "Never write to a provider file yourself, in any circumstance" (SKILL.md:21), a hazardc59e4bfclosed after the validator's own size-FAIL remediation text "actively invited the prohibited edit"; andskill-size-check.sh:121+tests/test-skill-size-check.sh:729both citea8cd5e8's exit-2 split as precedent for their own, so deleting it orphans two live cross-references. -
lint: delete the
lint-runneragent. Its body is "callvale-run, reformat output", which--output=JSONalready gives; it exists for backends that do not exist. It is the example boundary clause in threeagent-authortemplates and ADR-0016, so those need a new example. About 40% ofvale-configis install tables and settings lists the model can fetch from vale.sh. Keep the house-verified matrices (E100/E201,Packagesbelow glob, frontmatter, ignore paths).lint/docs/research/docs/vale/overlaps the skill's own references by about two thirds. Effort S.
Decision (2026-09-16): Not proceeding — the human declined this finding. The
lint-runneragent stays.
5. Prose and docs (9,600 lines, 109,000 words outside plugins)
-
Move or delete
docs/research/anddocs/notes/(4,500 lines, 47% of prose words). Six of eleven research files are linked only from each other; they are self-described session audit trails, agendas, and a "temporary build reference".docs/notes/factory-research-gaps-conflicts.mdsays "Status: Superseded";factory-integration-decisions.mdsays "Complete" and its decisions already live in ADRs, yetAGENTS.mdtells every session to read it.archive/team-self-organisation-sprint-brief.md(3,400 words) is unrelated to this repo. Archive or delete; drop the threeAGENTS.mdpointers. MovingCONTROLS.mdtodocs/spec/means updating its literal path in nine or more files including the deployedgovernance.md. Effort S.Decision (2026-09-12): Keep. Same reasoning as finding 9 — these docs are intentional context for sourced work. Not proceeding.
-
Four governance documents say one thing.
core/instructions/governance.md(949 words, always-on),docs/ai-constitution.md(2,906),docs/wiki/HUMANS.md(1,413),CONTROLS.md(1,224), with near-identical preambles and, in three of the four, a "what this file does not govern" block pointing at the others. The constitution repeats one of its own principle lead sentences. Keepgovernance.mdas the operative file, trimmed to about 50 lines (drop the classification table that repeats the bullets above it, the footer, the non-governance block). Dedupe the constitution by about 20%. Effort M.Refuted as framed (2026-09-14, at HEAD
062ca47). All four word counts are exact — the first finding in this audit whose figures survive checking — and everything built on them fails."Four documents say one thing" misreads audience separation as duplication. They are one principle set projected onto four execution surfaces, and each projection is load-bearing:
governance.mdis imperative to the model and injected into every session;HUMANS.mdis imperative to a person on a wiki;CONTROLS.mdis a declarative spec for CI tooling; the constitution is the justification layer with citations. Take "secrets never enter AI context": the constitution states it with evidence,governance.mdtells the model never to emit one,HUMANS.mdtells the person never to paste one,CONTROLS.mdspecifies the pre-commit hook that catches both when the first two fail.CONTROLS.md:8names this explicitly — "Agent instructions and human practitioner rules are probabilistic… A control that runs automatically in CI enforces a principle more reliably than any instruction in any file." The three "what this file does not govern" blocks are the seams that keep the four from bleeding together, each pointing at a different file for a different reason. Real overlap is ~15%.22% of the finding's word count is not this repo's to edit.
docs/wikiis a submodule pointing at a separate Gitea wiki repo, concurrently editable through the web UI.HUMANS.md's 1,413 words are out of scope for any change made here."Drop the classification table" would delete live rules. The table has four rows; only Confidential and Restricted restate the bullets above it. Public and Internal exist nowhere else in the file — dropping it removes the only statement of
Internal | Operational data, anonymised logs | Enterprise AI tools only; not consumer/free-tierfrom always-on agent context, in every project.The 50-line target is arithmetically unreachable and contradicts the finding's own keep-list. The file is 82 lines; the three named cuts total 16 lines counting only their own content — the table rows (31–36, 6), the non-governance block (71–76, 6), the footer (79–82, 4) — landing at 66, or at most 23 if each cut also takes its heading, surrounding blanks and the
---rules, landing at 59. Both include the table cut that shouldn't happen. Reaching 50 means cutting ~9–16 more from Hard Prohibitions (18 lines) or Required Behaviours (24), the operative rules the finding says to keep. "Dedupe the constitution by about 20%" overstates by 4× — verifiable duplication is 133 words (4.6%), in two adjacent principle pairs (§5 lines 114/117 byte-identical; §4 lines 89/92), both merge artifacts. §§1–10 are ten distinct domains with near-zero cross-section.Any cut to
governance.mdis a global agent-behaviour change, not a docs edit. Verified chain:scripts/deploy-manifest.sh:21mapscore:.claude/core, and bothproviders/claude-code/CLAUDE.mdand the live~/.claude/CLAUDE.mdcarry@~/.claude/core/instructions/governance.md. Repo and deployed copies are byte-identical (6,590 bytes). All 949 words are injected into every session in every project. Needs explicit sign-off on that basis.Honest ceiling: 168 words / 17.7% of the file's 949 — the cross-reference scaffolding only: preamble 43 (lines 3–5), non-governance block 77 (71–76), footer 48 (79–82), landing at ~67 lines with no rule loss. (An earlier revision said 47 for the preamble, which is only reachable by counting lines 1–7 — that sweeps in the
#glyph and a---rule as words.) Plus 133 words from the constitution. Not 50 lines, not 20%.Two defects the finding missed, both worth fixing independently of it. (1) A live bug:
docs/HUMANS.mddoes not exist — the file isdocs/wiki/HUMANS.md. The wrong path appears five times across three files, including the deployedcore/instructions/governance.md:82, which is self-inconsistent (line 73 correct, line 82 broken); the other four areCONTROLS.md:5,101,106andai-constitution.md:238. (An earlier revision said "four times" while enumerating all five.) Fixed (2026-09-15): all five corrected todocs/wiki/HUMANS.md; the deployed copy under~/.claude/is now stale until→ was redeployed on 2026-09-16 (see §10). (2) The deployed always-on file carries repo-relative pointers that dangle in every project but this one — an agent told to "read it when making decisions not covered here" cannot. That is the substantive question this finding should have asked. The footer is additionally self-referential:scripts/install.shre-runsgovernance.md:80lists the file as compatible with itself.Decided and done (2026-09-16, grill). The constitution moved from
docs/ai-constitution.mdtocore/ai-constitution.md, so the existingcoredeploy step ships it to~/.claude/core/ai-constitution.md, andgovernance.md's "read it when making decisions not covered here" pointer now names that deployed path. The three informational pointers (HUMANS.md,CONTROLS.md, and the footer) now say they live in the holocron repo rather than reading as local paths. Path-qualified citations were updated inAGENTS.md,docs/spec/architecture.md,docs/notes/skill-implementation-workflow.md,CONTROLS.mdand the wiki'sHUMANS.md; the vendoredwrite-skillexample underplugins/kyberforge/docs/research/examples/and this audit's historical notes were left as records. The wiki commitis local until its push is approved, and the→ is pushed (docs/wikigitlink is bumped only after thatca1b35fon the wiki'smain), and the gitlink bump landed in2ae7d4e.Decision (2026-09-16): The finding as written is not proceeding: the human declined its cuts, including the 168-word cross-reference trim, so no governance document was deduplicated or shortened. The two defects above are fixed separately. The
docs/HUMANS.mdpath was corrected on 2026-09-15 (see §10), and the dangling always-on pointer was fixed by the constitution move in the note above (adaa978). That move changedgovernance.md's pointers, not its rules. -
ADRs: 2,740 lines, 72% in eight ADRs over 150 lines. ADR-0020 is 513 lines with a 71-line measurement log as Context; ADR-0017 has 173 lines of amendments against 45 of decision. ADR-0001 is superseded and ADR-0006 moot, both keeping full text below the banner. ADR-0002 is three lines. Truncate superseded ones to the banner, fold amendments into the decision, cap Context at 20 lines, add a 25-line
docs/adr/README.mdindex with status. The rules already live ingates.md; the ADRs need only decision and consequences. Effort M.Moved backwards (measured 2026-09-14 over
afa7187^..a6434e0): today's ADR-0024 work did the opposite of this finding on every axis, and that is recorded here so it is a known trade rather than a surprise.docs/adr/went from 23 files / 2,748 lines to 24 / 3,084 — one new ADR (0024, 259 lines) plus amendment and banner text across eleven existing ADRs (0001, 0006, 0011, 0013, 0014, 0015, 0017, 0018, 0019, 0020, 0021 — 87 lines added, 10 removed, net +77), for a total of net +336 lines (+12%). The two ADRs this finding names for truncation both grew below their banners instead: ADR-0001 26 → 27 lines and ADR-0006 22 → 27, each gaining a fresh "as of ADR-0024" paragraph rather than losing the historical body beneath it. ADR-0017 gained a supersession banner while keeping its four amendments in full — the exact shape this finding proposes to fold.Not a defect in that work: a supersession has to be recorded somewhere, and an unread stale ADR is worse than a long one. But it does mean the finding's estimate is now conservative and its "truncate superseded ones to the banner" step has more to remove than when it was written — ADR-0001, ADR-0006 and ADR-0017 are all superseded-with-full-body today. State the basis when re-measuring: this is a two-SHA measurement, not a standing count, and further ADR amendments were being written by other sessions while it was taken. Re-derive with
git ls-tree -r --name-only <sha> docs/adrbefore acting on it.Verified (2026-09-14, at HEAD
062ca47): as written this finding saves nothing and breaks citations in four files. The size of the saving depends on a convention the finding never states. Truncating ADR-0001 and ADR-0006 to their banners removes 20 lines if the---separator and its trailing blank are kept (13 + 7), or 24–26 if truncation drops those too, which is the natural edit (15–16 + 9–10). The proposeddocs/adr/README.mdindex costs 25. So the range is +5 to −1 lines — the robust conclusion is that the proposal is a wash, not that it nets +5.The finding's headline was accurately measured; it has since gone stale. Current state is 3,118 lines / 24 files. The 2,740 was correct at commit
a3e721e(2026-09-09, "docs: retire the META.md guidance ADR-0022 overruled"), an ancestor of HEAD:docs/adr/there is exactly 2,740 lines across 23 files, exactly 8 ADRs exceed 150 lines, the top-eight share is 71.90% (1,970/2,740 — the finding says 72%), and ADR-0020 is 513 lines. Every headline figure reproduces at that one commit, which rules out coincidence, and across all 67 commits touchingdocs/adr/a3e721eis the unique one yielding 2,740 (neighbours:ed8c99e2,732,a3e721e2,740,568ca742,747,af80d272,748). What moved the numbers is the ADR-0024 wave, already recorded in the note above. Re-derive withgit show a3e721e:<path>rather than assuming the figure was invented.Today those same figures read: ten ADRs exceed 150 lines, not eight; top-eight share is 68.3%, the over-150 cohort 79.2%. ADR-0020 is 514 lines. Its Context is 72 lines counting the
## Contextheading and 71 without — a counting convention, not drift: the section is byte-identical ata3e721eand at HEAD (## Contextat :11 through## Decisionat :83), so the finding's 71 and this note's 72 are the same span counted two ways. ADR-0017's "173 amendment lines against 45 of decision" and ADR-0002's three lines are exact."The rules already live in
gates.md" is backwards.→docs/spec/gates.md:349-352→docs/spec/gates.md:397-400docs/spec/gates.md:399-401explicitly declines to restate ADR-0020's numbers: "they live in ADR-0020's Consequences section… Quoting them here would just create a second copy to go stale." gates.md is a consumer of the ADR, not its replacement. The index proposal also contradicts a recorded decision —docs/spec/architecture.md:90: "There is no index file — the directory holds numbered ADRs whose filenames state their decision, sols docs/adr/is the index."Repointed (2026-09-16, at HEAD
b426460): the quotedgates.mdpassage moved from:349-352to:397-400as later sections were added above it; verified withgrep -n "Quoting them here" docs/spec/gates.mdandsed -n 397,400p. At4b17703it is:399-401(the "Quoting them here" line is:400).architecture.md:90still resolves.No superseded body can be truncated — every one is quoted by content, not merely cited by number. ADR-0001's body text is quoted verbatim at
docs/adr/0015:5,36, andfactory-integration-decisions.md:133lists "Pull-based distribution (ADR-0001)" as settled, a concept living only in its consequences bullets. ADR-0006's version-parity invariant is stated only at0006:23and is relied on by0014:116and0024:183-185— and its banner (17 lines) is already longer than its body (7). ADR-0017's own banner says its diagnosis "is still accurate about how Claude Code's installer works", and ADR-0024 cites its body in eight places. ADR-0002 is only partially superseded and is cited as a design source by a shipped skill.Nothing in
tests/or.pre-commit-config.yamlreadsdocs/adr/—grep -n "docs/adr" tests/test-adr0020-*.shreturns nothing; the ADR-0020 gate family testsskill-size-check.shand the embedded resolver copies. Editing ADR prose breaks no gate. The only constraint is citation integrity."Cap Context at 20 lines" would destroy a derivation three scripts depend on. ADR-0020's Context pins base commit
f9b919d7e3b, states the summation method and the token approximation, and derives the 2,770 gate from 7.22 chars/word × 20,000 — stating body-only vs whole-file explicitly because conflating them is the defect the ADR exists to stop. Only the four illustrative anecdotes (~42 lines) are trimmable, and those are the argument, not the measurement.Honest ceiling ~235 lines (7.5%), and the one real win is not in the finding: delete ADR-0017's four amendments (−173) now that ADR-0024 consequence 7 has restated them in full, re-pointing eight citations. Plus ADR-0001/0006 compressed to banner-plus-one-line (−20) and ADR-0020's anecdotes (−42). No README index. Restate the headline as 79% in ten ADRs.
The framing question this finding never notices: it proposes reversing a convention the repo just re-affirmed — every banner added by the ADR-0024 work ends with some form of "kept below as the historical record". Is a superseded ADR's body a record or dead weight? Nothing here is mechanical; every proposed cut touches text another file quotes.
Closed (2026-09-16, grill): not proceeding. Decision: a superseded or accepted ADR's text is the historical record (the Nygard convention, and what every ADR-0024 banner already says), so no body is truncated, no amendment is deleted, and ADR-0020's Context is left intact. That removes every remaining cut — ADR-0017's amendments are part of its record, and ADR-0024 consequence 7 (
0024:213-252, ~40 lines) summarises them rather than restating them in full as the note above says. Corrected headline for anyone quoting it:79% of→docs/adr/lines sit in ten ADRs over 150 lines (measured 2026-09-14)80% of→ 85% ofdocs/adr/lines (2,983 of 3,709, across 25 files) sit in eleven ADRs over 150 lines (at HEADb426460)docs/adr/lines (3,295 of 3,896, across 25 files) sit in twelve ADRs over 150 lines (atbaa2f5d, 2026-09-16, fromwc -l docs/adr/*.md; ADR-0025 joined the cohort and the ADR-0019 and ADR-0022 amendments grew the directory). The 79%-in-ten figure was the 2026-09-14 state; the 2,740 figure is thea3e721estate only. -
The same facts are stated in full three or four times. "Edit.apm/, never the mirror": README (2 paragraphs), AGENTS.md (2 paragraphs), architecture.md (2 paragraphs plus the lost-README anecdote), ADR-0017. The apm.lock / SessionStart story: README (11 lines), AGENTS.md, ADR-0018, ADR-0019, gates.md. The offlineSKIP=command and the three-stage install each appear three times. Rule: README has the how-to, AGENTS.md has one-line rules with links, architecture.md has mechanics. Effort S.Corrected then partially done (2026-09-14): independent re-verification found the "edit
.apm/, never the mirror" and apm.lock/SessionStart clusters confirmed but the third overstated — no file documents an offlineSKIP=command (the oneSKIP=-adjacent mention ingates.mdexplicitly says a different opt-out "is notSKIP="), and "three-stage install" appears twice, not three times, with no restatement worth trimming. Trimmed the two confirmed clusters: README's "Editing plugin content" and AGENTS.md's "Edit.apm/, never the flat mirror" sections cut to the how-to/one-line-plus-link split the finding itself proposed, full mechanics (therm -rfbehavior and theplugins/kyberforge/hooks/README.mdanecdote) staying solely indocs/spec/architecture.md. README's "Keeping the install current" and AGENTS.md's apm.lock bullet trimmed to drop the restatedapm outdated/apm update --yestiming narrative, pointing to ADR-0019 as the canonical mechanism instead. No test greps the trimmed wording (checked). -
LESSONS.md: 41 entries, 2 graduated, about 12 stale. Twelve entries from 2026-05-17 describe a write-skill / write-eval workflow whose skills no longer exist. One entry is open work labelled "Status: neither part landed". The longest eight are 200 to 550-word incident reports. Delete the stale entries, move open work to an issue, cap entries at about 60 words, target 100 lines. Effort S.Done (2026-09-12): see commit
629320bondocs/simplification-audit. 255→131 lines, 41→30 entries. Kept 3 of the same-dated entries (RLHF defaults, secrets-rule gap, HITL gap) — judged unrelated to the defunct write-skill/write-eval workflow and still applicable, so 10 deleted rather than 12. The "neither part landed" open-work entry (CONTEXT.md not@imported at session start) was removed rather than filed as an issue — full text preserved in this session's transcript if wanted later. -
CONTEXT.md: 28 terms, most used only by gates.md, scripts, or tests rather than by skills; two (Preload tax, Skill context contract) are never used outsideCONTEXT.mdand ADR-0020. The preload-tax entry quotes two dated numbers then says not to quote them. The example dialogue and flagged-ambiguities sections are grill residue. Cut to about 20 one-line terms. Effort S.Corrected then done (2026-09-13): see commits
124ce6eand follow-up ondocs/simplification-audit. Independent re-verification found "most used only by gates.md/scripts/tests" overstated: 13 of 28 terms are actually referenced from model-facingreferences/*.mdfiles skills load in normal use (Routing target, Hand-invoked skill, Dispatch body, Near-miss, Thin adapter, Provenance chain, Output profile, apm package, Plugin marketplace, HITL, Skill composition, Delegation discipline, holocron) and were kept untouched. Only the 9 terms confirmed as true orphans were removed after a fresh independent grep: Content mirror, apm-consumed install, Vale audit prefilter, Vacuous green, Management Application, Sycophancy, HOTL, Preload tax, Skill context contract — 28 → 19 terms. Re-counted (2026-09-14, ata6434e0): 18 terms, not 19. The "28 → 19" above is an accurate record of this finding's own commit (124ce6e) and is left standing.718c79athen removed a twentieth-to-nineteenth entry this finding never touched: the standalone Plugin term, folded into apm package when ADR-0024 made "plugin" and "apm package" the same thing. Counted as bolded term entries between## Languageand## RelationshipsinCONTEXT.md: 19 at124ce6e, 18 at718c79aand unchanged ata6434e0. The finding's own target ("about 20 one-line terms") is met either way. The preload-tax self-contradiction (quotes 23,427/10,478-char figures then says not to quote either) was confirmed verbatim and resolved by the entry's own deletion. The "example dialogue" and "flagged ambiguities" sections were found to be mandated bygrill-with-docs/references/context-format.md's template spec, not grill residue — left untouched, except one dangling bolded cross-reference to the now-deleted "Preload tax" term in a Flagged-ambiguities line, which was unbolded/de-referenced in place (the ambiguity resolution itself still holds without a defined glossary entry to point at). -
Structure is described three ways (README layout table, architecture.md plugin table, AGENTS.md structure bullets), andVISION.mdcarries a 35-line stack spec for a product that lives in another repo. One layout table in README; architecture.md keeps mechanics only; VISION drops the stack detail. Effort S.Premise corrected, residual done (2026-09-14). Both halves were inflated; most of the proposed split already existed.
- "Described three ways" overstates it.
docs/spec/architecture.mdhad already been differentiated, and says so in the file: its plugin table is prefaced "These are routing boundaries, not inventories — they answer 'where does a new skill go', so they deliberately do not enumerate what each plugin ships today… For what a plugin ships today, readplugins/<name>/.apm/skills/or the plugin list inREADME.md." That is the split this finding proposes, already implemented and self-documenting. README holds a path→contents table plus the six-plugin inventory; architecture.md holds a plugin→scope routing table that delegates inventory to README.AGENTS.md's## Structurewas two bullets, not a third description. - "A 35-line stack spec" counted the wrong thing.
docs/VISION.mdis 71 lines total. The whole## Long-term: Management Applicationsection is 35 lines; the stack detail inside it was 5 lines (Stack, Stack rationale, Deployment, Hosting, Users).
The one genuine duplicate was
AGENTS.md'splugins/bullet restating apm-install mechanics owned bydocs/spec/architecture.md:22andREADME.md:55. Done: that section cut to two actionable one-liners plus pointers to the README layout table and architecture.md — keeping the load-bearing session rule (.claude/skills/and.claude/agents/are install output, never edit them), which finding 29's earlier trim had left the Structure bullet carrying implicitly. InVISION.md, the stack/framework/deployment lines were replaced with a one-line scope statement deferring those choices to that product's own repo, and the Phase 1 "Mobile/desktop (Phase 3)" line was dropped as an intra-file duplicate of the Phase 3 section. Net 6 lines (f91babc: 2 files changed, 5 insertions, 11 deletions); README and architecture.md untouched, both already correct. - "Described three ways" overstates it.
6. Distribution, versioning, and session startup
Not covered by the area audits above; found on a final sweep of the root config and install pipeline. The install pipeline itself (scripts/install.sh 55 lines, deploy-manifest.sh 24, statusline 109) is fine and needs nothing.
-
Every plugin version lives in four places (five for kyberforge), plus one per skill.
plugins/<name>/apm.yml, two generatedplugin.jsonfiles, the rootapm.ymlpackages list, theexecutables.allowkey (kyberforge#1.6.2), and ametadata.versionin all39→ 38 SKILL.md files (ADR-0022) that nothing consumes and that drifts freely (gitea skills sit at five different values). Repo tags (v2.0.1) follow a third scheme that the declaredtagPattern: v{version}can never match underper_packageversioning. ADR-0006, ADR-0022,check-executables-allow-sync,skill-frontmatter, andapm pack --check-versionsall exist to police this. Proposal: one version per plugin in itsapm.yml; dropmetadata.versionand ADR-0022; letapm packderive the rest. Effort M.Partially advanced (2026-09-14): see commit
718c79aondocs/simplification-audit. Two of the four locations per plugin are gone: the twelve generatedplugin.jsonmanifests (plugins/*/.claude-plugin/andplugins/*/.github/plugin/) were deleted with the mirror. ADR-0006 needed no action — it was already moot and governed only those two now-deleted manifests, so no version bumps were required by the change. Not closed. Still outstanding:plugins/<name>/apm.yml, the rootapm.ymlpackages list, theexecutables.allowpin, andmetadata.versionin all39→ 38 SKILL.md files (still unconsumed, still drifting), plus ADR-0022 and thev{version}tagPatternmismatch. (Since closed, 2026-09-16 grill — see the decision note at the end of this finding.) Verified (2026-09-14, at HEAD062ca47): headline wrong, central claim inverted — and it contains the one zero-risk, empirically-verified win in this audit.Do this regardless of anything else: delete the six root
apm.ymlpackages[].versionlines. Tested in an isolated scratch copy (repo untouched): settingplugins/lint/apm.ymlto9.9.9while root says1.1.7passesapm pack --check-versions --check-cleanwith exit 0, reports[matches], and emits1.1.7— the curator entry wins (output_mappers.py:163-171). Deleting the rootversion:line entirely leavesmarketplace.jsonbyte-unchanged (builder._fetch_local_metadatareads the plugin's ownapm.yml). All six are removable with zero output diff. This is unpoliced duplication that silently ships the wrong number on drift. Effort S, no decision needed.Corrected headline:
two hand-maintained per-plugin locations (three for kyberforge)→ one hand-maintained per-plugin version location,plugins/<name>/apm.yml(two for kyberforge, adding theexecutables.allowkey), not four.2def060deleted the rootpackages[].versionlines (corrected 2026-09-16, review round). The rootpackages[].description:duplicates dropped in the same round are a separate duplication, not a version location, so they do not change this count — the audit's own "already done" note records theplugin.jsondeletion but never fixed the headline. Gitea skills drift across six values (0.1.2, 0.1.3, 0.1.4, 0.1.5, 0.1.6, 1.0.1), not five —still six at HEAD on 2026-09-16→ five again at HEAD (b426460) on 2026-09-16 (0.1.2, 0.1.4, 0.1.5, 0.1.6, 1.0.1), because8451169bumpedgitea-branches0.1.3 → 0.1.4 under the new version-bump gate and it was the only skill at 0.1.3; re-derived by parsingmetadata.versionout of eachplugins/gitea/.apm/skills/*/SKILL.mdwith PyYAML.39→ 38 carry it, and all 38 do (re-measured 2026-09-16; ADR-0025's merge took one). TheSKILL.mdfiles ✓0.4.6duplication between rootversion:andmarketplace.version:is forced by apm, not a repo choice — deletingmarketplace.versionmakes--check-cleango dirty."Nothing consumes
metadata.version" is false twice over. Machine enforcers:→scripts/skill-size-check.sh:1365-1374scripts/skill-size-check.sh:1370-1379and→skill-audit/scripts/validate.sh:1292-1332plugins/kyberforge/.apm/skills/factory-audit/scripts/lib-checks-skill.sh:235-277, both FAIL tier, the latter citing ADR-0022 by name, with four dedicated bats cases and ~10 fixture generators baking the field in. Instruction-level consumers:skill-author/SKILL.md:60(bump minor on create, patch on improve),create.md:89,101,improve.md:82, andforge/SKILL.md:54+references/version-bump.md. apm parses it for Chatmode/Instruction/Context primitives but not for Skills, and never emits it. Precise statement: the value is written, shape-validated, and never read downstream — it is an agent-visible revision counter, and the drift table shows the counter is not being maintained.Repointed (2026-09-16, at HEAD):
skill-audit/scripts/validate.shno longer exists — ADR-0025's merge moved the ADR-0022 check intofactory-audit's skill-side check library, where it is theSEMVER_REblock (comment header at:235,fail()calls at:261and:275).skill-size-check.shgrew by 5 lines above the block since062ca47, hence the shifted range there. All five instruction-level citations still resolve at HEAD, verified withsed -n.ADR-0022 already considered and rejected dropping the field, on the grounds that
skill-authordepends on it to decide whether a pass owes a bump — a rationale still live today. Superseding costs: rewrite skill-author's bump rule, deleteforge's version-bump route premise, strip two scripts, delete four bats cases, fix ~10 fixture generators, edit the scaffold template, update→gates.md:97→gates.md:145gates.md:146— and re-open the "is this field present here?" question issue #127 closed, just from the other side. (Repointed 2026-09-16, at HEADb426460: themetadata.versionfrontmatter sentence formerly atgates.md:97was at:143-146, the field itself on:145, and is at:143-147/:146at4b17703; verified withgrep -n "metadata.version" docs/spec/gates.md.) Recommendation: keep it and fix the actual defect, which is that nobody bumps it. Either enforce the bump in the skill-author workflow or declare the values advisory in the ADR.The
tagPatternclaim is refuted — inert, not broken. Underversioning.strategy: per_package, apm never reads it:version_check.py:262gates onstrategy == "tag_pattern", andbuilder.py:641,781are reachable only for remote source entries, while all six packages here are local paths. Thev1.0.0/v2.0.0/v2.0.1tags are not "a third scheme" — they are the.pre-commit-hooks.yamlexternal-consumer contract tags from finding 36, a different axis entirely. Latent risk only: ifdependencies.apmever gainsref:pins, tagPattern goes live against per-package tags that do not exist.Also:
executables.allowshould be kept — it is version-keyed by apm's design andcheck-executables-allow-syncguards a real silent failure (ADR-0019). And ADR-0006's ADR-0024 amendment asserting "apm.yml'sversion:is the only version field a plugin has" is inaccurate while rootpackages[].versionexists — fixed by the deletion above.Decided and done (2026-09-16, grill): enforce the bump. Advisory status and dropping the field were both rejected. The six root
apm.ymlpackages[].versionlines are deleted (apm pack --check-versions --check-cleanstill passes, output unchanged), which also makes ADR-0006's "the only version field a plugin has" true.scripts/check-skill-version-bump.shnow runs at pre-push: any skill directory that changed against its merge-base withmain,tests/excluded, must carry a strictly highermetadata.versionthan→ the same skill had at that merge-base (notmainmain's current tip; see→gates.md:90and:111-112, and the hook comment at.pre-commit-config.yaml:203-206gates.md:86and:100-113, and the hook comment at.pre-commit-config.yaml:194-197, repointed at4b17703after4de5b6bshifted both files. Amended in the 2026-09-16 review round: the gate now also compares against theorigin/maintip; see §11.); new, renamed and deleted skills are exempt; every plugin is covered,binincluded. Recorded as a dated section in ADR-0022, not a new ADR. The 17 skills changed on this branch without a bump took a patch bump in the same commit. Theexecutables.allowpin and the inerttagPatternare left as the note above recommends. -
The SessionStart hook auto-updates the install on every startup.
check-apm-current.shrunsapm outdated(network, 60 s timeout) and thenapm update --yes(300 s timeout) at every session start, rewritingapm.lock.yaml. That is why the lock file is dirty at the start of this session and whyAGENTS.mdhas to explain "commit or discard it deliberately". It is a 60-line script with a 368-line test, an ADR (0019), theexecutables.allowpin, and a sync hook behind it. For a repo that is its own source, the update belongs ininstall.shor a manualapm update, not in session startup. Effort S to remove; the design question is whether auto-update at startup is wanted at all.Refuted (2026-09-14, at HEAD
062ca47). The evidence is inverted: the finding cites as proof of over-eagerness a session in which the mechanism did not fire, and the observed state is the exact silent failure ADR-0019 exists to prevent.The update is conditional, not unconditional.
check-apm-current.sh:42-43capturesapm outdatedandexit 0s unless the output matchesoutdated dependenc(y|ies) found. The staleness test is a real SHA comparison (apm_cli/commands/outdated.py, git-branch branch) of the lockfile'sresolved_commitagainst the remote tip. On a current install the cost is one ~0.8 s check and no lock rewrite — confirmed by timed probe.hooks.jsonalso declares"matcher": "startup"only, so--resume/--continue/post-compact sessions never fire it (ADR-0019 sub-decision 3)."That is why the lock file is dirty at the start of this session" is false. The session-start
git statusreads(clean)andapm.lock.yamlwas unmodified. Meanwhileapm outdatedreports 6 outdated dependencies — the install sits 9 commits behindmain, right now, with nothing reporting it. The hook did not run.ADR-0019 pre-answers the finding's core argument, Context ¶3: "Refreshing on push assumes the person who pushes is the person who goes stale, which is backwards: your install goes stale when someone else merges, and a push of your own is neither necessary nor sufficient for it to have happened." "For a repo that is its own source" conflates authoring source with installed content — under ADR-0018 this repo consumes its own plugins as unpinned git refs against the remote default branch, so a session loads
main, never the working tree (AGENTS.md states this). Being its own source makes it more exposed, not less: it is the only consumer whose authors routinely hold uninstalled edits and may assume they are live. The ADR also pre-rejects a manualapm update(sub-decision 1), accepting the dirty-lock cost deliberately — the AGENTS.md line the finding reads as evidence of a problem is the ADR's documented consequence.scripts/install.shhas no apm step at all — it installs git hooks and deploysproviders/claude-code/, and runs once at setup, so it structurally cannot address staleness caused by someone else merging later. The proposed destination does not exist. Footprint is also understated: six files, 1,096 lines. And the claimed saving largely evaporates — deleting theexecutables.allowblock turns apm's trust gate off for all six packages, a security regression ADR-0019 deliberately closed, so it must be retained in some form andcheck-executables-allow-sync(222 + 243) only becomes droppable if reduced to a non-version-keyed form.Recommendation: keep the hook. Cost is 0.8 s on a current install; offline it fails fast (0.81 s, status
unknown, grep misses, exit 0 — the 60 s timeout is a bound, not a latency). The benefit guards a failure that is silent by construction and that the repo is exhibiting right now.Two things worth fixing, neither of which is removal. (1) ADR-0019's ~10.4 s refresh figure is now ~18 s measured warm on a LAN remote — it is quoted in the
timeout: 380invariant reasoning and understates by 75%. (2) An undocumented branch hazard, and the strongest argument the finding could have made: the hook resolves against the remote default branch, so on a feature branch that changesplugins/, an auto-refresh reinstallsmain's version over it. Reproduced — runningapm updatetoday re-installsmain'splugins/bin/.mcp.jsonand writes back the obsidian MCP server that commitc96ca9cremoved on this branch. That deserves a line in ADR-0019's Consequences; the proportionate fix if it bites is ~3 lines skipping the refresh whenHEADis not the default branch.Decided and done (2026-09-16, grill): document, do not skip. Both follow-ups landed in ADR-0019. The refresh figure is re-measured at ~24–26 s (two runs, six packages behind), not the ~18 s above — still inside the 360 s the
timeout: 380invariant covers. The branch hazard is a new Consequences paragraph, written after it fired in this very session: the startup refresh redeployedmain'sskill-audit/agent-auditand theobsidianserver over this branch. Skipping the refresh off the default branch was rejected — it would freeze the session on an oldermainwithout making the branch live. -
Outputs and packages for consumers that do not exist. Thecodexoutput profile generates.agents/plugins/marketplace.json(95 lines) although Codex is not a supported consumer. Themattpocock-skillsremote package entry is the only reasonapm-marketplace-checkneeds the network, and its pin is advanced by hand (ADR-0015). The.github/plugin/marketplace.jsonmirror is a legacy path (finding 2). Removing all three leaves one generated marketplace manifest (the per-pluginplugin.jsonpairs remain) and no network-dependent hook. Effort S.Done (2026-09-13): see commit
568ca74ondocs/simplification-audit. Removed thecodexoutput profile from rootapm.ymland its compiled.agents/plugins/marketplace.json(95 lines), and themattpocock-skillsremote package entry — the only remote marketplace entry, soapm-marketplace-checkandapm-pack-check-cleanno longer need network access at all. UpdatedREADME.md,AGENTS.md,docs/spec/gates.md, anddocs/spec/architecture.mdaccordingly; added one-line superseded/updated notes to ADR-0015 and ADR-0021. Left.github/plugin/marketplace.jsonuntouched — that's the Copilot legacy-path question in finding 2/§8, out of scope here; only re-ran the sync script to keep it consistent.apm.lock.yamlunaffected (marketplace.packages[]isn't part of the lockfile). Verified viaapm install,apm pack --marketplace=claude --check-versions, and all four affected pre-push hooks. Both carve-outs overtaken the next day (2026-09-14, verified ata6434e0): neither survives, and the finding's headline outcome — "one generated marketplace manifest, no network-dependent hook" — is now literally true rather than approximately so.- "The per-plugin
plugin.jsonpairs remain" is void. All twelve were deleted in718c79a(ADR-0024);git ls-files '*plugin.json'returns nothing. The only tracked manifest left anywhere is the root.claude-plugin/marketplace.json. (The root.claude-plugin/plugin.jsonbeside it is untracked localapm packoutput, ignored at.gitignore:59.) - "Left
.github/plugin/marketplace.jsonuntouched … out of scope here" is void the same day:0dffff3deleted it under finding 2c, along withscripts/sync-marketplace-mirror.shand its test. The "only re-ran the sync script to keep it consistent" step above refers tosync-plugin-content.sh, itself deleted in718c79a.
- "The per-plugin
-
The release-tag mechanism guards an external contract with no known consumer..pre-commit-hooks.yamlexports three hooks for other repos to pin byrev: <tag>.check-release-needed(242 lines + 442 test),test-vale-hooks-consumer(270 lines), ADR-0014, and three tags exist to serve that. If no other repo pins these hooks today, the whole mechanism can be deferred until one does. Effort S.Verified (2026-09-14, at HEAD
062ca47): premise holds — the only premise in this audit to survive verification, though not the finding whole:test-vale-hooks-consumer.shis 272 lines, not 270. Not yet decided; deferred by the human on 2026-09-14.Exact: three exported hooks (
kyberforge-vale-audit-skill,kyberforge-vale-audit-agent,kyberforge-skill-size-check),check-release-needed.sh242, its test 442, three tags (v1.0.0,v2.0.0,v2.0.1).test-vale-hooks-consumer.shis 272 lines, not 270.Consumer evidence: none found, near-conclusive for this instance. The Gitea instance holds exactly two repos; the other (
Defame1297/ansible-homelab-mono) pins seven hook repos in its.pre-commit-config.yaml— conventional-pre-commit, gitleaks, jumanjihouse, yamllint, ansible-lint, pre-commit/pre-commit-hooks, pluslocalandmeta— none referencing this repo or any of the three hook ids. All 13 commits touching the mechanism are self-authored fixes found by this repo's own tests; none traces to a reported external breakage.test-vale-hooks-consumer.shbuilds a synthetic consumer inmktemp— a genuine regression test that caught a genuine shipped bug (LESSONS.md:101), simulating nobody who exists. Off-instance clones remain undeterminable. ADR-0024 already ruled this standard sufficient four commits earlier, deleting the 20,000-line mirror as "maintained for an audience of zero".The README documents a contradictory contract — "For external consumers" says consume through apm, "apm is the only supported install path", and never mentions
.pre-commit-hooks.yamlorrev:pinning.The mechanism is already failing at its one job.
scripts/skill-size-check.shchanged onorigin/mainin598a7c3afterv2.0.1, with no tag cut since — a consumer pinningrev: v2.0.1gets a stale hook today. The gate cannot fire: it is wholly gated onPRE_COMMIT_REMOTE_BRANCH == refs/heads/main, and PRs merge through Gitea's server-side button, which sets nothing. The script's own header documents this as needing "a server-side CI job, which this repo does not have yet".The premise that it serves only the external contract holds — all three exported hooks are separately wired internally via
repo: local(→.pre-commit-config.yaml:216,249,258→.pre-commit-config.yaml:221,254,269.pre-commit-config.yaml:212,245,260, the threeentry:lines), so deleting the export costs zero internal lint coverage.Correction to the finding: ADR-0014 gets amended, not retired. Its primary decision — moving Vale config/styles/wrapper into
skill-audit/assets/vale/andagent-audit/assets/vale/, self-locating from${BASH_SOURCE[0]}so the prefilter works at runtime in any repo installing kyberforge — is independent of the release-tag mechanism and stands on its own. Only the.pre-commit-hooks.yamlhalf and the tag consequence retire.Removal is ~1,000 lines and mechanical:
.pre-commit-hooks.yaml,check-release-needed.sh, both tests, the hook block at→.pre-commit-config.yaml:194-201.pre-commit-config.yaml:186-193, the→gates.md:83gates.md:96row and its "External consumers" section (gates.md:789). Tags are inert and can stay. The one real loss:test-vale-hooks-consumer.shis the sole test exercising the entry-resolution path that once shipped broken — it goes only with the manifest, never while it stays. Reversal cost is bounded provided ADR-0014 andLESSONS.md:101,105are kept: they preserve theentry[0]-only constraint that took three review rounds to find.Repointed (2026-09-16, at HEAD
b426460): the line citations in this note were taken at062ca47and have shifted. Thecheck-release-neededblock is now.pre-commit-config.yaml:186-193(grep -n "id: check-release-needed"); the three internalrepo: localwirings'entry:lines are:221(skill-size-check),:254and:269(the twovale-audit-prefilter-*hooks, both now onfactory-audit's onevale-wrap.sh); thecheck-release-neededtable row isgates.md:96and the "External consumers" section heading isgates.md:789. Verified withgrep -nandsed -n. Line counts in this note were not re-measured.Repointed again (2026-09-16, at
4b17703):4de5b6bremoved thecheck-release-neededblock, so the threeentry:lines are now:212,:245and:260. Thecheck-release-neededtable row and the "External consumers" section no longer exist ingates.md; the same commit deleted them, so the:96and:789citations above are historical.Decided and done (2026-09-16): see commit
4de5b6bondocs/simplification-audit. The human took the deferred decision: remove the mechanism. Deleted.pre-commit-hooks.yaml(31 lines),scripts/check-release-needed.sh(242),tests/test-check-release-needed.sh(449 at HEAD, not the 442 above) andtests/test-vale-hooks-consumer.sh(276 at HEAD, not 272), plus thecheck-release-neededhook block, for 1,443 lines removed and 234 added across 20 files. ADR-0014 is amended, not retired, as the note above says: its runtime bundling decision stands, and the amendment records why the export went and keeps theentry[0]-only constraint (LESSONS.md:101,105) in case it returns. ADR-0025 gets a pointer to that amendment. Tags are left in place. One cost the finding did not count:tests/test-vale-wrap.shcase 33, the cross-manifestfiles:drift check, and case 28's hook-scope half both read the published manifest and went with it. Case 33's one guard that did not need a second manifest, a local regex narrowed to one plugin, is now a third property of case 32, with its own mutation test, so that coverage is kept.gates.mdnow counts 8 authored pre-push hooks (10 reported), no longer 9 (11). -
Two.mcp.jsonfiles declare an Obsidian vault server overdocs/(root andplugins/bin/; the other five plugin.mcp.jsonfiles are empty stubs), whileAGENTS.mdforbids using an external memory system for this repo. If the Obsidian tools are unused, drop both and thereinject_mcp_serversexplanation in the bin README; the binplugin.jsonpair regenerates. Effort S.Not proceeding (2026-09-13): premise doesn't hold. The server exposes the repo's own git-tracked
docs/folder — not an external/off-repo store — so it isn't the "external memory system" AGENTS.md's rule targets. It was deliberately added and versioned (3 commits), is documented as current intended behavior in both READMEs, and ADR-0018 uses it as its only concrete worked example of apm's MCP-dependency propagation mechanism actually working. No skill invokes the Obsidian tools as a workflow step, but that alone doesn't make the config dead. No changes made; recommend a human confirm whether the vault tooling is still wanted before removing it. Confirmed and done (2026-09-14): the human confirmed the vault tooling is not wanted — remove it entirely. All seven.mcp.jsonfiles deleted (the six plugin-root files and the repo-root one), and the repo-root path added to.gitignoreso a localapmrun cannot recreate it as tracked content. The bin README'sreinject_mcp_serversexplanation goes with it; theplugin.jsonpair the finding expected to regenerate no longer exists (deleted in718c79a, finding 7).What made this urgent is the substantive discovery, not the tidying: deleting the per-plugin
plugin.jsonmanifests in718c79ahad already broken MCP propagation silently.apm_cli/deps/plugin_parser.pymaps a plugin-root.mcp.json→.apm/.mcp.json, and that code path runs only for marketplace plugins — with no manifest, apm never reads the file.plugins/bin/apm.ymldeclaresdependencies.mcp: [], so the supported mechanism was never used either. Proved on ref-pinned consumer clones: at the parent commit a consumer gets anobsidianserver, at HEAD it gets none, and on upgrade apm printsRemoved stale MCP server 'obsidian' from .mcp.json— which would in time have stripped the server from this repo's own tracked.mcp.jsononce the lock re-resolved. Deleting the files makes the intent match the behaviour instead of leaving a config that silently does nothing. -
pc-author/pc-run(689 lines) carry generic pre-commit documentation.hooks-by-language.md(128 lines) andfailure-patterns.md(133) restate pre-commit.com. Keep the skills, trim to the house-specific rules. Effort S.Corrected then done (2026-09-13): see commit
a622200ondocs/simplification-audit. Independent re-verification found the 689-line figure overstated (actual combined size 598 lines) and the realistic cut smaller than a rewrite (~60-85 lines, concentrated in the two named reference files, not the SKILL.md files or the four short flow files, which are house-specific gates rather than restatement). Landed within that range:hooks-by-language.md128 → 92 lines (collapsed six per-language tables repeating the same repo/rev/rationale into one shared-repo table plus a small other-repos table);failure-patterns.md133 → 109 lines (removed generic SSH/proxy and shellcheck SC-code restatement, compressed generic schema-error bullets). Kept verbatim: both "Unverified — not in research corpus" flags, the rev-freshness caveat, thertk git add -u/rtk git commitfix (ADR-0023), and thepre-commit install -fwarning. Combined cut: 60 lines. Flat mirror regenerated and verified byte-identical.
7. Suggested order
- Quick wins, all S, no design decisions needed: findings 9, 10, 26, 30, 31, 29, 12, 13, 1, 6, 4, 35, 37, 38, and the mirror-sync and executables-allow halves of 2. Removes roughly 25,000 to 30,000 lines and 6 hooks.
- Structural changes that need a short discussion:
14,15,19,20,23,25,17,3,5,7,33,34,36. - The real complexity:
16 (validators),11 (provenance),24 (core),8 and 28 (gates.md and ADRs).
Status (2026-09-16, after the grill on 33, 28, 22/18, 20, 8, 34): open findings were 15 (merge
skill-author+agent-author) and 36 (release-tag mechanism, decision deferred by the human). 22 is deferred with the rest ofbin. Every other finding is done, closed, or refuted at its own note.Updated (2026-09-16, later): 36 is decided and done (
4de5b6b), so 15 is the only open finding. 22 stays deferred withbin.Updated (2026-09-16, after the finding 15 grill): 15 is refuted on measurement (see its note), so no finding is open. 22 stays deferred with
bin.Complete (2026-09-16). The follow-up read after 15 closed turned up four loose ends, all now settled: finding 6's
check-apm-agents-validfold (not proceeding, see its note); finding 27's dangling always-on pointer (constitution moved tocore/and deployed,adaa978); finding 5's differential-suite speed-up (not proceeding, see its note); and finding 16's resolver-sourcing option (done,ef27c97). Nothing in this audit is open. 22 is out of scope withbinand, by the human's decision, is not tracked anywhere.
Re-derived (2026-09-16, at HEAD): this ordering was written before the findings were worked, and
seven of its entries are now closed→all but two→all but one→ all of its bucket-2 and bucket-3 entries are now closed (corrected later on 2026-09-16, after the grill, and again once 36 closed and once 15 was refuted). Struck above: 14 landed (→467bbd7620f20b, ADR-0025); 7 was superseded then done (718c79a); 3, 5 and 19 are not proceeding on refuted premises;34,16 and 24 are refuted outright; 34 was refuted as a removal and then decided and done as documentation of the branch hazard in ADR-0019 (afcf477), with the hook kept; 33 was decided and done (enforce the bump,8451169); 8, 20 and 28 closed at the grill; 17, 23 and 25 were declined by the human; 11 was declined by the human; 36 was done (4de5b6b).5 is left standing but is downstream of 16 by its own note, so it cannot be taken in this bucket's order.5 is closed with 16: its own note says it is downstream of 16, and 16 is refuted.Still open, per the Status note above: 15 alone, now that 36 is done (15 was refuted on measurement after its own grill, so none is still open; 22 is deferred with4de5b6b);bin. Read each finding's own marker, not this list — it is a plan of record, not a status board. Bucket 1 is left as written: every entry in it is marked[x]or carries a decision note at its own finding. (Updated 2026-09-16:)[x]now marks every closed finding, whatever the outcome — done, refuted, declined or not proceeding; read the note for which. The only finding without one is 22, deferred withbin.
Findings 9, 10, 11, and 12 are coupled through the provenance validator and the audit criteria; land them together or the audit gates start reporting the removals.
8. Questions to settle before starting
Native Claude Code marketplace install vs apm-only. The flat mirror,check-plugin-content-sync, and ADR-0017 exist only for nativeclaude plugin install. If apm install is the only supported path, the mirror and its 2,100 lines of tooling go away. Which install paths must work for consumers?Answered (2026-09-14): apm-only. See ADR-0024 (
docs/adr/0024-apm-is-the-only-supported-install-path.md) and commit718c79aondocs/simplification-audit. Nativeclaude plugin installsupport is dropped; the flat mirror, the twelve per-plugin manifests,sync-plugin-content.sh, its test suite,lib/marketplace-plugins.sh, and thecheck-plugin-content-syncandvalidate-pluginshooks are all deleted (245 files changed, −22,602 lines). ADR-0017 carries a superseded banner. Kept deliberately: the rootmarketplace:block and the root.claude-plugin/marketplace.json, which apm's own consumers read. (marketplace.jsonis the only tracked file under.claude-plugin/; the rootplugin.jsonbeside it is untracked localapm packoutput, ignored at.gitignore:59.) This answer is what voided finding 7's recommendation and closed §3'scheck-plugin-content-synctarget.Copilot CLI legacy path. Is.github/plugin/marketplace.jsonstill read by any Copilot version you target? If not, finding 2c is a pure delete.Answered (2026-09-14): yes, but only as a preferred path, not a required one — so the delete holds. Settled under finding 2c above and executed in commit
0dffff3; this bullet was left open by oversight when that finding closed. Copilot CLI falls throughmarketplace.json,.plugin/marketplace.json,.github/plugin/marketplace.json,.claude-plugin/marketplace.jsonin order, and the.claude-plugin/file apm already emits satisfies the last step.What was lost is discovery-order preference, not Copilot consumability.Corrected (2026-09-14, later the same day, verified at
a6434e0): "not Copilot consumability" no longer holds. It was true at0dffff3;718c79a(ADR-0024) then removed native install support for both hosts, and Copilot consumability went with it. The fallback still resolves — that part stands — but it now resolves to a catalogue of six packages whose roots contain no content:ls plugins/*/shows.apm/,apm.yml,docs/and a README, andplugins/*/skills,.../agents,.../hooksdo not exist at all.The mechanism is host-independent, which is why this bullet had to change. ADR-0024 consequence 1 and §9's first residual both state it for Claude Code: a native registration succeeds and installs six plugins containing zero skills, silently. Nothing in that chain is Claude-specific. The catalogue is a list of plugin roots; discovery of content inside a root is a convention-scan of flat
skills//agents//hooks/directories, and that is the layout718c79adeleted. Whichever of the four paths a host resolves the catalogue through, it lands on the same empty roots. Copilot was in fact always the weaker case — ADR-0017's ownhooksamendment records that the mirror only ever partially served it.The delete still holds, for a stronger reason than the one given: the file was a preferred discovery path to content that no longer exists. What changed is the accepted cost — this is no longer "preference lost", it is the same accepted silent-empty-install residual §9 records, now known to apply to Copilot as well.
Provenance chain. Is "which upstream informed this file" a requirement you still want, or was it a governance experiment? Finding 11 hinges on this.Sharpened (2026-09-14): still open, but ask it of the producer first.
plugins/bin/.apm/skills/research/specifies thesources.md+source_keys:format and three evals inplugins/bin/evals/research/research/eval.yamlassert it. Ifresearchkeeps emitting the chain, finding 11 collapses to "delete the validators" and the metadata stays. See finding 11's verification note.Answered (2026-09-16): keep it. The human declined finding 11; the chain and its validators stay, and
researchkeeps producing it.ADR-0012 (three core skills) and the one-script-per-skill install constraint.The merges in 14, 15, and 24 need the first revisited and are the only way around the second.Corrected (2026-09-14): this grouping was wrong, and finding 2b's note has said so since0dffff3while this bullet said the opposite. ADR-0012 governs only thecoreplugin's threeagentsmd-*skills (agentsmd-author,agentsmd-audit,provider-adapter-author) — read it: it names those three and nothing else. Only finding 24 touches them, so only finding 24 needs ADR-0012 revisited. Findings 14 and 15 merge kyberforge'sskill-audit/agent-auditandskill-author/agent-author, which ADR-0012 does not govern; what constrains them is the self-containment rule, and merging is the way around it rather than a reason to reverse anything. That rule survives ADR-0024 — see §9's negative result and ADR-0024 consequence 6, which also correct its source: it is the agentskills.io spec for APM package mode, not a property of Claude Code's plugin cache-install as finding 2b's note assumed. The open question for 14/15 is a design one — onedescriptioncarrying both skills' trigger phrases — not an ADR supersession.Are you open to superseding ADR-0012, for finding 24?Closed on the 14/15 half (2026-09-16, at HEAD): finding 14 landed as
factory-auditon 2026-09-15 (→467bbd7620f20b, ADR-0025), and the design question this bullet holds open was answered by doing it — the merged description ships at 241 characters, inside the 250 SUGGESTION target, and the binding ceiling turned out to be the 900-word body, solved with a dispatch body overskill-*/agent-*reference files. See finding 14's own note. What remains open here is finding 15 (skill-author+agent-author) and the ADR-0012 question below, which the next note already answers. Moot (2026-09-14): finding 24 is refuted on arithmetic before this question is reached — the threecorebodies total 1,360 words againstBODY_MAX_WORDS=900, and their descriptions 806 chars against a 400 cap. Nothing needs superseding because the merge it would unblock cannot be committed. Question closed unless finding 24 is rewritten.Closed (2026-09-16): both halves are settled — finding 14 landed and finding 24 is refuted. The only finding left under this bullet is 15, which needs no ADR-0012 revisit (see above); its remaining question is the design one this bullet already names. Closed (2026-09-16, later): finding 15 is refuted on measurement — about 150–180 shared lines, and ADR-0020's exclusion holds. See its note in §4.2. Nothing remains open under this bullet.
Granularity of git/gitea skills. Onegitskill vs seven trades routing precision for size. Is one broad description acceptable?Answered by measurement (2026-09-14): no, and it is not a preference question. A merged git description measures 1,950 chars against a 400-char FAIL ceiling (4.9×) and a 3,381-word body against 900 (3.8×). Both proposed gitea halves also FAIL at 2.5×, and the gitea split additionally puts a hard boundary through the edit-a-file-then-open-a-PR workflow. (An earlier revision also called the gitea split "blocked by ADR-0011, which already rejected a smaller bundling" — withdrawn; ADR-0011's objection is to a boundary being crossed, not to bundle size. See finding 20's verification note.)
Answered (2026-09-16): keep the seven-and-seven granularity. Finding 20 closed at the grill as not proceeding, salvage included; see its closing note.
Auto-update at session start. Do you want the install refreshed from the remote every time a session opens (finding 34), or is a manualapm updateacceptable?Recommendation on evidence (2026-09-14): keep it; finding 34 refuted. The premise that it runs on every startup is false (the update is conditional on a real SHA check), the lock was not dirty, the hook did not fire this session, and the install is currently 9 commits behind
mainwith nothing reporting it — the failure the hook exists to prevent.install.sh, the proposed alternative host, has no apm step. Still formally the human's call, but the factual basis for removing it does not survive. See finding 34.Decided (2026-09-16, grill): keep the hook and document the feature-branch hazard; skipping the refresh off the default branch was rejected. Landed in ADR-0019 (
afcf477). See finding 34's closing note.External hook consumers. Does any other repo pin this repo's.pre-commit-hooks.yamlby tag today? If not, finding 36 defers the release mechanism entirely.Evidence gathered, decision deferred (2026-09-14). No consumer found: the Gitea instance holds two repos, and the other pins seven hook repos, none of them this one. No consumer-driven commit in the 13 touching the mechanism. Off-instance clones undeterminable — but ADR-0024 accepted exactly this standard when it deleted the mirror. The mechanism is additionally already broken (a consumer pinning
rev: v2.0.1gets a staleskill-size-check.sh, and the guard cannot fire through Gitea's merge button). The human deferred the decision on 2026-09-14; the finding is ready to execute when it is taken. See finding 36. Answered (2026-09-16): no consumer, and the human took the decision: the mechanism is removed (4de5b6b), and ADR-0014 is amended to record why. See finding 36.Obsidian MCP. Are the Obsidian tools overdocs/used by anyone? If not, finding 37 is a pure delete.Answered (2026-09-14): not used — remove entirely. All seven
.mcp.jsonfiles are deleted and the repo-root path is gitignored; see finding 37, which also records the functional regression this uncovered (since718c79adeleted the per-plugin manifests, apm no longer propagated the server to consumers at all).
9. Carried forward from the apm-only decision (2026-09-14)
Recorded here so they are not rediscovered as defects. All follow from commit 718c79a / ADR-0024.
Two accepted residuals.
- Native install still half-works, and cannot be prevented. apm reuses Claude's catalogue format by design, so a Claude Code user can still register holocron natively and will install six plugins containing zero skills. Accepted, not overlooked: no schema change closes this, because the format that makes it possible is the format apm's own consumers need.
- Consumers now receive test fixtures. apm installs from
.apm/, which carries thetests/directories the mirror used to strip, so a consumer installing from this branch receives 10.batsfiles across 6 skills, plus those skills' 6tests/README.mdfiles — 16 files. (Repo-wide, 17 tracked paths contain/tests/: the 10.batsand 7README.md, one of which is a template asset underskill-author/assets/templates/tests/and is not a test fixture.) This is what consumers receive, not what this checkout shows:.claude/skills/here currently holds zero.batsfiles, because that deployed tree is stale and predates this branch. The mechanism was confirmed empirically on a ref-pinned consumer clone — the 16 files are absent at the parent commit and present at HEAD. Suppressing them means switching all sixapm.ymlfiles fromincludes: autoto explicit lists, where a wrong list silently drops content — worse failure mode than the noise. Deferred deliberately.
Negative result — do not re-litigate. Deleting native install does not relax the self-containment constraint. plugins/kyberforge/.apm/skills/skill-author/references/deployment-modes.md, sourced from the agentskills.io spec, states it independently for APM package mode: the spec defines no cross-skill sharing. So findings 14 and 15 still require → finding 14 required merging skills (done, ADR-0025), and finding 15 would have too (refuted on measurement, 2026-09-16); sharing one file between two skills remains impossible, and §8's "one-script-per-skill install constraint" bullet is unchanged by this decision.
Accepted gap — symlinks under .apm/. ADR-0017's check_apm_symlinks() was the only thing reporting that symlinks under .apm/ do not survive to a consumer. It is gone, and no replacement guard is being added — the human decided to accept the gap.
The mechanism is not the bundle exporter, as ADR-0017 assumed; it is the install path, and it has since been verified. apm_cli/security/gate.py's ignore_non_content() is a shutil.copytree ignore callback whose docstring says "Excludes symlinks (security)"; it is used at apm_cli/integration/skill_integrator.py:424, :791 and :1152. Materialization into apm_modules/ dereferences first, so symlinked content survives there and is dropped when skills are deployed out of it. ADR-0024 flagged the prediction as unverified; it holds, with that corrected attribution. No symlinks exist under any .apm/ today, so nothing is broken now — but the next one added there will silently not reach consumers, and nothing will say so.
10. Verification wave (2026-09-14)
Ten open findings with claimed yield — 11, 16, 20, 22, 24, 27, 28, 33, 34, 36 — were each re-checked against the files by an independent read-only agent, at HEAD 062ca47. Findings 14 and 15 were deliberately excluded: their blocker is a design decision, not a premise. Results are recorded in each finding's own note above.
Read this section before acting on any remaining finding.
Why the wave was run
This audit was written read-only, and its scope estimates are systematically optimistic. Before the wave, ten findings had been examined closely in the course of implementing them: 3, 19 and 37 each cost a full agent run to conclude "premise doesn't hold", and 2d, 29, 31 and 38 each needed correcting mid-implementation. Findings 5, 18 and 32 were then examined during a grill on 2026-09-14 and all three collapsed — 18's four examples were three different classes of load-bearing content, 5's suites turned out to be split by failure class rather than ADR section, and 32's proposed split already existed and was self-documenting in architecture.md.
That base rate made "effort S, no decisions needed" an unreliable signal, and §7's bucket 1 an unreliable plan. Dispatching implementation agents against unverified premises costs more than verifying first.
Outcome
| Finding | Verdict | Verified yield |
|---|---|---|
| 36 | Premise holds — the only one whose premise survived; one supporting figure wrong (272 lines, not 270) | ~1,000 lines |
| 33 | Headline wrong; one item empirically verified zero-risk | 6 lines, zero output diff |
| 28 | Headline accurate when measured (a3e721e), now stale; as written it is a wash (+5 to −1 lines); real win is elsewhere |
~235 lines |
| 22 | Percentages 3–4× inflated, wrong target set; better defect found | ~150–180 lines |
| 20 | Refuted — git 7→1 is 4.9× the description FAIL ceiling | ~230 lines salvage |
| 27 | Refuted — audience separation misread as duplication | ~168 words + a live bug |
| 11 | Direction defensible, two scope figures wrong; blocked on a decision it never poses | ~6,393 if unblocked |
| 16 | Refuted — its only safe saving belongs to finding 14 | 0 independent |
| 24 | Refuted — arithmetically impossible (1,360w vs a 900 cap) | 0 |
| 34 | Refuted — evidence inverted | 0 |
Dispositions since the wave (2026-09-16): this table records the verdicts at
062ca47and is left as written. Of the ten, none is still open: 36 was decided and done later the same day (4de5b6b), and before that it was the only open one. 33 and 34 are decided and done — the bump is enforced (8451169) and the feature-branch hazard is documented in ADR-0019 (afcf477), with the hook kept. 20 and 28 closed at the grill as not proceeding; 11 and 27 were declined by the human; 22 is deferred withbin. See each finding's own closing note.
One premise of ten survived — finding 36's — but not the finding whole: its supporting figure was wrong (test-vale-hooks-consumer.sh is 272 lines, not 270). The other nine premises failed.
The headline figure was wrong in at most eight of the ten, not all ten. Two exceptions, stated so the claim is not overstated:
- Finding 36 states no headline figure. Its headline is a claim — "the release-tag mechanism guards an external contract with no known consumer" — and the numbers appear only in a supporting sentence.
- Finding 34's stated figures are exact. "A 60-line script with a 368-line test" checks out at both ends (
plugins/kyberforge/.apm/hooks/check-apm-current.sh60,tests/test-apm-current-hook.sh368). Its note's only figure correction runs the other way — the footprint is understated at six files / 1,096 lines. What is refuted in 34 is the mechanism claim ("on every startup"), not an arithmetic error.
Three findings (16, 24, 34) are refuted outright; two (22, 28) contain a real finding different from the one written. Finding 28 is the one case where the headline was accurately measured and went stale: 2,740 lines / 72% in eight ADRs is exact at a3e721e, and the ADR-0024 wave moved it afterwards.
The recurring failure mode is worth naming, because it has now produced six wrong findings (3, 5, 16, 22, 24, and by implication 28): dense validator and test code with heavy comments reads as over-engineering when skimmed, and turns out to be regression coverage whose comments name the incident. Findings 16 and 24 propose reverting validators to sizes whose defects are on the commit record. Before proposing to cut any script or suite in this repo, read its header.
Where the real remaining opportunity is: Taken. Finding 14 (merge skill-audit + agent-audit) at −1,587 lines with zero coverage loss → −2,934 lines, which is also where finding 16's savings actually live. Its blocker is the design question in §8 — one That blocker was a non-issue; see the note below.description carrying both skills' trigger phrases — not an ADR supersession.
Executed, and one knock-on claim corrected (2026-09-15). Finding 14 landed as
factory-audit(ADR-0025); yield 2,934 lines and one pre-push hook, and the §8 blocker turned out to be a non-issue. The body was the binding ceiling, not the description, which ships at 241 characters, under the 250 target, once a duplicated trigger register was removed. See finding 14's own note for the corrections.The merge does not unblock
check-scope-walkup-sync, and nothing in this audit should be read as saying it does. §3's finding 2 bullet says that gate "disappears if the ports share one script or the skills merge"; the second half of that is wrong, and the first is unreachable. The gate cross-checks four independent$HOME/.git/apm.ymlwalk-up ports, and only two of them are in the audit pair (validate.sh'sdetect_scope,validate-provenance.sh'sfind_plugin_root). The other two —new-agent.sh's andnew-skill.sh'sfind_package_root— live in the author skills, whichfinding 15 has not merged→ stay separate now that finding 15 is refuted (2026-09-16), and which could not be merged into the audit skill in any case. Four ports go to four ports.It cannot degrade into a text diff either, which is the shape that would let it be deleted rather than merely shrunk: the two audit-side ports are Python (
def detect_scope,def find_plugin_root, inside heredocs) and the two author-side ports are Bash functions. Byte-comparing them is not an option at any point on this path, so the behavioural fixture cross-check is the only available form of the gate. It survives finding 15 too.
check-vale-style-syncwas the only one of the two "keep two copies in sync" gates that finding 14 could remove, which is why the yield is one hook and not two.
Two defects to fix independently of any finding
A live bug in always-on context.Fixed (2026-09-15). The deployedcore/instructions/governance.mdciteddocs/HUMANS.md, which does not exist — the file isdocs/wiki/HUMANS.md. Five occurrences across three files (governance.md:82, which was self-inconsistent against its own correct line 73;CONTROLS.md:5,101,106;ai-constitution.md:238), in a file@-imported into every session in every project. All five now point atdocs/wiki/HUMANS.md.Note the deployed copy underDeployed (2026-09-16): the fixed file was copied to~/.claude/no longer matches the repo untilscripts/install.shre-runs.~/.claude/core/instructions/governance.mdanddiff -rq core ~/.claude/coreis clean.install.shitself was deliberately not run: it overwrites~/.claude/settings.jsonwholesale, and the deployed copy carried machine-local keys (model,extraKnownMarketplaces,autoMemoryEnabled, notification flags) that the repo'sproviders/claude-code/settings.jsondoes not.- This checkout's install is stale and there is a branch hazard. At the time of the wave
apm outdatedreported 6 outdated dependencies, 9 commits behindmain, with a clean tree and nothing reporting it. Do not runapm updateon this branch — it resolves againstmainand restores the obsidian MCP server that commitc96ca9cremoved here. Reproduced. The mechanism is worse than "reinstallsplugins/bin/.mcp.json": apm never writes intoplugins/, it re-materialises the file underapm_modules/and regenerates the repo-root/.mcp.json— whichc96ca9cgitignored, so the restoration would not appear ingit statusat all. This belongs in ADR-0019's Consequences; see finding 34.Landed (2026-09-16): commit
afcf477amended ADR-0019's Consequences with the feature-branch hazard, and the discard guidance for a feature branch is now also inAGENTS.mdandREADME.md(dd0b923). The reason those two files and ADR-0019 gave for discarding the lock was wrong, and the review round below corrected it. See finding 34's closing note.
11. Review round on the grill commits (2026-09-16)
A review of this branch's grill commits (8451169 through b426460) raised the findings below. Each was decided in this round and fixed on this branch. Several agents made the fixes in parallel. This note records the decisions. It does not re-verify the details of fixes it did not make itself: for those, read the named file or ADR.
- Version-bump gate baseline. The gate now also compares against the
origin/maintip, as well as the merge-base. ADR-0022 is amended to match. This supersedes the merge-base-only wording in finding 33's closing note. - Version-bump gate parsing. Frontmatter that starts with a BOM, and version components with leading zeros, are now parsed correctly.
- Version-bump gate tests. The gaps the review found in
tests/test-skill-version-bump.share closed. - Plugin patch bumps. Five plugins took a patch bump:
bin,git,gitea,coreandlint. kyberforge was already at2.0.0on this branch and needed no further bump. - Root
apm.ymldescriptions. Thepackages[].description:duplicates are dropped, following theversion:lines2def060already removed. ADR-0021 is amended. This is not a version location, so finding 33's corrected count (one per plugin, two for kyberforge) is unaffected. - Remote-entry
version:guidance. Theapm-workflowreferences now give the right guidance on a remote marketplace entry'sversion:. - Lock-file discard reasoning.
README.md,AGENTS.mdand ADR-0019's 2026-09-16 amendment used to say to discard the refreshed lock on a feature branch "because it recordsmain's commit, not the branch's". That was wrong: the branch's committed lock records amaincommit too, just an older one. In this checkout it isb7bec71, whichgit branch -r --containsfinds onorigin/main. All three now give the real reasons. Discarding keeps unrelated lock churn out of the branch diff, and it keeps the deployed tree consistent with the lock thatapm pack --check-cleanreads. They also state the cost: the session runs the oldermainuntil the next session start refreshes again. The SessionStart notice incheck-apm-current.shnow gives branch-specific advice, andtests/test-apm-current-hook.shpins it. ADR-0019 had two claims that were checked against apm's source.apm pack"refuses to run": precisely, it raises a build error before the--check-cleangate is reached, and only when a file the lock lists is missing on disk (bundle/packer.py,pack_bundle). apm "removes a server on its next update": this holds, and it holds forapm installas well (install/mcp/integration.py,MCPIntegrator.remove_stale). The amendment now says both precisely. - ADR-0022 amendment. The amendment's placement and the validator names it cites are fixed.
12. Final review round on the whole branch (2026-09-16)
Seven parallel reviewers went over the whole branch against main, each covering one area: the gate scripts, a full test and hook run, references to removed files, kyberforge, the other five plugins, the docs and ADRs, and this document. The full suite and every hook passed at 55221d0. Nothing still pointed at a removed file, and no finding marked done was missing. The fixes below landed after that review.
Fixed:
- Duplicated
SessionStartentry on a fresh install (3a9d257). apm recognises its ownsettings.jsonentries only through the.claude/apm-hooks.jsonsidecar. With the sidecar gitignored, a fresh clone'sapm installadded a second copy of the entry andapm audit --cireported drift. This was reproduced onmaintoo. The sidecar is now committed and excluded frompretty-format-json, and ADR-0019 carries a correction. - Version-bump gate frontmatter shape (
614a0d5).read_versionnow accepts the leading whitespace thatskill-size-checkalready accepts, and case 39 pins it. The hook entry now describes the main-tip check. - README advice in the size checks (
8ce5392).skill-size-checkand factory-audit's validator no longer tell authors to move detail to a README, since skills no longer have one. - Test runners inside a Claude worktree (
7380bed). The runners' worktree exclusion is now relative to the search root, so they also work when the repo itself is a Claude worktree. - Catalog version and Copilot wording (
2574391). The catalog is bumped0.4.7→0.5.0: removing an entry is a minor change under apm-workflow's marketplace policy. The Copilot wording now says Copilot is reached through apm. - Stale doc claims (
1f3d4f9):- ADR-0014 carries a correction:
skill-size-checksources the resolver sinceef27c97. - ADR-0017's status line now matches its supersession.
architecture.mdandgates.mdcarry the current duplication counts.- "Vacuous green" is defined where
gates.mduses it. - The gitleaks lesson is marked historical.
- ADR-0014 carries a correction:
- Bare-
gitrule ingit-commits(0323c29). The general rule is restored. - Retrofit cut order in
skill-author(baa2f5d). The ordered cuts are restored inline, and the stale hook name and plugin-mode wording are fixed. - Stale hashes and figures in this document (this commit). Hashes left by the branch rewrite are corrected in place.
a8cd5e8andc59e4bfare annotated as unreachable, with their content in598a7c3. The case 33 lines are struck. The §1 table, thegates.mdlength and the ADR share are re-measured atbaa2f5d. The document moves todocs/notes/.
Declined:
- Removing the remaining
(ADR-0023)tags. They are the opt-out markerscheck-rtk-prefixrequires on deliberately bare git commands, so removing them would fail that hook. - Fixing the constitution path in
plugins/kyberforge/docs/research/examples/skill-write/. That directory is a frozen research snapshot of a retired skill. - Restoring factory-audit's dropped trigger phrases. Removing them was deliberate under ADR-0020's duplicate-wording rule.
- Checking every ref in a multi-ref push. The version-bump gate checks only one ref per push. That is pre-commit's behaviour and is documented; closing the gap needs a server-side CI check, not a hook change.
Open follow-ups:
- Gitea #101. Close it through this branch's PR with
Closes #101. A comment is posted. - Gitea #66. It needs re-scoping, because its
.mcp.jsontarget is gone. A comment is posted. - The dropped
LESSONS.mdentry. The entry saying that "read at session start" is only a hope was removed, and no issue tracks it. - The ADR-0020 constants. They could move into the shared library that
skill-size-checknow sources, which would remove the last duplicated copy. - The
a8cd5e8citations.scripts/skill-size-check.shandtests/test-skill-size-check.shstill citea8cd5e8, which no branch reaches.598a7c3is the reachable equivalent.