Defame1297
8cd5c79c0a
Plugin scope now authors a single vendor-neutral .apm/agents/<name>.agent.md file (name/description/model/body only) instead of a Claude Code + Copilot CLI pair, per ADR-0016: apm compile has no per-target field integrator, so tools: and all Claude-only fields (isolation/maxTurns/effort/memory/ permissionMode) are omitted entirely rather than shipping a value that's guaranteed wrong on one harness. Scope detection switches from a flat plugin.json check to the same apm.yml+type: walk-up agent-audit's validate.sh already uses. Project scope and user scope are unaffected — both keep the existing dual-file pair model. Refs: #89
256 lines
8.9 KiB
Bash
256 lines
8.9 KiB
Bash
#!/usr/bin/env bats
|
|
|
|
setup() {
|
|
REPO_ROOT="$(cd "$BATS_TEST_DIRNAME/../../../../../" && pwd)"
|
|
load "$REPO_ROOT/tests/test_helper/bats-support/load"
|
|
load "$REPO_ROOT/tests/test_helper/bats-assert/load"
|
|
|
|
SCRIPT="$(cd "$BATS_TEST_DIRNAME/../scripts" && pwd)/new-agent.sh"
|
|
ROOT="$(mktemp -d)"
|
|
}
|
|
|
|
teardown() {
|
|
rm -rf "$ROOT"
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Help
|
|
# ---------------------------------------------------------------------------
|
|
|
|
@test "--help exits 0" {
|
|
run bash "$SCRIPT" --help
|
|
assert_success
|
|
assert_output --partial "Usage:"
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Plugin/APM scope (type:-bearing apm.yml at root)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
@test "plugin/APM scope: creates single agent file in .apm/agents/" {
|
|
printf 'name: my-package\ntype: skill\n' > "$ROOT/apm.yml"
|
|
run bash "$SCRIPT" my-agent "$ROOT"
|
|
assert_success
|
|
assert [ -f "$ROOT/.apm/agents/my-agent.agent.md" ]
|
|
}
|
|
|
|
@test "plugin/APM scope: does not create the old dual-file pair" {
|
|
printf 'name: my-package\ntype: skill\n' > "$ROOT/apm.yml"
|
|
run bash "$SCRIPT" my-agent "$ROOT"
|
|
assert_success
|
|
assert [ ! -f "$ROOT/agents/my-agent.md" ]
|
|
assert [ ! -f "$ROOT/agents/my-agent.agent.md" ]
|
|
}
|
|
|
|
@test "plugin/APM scope: creates .apm/agents/ directory if missing" {
|
|
printf 'name: my-package\ntype: skill\n' > "$ROOT/apm.yml"
|
|
run bash "$SCRIPT" my-agent "$ROOT"
|
|
assert_success
|
|
assert [ -d "$ROOT/.apm/agents" ]
|
|
}
|
|
|
|
@test "plugin/APM scope: creates sources.md at package root" {
|
|
printf 'name: my-package\ntype: skill\n' > "$ROOT/apm.yml"
|
|
run bash "$SCRIPT" my-agent "$ROOT"
|
|
assert_success
|
|
assert [ -f "$ROOT/sources.md" ]
|
|
}
|
|
|
|
@test "plugin/APM scope: no-op if agent file already exists" {
|
|
printf 'name: my-package\ntype: skill\n' > "$ROOT/apm.yml"
|
|
mkdir -p "$ROOT/.apm/agents"
|
|
echo "existing" > "$ROOT/.apm/agents/my-agent.agent.md"
|
|
run bash "$SCRIPT" my-agent "$ROOT"
|
|
assert_success
|
|
run grep "existing" "$ROOT/.apm/agents/my-agent.agent.md"
|
|
assert_success
|
|
}
|
|
|
|
@test "plugin/APM scope: frontmatter has no tools/isolation/maxTurns/effort/memory/permissionMode keys" {
|
|
printf 'name: my-package\ntype: skill\n' > "$ROOT/apm.yml"
|
|
bash "$SCRIPT" my-agent "$ROOT"
|
|
file="$ROOT/.apm/agents/my-agent.agent.md"
|
|
fm="$(sed -n '/^---$/,/^---$/p' "$file")"
|
|
# Column-0 key lines only — comment bodies in the template are indented,
|
|
# so this anchor naturally excludes commented-out example fields.
|
|
run grep -E '^(tools|isolation|maxTurns|effort|memory|permissionMode|disallowedTools|skills|color|initialPrompt|background|hooks|mcpServers):' <<< "$fm"
|
|
assert_failure
|
|
}
|
|
|
|
@test "plugin/APM scope: frontmatter carries only name, description, model, source_keys fields" {
|
|
printf 'name: my-package\ntype: skill\n' > "$ROOT/apm.yml"
|
|
bash "$SCRIPT" my-agent "$ROOT"
|
|
file="$ROOT/.apm/agents/my-agent.agent.md"
|
|
fm="$(sed -n '/^---$/,/^---$/p' "$file")"
|
|
keys="$(grep -oE '^[a-zA-Z][a-zA-Z0-9_-]*:' <<< "$fm" | sed 's/:$//' | sort -u)"
|
|
for key in $keys; do
|
|
if [[ "$key" != "name" && "$key" != "description" && "$key" != "model" && "$key" != "source_keys" ]]; then
|
|
fail "unexpected frontmatter key: $key"
|
|
fi
|
|
done
|
|
}
|
|
|
|
@test "plugin/APM scope: sources.md contributing-files template mentions the single-file path" {
|
|
printf 'name: my-package\ntype: skill\n' > "$ROOT/apm.yml"
|
|
bash "$SCRIPT" my-agent "$ROOT"
|
|
run grep ".apm/agents/<name>.agent.md" "$ROOT/sources.md"
|
|
assert_success
|
|
}
|
|
|
|
@test "plugin/APM scope: template AGENT_NAME substituted" {
|
|
printf 'name: my-package\ntype: skill\n' > "$ROOT/apm.yml"
|
|
bash "$SCRIPT" my-agent "$ROOT"
|
|
run grep "my-agent" "$ROOT/.apm/agents/my-agent.agent.md"
|
|
assert_success
|
|
}
|
|
|
|
@test "plugin/APM scope: walk-up finds apm.yml at an ancestor directory, not just root arg" {
|
|
printf 'name: my-package\ntype: skill\n' > "$ROOT/apm.yml"
|
|
mkdir -p "$ROOT/nested/subdir"
|
|
run bash "$SCRIPT" my-agent "$ROOT/nested/subdir"
|
|
assert_success
|
|
assert [ -f "$ROOT/.apm/agents/my-agent.agent.md" ]
|
|
}
|
|
|
|
@test "plugin/APM scope: apm.yml without type: is skipped (marketplace-only manifest)" {
|
|
printf 'name: my-marketplace\n' > "$ROOT/apm.yml"
|
|
mkdir -p "$ROOT/.git"
|
|
run bash "$SCRIPT" my-agent "$ROOT"
|
|
assert_success
|
|
assert [ ! -f "$ROOT/.apm/agents/my-agent.agent.md" ]
|
|
assert [ -f "$ROOT/.claude/agents/my-agent.md" ]
|
|
}
|
|
|
|
@test "plugin/APM scope: type:-less apm.yml at leaf falls through to a type:-bearing apm.yml higher up" {
|
|
printf 'name: outer-package\ntype: skill\n' > "$ROOT/apm.yml"
|
|
mkdir -p "$ROOT/inner"
|
|
printf 'name: inner-marketplace\n' > "$ROOT/inner/apm.yml"
|
|
run bash "$SCRIPT" my-agent "$ROOT/inner"
|
|
assert_success
|
|
assert [ -f "$ROOT/.apm/agents/my-agent.agent.md" ]
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Old plugin.json marker is no longer recognized (full switch, no dual-mode)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
@test "bare plugin.json (no apm.yml) is no longer detected as plugin scope — falls through to project scope" {
|
|
touch "$ROOT/plugin.json"
|
|
run bash "$SCRIPT" my-agent "$ROOT"
|
|
assert_success
|
|
assert [ ! -f "$ROOT/agents/my-agent.md" ]
|
|
assert [ ! -f "$ROOT/agents/my-agent.agent.md" ]
|
|
assert [ ! -f "$ROOT/.apm/agents/my-agent.agent.md" ]
|
|
assert [ -f "$ROOT/.claude/agents/my-agent.md" ]
|
|
assert [ -f "$ROOT/.github/agents/my-agent.agent.md" ]
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Non-plugin (project) scope
|
|
# ---------------------------------------------------------------------------
|
|
|
|
@test "non-plugin scope: creates claude code file in .claude/agents/" {
|
|
run bash "$SCRIPT" my-agent "$ROOT"
|
|
assert_success
|
|
assert [ -f "$ROOT/.claude/agents/my-agent.md" ]
|
|
}
|
|
|
|
@test "non-plugin scope: creates copilot file in .github/agents/" {
|
|
run bash "$SCRIPT" my-agent "$ROOT"
|
|
assert_success
|
|
assert [ -f "$ROOT/.github/agents/my-agent.agent.md" ]
|
|
}
|
|
|
|
@test "non-plugin scope: creates .claude/agents/ directory if missing" {
|
|
run bash "$SCRIPT" my-agent "$ROOT"
|
|
assert_success
|
|
assert [ -d "$ROOT/.claude/agents" ]
|
|
}
|
|
|
|
@test "non-plugin scope: creates .github/agents/ directory if missing" {
|
|
run bash "$SCRIPT" my-agent "$ROOT"
|
|
assert_success
|
|
assert [ -d "$ROOT/.github/agents" ]
|
|
}
|
|
|
|
@test "non-plugin scope: no sources.md created" {
|
|
run bash "$SCRIPT" my-agent "$ROOT"
|
|
assert_success
|
|
assert [ ! -f "$ROOT/.claude/agents/sources.md" ]
|
|
assert [ ! -f "$ROOT/.github/agents/sources.md" ]
|
|
}
|
|
|
|
@test "non-plugin scope: no-op if claude code file already exists" {
|
|
mkdir -p "$ROOT/.claude/agents"
|
|
echo "existing" > "$ROOT/.claude/agents/my-agent.md"
|
|
run bash "$SCRIPT" my-agent "$ROOT"
|
|
assert_success
|
|
run grep "existing" "$ROOT/.claude/agents/my-agent.md"
|
|
assert_success
|
|
}
|
|
|
|
@test "project scope: detected via .git present above root, output still relative to root arg" {
|
|
mkdir -p "$ROOT/repo/.git"
|
|
mkdir -p "$ROOT/repo/pkg"
|
|
run bash "$SCRIPT" my-agent "$ROOT/repo/pkg"
|
|
assert_success
|
|
assert [ -f "$ROOT/repo/pkg/.claude/agents/my-agent.md" ]
|
|
assert [ -f "$ROOT/repo/pkg/.github/agents/my-agent.agent.md" ]
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# User scope
|
|
# ---------------------------------------------------------------------------
|
|
|
|
@test "user scope: root exactly \$HOME creates files under ~/.claude and ~/.copilot" {
|
|
FAKE_HOME="$(mktemp -d)"
|
|
run env HOME="$FAKE_HOME" bash "$SCRIPT" my-agent "~"
|
|
assert_success
|
|
assert [ -f "$FAKE_HOME/.claude/agents/my-agent.md" ]
|
|
assert [ -f "$FAKE_HOME/.copilot/agents/my-agent.agent.md" ]
|
|
rm -rf "$FAKE_HOME"
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Name validation
|
|
# ---------------------------------------------------------------------------
|
|
|
|
@test "fails when no arguments given" {
|
|
run bash "$SCRIPT"
|
|
assert_failure
|
|
}
|
|
|
|
@test "fails when agent name contains uppercase" {
|
|
run bash "$SCRIPT" MyAgent "$ROOT"
|
|
assert_failure
|
|
}
|
|
|
|
@test "fails when agent name has consecutive hyphens" {
|
|
run bash "$SCRIPT" my--agent "$ROOT"
|
|
assert_failure
|
|
}
|
|
|
|
@test "fails when agent name has a leading hyphen" {
|
|
run bash "$SCRIPT" -my-agent "$ROOT"
|
|
assert_failure
|
|
}
|
|
|
|
@test "fails when agent name has a trailing hyphen" {
|
|
run bash "$SCRIPT" my-agent- "$ROOT"
|
|
assert_failure
|
|
}
|
|
|
|
@test "agent name with numbers is valid" {
|
|
run bash "$SCRIPT" agent-v2 "$ROOT"
|
|
assert_success
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Root validation
|
|
# ---------------------------------------------------------------------------
|
|
|
|
@test "fails when root directory does not exist" {
|
|
run bash "$SCRIPT" my-agent "/nonexistent/path"
|
|
assert_failure
|
|
}
|