Files

Defame1297 d98d0dae18 chore: migrate legacy pre-commit hook to .pre-commit-config.yaml

Replaces shell script (.git/hooks/pre-commit.legacy) with ecosystem-managed pre-commit framework:
- gitleaks/gitleaks: secret scanning
- jumanjihouse/pre-commit-hooks: shellcheck wrapper
- pre-commit/pre-commit-hooks: JSON/YAML validation, end-of-file-fixer, trailing-whitespace
- local hooks: SKILL.md frontmatter validation

Uses pinned versions for reproducibility across environments. Includes auto-fixes from hook runs (formatting, trailing whitespace, JSON beautification).

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

2026-06-27 18:54:37 +00:00

2.8 KiB

Raw Blame History

0016 — Second grill: skill implementation workflow

Type: HITL Parent PRD: docs/prd/chunk-3-skills-library.md

What to build

Run a dedicated grill session on the general skill implementation workflow before any skill is written. The PRD identifies this as the first issue after the AGENTS.md prerequisite — the grill produces the working conventions applied to all subsequent skill issues (0017–0028).

The grill covers:

Per-skill process steps: trigger-first, eval-first, upstream review, source: field population
How the factory/write-eval-first bootstrap works in practice (hand-written eval for write-eval itself; write-eval used for all subsequent skills)
Working conventions for refactors (existing Pocock skills) vs new skills
How to handle a skill that combines patterns from multiple upstream sources
The upstream review process at chunk start: what to check, what to record, how to decide whether to pull changes in
Any open questions from the PRD flagged as "refine during implementation" (PRD/issue template scope, bidirectional reference convention in skill frontmatter)

Output is documented in docs/notes/skill-implementation-workflow.md, used to update docs/prd/chunk-3-skills-library.md with any decisions made, and used to refine issues 0017–0028 with specific acceptance criteria.

HITL: requires human participation in the grill session.

Acceptance criteria

Grill session completed covering all topics above
docs/notes/skill-implementation-workflow.md written with the agreed working conventions
docs/prd/chunk-3-skills-library.md updated with any decisions that change or extend the Implementation Decisions section
Issues 0017–0028 updated with specific acceptance criteria derived from the grill output
HITL: human participates in grill, reviews conventions, and approves before implementation of any skill begins

Handoff

Status: complete Files produced:

docs/notes/skill-implementation-workflow.md

Key decisions:

Step 6 (session handoff) added post-grill: each skill session closes by appending a ## Handoff section to the skill's issue file. Cross-cutting observations go to LESSONS.md immediately, not batched to chunk end.
Handoff artifact is the issue file, not a separate docs/notes/ file — avoids proliferating per-skill note files.

Open threads:

when: full bidirectional reference convention — deferred to Chunk 4
PRD/issue template scope — refined during 0019/0020 implementation
Merging zoom-out into architect role — revisit at Chunk 5 grill

Next session start:

Load: CONTEXT.md, docs/notes/skill-implementation-workflow.md, issue 0017 or 0018
First action: Step 1 (source discovery) for write-eval

Blocked by

0015 (AGENTS.md refactor must be complete so grill references stable file structure)

2.8 KiB Raw Blame History Unescape Escape