Files

Defame1297 38f1ba4e03 fix(kyberforge): bridge apm content to Claude Code's flat plugin discovery

Claude Code's (and Copilot's) native plugin installer has zero awareness of
.apm/ nesting -- it convention-scans only flat skills/, agents/, commands/,
hooks.json at each plugin's root. Confirmed via strings on the installed
claude binary and live installs of git@holocron/gitea@holocron/kyberforge@
holocron, all reporting Skills(0) Agents(0) Hooks(0) post ADR-0015's apm
conversion. Root cause (apm_cli/core/plugin_manifest.py): apm's plugin.json
compiler deliberately strips skills/agents/commands keys, assuming the host
already auto-discovers those convention directories -- it has no model of
.apm/ being host-visible at all. Separately, apm's own bundle exporter
(apm_cli/bundle/plugin_exporter.py, behind `apm pack --format plugin`)
implements the correct .apm/ -> flat mapping, but only ever targeted
build/<name>-<version>/, a path nothing in marketplace.json's source: points
at.

scripts/sync-plugin-content.sh wraps that bundle exporter and copies its
agents/, skills/, commands/, instructions/, extensions/, and merged
hooks.json back into each plugin's own root as a second tracked
compiled-output category -- same governance status as
.claude-plugin/plugin.json: generated from .apm/, never hand-edited. tests/
subdirectories are excluded from the mirror (dev fixtures, not host-visible
runtime content; several hardcode a relative repo-root walk-up sized for the
.apm/-nested depth, which breaks when duplicated one level shallower).
Applied for real across all 6 plugins and verified two ways: `claude plugin
validate --strict` passes on every real plugin directory, and a live
`claude --plugin-dir <path> -p "list skills/agents"` behavioral test
confirms content is now actually discovered.

Also, from the same issue #90 review round:
- scripts/check-manifests.sh pointed at each plugin's root-level plugin.json
  (checking skills/hooks/mcpServers/agents pointer fields) -- that file was a
  stale near-duplicate of .claude-plugin/plugin.json nothing else read or
  wrote, now deleted across all 6 plugins. check-manifests.sh is rewritten to
  validate .claude-plugin/plugin.json instead, and drops the pointer-field
  checks entirely (nothing to check -- those fields are correctly absent by
  design). Content-presence drift is now check-plugin-content-sync's job, a
  new pre-push hook wired in .pre-commit-config.yaml.

docs/adr/0017 records the root cause and decision in full, including two
rejected alternatives (patching plugin.json's path fields directly -- apm's
compiler strips them on every run; pointing marketplace.json at apm pack's
build/ output -- a version-suffixed non-source directory nothing can install
from without an extra build step). ADR-0015 and CONTEXT.md are updated to
point at it.

Refs: #90

2026-08-13 16:59:03 +00:00

4.9 KiB

Raw Blame History

source_keys

conventional-commits-spec

commitlint-config-conventional

Conventional Commits Specification (v1.0.0)

Conventional Commits is a lightweight convention on top of commit messages that provides a set of rules for creating an explicit commit history. It enables automated tooling (CHANGELOG generation, semantic version bumping) and structured filtering.

Message Format

<type>[optional scope]: <description>

[optional body]

[optional footer(s)]

Each section is separated by a blank line. The header is the only required part.

Rules

Element	Rule
`type`	Required. Lowercase noun.
`scope`	Optional. Noun in parentheses directly after type: `feat(api):`.
`description`	Required. Immediately follows `type/scope:` . Imperative mood, no trailing period.
`body`	Optional. Begins one blank line after description. Free-form prose, multiple paragraphs allowed. Lines max 100 characters.
`footer(s)`	Optional. Begins one blank line after body (or description). `<token>: <value>` format. Lines max 100 characters.
`BREAKING CHANGE`	Must be uppercase. Either a footer token or signalled by `!` before the colon.

Standard Types

The spec itself mandates only feat and fix. The 11-type set below is the de-facto standard from @commitlint/config-conventional (Angular commit message guidelines), not a spec requirement — but it is what this skill validates against.

11-type set (commitlint/config-conventional)

Type	Meaning	SemVer impact	Appears in CHANGELOG
`feat`	New user-visible feature	MINOR	Yes
`fix`	Bug fix	PATCH	Yes
`perf`	Performance improvement, no API change	PATCH	Yes
`revert`	Reverts a previous commit	PATCH	Yes
`docs`	Documentation only	none	No
`style`	Formatting, whitespace — no logic change	none	No
`refactor`	Code restructuring — no feature or fix	none	No
`test`	Adding or fixing tests	none	No
`build`	Build system or external dependency changes	none	No
`ci`	CI configuration and scripts	none	No
`chore`	Anything not fitting above	none	No

A BREAKING CHANGE footer or ! on any type always triggers a MAJOR bump.

Breaking Changes

Two equivalent notations:

! in header (preferred — visible in git log --oneline):

feat!: drop support for Node 6
feat(api)!: remove deprecated endpoint

BREAKING CHANGE footer (machine-readable body):

feat: allow config to extend other configs

BREAKING CHANGE: `extends` key now used for extending config files

Both together (most explicit):

feat!: drop support for Node 6

BREAKING CHANGE: use JavaScript features not available in Node 6.

Rules:

BREAKING CHANGE must be all caps.
BREAKING-CHANGE (hyphenated) is an accepted synonym.
Any type can carry a breaking change, not just feat.
The footer value must describe what broke.

Footer Token Rules

<token>: <value>
<token> #<value>    # for issue references

Tokens use hyphens for word separation: Reviewed-by, Co-authored-by, Refs.
Exception: BREAKING CHANGE (space allowed, uppercase).
Multiple footers allowed, one per line.
Blank line required before the footer block.

Valid footer examples:

Reviewed-by: Z
Refs: #123
Co-authored-by: Alice <alice@example.com>
BREAKING CHANGE: the `--format` flag now requires a value

Examples

Minimal — no body, no footer:

docs: correct spelling of CHANGELOG

With scope:

feat(lang): add Polish language

Breaking change via !:

feat!: send an email to the customer when a product is shipped

Breaking change via footer:

feat: allow provided config object to extend other configs

BREAKING CHANGE: `extends` key in config file is now used for extending other config files

Multi-paragraph body with multiple footers:

fix: prevent racing of requests

Introduce a request id and a reference to latest request. Dismiss
incoming responses other than from latest request.

Remove timeouts which were used to mitigate the racing issue but are
obsolete now.

Reviewed-by: Z
Refs: #123

Revert:

revert: let us never again speak of the noodle incident

Refs: 676104e, a215868

commitlint Constraints (config-conventional)

Constraint	Value
Header max length	100 characters
Subject must not end with `.`	enforced
Subject must be lowercase (not sentence-case or UPPER-CASE)	enforced
Body / footer line max length	100 characters
Type must be one of the 11 standard types	error if not
Blank line before body	warning
Blank line before footer	warning

SemVer Mapping Summary

Condition	SemVer bump
`fix`, `perf`, `revert`	PATCH
`feat`	MINOR
Any type with `BREAKING CHANGE` or `!`	MAJOR
All other types (`docs`, `style`, `refactor`, `test`, `build`, `ci`, `chore`)	none

4.9 KiB Raw Blame History