Defame1297
b6e68e9a2b
Three ways the gates could report green having measured nothing. All three were
invisible to a passing test suite, because pre-commit prints nothing at all for a
hook that exits 0 — a gate that declines to check and a gate that checked and
passed produce the identical signal.
- A UTF-8 BOM, a leading blank line, a trailing space after a `---` marker or
CRLF line endings defeated the `^---\n` frontmatter matcher. Every ADR-0020
check was then skipped and the file passed: measured at the time, a
550-character description with a 1,000-word body exited 0 behind a BOM.
All four shapes are now tolerated, and frontmatter that genuinely cannot be
parsed is a hard ERROR rather than a silent skip.
- An agent file with a valueless `description:` followed by another key let a
line regex capture the *next* key, which looked non-empty, so the
missing-or-empty branch never fired and every gate below it early-returned on
the empty folded value — zero output, exit 0, on a blocking gate. The one
field this contract is entirely about was the one field a gate could fail to
notice was absent. Presence is now decided on the YAML-folded value and
nowhere else, and a missing or empty description is a hard FAIL in all three
validators.
- The hand-rolled frontmatter fallback disagreed with PyYAML across the FAIL
boundary on folded scalars, so which reader happened to be available decided
the verdict. A fallback that mis-parses a scalar shape reports a vacuous pass,
which is worse than not running, so it is deleted: python3 and PyYAML are hard
requirements that fail loudly with an install pointer.
Boundary-target resolution no longer derives its universe from its own location.
A `${BASH_SOURCE}`-relative repo root leaked this repo's 39-skill universe into
every consumer repo running the hook through pre-commit, so a consumer skill
routing to `skill-audit` resolved against a plugin it had never installed. The
interim form resolved through `.claude/` and `.agents/`, which are gitignored
`apm install` output — the same commit reported 2 dangling targets on a machine
that had run the install and 6 on a fresh clone. Resolution now walks up from the
file being checked to an authoring root (nearest ancestor holding
`plugins/*/.apm/{skills,agents}`, else the nearest `.git`, in two passes so a
nested `.git` cannot outrank a real monorepo root); the universe is every skill
and agent under `<root>/plugins/*/` plus the file's own apm package and that
package's declared `dependencies.apm`. Deployed trees are consulted only when no
authoring root exists at all — the consumer case. One commit now gets one verdict,
which a gate shipping hot with no baseline file has to.
Narrowed in the same pass: a routing target inferred from the prose boundary form
and corroborated by nothing else reports at SUGGESTION instead of blocking. A
blocking check with no escape hatch is the wrong trade when the inference from
prose is the weak part of it.
New deterministic checks, all previously untested or absent: every
`references/<file>.md` a body names must exist (ERROR — a broken pointer is not a
style opinion); a description with no boundary clause at all, a Gotchas section
over five entries, and a Gotchas section over 25% of the body are SUGGESTIONs.
Where no universe can be determined the target check prints `INFO ... DID NOT
RUN` rather than passing quietly. Each prose-scanning check needed its own
false-positive fix — a fenced example of a Gotchas section was being read as the
section itself — and those fixes are pinned rather than assumed.
The resolver is one block copied verbatim into all three scripts between
BEGIN/END markers, because a cache-installed plugin's scripts cannot read outside
their own plugin directory. Nothing asserted the copies were still identical; a
one-line edit to a single copy passed every constant-agreement assertion, since
constants are not what drifts.
Tests land here rather than in a later commit. The existing suites assert the old
behaviour and go red against these scripts, so splitting them would leave a commit
whose own `run-tests` pre-push gate fails in isolation.
Refs: ADR-0020
1259 lines
59 KiB
Bash
Executable File
1259 lines
59 KiB
Bash
Executable File
#!/usr/bin/env bash
|
||
set -euo pipefail
|
||
|
||
usage() {
|
||
cat <<EOF
|
||
Usage: validate.sh <agent-file>
|
||
|
||
Validate an agent definition file against the agent definition spec.
|
||
|
||
At plugin/APM scope, <agent-file> is a single vendor-neutral
|
||
.apm/agents/<name>.agent.md file with no counterpart. Its frontmatter allowlist
|
||
is not restated here: it is read at load time from the apm-agent-allowlist
|
||
section of references/field-inventory.md, which is the authoritative list.
|
||
At project or user scope, <agent-file> is either half of a Claude Code .md /
|
||
Copilot .agent.md pair.
|
||
|
||
Arguments:
|
||
agent-file Path to the agent file (or either half of a project/user-scope pair).
|
||
|
||
Exit codes:
|
||
0 All checks passed (may include SUGGESTIONs)
|
||
1 One or more checks failed
|
||
2 Script error (unrecognized file extension or missing field-inventory.md)
|
||
EOF
|
||
}
|
||
|
||
if [[ "${1:-}" == "--help" || "${1:-}" == "-h" ]]; then
|
||
usage
|
||
exit 0
|
||
fi
|
||
|
||
if [[ $# -lt 1 ]]; then
|
||
echo "Error: agent-file is required." >&2
|
||
echo "" >&2
|
||
usage >&2
|
||
exit 1
|
||
fi
|
||
|
||
# PyYAML is a HARD dependency, not a nice-to-have. The description VALUE has to
|
||
# be measured after YAML folding is resolved, and the hand-rolled reader that
|
||
# used to stand in for PyYAML disagreed with it across the 400-character FAIL
|
||
# boundary — same description, two verdicts, depending on which reader ran.
|
||
# Refusing to start is the only honest option; the repo's jq / apm / vale
|
||
# dependencies are declared the same way.
|
||
# Check the interpreter separately from the library: `python3 -c` fails the same
|
||
# way whether python3 is missing or PyYAML is, and reporting the wrong missing
|
||
# dependency sends the reader to install the wrong thing.
|
||
if ! command -v python3 > /dev/null 2>&1; then
|
||
echo "Error: python3 is required but was not found on PATH." >&2
|
||
echo " Why: skipping the ADR-0020 description and boundary-target gates would be a vacuous pass." >&2
|
||
echo " Fix: install python3 (pre-commit itself is a Python application, so it is almost certainly already present)." >&2
|
||
exit 1
|
||
fi
|
||
|
||
if ! python3 -c 'import yaml' > /dev/null 2>&1; then
|
||
echo "Error: PyYAML is required but is not importable by python3." >&2
|
||
echo " Why: skipping the ADR-0020 description and boundary-target gates would be a vacuous pass." >&2
|
||
echo " Fix: python3 -m pip install PyYAML (or your distro's python3-yaml package)." >&2
|
||
exit 1
|
||
fi
|
||
|
||
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
||
|
||
python3 -u - "$1" "$SCRIPT_DIR" <<'PYTHON'
|
||
import sys
|
||
import os
|
||
import re
|
||
import glob
|
||
|
||
import yaml
|
||
|
||
agent_file = os.path.abspath(sys.argv[1])
|
||
script_dir = sys.argv[2]
|
||
|
||
fname = os.path.basename(agent_file)
|
||
|
||
# --- Detect provider (check .agent.md before .md) ---
|
||
if fname.endswith('.agent.md'):
|
||
provider = 'copilot'
|
||
name_stem = fname[:-len('.agent.md')]
|
||
elif fname.endswith('.md'):
|
||
provider = 'claude-code'
|
||
name_stem = fname[:-len('.md')]
|
||
else:
|
||
print(f"Error: unrecognized extension '{fname}' — expected .md or .agent.md", file=sys.stderr)
|
||
sys.exit(2)
|
||
|
||
# --- Load field-inventory.md ---
|
||
inv_path = os.path.normpath(os.path.join(script_dir, '..', 'references', 'field-inventory.md'))
|
||
if not os.path.isfile(inv_path):
|
||
print(f"Error: field-inventory.md not found at {inv_path}", file=sys.stderr)
|
||
sys.exit(2)
|
||
|
||
# Encoding is pinned to UTF-8 rather than inherited from the locale: under
|
||
# LC_ALL=C the inherited default is ASCII, and this file legitimately carries
|
||
# non-ASCII prose. read_text() in the shared resolver block below does the same
|
||
# thing for every other file; this one is read before that block is defined.
|
||
try:
|
||
with open(inv_path, encoding='utf-8') as f:
|
||
inv_content = f.read()
|
||
except UnicodeDecodeError as exc:
|
||
print(f"Error: field-inventory.md at {inv_path} is not valid UTF-8 "
|
||
f"({exc.reason} at byte {exc.start}) — re-save it as UTF-8.",
|
||
file=sys.stderr)
|
||
sys.exit(2)
|
||
|
||
def parse_section_tokens(content, section_name):
|
||
lines = content.splitlines()
|
||
for i, line in enumerate(lines):
|
||
if line.strip() == f'## {section_name}':
|
||
for j in range(i + 1, len(lines)):
|
||
stripped = lines[j].strip()
|
||
if stripped and not stripped.startswith('#') and not stripped.startswith('---'):
|
||
return set(stripped.split())
|
||
return set()
|
||
|
||
cc_only_fields = parse_section_tokens(inv_content, 'claude-code-only-fields')
|
||
copilot_only_fields = parse_section_tokens(inv_content, 'copilot-only-fields')
|
||
apm_agent_allowlist = parse_section_tokens(inv_content, 'apm-agent-allowlist')
|
||
|
||
# Tools the runtime withholds from subagents regardless of the tools field
|
||
SUBAGENT_UNAVAILABLE_TOOLS = {
|
||
'AskUserQuestion', 'EnterPlanMode', 'ExitPlanMode', 'ScheduleWakeup', 'WaitForMcpServers',
|
||
}
|
||
|
||
# Copilot body length limit (chars) — content beyond this is silently truncated
|
||
COPILOT_BODY_LIMIT = 30000
|
||
|
||
# ADR-0020 description budget. An agent's name + description is preloaded into
|
||
# every session exactly like a skill's, so agents take the SAME description
|
||
# gates. These two constants are DUPLICATED from scripts/skill-size-check.sh
|
||
# and skill-audit/scripts/validate.sh rather than shared from one file: a
|
||
# cache-installed plugin's scripts cannot read files outside their own plugin
|
||
# directory, so there is no single source to share (same rationale as
|
||
# vale-wrap.sh's per-plugin duplication). tests/test-skill-size-check.sh
|
||
# asserts all copies agree, so drift fails CI rather than silently diverging.
|
||
#
|
||
# Agents deliberately take NO body word gate, and adding one here would
|
||
# contradict ADR-0020: a skill body is loaded into the caller's context and
|
||
# competes with the live conversation, while an agent body becomes the system
|
||
# prompt of a fresh context. The rationale for the 900-word skill ceiling does
|
||
# not transfer. Agent body length falls out of the delegation rule instead.
|
||
DESC_SUGGEST_CHARS = 250
|
||
DESC_MAX_CHARS = 400
|
||
|
||
# --- Helpers (shared by every scope) ---
|
||
failed = False
|
||
suggestions = []
|
||
|
||
def fail(msg):
|
||
# stderr, matching scripts/skill-size-check.sh's ERROR routing. All three
|
||
# scripts in the ADR-0020 family now agree: findings that fail the run go to
|
||
# stderr, everything advisory (SUGGESTION / INFO) goes to stdout. Both repo
|
||
# callers (check-apm-agents-valid.sh, check-scope-walkup-sync.sh) capture
|
||
# `2>&1`, so nothing a human reads moves.
|
||
global failed
|
||
failed = True
|
||
print(f"FAIL {msg}", file=sys.stderr)
|
||
|
||
def suggest(msg):
|
||
suggestions.append(msg)
|
||
|
||
def info(msg):
|
||
# A check that DECLINED to run says so out loud, rather than passing
|
||
# silently. Silence is what let a whole gate family go missing unnoticed.
|
||
print(f"INFO {msg}")
|
||
|
||
PLACEHOLDER_RE = re.compile(r'(?<!`)FILL IN:[^`\n]')
|
||
|
||
|
||
# ===== BEGIN ADR-0020 SHARED BOUNDARY RESOLVER =====
|
||
# ONE resolver, embedded VERBATIM in three scripts:
|
||
# scripts/skill-size-check.sh
|
||
# plugins/kyberforge/.apm/skills/skill-audit/scripts/validate.sh
|
||
# plugins/kyberforge/.apm/skills/agent-audit/scripts/validate.sh
|
||
# The block between these markers must stay byte-identical in all three. It is
|
||
# copied rather than imported because a cache-installed plugin's scripts cannot
|
||
# read files outside their own plugin directory, so there is no single file all
|
||
# three can share (same constraint that forces the ADR-0020 constants to be
|
||
# duplicated). Edit one copy, then paste it over the other two.
|
||
#
|
||
# Requires: glob, os, re, yaml (imported by the host script; PyYAML is a hard
|
||
# dependency, preflighted in bash before the interpreter starts).
|
||
|
||
# --- Input ----------------------------------------------------------------
|
||
# Every file this resolver's callers read goes through read_text(), which pins
|
||
# UTF-8 explicitly instead of inheriting locale.getpreferredencoding(). Under
|
||
# LC_ALL=C that inherited encoding is ASCII, so a perfectly ordinary em dash in
|
||
# a SKILL.md aborted the run with a bare UnicodeDecodeError traceback — loud,
|
||
# but pointing at the interpreter rather than at the file or the fix. A file
|
||
# that genuinely is not UTF-8 still fails; it just says so.
|
||
|
||
|
||
class EncodingError(Exception):
|
||
pass
|
||
|
||
|
||
def read_text(path):
|
||
"""File contents as text, UTF-8, with a diagnostic instead of a traceback."""
|
||
try:
|
||
with open(path, encoding='utf-8') as fh:
|
||
return fh.read()
|
||
except UnicodeDecodeError as exc:
|
||
raise EncodingError(
|
||
"not valid UTF-8 (%s at byte %d) — re-save the file as UTF-8; "
|
||
"this gate does not guess at other encodings"
|
||
% (exc.reason, exc.start))
|
||
|
||
|
||
# --- Universe ------------------------------------------------------------
|
||
# The set of names a boundary clause may resolve against is derived from an
|
||
# AUTHORING ROOT found by walking up FROM THE TARGET FILE. It is NEVER derived
|
||
# from this script's own location: deriving it from ${BASH_SOURCE} leaked
|
||
# holocron's 39-skill universe into every consumer repo that ran this hook
|
||
# through pre-commit, so a consumer skill routing to `skill-audit` resolved
|
||
# against a plugin it had never installed.
|
||
#
|
||
# An authoring root is the nearest ancestor holding plugins/*/.apm/skills/ or
|
||
# plugins/*/.apm/agents/ (a plugin monorepo), falling back to the nearest
|
||
# ancestor holding .git. When one is found the universe is:
|
||
# 1. every skill and agent under <root>/plugins/*/ — sibling plugins resolve,
|
||
# which is what a monorepo means,
|
||
# 2. the target's own apm package,
|
||
# 3. the packages that package DECLARES in apm.yml dependencies.apm.
|
||
# Deployed .claude/ and .agents/ trees are deliberately NOT consulted in that
|
||
# case. They are `apm install` output, gitignored, and present only on a machine
|
||
# that has run it: four cross-plugin targets in this repo (gitea-branches ->
|
||
# git-branches, gitea-branches -> git-history, gitea-issues -> git-branches,
|
||
# gitea-workflow -> git-workflow) resolved through .claude/skills/ alone, so the
|
||
# same commit measured 2 dangling targets on a developer machine and 6 on a
|
||
# fresh clone. A gate shipping hot with no baseline cannot give two answers.
|
||
#
|
||
# Deployed trees are used only when NO authoring root exists — the consumer
|
||
# case, where the file being checked lives in or beside a deployed tree and
|
||
# there is no monorepo to read.
|
||
|
||
|
||
def _is_fs_root(path):
|
||
return os.path.dirname(path) == path
|
||
|
||
|
||
def _collect_package(pkg_dir, names):
|
||
"""Add every skill/agent name a package directory exposes, any layout."""
|
||
for sub in ('.apm/skills/*/', 'skills/*/'):
|
||
for path in glob.glob(os.path.join(pkg_dir, sub)):
|
||
names.add(os.path.basename(path.rstrip('/')).lower())
|
||
for sub in ('.apm/agents/*.md', 'agents/*.md'):
|
||
for path in glob.glob(os.path.join(pkg_dir, sub)):
|
||
base = os.path.basename(path)
|
||
if base.endswith('.agent.md'):
|
||
base = base[:-len('.agent.md')]
|
||
else:
|
||
base = base[:-len('.md')]
|
||
names.add(base.lower())
|
||
|
||
|
||
def _apm_package_root(start_dir):
|
||
"""Nearest ancestor that is an apm package root (apm.yml or .apm/).
|
||
|
||
The filesystem root is never a candidate: a stray /.apm/skills/ — a
|
||
scaffolding test's leftover, say, and one really does exist on at least one
|
||
machine here — would otherwise become the package root of every path on it.
|
||
Capped at ten levels so a pathological path can't become a filesystem
|
||
crawl; that covers every real layout by a wide margin.
|
||
"""
|
||
current = os.path.abspath(start_dir)
|
||
for _ in range(10):
|
||
if _is_fs_root(current):
|
||
return None
|
||
if (os.path.isfile(os.path.join(current, 'apm.yml'))
|
||
or os.path.isdir(os.path.join(current, '.apm'))):
|
||
return current
|
||
current = os.path.dirname(current)
|
||
return None
|
||
|
||
|
||
def _authoring_root(start_dir):
|
||
"""Nearest ancestor that is a plugin monorepo, else the nearest .git tree.
|
||
|
||
Two passes, not one interleaved walk: a nested .git (a submodule, a
|
||
worktree of a sub-package) must not win over a real plugins/ root further
|
||
up. Both passes stop before the filesystem root for the same reason
|
||
_apm_package_root does.
|
||
"""
|
||
for probe in (
|
||
lambda d: bool(glob.glob(os.path.join(d, 'plugins', '*', '.apm', 'skills'))
|
||
or glob.glob(os.path.join(d, 'plugins', '*', '.apm', 'agents'))),
|
||
lambda d: os.path.exists(os.path.join(d, '.git'))):
|
||
current = os.path.abspath(start_dir)
|
||
for _ in range(12):
|
||
if _is_fs_root(current):
|
||
break
|
||
if probe(current):
|
||
return current
|
||
current = os.path.dirname(current)
|
||
return None
|
||
|
||
|
||
def _collect_authoring_root(root, names):
|
||
"""Every plugin in the monorepo contributes its names."""
|
||
for pkg in glob.glob(os.path.join(root, 'plugins', '*')):
|
||
if os.path.isdir(pkg):
|
||
_collect_package(pkg, names)
|
||
|
||
|
||
def _declared_dependency_dirs(pkg_dir):
|
||
"""Directories of the apm packages pkg_dir's manifest DECLARES.
|
||
|
||
Reads dependencies.apm and resolves each entry to a directory on disk:
|
||
a monorepo-relative `path:` (against the package root and the nearest
|
||
ancestor manifest, which is the monorepo root) or an installed
|
||
apm_modules/<name>/. Entries that resolve to nothing are skipped — an
|
||
undeployed dependency contributes no names rather than an error.
|
||
"""
|
||
manifest = os.path.join(pkg_dir, 'apm.yml')
|
||
if not os.path.isfile(manifest):
|
||
return []
|
||
try:
|
||
data = yaml.safe_load(read_text(manifest)) or {}
|
||
except Exception:
|
||
return []
|
||
if not isinstance(data, dict):
|
||
return []
|
||
deps = data.get('dependencies')
|
||
deps = deps.get('apm') if isinstance(deps, dict) else None
|
||
if not isinstance(deps, list):
|
||
return []
|
||
|
||
roots = [pkg_dir]
|
||
ancestor = os.path.dirname(os.path.abspath(pkg_dir))
|
||
for _ in range(10):
|
||
if _is_fs_root(ancestor):
|
||
break
|
||
if os.path.isfile(os.path.join(ancestor, 'apm.yml')):
|
||
roots.append(ancestor)
|
||
break
|
||
ancestor = os.path.dirname(ancestor)
|
||
|
||
found = []
|
||
for entry in deps:
|
||
candidates = []
|
||
if isinstance(entry, dict):
|
||
rel = entry.get('path')
|
||
name = entry.get('name')
|
||
if not name and rel:
|
||
name = os.path.basename(str(rel).rstrip('/'))
|
||
if rel:
|
||
candidates.extend(os.path.join(r, str(rel)) for r in roots)
|
||
if name:
|
||
candidates.append(os.path.join(pkg_dir, 'apm_modules', str(name)))
|
||
elif isinstance(entry, str):
|
||
name = re.split(r'[#@]', entry)[0].strip().rstrip('/').split('/')[-1]
|
||
if name:
|
||
candidates.append(os.path.join(pkg_dir, 'apm_modules', name))
|
||
candidates.extend(os.path.join(r, 'plugins', name) for r in roots)
|
||
for candidate in candidates:
|
||
if os.path.isdir(candidate):
|
||
found.append(candidate)
|
||
return found
|
||
|
||
|
||
def _deployed_roots(start_dir):
|
||
""".claude/ and .agents/ trees above start_dir — what a host really sees.
|
||
|
||
Consulted ONLY when no authoring root exists; see the section header. The
|
||
filesystem root is skipped for the same reason _apm_package_root skips it:
|
||
a stray /.claude/skills/ must not join every path's universe.
|
||
"""
|
||
found = []
|
||
current = os.path.abspath(start_dir)
|
||
for _ in range(10):
|
||
if _is_fs_root(current):
|
||
break
|
||
for name in ('.claude', '.agents'):
|
||
base = os.path.join(current, name)
|
||
if os.path.isdir(base):
|
||
found.append(base)
|
||
current = os.path.dirname(current)
|
||
return found
|
||
|
||
|
||
def known_targets(start_dir):
|
||
"""Every skill/agent name a boundary clause in start_dir may name."""
|
||
names = set()
|
||
start = os.path.abspath(start_dir)
|
||
|
||
# Siblings: a cache-installed plugin and a deployed .claude/skills/ tree
|
||
# both put peers one level up, with no plugins/ directory above them. The
|
||
# grandparent is guarded against the filesystem root exactly like the two
|
||
# walk-up loops above — for a start dir of /skills/<x> the grandparent is
|
||
# `/`, and collecting there picks up this machine's stray /.apm/skills/.
|
||
parent = os.path.dirname(start)
|
||
grandparent = os.path.dirname(parent)
|
||
if (os.path.basename(parent) in ('skills', 'agents')
|
||
and os.path.isdir(parent) and not _is_fs_root(grandparent)):
|
||
_collect_package(grandparent, names)
|
||
|
||
package = _apm_package_root(start)
|
||
if package:
|
||
_collect_package(package, names)
|
||
for dep_dir in _declared_dependency_dirs(package):
|
||
_collect_package(dep_dir, names)
|
||
|
||
root = _authoring_root(start)
|
||
if root:
|
||
_collect_authoring_root(root, names)
|
||
else:
|
||
for base in _deployed_roots(start):
|
||
_collect_package(base, names)
|
||
return names
|
||
|
||
|
||
# --- Extraction -----------------------------------------------------------
|
||
# False positives are the design constraint here, not recall. The rules:
|
||
# * A BARE target must be hyphenated AND sit in a boundary sentence (one
|
||
# carrying "do not"/"instead"/"rather than"/"not for"). Without the second
|
||
# condition, pc-run's "run pre-commit hooks" reads as a route to a
|
||
# non-existent `pre-commit` skill.
|
||
# * A BARE arrow target counts only in ADR-0020's compressed boundary form,
|
||
# `Not <thing> -> <skill-name>`. Without that, diagnose's process chain
|
||
# "fix -> regression-test" reads as a route to `regression-test`.
|
||
# * A backticked hyphenated token counts only inside a boundary sentence.
|
||
# Unconditionally, `pre-push` or `commit-msg` in a TRIGGER clause is a hard
|
||
# FAIL with no escape hatch. Gating it costs nothing (measured over this
|
||
# corpus: 54 targets before and after); DELETING it costs 7 real targets
|
||
# across three gitea skills, so it is gated, not removed.
|
||
# * SINGLE-WORD targets are deliberately NOT matchable bare — `research`,
|
||
# `triage`, `forge`, `prototype` and `tdd` are all real skill names and all
|
||
# ordinary English, so a bare-word rule would flag most of the corpus. A
|
||
# single-word target must be written `` `forge` `` or /forge to be seen.
|
||
# That is a known recall limitation, accepted over the false positives.
|
||
# Tool names (Read/Write/Edit) are excluded by the lowercase-only pattern; MCP
|
||
# tool names (issue_write) by its rejection of underscores; file names by its
|
||
# rejection of dots and slashes.
|
||
#
|
||
# ATTRIBUTIVE USE. The boundary-sentence gate above does NOT solve the
|
||
# `pre-commit` false positive, and the comment that claimed it did was wrong:
|
||
# "instead", "rather than", "do not" and "not for" are exactly the words a
|
||
# boundary clause uses, so the gate is open precisely where the risk is. All of
|
||
# these were hard dangling FAILs with no suppression:
|
||
# Use pre-commit hooks instead of ad-hoc scripts.
|
||
# Invoke the pull-request template instead of writing one by hand.
|
||
# Use conventional-commits formatting rather than free-form messages.
|
||
# Composes label-resolution logic instead of duplicating it.
|
||
# Do not use for X — run the `pre-push` hooks instead.
|
||
# What separates every one of them from a real route is grammar, not marking:
|
||
# the hyphenated token is a compound MODIFIER of the noun that follows it
|
||
# ("pre-commit hooks", "pull-request template"), where a route target is
|
||
# terminal — followed by punctuation, a conjunction, or a boundary word. So a
|
||
# target whose next token is an ordinary lowercase noun is CONFIRM-ONLY: it
|
||
# still resolves and still counts as a route when the name exists, but it can
|
||
# never raise a dangling error on its own.
|
||
#
|
||
# This is deliberately NOT the simpler "only marked targets may dangle" rule,
|
||
# which would have been wrong here: BOTH live true positives in this corpus are
|
||
# BARE — research's "(use neuledge-context)" and gitea-issues' "Composes
|
||
# gitea-labels-\n milestones", where the `>` fold yields "gitea-labels-
|
||
# milestones" and the trailing hyphen is what keeps it terminal. Marking is a
|
||
# poor proxy, so the follower token is the signal, and it is applied to
|
||
# backticked targets too.
|
||
#
|
||
# TERMINAL IS NOT ENOUGH — IN-SENTENCE CORROBORATION. The follower test clears
|
||
# `pre-push` in the example above only because that example happens to be
|
||
# followed by the noun "hooks". Move the same token into terminal position and
|
||
# it was a hard FAIL again, with no suppression mechanism anywhere in this gate:
|
||
# Do not use for running hooks — run `pre-commit` instead.
|
||
# Do not use for the commit message — see `commit-msg`.
|
||
# Do not use for type errors — run `type-check` first.
|
||
# Instead, use `semantic-release`.
|
||
# Do not use for the old flow — use the clean-up instead.
|
||
# Do not run end-to-end, run unit-tests.
|
||
# Every one of those is grammatically identical to a genuinely broken route:
|
||
# "route verb + hyphenated name + terminal" is also exactly how prose cites a
|
||
# tool, a hook, a file format or an English compound. Nothing local separates
|
||
# them, and the skills most exposed are the ones this contract sends authors
|
||
# back to rewrite first — pc-run, pc-author, vale-run, vale-config and the apm-*
|
||
# family are all ABOUT hyphenated tools.
|
||
#
|
||
# So the confidence to BLOCK a commit comes from the sentence, not the token: a
|
||
# prose-form target may raise a hard error only when its own sentence names at
|
||
# least one OTHER target that RESOLVES. A routing sentence proves itself by
|
||
# routing somewhere real; a lone unresolvable name proves nothing. That is not a
|
||
# rule fitted to the fixtures — it is the shape of both live true positives,
|
||
# which sit beside `write-docs` and `gitea-labels-milestones` respectively, and
|
||
# it changes this corpus's verdict by exactly nothing.
|
||
#
|
||
# An uncorroborated unresolvable target is NOT discarded: every caller reports
|
||
# it at its SUGGESTION tier, naming the target. The finding stays visible on
|
||
# every run; only the power to block a commit is withdrawn, which is the part
|
||
# that had no escape hatch.
|
||
#
|
||
# EXPLICIT ROUTE NOTATION is exempt from corroboration and always blocks:
|
||
# ADR-0020's compressed arrow (`Not <thing> -> <name>`) and Claude Code's
|
||
# invocation form (`/<name>`). Neither is ever how English cites a tool — nobody
|
||
# writes `-> pre-commit` or `/pre-commit` to mean the hook — so there is no
|
||
# ambiguity to resolve, and an author who wants a route checked unconditionally
|
||
# has two ways to say so.
|
||
#
|
||
# NAMESPACE: `plugin:skill` is live in this repo (native user-scope installs
|
||
# still resolve `gitea:gitea-prs`), so the patterns admit an optional
|
||
# `<plugin>:` prefix and normalize_target() strips it before resolution.
|
||
NS = r"(?:[a-z0-9]+(?:-[a-z0-9]+)*:)?"
|
||
NAME_ANY = NS + r"[a-z0-9]+(?:-[a-z0-9]+)*"
|
||
NAME_HYPH = NS + r"[a-z0-9]+(?:-[a-z0-9]+)+"
|
||
ROUTE_VERB = (r"(?:use|uses|using|run|runs|invoke|invokes|invoking|try|see"
|
||
r"|that'?s|compose|composes|call|calls"
|
||
r"|routes?\s+to|delegates?\s+to|prefers?|switch(?:es)?\s+to"
|
||
r"|hands?\s+off\s+to)")
|
||
MARKED_TARGET = r"(?:`/?(%s)`|(?<![\w./*-])/(%s)\b)" % (NAME_ANY, NAME_ANY)
|
||
ANY_TARGET = r"(?:%s|(%s)\b)" % (MARKED_TARGET, NAME_HYPH)
|
||
ROUTE_MARKED = re.compile(r"\b%s\s+(?:the\s+|an?\s+)?%s" % (ROUTE_VERB, MARKED_TARGET), re.I)
|
||
ROUTE_ANY = re.compile(r"\b%s\s+(?:the\s+|an?\s+)?%s" % (ROUTE_VERB, ANY_TARGET), re.I)
|
||
CONT_MARKED = re.compile(r"\s*(?:or|and|/|,)\s*%s" % MARKED_TARGET)
|
||
CONT_ANY = re.compile(r"\s*(?:or|and|/|,)\s*%s" % ANY_TARGET)
|
||
ARROW_MARKED = re.compile(r"(?:->|→)\s*%s" % MARKED_TARGET)
|
||
ARROW_BOUNDARY = re.compile(r"\bnot\b[^.;]*?(?:->|→)\s*(%s)\b" % NAME_HYPH, re.I)
|
||
BACKTICK = re.compile(r"`(%s)`" % NAME_HYPH)
|
||
# A boundary clause takes two shapes and BOTH count: the prose markers, and
|
||
# ADR-0020's compressed arrow form `Not <thing> -> <name>`.
|
||
BOUNDARY_MARKER = re.compile(r"\b(?:do\s+not|instead|rather\s+than|not\s+for)\b", re.I)
|
||
BOUNDARY_ARROW = re.compile(r"\bnot\b[^.;]*?(?:->|→)", re.I)
|
||
SENTENCE_SPLIT = re.compile(u'(?<=[.!?])\\s+(?=[A-Z"“(])')
|
||
|
||
# The token that may follow a route target without turning it into a compound
|
||
# modifier: punctuation, end of sentence, a conjunction, a boundary word, or a
|
||
# head noun that names the artifact itself ("the git-workflow skill"). Anything
|
||
# else — `hooks`, `template`, `formatting`, `logic` — is attributive prose.
|
||
FOLLOWER = re.compile(r"[`\s]*([a-z][a-z0-9]*)")
|
||
FOLLOWER_OK = frozenset("""
|
||
and or nor but for to when if unless while after before with from in on at by
|
||
of as than then instead rather directly first only always never also even
|
||
both either neither so because since per via plus alone here there this that
|
||
these those it its they them is are was were be been being has have had will
|
||
would can could should must may might does do did
|
||
skill skills agent agents plugin plugins command commands
|
||
""".split())
|
||
|
||
|
||
def normalize_target(target):
|
||
"""Comparison key: namespace stripped, lowercased.
|
||
|
||
Extraction is case-insensitive (re.I) but the universe is built from
|
||
lowercase directory names, so `Git-Commits` at the start of a sentence
|
||
resolved to nothing until this normalization existed.
|
||
"""
|
||
return target.split(':')[-1].lower()
|
||
|
||
|
||
def has_boundary_clause(description):
|
||
return bool(BOUNDARY_MARKER.search(description)
|
||
or BOUNDARY_ARROW.search(description))
|
||
|
||
|
||
def _first(match):
|
||
"""(name, start, end) offsets for the first group that matched."""
|
||
for index in range(1, (match.re.groups or 0) + 1):
|
||
if match.group(index):
|
||
return match.group(index), match.start(index), match.end(index)
|
||
return None, None, None
|
||
|
||
|
||
def _terminal(text, pos):
|
||
"""True if the token at pos does not make the preceding name a modifier."""
|
||
follower = FOLLOWER.match(text, pos)
|
||
return not follower or follower.group(1) in FOLLOWER_OK
|
||
|
||
|
||
def _notation(text, start, arrow):
|
||
"""True if the name is written in route NOTATION rather than in prose.
|
||
|
||
Two forms qualify: `/name` (Claude Code's invocation syntax, detected from
|
||
the character before the name) and `-> name` (ADR-0020's compressed boundary
|
||
form, passed in by the caller that matched the arrow). A backticked name
|
||
does NOT qualify — a code span is how a tool, a file and a skill are all
|
||
cited, so it carries no intent the follower test hasn't already read.
|
||
"""
|
||
return arrow or (start > 0 and text[start - 1] == '/')
|
||
|
||
|
||
def _add(out, text, name, start, end, strict=None, arrow=False):
|
||
if not name:
|
||
return
|
||
out.append((name,
|
||
_terminal(text, end) if strict is None else strict,
|
||
_notation(text, start, arrow)))
|
||
|
||
|
||
def _scan(text, route_re, cont_re, out):
|
||
for match in route_re.finditer(text):
|
||
name, start, end = _first(match)
|
||
if not name:
|
||
continue
|
||
_add(out, text, name, start, end)
|
||
# "use git-history or git-branches instead" / "use gitea-issues /
|
||
# gitea-prs" — keep consuming conjoined targets after the first.
|
||
pos = match.end()
|
||
while True:
|
||
cont = cont_re.match(text, pos)
|
||
if not cont:
|
||
break
|
||
_add(out, text, *_first(cont))
|
||
pos = cont.end()
|
||
|
||
|
||
def _extract_sentence(sentence):
|
||
"""[(name, may_dangle, notation)] for the routing targets in ONE sentence.
|
||
|
||
Kept separate from _extract() because corroboration is scoped to a single
|
||
sentence: a target's evidence is what stands beside it, not what the rest of
|
||
the description happens to mention.
|
||
"""
|
||
out = []
|
||
boundary = bool(BOUNDARY_MARKER.search(sentence))
|
||
_scan(sentence,
|
||
ROUTE_ANY if boundary else ROUTE_MARKED,
|
||
CONT_ANY if boundary else CONT_MARKED,
|
||
out)
|
||
for match in ARROW_MARKED.finditer(sentence):
|
||
# `-> name` and `-> /name` are route notation, not prose: nothing
|
||
# reads as a compound modifier after an arrow, so no follower test.
|
||
_add(out, sentence, *_first(match), strict=True, arrow=True)
|
||
for match in ARROW_BOUNDARY.finditer(sentence):
|
||
_add(out, sentence, match.group(1), match.start(1), match.end(1),
|
||
strict=True, arrow=True)
|
||
if boundary:
|
||
for match in BACKTICK.finditer(sentence):
|
||
_add(out, sentence, match.group(1), match.start(1), match.end(1))
|
||
return out
|
||
|
||
|
||
def _extract(description):
|
||
"""[(name, may_dangle, notation)] for every routing target."""
|
||
out = []
|
||
for sentence in SENTENCE_SPLIT.split(description):
|
||
out.extend(_extract_sentence(sentence))
|
||
return out
|
||
|
||
|
||
def boundary_targets(description):
|
||
"""Every routing target, for reporting and for confirming a route."""
|
||
return sorted({name for name, _, _ in _extract(description)})
|
||
|
||
|
||
def unresolved_targets(description, known):
|
||
"""Targets resolving to nothing, split into (blocking, reported).
|
||
|
||
`blocking` earns a hard error; `reported` is SUGGESTION tier — named on
|
||
every run, never fatal. Three conditions gate the promotion, and all of them
|
||
are documented at length in the ATTRIBUTIVE USE and CORROBORATION notes
|
||
above:
|
||
|
||
1. the target must be terminal, not a compound modifier ("pre-commit
|
||
hooks" is prose about a tool, not a route),
|
||
2. it must be written in route notation (`/name`, `-> name`), OR
|
||
3. its own sentence must name another target that DOES resolve.
|
||
|
||
Everything else is reported and left alone. `known` is the resolved
|
||
universe from known_targets(); passing an empty set is not meaningful —
|
||
callers check for that first and decline out loud instead.
|
||
"""
|
||
blocking, reported = set(), set()
|
||
for sentence in SENTENCE_SPLIT.split(description):
|
||
found = _extract_sentence(sentence)
|
||
resolved = {normalize_target(name) for name, _, _ in found
|
||
if normalize_target(name) in known}
|
||
for name, may_dangle, notation in found:
|
||
key = normalize_target(name)
|
||
if key in known or not may_dangle:
|
||
continue
|
||
if notation or (resolved - {key}):
|
||
blocking.add(name)
|
||
else:
|
||
reported.add(name)
|
||
return sorted(blocking), sorted(reported - blocking)
|
||
|
||
# --- Frontmatter ----------------------------------------------------------
|
||
# Tolerant on the way in, HARD-FAILING on the way out. A UTF-8 BOM, a leading
|
||
# blank line, trailing whitespace after either `---`, or CRLF line endings all
|
||
# defeated the old `^---\n(.*?)\n---`, and the miss was SILENT: every ADR-0020
|
||
# check was skipped and the file reported green (measured: a 550-character
|
||
# description with a 1,000-word body exited 0 behind a BOM). A file that cannot
|
||
# be measured must never report green, so every caller of these two ERRORs on a
|
||
# miss instead of moving on.
|
||
FRONTMATTER_RE = re.compile(
|
||
r'^[ \t\r\n]*---[ \t]*\r?\n(.*?)\r?\n[ \t]*---[ \t]*(?:\r?\n|\Z)', re.DOTALL)
|
||
|
||
|
||
def strip_bom(text):
|
||
return text[1:] if text.startswith(u'') else text
|
||
|
||
|
||
class FrontmatterError(Exception):
|
||
pass
|
||
|
||
|
||
def description_value(fm_text):
|
||
"""The description VALUE, with YAML folding resolved.
|
||
|
||
PyYAML is a HARD requirement, preflighted in bash. The hand-rolled fallback
|
||
this replaced diverged from a real parser across the FAIL boundary — one
|
||
corpus description measured 270 characters parsed and 412 unparsed, and a
|
||
quoted `"description"` key or an explicit `description: null` returned empty
|
||
from it, silently skipping the description AND routing checks. A gate that
|
||
disagrees with itself depending on which reader ran is worse than no gate.
|
||
|
||
This is the ONLY reader any of the three scripts may use to decide whether a
|
||
description is present. A line regex cannot: `description:` with no value
|
||
followed by `model: sonnet` lets `\\s*` cross the newline and captures the
|
||
NEXT key, which reads as a non-empty description, skips the "missing or
|
||
empty" failure, and then early-returns out of every ADR-0020 gate on the
|
||
genuinely empty folded value. That combination exited 0 with zero output on
|
||
a BLOCKING pre-push gate.
|
||
"""
|
||
try:
|
||
data = yaml.safe_load(fm_text)
|
||
except Exception as exc:
|
||
raise FrontmatterError(re.sub(r'\s+', ' ', str(exc)).strip())
|
||
if not isinstance(data, dict):
|
||
raise FrontmatterError('frontmatter is not a YAML mapping')
|
||
value = data.get('description')
|
||
if value is None:
|
||
return ''
|
||
if not isinstance(value, str):
|
||
value = str(value)
|
||
return re.sub(r'\s+', ' ', value).strip()
|
||
|
||
|
||
# --- Body-shape checks (skills only; agents have no references/ dir) -------
|
||
# Deterministic and countable, so they are enforced here. Whether a given
|
||
# gotcha is WARRANTED is semantic and stays the auditor's judgment, which is why
|
||
# both gotcha checks are SUGGESTION tier. A missing reference file is not a
|
||
# style opinion — it is a broken pointer — so that one is ERROR tier.
|
||
#
|
||
# Both read a FENCE-MASKED copy of the body. Scanning the raw body made a
|
||
# ```-fenced example a hard ERROR — and the skills most likely to carry one are
|
||
# skill-author and skill-audit, which DOCUMENT the references/ convention — and
|
||
# let a `## Gotchas` heading inside a fenced block stand in for the real
|
||
# section. Masking preserves every byte offset (content becomes spaces,
|
||
# newlines stay), so a span found in the mask slices the original.
|
||
GOTCHA_MAX_ENTRIES = 5
|
||
GOTCHA_MAX_BODY_FRACTION = 0.25
|
||
# The heading has to BE "Gotchas", not merely contain the word: `## Gotcha
|
||
# handling` and `## Why gotchas matter` are prose sections, and treating one as
|
||
# the Gotchas section measured a span that was never a gotcha list.
|
||
GOTCHA_HEADING = re.compile(r'^(#{1,6})[ \t]+(?:[^\n]*?[ \t])?gotchas?[ \t]*:?[ \t]*$',
|
||
re.I | re.M)
|
||
# Column 0 only. `^[ \t]{0,3}` counted a two-space-indented CHILD bullet as a
|
||
# top-level entry, so a five-entry section with sub-bullets reported nine.
|
||
GOTCHA_ENTRY = re.compile(r'^(?:[-*+]|\d+[.)])[ \t]+', re.M)
|
||
FENCE_OPEN = re.compile(r'^[ \t]{0,3}(`{3,}|~{3,})')
|
||
REFERENCE_POINTER = re.compile(
|
||
r'(?<![\w./-])(?:\./)?references/([A-Za-z0-9][A-Za-z0-9._/-]*\.md)')
|
||
# A pointer named in a sentence that says the file is GONE is a historical
|
||
# mention, not a dispatch entry: "the old `references/legacy.md` was removed in
|
||
# v2" is prose and must not be a hard ERROR. Narrow on purpose — a live
|
||
# dispatch table never describes its own target as removed, so this costs no
|
||
# recall.
|
||
REFERENCE_PAST = re.compile(
|
||
r'\b(?:removed|deleted|renamed|superseded|replaced|obsolete|deprecated'
|
||
r'|former|formerly|gone|no longer|used to)\b', re.I)
|
||
# A pointer QUALIFIED by another skill's name — "skill-audit's
|
||
# references/validation-scripts.md" — names a file that is deliberately NOT in
|
||
# this skill's directory. Requiring it on the local disk left NO legal spelling
|
||
# for a cross-skill reference at all: the only alternative, a full repo path
|
||
# (`plugins/kyberforge/.apm/skills/skill-audit/references/...`), is itself a
|
||
# FAIL under skill-audit's own file-structure rubric, because a path that climbs
|
||
# out of the skill directory stops resolving once the plugin is cache-installed.
|
||
# The possessive form is the sanctioned spelling, and it is skipped here. It is
|
||
# not checked further — this function has no way to locate another skill's
|
||
# directory, and inventing one would reintroduce exactly the cross-plugin path
|
||
# assumption the rubric forbids.
|
||
REFERENCE_QUALIFIER = re.compile(u"[A-Za-z0-9][A-Za-z0-9._-]*`?['’]s[ \t]+`?$")
|
||
|
||
|
||
def mask_fenced(text):
|
||
"""Body with fenced code blocks blanked out, byte offsets preserved."""
|
||
out = []
|
||
fence = None
|
||
for line in text.splitlines(keepends=True):
|
||
stripped = line.rstrip('\r\n')
|
||
opener = FENCE_OPEN.match(stripped)
|
||
marker = opener.group(1) if opener else None
|
||
if fence is None:
|
||
if marker:
|
||
fence = marker
|
||
out.append(' ' * len(stripped) + line[len(stripped):])
|
||
continue
|
||
out.append(line)
|
||
else:
|
||
out.append(' ' * len(stripped) + line[len(stripped):])
|
||
if (marker and marker[0] == fence[0] and len(marker) >= len(fence)
|
||
and not stripped.strip()[len(marker):].strip()):
|
||
fence = None
|
||
return ''.join(out)
|
||
|
||
|
||
def gotcha_stats(body):
|
||
"""(entry count, section word count) for the first Gotchas section, or None.
|
||
|
||
The section runs to the next heading at the same level or shallower.
|
||
Entries are top-level list items; a section written as subheadings instead
|
||
of a list counts those. Headings and entries are read from the fence mask;
|
||
the word count is taken from the original slice, because fenced lines are
|
||
real body words and the fraction is measured against the whole body.
|
||
"""
|
||
masked = mask_fenced(body)
|
||
match = GOTCHA_HEADING.search(masked)
|
||
if not match:
|
||
return None
|
||
level = len(match.group(1))
|
||
rest = masked[match.end():]
|
||
nxt = re.search(r'^#{1,%d}[ \t]+' % level, rest, re.M)
|
||
end = match.end() + (nxt.start() if nxt else len(rest))
|
||
section = masked[match.end():end]
|
||
entries = len(GOTCHA_ENTRY.findall(section))
|
||
if entries == 0 and level < 6:
|
||
entries = len(re.findall(r'^#{%d,6}[ \t]+' % (level + 1), section, re.M))
|
||
return entries, len(body[match.end():end].split())
|
||
|
||
|
||
def missing_reference_pointers(body, skill_dir):
|
||
"""references/<file>.md named in the body but absent from disk."""
|
||
masked = mask_fenced(body)
|
||
missing = set()
|
||
for match in REFERENCE_POINTER.finditer(masked):
|
||
start = masked.rfind('\n', 0, match.start()) + 1
|
||
end = masked.find('\n', match.end())
|
||
if end < 0:
|
||
end = len(masked)
|
||
if REFERENCE_PAST.search(masked[start:end]):
|
||
continue
|
||
if REFERENCE_QUALIFIER.search(masked[start:match.start()]):
|
||
continue
|
||
if not os.path.isfile(os.path.join(skill_dir, 'references', match.group(1))):
|
||
missing.add('references/' + match.group(1))
|
||
return sorted(missing)
|
||
# ===== END ADR-0020 SHARED BOUNDARY RESOLVER =====
|
||
|
||
|
||
def parse_frontmatter(content):
|
||
m = FRONTMATTER_RE.match(strip_bom(content))
|
||
if not m:
|
||
return None, content
|
||
return m.group(1), strip_bom(content)[m.end():]
|
||
|
||
def extract_field(fm, field):
|
||
"""The raw text after `field:` ON ITS OWN LINE, or None.
|
||
|
||
The character class is `[^\\S\\r\\n]`, never `\\s`: under re.MULTILINE a
|
||
`\\s*` after the colon crosses the newline, so `description:` with no value
|
||
followed by `model: sonnet` captured `model: sonnet` as the description.
|
||
That made the value look present, skipped the "missing or empty" failure,
|
||
and then every ADR-0020 gate early-returned on the genuinely empty folded
|
||
value — a valueless description exited 0 with zero output on a BLOCKING
|
||
pre-push gate. This function is now used only for fields with no folding
|
||
semantics (name, tools); description goes through description_value(), the
|
||
shared resolver's YAML reader, which is the only thing that can see through
|
||
`>`, `null`, `''` and a quoted `"description"` key alike.
|
||
"""
|
||
m = re.search(rf'^{re.escape(field)}:[^\S\r\n]*(.+)', fm, re.MULTILINE)
|
||
return m.group(1).strip() if m else None
|
||
|
||
def get_frontmatter_keys(fm):
|
||
keys = set()
|
||
for line in fm.splitlines():
|
||
m = re.match(r'^([a-zA-Z][a-zA-Z0-9_-]*):', line)
|
||
if m:
|
||
keys.add(m.group(1))
|
||
return keys
|
||
|
||
def agent_description(fm, local_fname):
|
||
"""The folded description VALUE, or None if the frontmatter is not YAML."""
|
||
try:
|
||
return description_value(fm)
|
||
except FrontmatterError as exc:
|
||
fail(f"frontmatter is not valid YAML ({exc}) — the ADR-0020 description and "
|
||
f"boundary-target gates could not run — {local_fname}")
|
||
return None
|
||
|
||
def check_description_budget(value, local_fname):
|
||
"""ADR-0020 description gates — identical for every scope."""
|
||
if not value:
|
||
return
|
||
dlen = len(value)
|
||
if dlen > DESC_MAX_CHARS:
|
||
fail(f"description is {dlen} chars — exceeds the {DESC_MAX_CHARS}-character "
|
||
f"ADR-0020 ceiling. It is preloaded into every session whether or not the "
|
||
f"agent is invoked. Keep a trigger clause, at most one capability clause, "
|
||
f"and a boundary clause; move capability enumeration, output-format detail, "
|
||
f"composition notes and implementation detail to the body — {local_fname}")
|
||
elif dlen > DESC_SUGGEST_CHARS:
|
||
suggest(f"description is {dlen} chars — over the {DESC_SUGGEST_CHARS}-character "
|
||
f"ADR-0020 target (hard fail at {DESC_MAX_CHARS}). The SUGGESTION tier is "
|
||
f"what moves the corpus average; the FAIL tier only stops outliers "
|
||
f"— {local_fname}")
|
||
|
||
def check_boundary(value, fpath, local_fname):
|
||
"""ADR-0020 boundary clause + resolvable boundary targets.
|
||
|
||
agent-author's SKILL.md states that an agent's boundary targets must
|
||
resolve, but until this ran no script checked it — the contract was
|
||
documented and unenforced. The resolution universe is derived from the
|
||
AGENT FILE's own location (the authoring root above it, its own apm
|
||
package, and that package's declared apm dependencies), never from this
|
||
script's path, and — when an authoring root exists — never from a deployed
|
||
.claude/ tree, so a fresh clone and a machine that has run `apm install`
|
||
return the same verdict.
|
||
"""
|
||
if not value:
|
||
return
|
||
# SUGGESTION, not FAIL: detecting the absence is deterministic, but whether
|
||
# this particular agent warrants a boundary clause is judgment. All four
|
||
# agents in this corpus currently lack one.
|
||
if not has_boundary_clause(value):
|
||
suggest(f"description has no boundary clause — add the prose form (\"Do not use "
|
||
f"for X — use `y` instead\") or ADR-0020's compressed form (\"Not X -> y\") "
|
||
f"so the router knows where NOT to send this agent — {local_fname}")
|
||
targets = boundary_targets(value)
|
||
if not targets:
|
||
return
|
||
known = known_targets(os.path.dirname(os.path.abspath(fpath)))
|
||
if not known:
|
||
info(f"boundary-target resolution DID NOT RUN — no skill universe could be "
|
||
f"determined for this path (no authoring root above it, no apm package "
|
||
f"root, no declared apm dependencies, no deployed .claude/ or .agents/ "
|
||
f"tree). Unchecked target(s): {', '.join(targets)} — {local_fname}")
|
||
return
|
||
# blocking vs reported: a target only earns a FAIL when it is written in
|
||
# route notation or its own sentence corroborates it by naming another target
|
||
# that resolves. See the shared resolver's CORROBORATION note.
|
||
blocking, reported = unresolved_targets(value, known)
|
||
for target in blocking:
|
||
fail(f"description routes to '{target}', which resolves to no skill or agent "
|
||
f"in this monorepo, in this package, or in a package it declares in "
|
||
f"apm.yml dependencies.apm — a boundary clause naming a non-existent "
|
||
f"target sends the router nowhere — {local_fname}")
|
||
for target in reported:
|
||
suggest(f"description routes to '{target}', which resolves to no skill or agent "
|
||
f"in this monorepo, in this package, or in a package it declares in "
|
||
f"apm.yml dependencies.apm — SUGGESTION rather than FAIL because nothing "
|
||
f"else in that sentence resolves, so it is equally likely to be a tool, a "
|
||
f"file format or an English compound. If it IS a route, write it as "
|
||
f"`/{target}` or `-> {target}` and it will be checked properly — "
|
||
f"{local_fname}")
|
||
|
||
def extract_tools_list(fm):
|
||
"""Extract tool names from the tools frontmatter field (space or comma separated)."""
|
||
val = extract_field(fm, 'tools')
|
||
if not val:
|
||
return set()
|
||
return set(re.split(r'[\s,]+', val.strip()))
|
||
|
||
def is_copilot_cloud_ide(fpath):
|
||
"""True if the file is a cloud/IDE Copilot agent (name is optional for these)."""
|
||
return '.github/copilot/agents' in os.path.abspath(fpath).replace(os.sep, '/')
|
||
|
||
# --- Detect scope ---
|
||
# APM_TYPE_RE matches a top-level (column-0) `type:` line in apm.yml whose value is
|
||
# exactly one of the four package content types. Group 1 captures an optional
|
||
# opening quote; \1 requires the same character (or nothing) to close it, so
|
||
# "skill" and '"skill"' both match but a mismatched quote doesn't. The value
|
||
# must then be followed by whitespace or end-of-line — not just a non-word
|
||
# character — so a malformed value like `prompts-only` is correctly rejected
|
||
# instead of false-matching on the `prompts` prefix.
|
||
APM_TYPE_RE = re.compile(r"^type:\s*(['\"]?)(instructions|skill|hybrid|prompts)\1(?:\s|$)")
|
||
|
||
def find_apm_package_root(apm_yml_path):
|
||
"""Return True if apm_yml_path has a top-level type: line (i.e. is a package
|
||
manifest, not a type:-less marketplace-only apm.yml)."""
|
||
# errors='replace', not a hard failure: this only asks whether a `type:`
|
||
# line exists, and a stray undecodable byte elsewhere in someone else's
|
||
# apm.yml must not abort scope detection.
|
||
with open(apm_yml_path, encoding='utf-8', errors='replace') as f:
|
||
for line in f:
|
||
if APM_TYPE_RE.match(line):
|
||
return True
|
||
return False
|
||
|
||
def detect_scope(start_dir):
|
||
home = os.path.expanduser('~')
|
||
original_start = os.path.abspath(start_dir)
|
||
# Agent files conventionally live exactly two path segments below their
|
||
# scope root — <root>/.claude/agents, <root>/.github/agents,
|
||
# <root>/.copilot/agents, or <root>/.apm/agents (see new-agent.sh's
|
||
# CC_DIR/CP_DIR and user-scope dirs). Stripping those two segments
|
||
# recovers the same root new-agent.sh would have been invoked with to
|
||
# produce this exact file, independent of how far the walk below has to
|
||
# travel to find (or fail to find) a marker — mirrors new-agent.sh's
|
||
# `root` vs `current` distinction even though validate.sh is handed a
|
||
# file's directory, not the scope root itself.
|
||
#
|
||
# That arithmetic is only trustworthy when the path actually has this
|
||
# shape: parent directory literally named "agents", grandparent one of
|
||
# the four known scope-dir names. A hand-placed or otherwise
|
||
# non-conventional agent file (never produced by new-agent.sh) has no
|
||
# such guarantee — blindly trusting two-segments-up there could point at
|
||
# an unrelated ancestor. conventional_shape gates every use of
|
||
# conventional_root below; when it's false, the walked-to `current`
|
||
# directory is used instead, the same fallback this function used before
|
||
# conventional_root existed.
|
||
scope_dir_name = os.path.basename(os.path.dirname(original_start))
|
||
conventional_shape = (
|
||
os.path.basename(original_start) == 'agents'
|
||
and scope_dir_name in ('.claude', '.github', '.copilot', '.apm')
|
||
)
|
||
conventional_root = os.path.dirname(os.path.dirname(original_start))
|
||
current = original_start
|
||
while True:
|
||
# The filesystem root is never a candidate, the same guard the shared
|
||
# resolver's walk-up loops carry. Without it a file under a marker-less
|
||
# temp directory walked all the way to `/` and returned it as the scope
|
||
# root, which then reported `counterpart file not found:
|
||
# /.claude/agents/<name>.md` — a path that names someone else's machine,
|
||
# not the user's project. When the walk runs out, the agent file's own
|
||
# directory (or its conventional root) is the honest answer.
|
||
if _is_fs_root(current):
|
||
return 'project', conventional_root if conventional_shape else original_start
|
||
apm_yml = os.path.join(current, 'apm.yml')
|
||
if os.path.isfile(apm_yml) and find_apm_package_root(apm_yml):
|
||
return 'plugin', current
|
||
# $HOME is the user-scope boundary — checked before the .git test
|
||
# below, so a dotfiles-managed $HOME (yadm, chezmoi bare-repo, etc.)
|
||
# can't shadow user scope by being its own .git repo. 'user' scope
|
||
# requires EITHER start_dir to BE $HOME itself (no walk-up — the
|
||
# new-agent.sh "root exactly $HOME" case) OR start_dir to sit at the
|
||
# conventional two-segments-below-root depth (i.e. $HOME IS that
|
||
# root, matching the real ~/.claude/agents or ~/.copilot/agents
|
||
# shape). Any other walk-up into $HOME — a marker-less directory
|
||
# nested deeper than that convention — resolves to project scope
|
||
# instead: a stray directory under $HOME can't be silently
|
||
# redirected into the shared global ~/.claude or ~/.copilot agent
|
||
# directories.
|
||
if current == home:
|
||
if original_start == home or (conventional_shape and conventional_root == home):
|
||
return 'user', home
|
||
return 'project', conventional_root if conventional_shape else current
|
||
# .git is a directory in a normal checkout but a file (`gitdir: ...`)
|
||
# in a git worktree — exists() covers both. Returns conventional_root,
|
||
# not current: new-agent.sh's project-scope file placement always
|
||
# uses its `$ROOT` argument directly, never the walked-up `.git`
|
||
# location, so a <root> one or more levels below the repo's .git
|
||
# (a subdirectory of a larger git-tracked tree — explicitly a
|
||
# supported case per new-agent.sh's usage text) must resolve to the
|
||
# same root new-agent.sh actually wrote to, not to the .git dir —
|
||
# unless the path lacks the conventional shape, in which case that
|
||
# arithmetic isn't trustworthy and current is used instead.
|
||
if os.path.exists(os.path.join(current, '.git')):
|
||
return 'project', conventional_root if conventional_shape else current
|
||
parent = os.path.dirname(current)
|
||
if parent == current:
|
||
return 'project', conventional_root if conventional_shape else current
|
||
current = parent
|
||
|
||
agent_dir = os.path.dirname(agent_file)
|
||
scope, scope_root = detect_scope(agent_dir)
|
||
|
||
# --- Plugin/APM scope: single vendor-neutral file, no counterpart ---
|
||
def check_apm_agent_file(fpath, allowlist, stem):
|
||
local_fname = os.path.basename(fpath)
|
||
try:
|
||
content = read_text(fpath)
|
||
except EncodingError as exc:
|
||
fail(f"file is {exc}. Nothing could be measured, so this is a hard "
|
||
f"failure, not a skip — {local_fname}")
|
||
return
|
||
|
||
fm, body = parse_frontmatter(content)
|
||
if fm is None:
|
||
fail(f"no parseable YAML frontmatter block — expected a `---` line, the fields, "
|
||
f"then a closing `---` line (a BOM, leading blank lines, trailing spaces "
|
||
f"after either marker and CRLF endings are all tolerated). Nothing could be "
|
||
f"measured, so this is a hard failure, not a skip — {local_fname}")
|
||
return
|
||
|
||
# The apm-agent.md template embeds its authoring guidance as HTML
|
||
# comments inside the frontmatter block (so they render invisible in a
|
||
# Markdown preview but stay visible in the raw file). get_frontmatter_keys
|
||
# silently ignores any line that isn't a `key:` match, so a comment left
|
||
# behind at ship time would otherwise pass unnoticed — yet apm compile
|
||
# copies this frontmatter verbatim to both harnesses, and `<!-- -->` is
|
||
# not valid YAML, so yaml.safe_load breaks on both downstream (ADR-0016).
|
||
if re.search(r'<!--|-->', fm):
|
||
fail(f"frontmatter still contains template HTML comments (<!-- ... -->) "
|
||
f"— delete them before shipping — {local_fname}")
|
||
|
||
# Allowlist: the permitted keys are data, read at load time from
|
||
# references/field-inventory.md's `## apm-agent-allowlist` section — do not
|
||
# restate them here, or this comment goes stale the next time that line
|
||
# changes. apm compile verbatim-copies frontmatter to every target, so a key
|
||
# outside the list is unsafe on at least one harness (ADR-0016). Note the
|
||
# list admits denylist-shaped restrictions (disallowedTools) but never
|
||
# allowlist-shaped ones (tools), whose value shape differs per harness.
|
||
fm_keys = get_frontmatter_keys(fm)
|
||
for key in sorted(fm_keys):
|
||
if key not in allowlist:
|
||
fail(f"field '{key}' is not in the vendor-neutral APM agent allowlist "
|
||
f"({', '.join(sorted(allowlist))}) — {local_fname}")
|
||
|
||
# name — required, kebab-case, must match filename stem (file is <name>.agent.md)
|
||
name_val = extract_field(fm, 'name')
|
||
if not name_val:
|
||
fail(f"name field is missing or empty — {local_fname}")
|
||
else:
|
||
if not re.match(r'^[a-z0-9]+(-[a-z0-9]+)*$', name_val):
|
||
fail(f"name '{name_val}' is not kebab-case — {local_fname}")
|
||
if name_val != stem:
|
||
fail(f"name '{name_val}' does not match filename stem '{stem}' — {local_fname}")
|
||
|
||
# description — required, non-empty, no placeholder
|
||
# Presence is decided on the FOLDED value, never on a line regex. Deciding
|
||
# it on extract_field's raw capture is what let `description:` with no value
|
||
# pass this gate in total silence: the capture picked up the next key, so
|
||
# "missing or empty" never fired, and every ADR-0020 check below then
|
||
# early-returned on the empty folded value. Exit 0, zero output, no gate run.
|
||
folded = agent_description(fm, local_fname)
|
||
if folded is None:
|
||
pass # frontmatter is not valid YAML — agent_description already failed
|
||
elif not folded:
|
||
fail(f"description field is missing or empty — {local_fname}")
|
||
else:
|
||
if PLACEHOLDER_RE.search(folded):
|
||
fail(f"description contains unfilled FILL IN: placeholder — {local_fname}")
|
||
check_description_budget(folded, local_fname)
|
||
check_boundary(folded, fpath, local_fname)
|
||
|
||
# body — required, non-empty, no placeholder; same Copilot truncation risk
|
||
# applies since this file compiles verbatim into a real Copilot file downstream.
|
||
if not body.strip():
|
||
fail(f"system prompt body is empty — {local_fname}")
|
||
else:
|
||
if PLACEHOLDER_RE.search(body):
|
||
fail(f"body contains unfilled FILL IN: placeholder — {local_fname}")
|
||
if len(body) > COPILOT_BODY_LIMIT:
|
||
suggest(f"body exceeds {COPILOT_BODY_LIMIT:,} characters ({len(body):,} chars) — "
|
||
f"content beyond the limit is silently truncated by the Copilot runtime "
|
||
f"once apm compile emits it downstream — {local_fname}")
|
||
|
||
if scope == 'plugin':
|
||
check_apm_agent_file(agent_file, apm_agent_allowlist, name_stem)
|
||
for s in suggestions:
|
||
print(f"SUGGESTION {s}")
|
||
sys.exit(1 if failed else 0)
|
||
|
||
# --- Project/user scope: unchanged CC/Copilot pair validation ---
|
||
|
||
# --- Derive counterpart path ---
|
||
if scope == 'project':
|
||
if provider == 'claude-code':
|
||
counterpart = os.path.join(scope_root, '.github', 'agents', name_stem + '.agent.md')
|
||
counterpart_provider = 'copilot'
|
||
else:
|
||
counterpart = os.path.join(scope_root, '.claude', 'agents', name_stem + '.md')
|
||
counterpart_provider = 'claude-code'
|
||
else: # user
|
||
home = os.path.expanduser('~')
|
||
if provider == 'claude-code':
|
||
counterpart = os.path.join(home, '.copilot', 'agents', name_stem + '.agent.md')
|
||
counterpart_provider = 'copilot'
|
||
else:
|
||
counterpart = os.path.join(home, '.claude', 'agents', name_stem + '.md')
|
||
counterpart_provider = 'claude-code'
|
||
|
||
def check_file(fpath, file_provider):
|
||
local_fname = os.path.basename(fpath)
|
||
try:
|
||
content = read_text(fpath)
|
||
except EncodingError as exc:
|
||
fail(f"file is {exc}. Nothing could be measured, so this is a hard "
|
||
f"failure, not a skip — {local_fname}")
|
||
return
|
||
|
||
fm, body = parse_frontmatter(content)
|
||
if fm is None:
|
||
fail(f"no parseable YAML frontmatter block — expected a `---` line, the fields, "
|
||
f"then a closing `---` line (a BOM, leading blank lines, trailing spaces "
|
||
f"after either marker and CRLF endings are all tolerated). Nothing could be "
|
||
f"measured, so this is a hard failure, not a skip — {local_fname}")
|
||
return
|
||
|
||
# name — required for CC and Copilot CLI; optional for Copilot cloud/IDE agents
|
||
cloud_ide = (file_provider == 'copilot' and is_copilot_cloud_ide(fpath))
|
||
name_val = extract_field(fm, 'name')
|
||
if not cloud_ide:
|
||
if not name_val:
|
||
fail(f"name field is missing or empty — {local_fname}")
|
||
else:
|
||
if not re.match(r'^[a-z0-9]+(-[a-z0-9]+)*$', name_val):
|
||
fail(f"name '{name_val}' is not kebab-case — {local_fname}")
|
||
# Stem check applies to Copilot CLI only; CC docs say filename need not match name
|
||
if file_provider == 'copilot':
|
||
stem = local_fname[:-len('.agent.md')]
|
||
if name_val != stem:
|
||
fail(f"name '{name_val}' does not match filename stem '{stem}' — {local_fname}")
|
||
elif name_val and not re.match(r'^[a-z0-9]+(-[a-z0-9]+)*$', name_val):
|
||
# cloud/IDE: name is optional, but if present it must be valid
|
||
fail(f"name '{name_val}' is not kebab-case — {local_fname}")
|
||
|
||
# description
|
||
# Presence is decided on the FOLDED value, never on a line regex. Deciding
|
||
# it on extract_field's raw capture is what let `description:` with no value
|
||
# pass this gate in total silence: the capture picked up the next key, so
|
||
# "missing or empty" never fired, and every ADR-0020 check below then
|
||
# early-returned on the empty folded value. Exit 0, zero output, no gate run.
|
||
folded = agent_description(fm, local_fname)
|
||
if folded is None:
|
||
pass # frontmatter is not valid YAML — agent_description already failed
|
||
elif not folded:
|
||
fail(f"description field is missing or empty — {local_fname}")
|
||
else:
|
||
if PLACEHOLDER_RE.search(folded):
|
||
fail(f"description contains unfilled FILL IN: placeholder — {local_fname}")
|
||
check_description_budget(folded, local_fname)
|
||
check_boundary(folded, fpath, local_fname)
|
||
|
||
# body
|
||
if not body.strip():
|
||
fail(f"system prompt body is empty — {local_fname}")
|
||
else:
|
||
if PLACEHOLDER_RE.search(body):
|
||
fail(f"body contains unfilled FILL IN: placeholder — {local_fname}")
|
||
# Copilot body length limit
|
||
if file_provider == 'copilot' and len(body) > COPILOT_BODY_LIMIT:
|
||
suggest(f"body exceeds {COPILOT_BODY_LIMIT:,} characters ({len(body):,} chars) — content beyond the limit is silently truncated by the Copilot runtime — {local_fname}")
|
||
|
||
# CC-only fields in Copilot file
|
||
if file_provider == 'copilot':
|
||
fm_keys = get_frontmatter_keys(fm)
|
||
for key in sorted(fm_keys):
|
||
if key in cc_only_fields:
|
||
fail(f"CC-only field '{key}' present in Copilot file — {local_fname}")
|
||
|
||
# Copilot-only fields in CC file
|
||
if file_provider == 'claude-code':
|
||
fm_keys = get_frontmatter_keys(fm)
|
||
for key in sorted(fm_keys):
|
||
if key in copilot_only_fields:
|
||
fail(f"Copilot-only field '{key}' present in CC file — {local_fname}")
|
||
|
||
# Subagent-unavailable tools listed in tools field
|
||
tools = extract_tools_list(fm)
|
||
unavailable = tools & SUBAGENT_UNAVAILABLE_TOOLS
|
||
for tool in sorted(unavailable):
|
||
suggest(f"'{tool}' is listed in tools but is never available to subagents — the runtime withholds it regardless — {local_fname}")
|
||
|
||
# --- Check counterpart exists ---
|
||
if not os.path.isfile(counterpart):
|
||
fail(f"counterpart file not found: {counterpart}")
|
||
sys.exit(1)
|
||
|
||
# --- Check both files ---
|
||
check_file(agent_file, provider)
|
||
check_file(counterpart, counterpart_provider)
|
||
|
||
for s in suggestions:
|
||
print(f"SUGGESTION {s}")
|
||
|
||
sys.exit(1 if failed else 0)
|
||
PYTHON
|