Defame1297
c705a38809
Produces docs/notes/skill-implementation-workflow.md with agreed conventions for all Chunk 3 skill issues (0017–0028). Key decisions: - Per-skill process: source discovery (sub-agent) → source review with licence/security check (sub-agent) → conflict check vs constitution + factory principles (sub-agent) → synthesis grill → co-write iteratively - Bootstrap: write-eval (hand-written) → write-skill (hand-written) → write-docs (first factory-authored, phase 2 of 0018) → everything else - Upstream review changed from per-chunk-start to per-skill - `when:` and `references:` frontmatter fields added to authoring standard - Sub-agent usage prescribed as named steps in the workflow - HITL: human reviewed and approved conventions Updates: PRD implementation decisions; issues 0016–0028 with specific acceptance criteria; docs/spec/overview.md; ROADMAP Chunk 3 housekeeping note (bootstrap order, cadence, acceptance criteria status); CONTEXT.md Source field (per-skill cadence, references: companion field); LESSONS.md with three patterns from the grill session. Post-grill additions (same session): Step 6 (session handoff) added to the workflow; handoff section appended to issue 0016; handoff checklist item added to Chunk 3 closure issue (0028). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3.3 KiB
3.3 KiB
0024 — Deploy skills: write-ci-pipeline, write-deployment-config, write-ai-review-workflow, deployment-checklist
Type: HITL
Parent PRD: docs/prd/chunk-3-skills-library.md
What to build
The 4 deploy phase skills. All are new. Authored via write-skill (0018), evals via write-eval (0017).
Skills and trigger descriptions:
| Flat name | Trigger description |
|---|---|
write-ci-pipeline |
Write CI pipeline, create Gitea Actions workflow |
write-deployment-config |
Write deployment config, Docker Compose, K8s manifest |
write-ai-review-workflow |
Create AI review workflow, automated PR review |
deployment-checklist |
Pre-deployment checklist, ready to deploy, deployment validation |
Key constraints per skill:
write-ci-pipeline: targets Gitea Actions YAML; includes secret scan, dependency scan, licence scan, test, and build steps by defaultwrite-deployment-config: pinned image/provider versions; resource limits on all K8s resources; no hardcoded secrets; secrets via env varswrite-ai-review-workflow: calls AI API via script; posts findings via Gitea API; never auto-merges; human remains in the loopdeployment-checklist: validates — linked issue exists and is closed or in-progress; secrets scan clean; dependency scan clean; licence scan clean; tests passing; rollback plan documented;docs/spec/updated if behaviour changed; which reviewer roles (Architect, Reviewer, Security) have been invoked on this change
Implementation notes
Follow the per-skill workflow defined in docs/notes/skill-implementation-workflow.md.
Known upstream sources to review:
bmad-method/bmad-method— BMAD ops/deploy patterns and deployment checklist approach- Search GitHub for open-source Gitea Actions skill examples
- Gitea Actions documentation (Gitea-specific CI syntax differences from GitHub Actions)
Acceptance criteria
- All 4 SKILL.md files exist at
.agents/skills/<skill-name>/SKILL.md;metadata.category: deploy; authoring standard met deployment-checklistincludes all listed validation checks, including reviewer role invocation checkwrite-ai-review-workflowincludes explicit constraint that it never auto-mergessource:fields populated for any adopted upstream content- Each skill has a co-located eval at
.agents/evals/deploy/<skill-name>/eval.yamlviawrite-eval install.shdeploys all 4 to~/.agents/skills/- HITL: human runs behavioral test per skill
- HITL: human reviews each SKILL.md and eval before committing
- Per-skill process followed for all 4 skills: source discovery (sub-agent) → source review with licence/security check (sub-agent) → conflict check against constitution + factory principles (sub-agent) → synthesis grill → co-write iteratively
- Trigger description for each skill tested against explicit, implicit, and negative queries before body written
when:frontmatter field present in all SKILL.md filessource:andreferences:fields correctly populated or absent- eval.yaml for each skill contains all 5 required test types
- Body ≤500 lines for each skill
docs/spec/overview.mdupdated to reflect all 4 skills deployed
Blocked by
- 0016 (per-skill workflow)
- 0017 (
write-eval) - 0018 (
write-skill)