Files

Defame1297 620f20b0fd refactor(kyberforge)!: merge skill-audit and agent-audit into factory-audit

Why

The two audit skills carried 1,724 lines of byte-identical duplication: the ADR-0020 boundary
resolver (1,061), vale-wrap.sh (526), the Vale style rules (44) and the Contributing-files parser
(93). Nothing shared them — they were held in sync by a 413-line pre-push gate and its 797-line
test suite. Sync-by-gate had already failed once: at 484357a the two parser copies drifted into
different spellings of the bullet loop while a docstring asserted they were identical. That drift
was behaviour-neutral and was re-unified by hand at 598a7c3, so the copies were identical at merge
time — but nothing had caught it, and the next drift need not be neutral.

Implementation Notes

Self-containment binds BETWEEN skills, not within one. The agentskills.io spec forbids reaching
across skill directories, which is why two separate skills needed embedded copies; two files inside
ONE skill may source a third. That is the whole reason the merge removes duplication rather than
relocating it.

The union of both bodies measured 1,532 words against BODY_MAX_WORDS=900, and only 211 of those
words were shared, so SKILL.md is a dispatch body. Step 0 resolves the flow from the target path
before any validation, and its table mirrors validate.sh's detection exactly: a directory holding
SKILL.md or a SKILL.md file (skill); a *.agent.md, or a .md directly under an agents/ directory
(agent); anything else stops without running a validator. Steps 1-3 live in
references/skill-flow.md and references/agent-flow.md, and gotchas that apply to one flow live in
that flow's file, since it is loaded on every invocation anyway. If validate.sh reports on the
other artifact type, the body restarts at Step 0.

Named factory-audit rather than forge-audit because forge is a live skill, and a family prefix that
matches a live sibling reads as ownership rather than membership.

The description carries one arrow per boundary target, because ADR-0020 resolves only the first
target after an arrow. It drops the quoted "audit this skill"-style phrases, which restated
"audited" in a second register (ADR-0020's duplicate-register rule). 241 characters, Gotchas 16%
of the body: no size SUGGESTIONs.

The boundary resolver stays embedded in two files rather than imported: a cache-installed plugin
cannot read outside its own directory, and the repo-root hook resolves via .pre-commit-hooks.yaml
where entry[0] is the only token pre-commit rewrites, so no single file is reachable by both.
tests/test-adr0020-contract.sh hashes both copies for byte-identity, and asserts validate.sh sources
the resolver and that no third copy exists.

The entry scripts classify the target from its resolved parent directory, so a bare agent filename
typed inside agents/ works; resolve SCRIPT_DIR CDPATH-safely; and exit 2 when a lib-*.sh is
missing, rather than dying with exit 1, the tier the flows relay as real findings.

The provenance run functions stash their findings code in KYBERFORGE_PROV_RC and
return 0, so validate-provenance.sh calls them UNTESTED. Testing a function's
status (`f || RC=$?`) disables errexit for its entire body, and no subshell or
`set -e` inside can re-arm it once the call sits in a condition context
(measured, both spellings). Their error paths use `exit`, which is unaffected
either way; this keeps errexit armed for anything added later.

Case 0's readability guard reads the file instead of asking `[[ -r ]]`. `-r` is
access(2), which answers yes for uid 0 even on a mode-000 file, and this repo's
dev environment is root -- so the guard could never fire where it exists to fire.
A read attempt is also the stricter question, catching EIO. This is the reasoning
scripts/check-vale-style-sync.sh carried before this commit deleted it; the
hazard did not go with it.

All three entry scripts are CDPATH-safe, vale-wrap.sh included: both of its cd sites are cleared,
the --config resolution and the directory-mirror walk, where an exported CDPATH would otherwise
print a decoy path into the -print0 stream and build the mirror from the decoy's files. The two
remaining bare cd calls take absolute paths, which CDPATH is never consulted for.

Impact

BREAKING: skill-audit and agent-audit no longer exist as invocable skills. kyberforge goes to
2.0.0 (catalog 0.4.7).

Check logic is unchanged: differential runs of the old and new validators across every skill and
agent produced byte-identical stdout, stderr and exit codes, and the reconstructed Python payloads
differ only in comments and the references/field-inventory.md -> agent-field-inventory.md rename.
One doctrine governs the tiers: exit 0 is audited and clean, exit 1 is audited with findings OR a
target present but unreadable, exit 2 is that nothing was audited at all. Edge paths DID change,
deliberately (full table in ADR-0025):
- a missing target exits 2 (never ran), not 1, under its own "does not exist" message; detection is
  by path shape, so a shape-matching path that is simply absent used to reach the validator and come
  back as a FAIL against a file that never existed;
- an unshaped target exits 2 under the generic "matches neither" message, and a directory with no
  SKILL.md under a third, distinct one -- three exit-2 messages, not one;
- a dangling symlink or a symlink loop stays exit 1: it is present but broken, which is a finding
  about the artifact rather than a usage error;
- a SKILL.md file path is audited as its skill directory instead of refused;
- a .md agent outside an agents/ directory is refused rather than audited;
- a missing script library, a missing python3, a missing PyYAML, and no argument at all each exit 2.
  validate-provenance.sh already exited 2 for the last two; validate.sh now matches it.

.pre-commit-hooks.yaml is a published contract consumed by external repos. Both hook IDs and both
files: regexes are unchanged; only entry: and description: moved.

scripts/check-vale-style-sync.sh (413), scripts/sync-vale-styles.sh (21),
tests/test-check-vale-style-sync.sh (797) and agent-audit/scripts/README.md (47) are deleted. The
checker made 17 assertions: 6 compared the two Vale copies and are moot; 10 are rehomed into
tests/test-vale-wrap.sh (case 0, cases 28-31, and the suite's Vale-absent skip); and the
cross-manifest files: agreement check, which selected hooks by entry: and so could not survive both
hooks sharing one, is ported as case 33 pairing hooks by id:. Cases 28, 30 and 33 carry mutation
self-tests; narrowing the local skill prefilter to 6 of 38 SKILL.md files now fails the suite.

Skills go 39 to 38. Pre-push goes 9 repo-authored hooks to 8.

ADR: 0025
BREAKING-CHANGE: the skill-audit and agent-audit skills are removed. Both flows are served by
  factory-audit, which auto-detects whether it was handed a skill directory or an agent file.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YR2CjVumUbEGWcMikcoXBD

2026-09-16 09:13:57 +00:00

4.1 KiB

Raw Blame History

tests/

Test files for scripts bundled with this skill.

When to add tests

Add tests here when the skill has scripts in scripts/ that are complex enough to break silently — validators, parsers, generators, anything with branching logic or edge cases. Test infrastructure (.bats, *_test.*, test_*.sh) belongs here, not in scripts/.

Dependencies

Tests require bats-support and bats-assert. The test files load helpers from the repo root's tests/test_helper/.

From the repo root:

git clone https://github.com/bats-core/bats-support tests/test_helper/bats-support
git clone https://github.com/bats-core/bats-assert tests/test_helper/bats-assert

Run all tests for this skill (from the repo root):

bats plugins/kyberforge/.apm/skills/factory-audit/tests/

Files

File	Purpose
`validate-skill.bats`	`scripts/validate.sh` against skill directories
`validate-agent.bats`	`scripts/validate.sh` against agent files
`validate-provenance-skill.bats`	`scripts/validate-provenance.sh` against skill directories
`validate-provenance-agent.bats`	`scripts/validate-provenance.sh` against agent files

Two scripts, four suites

factory-audit merges what were two skills — skill-audit and agent-audit — each of which shipped its own validate.sh and validate-provenance.sh. The merged skill has one of each. Every suite here invokes one of those two scripts; the four files are two scripts × two artifact types, not four scripts.

validate-skill.bats and validate-agent.bats run the same scripts/validate.sh and differ only in the fixtures they point it at. The two provenance suites stand in the same relation to scripts/validate-provenance.sh. Do not add a third script path here on the assumption that a differently named suite must mean a differently named script.

Auto-detection is pinned across the pair

Each entry point decides for itself what it was handed. ADR-0025 states the rule: a directory containing SKILL.md takes the skill flow; an .agent.md file, or a file under a directory named agents/, takes the agent flow. Anything else is rejected rather than guessed at. That behaviour is new with the merge — before it, each script was hard-wired to one artifact type and nothing about classification could be wrong — so it is asserted from both sides rather than in one place:

the skill-side suites pin the skill-directory classification and the neither-shape rejection,
the agent-side suites pin the two agent rules separately — .agent.md in a directory that is not agents/, and a plain .md under .apm/agents/ — so that a detector implementing only one of them cannot pass both. Plus a control asserting an agent file never picks up a skill-only gate.

Both skill-side suites additionally pin the SKILL.md file path, not just the directory: a pre-commit files: hook matches files, so every hook-driven invocation hands over a SKILL.md path. Each entry point resolves it to the directory, and the suites assert the two spellings produce the identical verdict rather than merely that the file spelling survives.

A misclassification is silent and total — the wrong rubric runs end to end and reports the artifact clean against gates that never applied to it — and no other fixture in these suites would notice, because every other fixture is already the shape its own suite expects.

The two provenance exit contracts are different on purpose

scripts/validate-provenance.sh does not behave identically in its two modes, and the difference is deliberate:

Mode	Successful run
skill	may exit 0 with output — INFO findings print, status stays 0
agent	exits 0 and prints nothing

Each half is asserted from its own side, by the exit contract: test in each provenance suite. Both are asserted on purpose: a merge that collapsed one contract into the other would still satisfy whichever side was left unasserted, so a single-sided pin would go green on exactly the defect it exists to catch.

4.1 KiB Raw Blame History Unescape Escape