Defame1297
e849a823f7
boundary_clause_status() ran BOUNDARY_ARROW.search() and _arrow_targets()
over the whole description, so one arrow clause that parsed suppressed the
diagnostic for every other clause in it. A backticked hyphenated routing
target wrapped across lines in a folded scalar was therefore silently
unchecked -- no error, no suggestion, exit 0 -- whenever the description
carried one other clause that parsed. Written bare, the same wrap errors
correctly. That is the shape #100 regressed on.
The check is now per clause. Nothing that passed starts failing: all 68
routing targets across the 38 SKILL.md files resolved before and still do.
26 of those descriptions carry more than one arrow clause, so the
suppression was live across two thirds of the corpus, not an edge case.
validate-skill.bats pins the shape. test-adr0020-targets.sh's comment
described the #100 regression as a backticked wrap; the historical text was
unbackticked, which is precisely the shape the gate did not catch.
Also closes three README misroutes the branch left in the enforcement
layer: CompositionNote.yml's message, agent-description-quality.md:58 and
vale-wrap.sh's header still sent overflow to a skill-root README.md and
named the two skills ADR-0025 merged away. 1ec3e8a fixed the prose and
missed the rules that enforce it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NwD8Egs5r4ndqeFLmhusX2
tests/
Test files for scripts bundled with this skill.
When to add tests
Add tests here when the skill has scripts in scripts/ that are complex enough
to break silently — validators, parsers, generators, anything with branching
logic or edge cases. Test infrastructure (.bats, *_test.*, test_*.sh)
belongs here, not in scripts/.
Dependencies
Tests require bats-support and
bats-assert. The test files load
helpers from the repo root's tests/test_helper/.
From the repo root:
git clone https://github.com/bats-core/bats-support tests/test_helper/bats-support
git clone https://github.com/bats-core/bats-assert tests/test_helper/bats-assert
Run all tests for this skill (from the repo root):
bats plugins/kyberforge/.apm/skills/factory-audit/tests/
Files
| File | Purpose |
|---|---|
validate-skill.bats |
scripts/validate.sh against skill directories |
validate-agent.bats |
scripts/validate.sh against agent files |
validate-provenance-skill.bats |
scripts/validate-provenance.sh against skill directories |
validate-provenance-agent.bats |
scripts/validate-provenance.sh against agent files |
Two scripts, four suites
factory-audit merges what were two skills — skill-audit and agent-audit —
each of which shipped its own validate.sh and validate-provenance.sh. The
merged skill has one of each. Every suite here invokes one of those two
scripts; the four files are two scripts × two artifact types, not four scripts.
validate-skill.bats and validate-agent.bats run the same
scripts/validate.sh and differ only in the fixtures they point it at. The two
provenance suites stand in the same relation to scripts/validate-provenance.sh.
Do not add a third script path here on the assumption that a differently named
suite must mean a differently named script.
Auto-detection is pinned across the pair
Each entry point decides for itself what it was handed. ADR-0025 states the
rule: a directory containing SKILL.md takes the skill flow; an .agent.md
file, or a file under a directory named agents/, takes the agent flow.
Anything else is rejected rather than guessed at. That behaviour is new with the
merge — before it, each script was hard-wired to one artifact type and nothing
about classification could be wrong — so it is asserted from both sides rather
than in one place:
- the skill-side suites pin the skill-directory classification and the neither-shape rejection,
- the agent-side suites pin the two agent rules separately —
.agent.mdin a directory that is notagents/, and a plain.mdunder.apm/agents/— so that a detector implementing only one of them cannot pass both. Plus a control asserting an agent file never picks up a skill-only gate.
Both skill-side suites additionally pin the SKILL.md file path, not just
the directory: a pre-commit files: hook matches files, so every hook-driven
invocation hands over a SKILL.md path. Each entry point resolves it to the
directory, and the suites assert the two spellings produce the identical
verdict rather than merely that the file spelling survives.
A misclassification is silent and total — the wrong rubric runs end to end and reports the artifact clean against gates that never applied to it — and no other fixture in these suites would notice, because every other fixture is already the shape its own suite expects.
The two provenance exit contracts are different on purpose
scripts/validate-provenance.sh does not behave identically in its two
modes, and the difference is deliberate:
| Mode | Successful run |
|---|---|
| skill | may exit 0 with output — INFO findings print, status stays 0 |
| agent | exits 0 and prints nothing |
Each half is asserted from its own side, by the exit contract: test in each
provenance suite. Both are asserted on purpose: a merge that collapsed one
contract into the other would still satisfy whichever side was left unasserted,
so a single-sided pin would go green on exactly the defect it exists to catch.