Defame1297
38f1ba4e03
Claude Code's (and Copilot's) native plugin installer has zero awareness of .apm/ nesting -- it convention-scans only flat skills/, agents/, commands/, hooks.json at each plugin's root. Confirmed via strings on the installed claude binary and live installs of git@holocron/gitea@holocron/kyberforge@ holocron, all reporting Skills(0) Agents(0) Hooks(0) post ADR-0015's apm conversion. Root cause (apm_cli/core/plugin_manifest.py): apm's plugin.json compiler deliberately strips skills/agents/commands keys, assuming the host already auto-discovers those convention directories -- it has no model of .apm/ being host-visible at all. Separately, apm's own bundle exporter (apm_cli/bundle/plugin_exporter.py, behind `apm pack --format plugin`) implements the correct .apm/ -> flat mapping, but only ever targeted build/<name>-<version>/, a path nothing in marketplace.json's source: points at. scripts/sync-plugin-content.sh wraps that bundle exporter and copies its agents/, skills/, commands/, instructions/, extensions/, and merged hooks.json back into each plugin's own root as a second tracked compiled-output category -- same governance status as .claude-plugin/plugin.json: generated from .apm/, never hand-edited. tests/ subdirectories are excluded from the mirror (dev fixtures, not host-visible runtime content; several hardcode a relative repo-root walk-up sized for the .apm/-nested depth, which breaks when duplicated one level shallower). Applied for real across all 6 plugins and verified two ways: `claude plugin validate --strict` passes on every real plugin directory, and a live `claude --plugin-dir <path> -p "list skills/agents"` behavioral test confirms content is now actually discovered. Also, from the same issue #90 review round: - scripts/check-manifests.sh pointed at each plugin's root-level plugin.json (checking skills/hooks/mcpServers/agents pointer fields) -- that file was a stale near-duplicate of .claude-plugin/plugin.json nothing else read or wrote, now deleted across all 6 plugins. check-manifests.sh is rewritten to validate .claude-plugin/plugin.json instead, and drops the pointer-field checks entirely (nothing to check -- those fields are correctly absent by design). Content-presence drift is now check-plugin-content-sync's job, a new pre-push hook wired in .pre-commit-config.yaml. docs/adr/0017 records the root cause and decision in full, including two rejected alternatives (patching plugin.json's path fields directly -- apm's compiler strips them on every run; pointing marketplace.json at apm pack's build/ output -- a version-suffixed non-source directory nothing can install from without an extra build step). ADR-0015 and CONTEXT.md are updated to point at it. Refs: #90
3.4 KiB
topic, source_keys
| topic | source_keys | ||
|---|---|---|---|
| milestones |
|
Milestone operations
Execution detail for milestone_read and milestone_write. Milestones are always repo-scoped —
there is no org-level milestone concept, unlike labels.
Verified live schemas
milestone_read — required: method, owner, repo.
| Param | Type | Notes |
|---|---|---|
method |
string (enum) | "get" | "list" |
owner |
string | required |
repo |
string | required |
id |
number | milestone ID, required for "get" |
name |
string | title filter, for "list" |
state |
string | default "all" — conventional values "open"/"closed"/"all", but not enforced by an enum in the live schema (plain string). Any other value is passed through to Gitea rather than rejected client-side. |
page |
number | default 1 |
per_page |
number | default 30 |
milestone_write — required: method, owner, repo.
| Param | Type | Notes |
|---|---|---|
method |
string (enum) | "create" | "update" | "edit" | "delete" — "update"/"edit" are aliases for the same operation; prefer "update" |
owner |
string | required |
repo |
string | required |
id |
number | required for update/delete |
title |
string | required for create |
description |
string | optional |
due_on |
string | due date — the live tool schema only describes this as an opaque "due date" string with no enforced format; ISO 8601 (e.g. "2025-03-01T00:00:00Z") is the conventional value Gitea's REST API accepts, not something confirmed by the live MCP schema itself |
state |
string (enum) | "open" | "closed" — this one is schema-enforced, unlike milestone_read's state |
Note: unlike label_read/label_write, both milestone tools hard-require owner and repo at the
schema level — there's no scope variant to omit them for.
List milestones
milestone_read method: "list" owner: <owner> repo: <repo> state: "open"
Report each as: id, title, state, due date, open/closed issue counts.
Get one milestone
milestone_read method: "get" owner: <owner> repo: <repo> id: <id>
Resolve a milestone ID from a title
Needed whenever the only handle available is a title — e.g. a pull_request_read response, which
returns milestone as a bare title string rather than {id, title}. Call:
milestone_read method: "list" owner: <owner> repo: <repo> name: <title>
and take the id of the matching result. If name filtering returns no match (e.g. due to a
title typo or case mismatch), fall back to listing without the filter and matching manually.
Create a milestone
milestone_write method: "create"
owner: <owner> repo: <repo>
title: "v1.0"
description: "First stable release"
due_on: "2025-03-01T00:00:00Z"
Report the returned ID — the caller (gitea-issues/gitea-prs) needs it to assign issues/PRs to
this milestone via issue_write/pull_request_write.
Update or close a milestone
milestone_write method: "update" owner: <owner> repo: <repo> id: <id> state: "closed"
Only pass the fields being changed — id plus any of title/description/due_on/state.
Delete a milestone
milestone_write method: "delete" owner: <owner> repo: <repo> id: <id>
Deleting a milestone does not delete or unassign the issues/PRs that referenced it — they simply lose the milestone reference.