Files

Defame1297 f7cc27908c fix(kyberforge): close the vacuous-green and consumer-resolution defects

Review of the ADR-0020 gate found four ways it could exit 0 without measuring, and
one way it hard-failed a repo it had no business failing. On a gate shipping hot
with no baseline, a silent pass is the worst outcome available and a false block is
the second worst.

Consumer resolution was the blocker. _authoring_root() fell back to the nearest
.git, so it returned truthy in ANY git repo; _collect_authoring_root() then
contributed nothing and the deployed-tree branch was dead code in precisely the
consumer case it exists for. A consumer repo routing to an installed sibling got an
unblockable ERROR, and deleting .git "fixed" it. It now keys on which of the two
walk-up passes matched. A name-count delta was tried first and is wrong: a
single-plugin monorepo re-collects its own package and adds no new name, so the
delta reads zero and drags the deployed trees — including a global ~/.claude — back
into the universe. That reintroduces the install-dependence ADR-0020 forbids, one
layer down.

The three silent passes: an indented `---` inside a block scalar truncated the
frontmatter and reclassified the rest of the description as body; a non-string
description was str()-coerced, so `description: true` measured as the four-character
"True"; and an unterminated fence blanked the rest of the body, disabling the
ERROR-tier references/ check and the gotcha counts.

Two measurement defects came with them. The awk line/word counts discarded awk's
exit status, so an unreadable file passed both spec ceilings in total silence, and
awk NR/NF disagreed with the audit script's splitlines()/split() on Unicode
whitespace — the "fix one gate, get blocked by the other" bug, on the two axes the
differential test deliberately excluded. Both counts now run in the Python block
that already reads the file. A type error also no longer reports itself as a syntax
error.

Also: glob metacharacters in the checkout path silently disabled the resolver;
re.I was applied to some extraction patterns and not others; agent-audit missed
`tools:` written as a YAML block sequence, the shape Copilot files use; and a
nonexistent agent file raised a bare FileNotFoundError instead of a diagnostic.

The shared resolver block stays byte-identical across all three scripts. Corpus
output is unchanged — 26 description FAIL, 9 body FAIL, 2 dangling, 0 missing
references, 58 SUGGESTIONs — so no documented count moves.

Refs: #99
ADR: 0020

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015W3iwF9ncfRZddGBxsMCYi

2026-08-16 19:48:56 +00:00

assets/vale

feat(kyberforge): enforce the ADR-0020 context contract for skills and agents

2026-08-14 21:13:13 +00:00

references

fix(kyberforge): reconcile the authoring rules the ADR-0020 trim left disagreeing

2026-08-16 16:40:51 +00:00

scripts

fix(kyberforge): close the vacuous-green and consumer-resolution defects

2026-08-16 19:48:56 +00:00

README.md

feat(kyberforge): enforce the ADR-0020 context contract for skills and agents

2026-08-14 21:13:13 +00:00

SKILL.md

feat(kyberforge): enforce the ADR-0020 context contract for skills and agents

2026-08-14 21:13:13 +00:00

README.md

agent-audit

Audits an agent definition for correctness and quality against the Claude Code and Copilot agent references and the house context-budget contract (ADR-0020) — a single vendor-neutral file at plugin/APM scope, or a Claude Code and Copilot file pair at project/user scope.

What it does

Runs scripts/validate.sh and scripts/validate-provenance.sh for structural and provenance checks, plus scripts/vale-wrap.sh — a Vale prefilter that deterministically flags non-imperative description openers, composition and architecture notes, vague wording, padding phrases, "There is/are" sentence openers, and CC-specific "Use proactively" phrasing in a Copilot or vendor-neutral description
Reads the agent file, and its counterpart when one exists, then loads the contract for its scope
Applies qualitative checks across description, body, delegation and comment discipline, loading one rubric from references/ per group
Outputs a compact findings report — findings only, grouped by dimension, each with Why and Fix — and a result block with handoff to agent-author

Two things follow from ADR-0020 and are easy to get backwards. Agents take the same description gates a skill takes — 250 characters SUGGESTION, 400 FAIL, since a name + description is preloaded into every session either way — and no body word gate at all, because an agent body becomes the system prompt of a fresh context rather than competing with the caller's live conversation. Body length is judged through the delegation check instead: an agent body that restates a procedure owned by a skill it can invoke is a FAIL, because a plugin-scope agent has no sibling references/ directory to disclose to and can only delegate.

At plugin/APM scope the audit accepts the single .apm/agents/<name>.agent.md file — there is no counterpart, and pair consistency does not apply. validate.sh hard-FAILs any frontmatter field outside the vendor-neutral allowlist, since apm compile copies frontmatter verbatim to both harnesses and an unsafe field cannot be silently dropped for just one of them. The allowlist lives in the apm-agent-allowlist section of references/field-inventory.md, is read from there as data by the script, and is deliberately not restated anywhere else in this skill (ADR-0009).

At project/user scope the audit accepts either file in a CC .md / Copilot .agent.md pair, derives the counterpart automatically, and validates both, including the field-leakage checks in each direction.

Usage

/agent-audit

Pass the path to either agent file as the argument.

Files

File	Purpose
`SKILL.md`	Skill instructions for agents
`assets/vale/.vale.ini`	Vale config: scopes `Kyberforge` to `*/agents/.md`, `Kyberforge`+`KyberforgeCopilot` to `*/.agent.md`
`assets/vale/styles/Kyberforge/CompositionNote.yml`	Flags composition and architecture notes in a description ("cross-cutting", "entry point", "composes", "rather than duplicating") that belong in README.md
`assets/vale/styles/Kyberforge/DescriptionOpener.yml`	Flags descriptions opening with "This..." instead of an imperative "Use when..."
`assets/vale/styles/Kyberforge/PaddingPhrase.yml`	Flags generic "see references/ for info" pointers instead of specific file references
`assets/vale/styles/Kyberforge/SentenceOpenerThereIs.yml`	Flags sentences opening with "There is/are" instead of naming the subject directly
`assets/vale/styles/Kyberforge/VagueWording.yml`	Flags vague capability wording ("helps with", "utilize", "assists with", "used for") in descriptions
`assets/vale/styles/KyberforgeCopilot/ProactivePhrase.yml`	Flags CC-specific "Use proactively" phrasing with no effect in Copilot descriptions
`references/README.md`	Directory documentation for references/
`references/description-quality.md`	Rubric for the description dimension — three-part shape, the 250/400-character budget, the hand-invoked contract, and the internal-mechanics FAIL
`references/body-and-delegation.md`	Rubric for the body, delegation and comment-discipline dimensions — the delegation FAIL and why agents take no body word gate
`references/scope-plugin-apm.md`	Scope contract for a single vendor-neutral APM agent file — allowlist, dimension routing, and the dimensions that do not apply
`references/scope-project-user.md`	Scope contract for a CC / Copilot pair — counterpart derivation, provider field rules, pair consistency
`references/validation-scripts.md`	Loaded only when a Step 1 script fails or cannot run — scope-detection walk-up, manual fallback checks, known script failures
`references/field-inventory.md`	Authoritative field lists read as data by `validate.sh`: valid CC and Copilot agent fields, and the vendor-neutral plugin/APM-scope allowlist
`references/sources.md`	Research provenance for skill content
`scripts/README.md`	Directory documentation for scripts/
`scripts/validate.sh`	Structural validator — required fields, name format, placeholder detection, the ADR-0020 description budget, and the field rules for the detected scope
`scripts/validate-provenance.sh`	Provenance chain validation against `sources.md` at the package root (plugin/APM scope only)
`scripts/vale-wrap.sh`	Drop-in `vale` wrapper that works around a frontmatter-description NLP scope limitation
`tests/README.md`	(source-only) Bats test dependency and run instructions
`tests/validate.bats`	(source-only) Bats tests for validate.sh
`tests/validate-provenance.bats`	(source-only) Bats tests for validate-provenance.sh

Rows marked (source-only) exist in the authoring source (.apm/skills/agent-audit/) but are not present in an installed plugin: scripts/sync-plugin-content.sh strips <category>/<name>/tests when it generates the flat mirror, because these are dev-time fixtures no plugin host needs to discover (ADR-0017). Run them from a repo checkout, not from an install.