-
Gitea user account used by Claude Code with Gitea MCP to manage repositories: read/write issues and PRs, comment on changes, and perform merge/review actions with appropriate permissions.
- Joined on
2026-06-20
7a5c50fecc
Merge pull request 'feat(kyberforge): add apm-install/apm-workflow/apm-orchestrate, ADR-0015' (#91) from feat/88-marketplace-apm-conversion into main
Resolved the second review round in 591b9cc.
Fixed:
- Wrong ADR citation in
plugin-author/SKILL.md(ADR-0016 doesn't exist → ADR-0006). - The deprecation banner this PR added to…
Review response
Ran a full /code-review pass on this PR (8 finder angles). 7 of 8 confirmed findings were fixed in d6fd9b6:
- apm-workflow description missing install trigger — added…
Summary of 92e7ff2 — a grill-me session resolved how plugin-author/marketplace-author relate to the newly-landed apm-install/apm-workflow/apm-orchestrate artifacts (issue…
Scope correction (per ADR-0015): per the ADR-0015 correction recorded on branch feat/88-marketplace-apm-conversion (commit 92e7ff2, "docs(kyberforge): narrow issue #89 scope, migrate CC…
Addressed all 6 findings from the latest review (review #24, re-review of e16c3dc) in 394052f:
- Dangling "secret indirection" reference (
apm-orchestrate.md/.agent.mdProcess step 2) —…
Process step 2 still tells the orchestrator to check the Hard rules for "secret indirection," but that Hard Rule bullet was deleted from the Hard rules section in this same PR's fix commit (e16c3dc), leaving a dangling reference to a rule that no longer exists.
ADR-0015 states "CONTEXT.md's Plugin/Skill/Plugin-marketplace glossary entries remain accurate as written until issue #90 actually executes — this ADR does not update them," but this same PR's fix commit (e16c3dc) edited CONTEXT.md's Plugin and Plugin marketplace entries to add an ADR-0015 forward-pointer sentence.
The "custom install directory" example APM_INSTALL_DIR=$HOME/.local/bin sh omits the `curl -sSL https://aka.ms/apm-unix
Neither apm-workflow's dispatch table nor apm-orchestrate's operation list ever routes to plain apm install [PACKAGE_REF] — the core command that actually resolves/downloads a dependency declared in apm.yml — and apm-install (the skill whose name most resembles it) is explicitly scoped only to installing the apm binary/runtime, not running apm install.
The Output contract here is collapsed to one prose sentence and omits the explicit error-code enum (`not_confirmed
This apm.yml schema block omits the "legacy singular target: CSV form is still accepted" caveat that the sibling research doc (docs/research/docs/microsoft-apm/configuration.md:32) documents for the same targets: field.
Full re-review of the fix commit (e16c3dc) against PR review conventions. 6 findings — mostly places where this same fix commit's own edits now contradict its own claims or leave dangling references. See inline comments.
The "custom install directory" example APM_INSTALL_DIR=$HOME/.local/bin sh omits the `curl -sSL https://aka.ms/apm-unix
Neither apm-workflow's dispatch table nor apm-orchestrate's operation list ever routes to plain apm install [PACKAGE_REF] — the core command that actually resolves/downloads a dependency declared in apm.yml — and apm-install (the skill whose name most resembles it) is explicitly scoped only to installing the apm binary/runtime, not running apm install.
The Output contract here is collapsed to one prose sentence and omits the explicit error-code enum (`not_confirmed
This apm.yml schema block omits the "legacy singular target: CSV form is still accepted" caveat that the sibling research doc (docs/research/docs/microsoft-apm/configuration.md:32) documents for the same targets: field.
Full re-review of the fix commit (e16c3dc) against PR review conventions. 6 findings — mostly places where this same fix commit's own edits now contradict its own claims or leave dangling references. See inline comments.