-
Gitea user account used by Claude Code with Gitea MCP to manage repositories: read/write issues and PRs, comment on changes, and perform merge/review actions with appropriate permissions.
- Joined on
2026-06-20
Scaffolds into the wrong directory for existing plugins. find_package_root() dropped the direct plugin.json check at $ROOT, so scaffolding a new agent inside an existing plugin.json-only plugin creates files in the wrong place.
.git-as-file (worktrees) not recognized as a boundary. The project-boundary check uses isdir()/[[ -d ]] in all four rewritten walk-up implementations, which misses git worktrees where .git is a regular file (gitdir: ...), not a directory.
Root-fallback scope disagrees with new-agent.sh. detect_scope()'s filesystem-root fallback returns 'user' scope (pinned to real $HOME), while new-agent.sh's equivalent fallback returns 'project' scope rooted at the given path — the two scripts disagree on any directory outside $HOME with no .git/apm.yml above it.
Misclassifies legacy plugin.json-only plugins. detect_scope() no longer recognizes plugin.json (only apm.yml), so existing plugin.json-only plugins are misclassified as project scope with the wrong counterpart path.
Documented parity with validate.sh doesn't hold. This usage text and agent-author/SKILL.md both claim this script walks up 'the same way validate.sh does', but it lacks validate.sh's $HOME-boundary and quote-tolerance handling — the documented behavioral parity is false (see the two paired findings above on this PR).
Not quote-tolerant, unlike validate.sh. TYPE_RE lacks the quote-tolerant ['\"]? group that validate.sh's APM_TYPE_RE has, so a quoted type: "skill" value is recognized as plugin scope by validate.sh but not by validate-provenance.sh (or new-agent.sh/new-skill.sh).
Silent no-op on plugin.json-only plugins. find_plugin_root() shares validate.sh's plugin.json blind spot, so provenance validation silently exits 0 (no check performed) for every existing plugin.json-only plugin.
Automated review findings (10) — all reproduced by direct script execution. Root cause: the plugin-scope walk-up logic (detect_scope/find_package_root) was independently reimplemented across four scripts (validate.sh, validate-provenance.sh, new-agent.sh, new-skill.sh) and the copies have drifted from each other and from the pre-PR behavior.
Allowlist contradicts agent-author's own instructions. apm-agent-allowlist omits source_keys, contradicting agent-author/SKILL.md's explicit instruction to add source_keys at plugin/APM scope when research-sourced — so a correctly-authored file fails validation.
Scaffolds into the wrong directory for existing plugins. find_package_root() dropped the direct plugin.json check at $ROOT, so scaffolding a new agent inside an existing plugin.json-only plugin creates files in the wrong place.
.git-as-file (worktrees) not recognized as a boundary. The project-boundary check uses isdir()/[[ -d ]] in all four rewritten walk-up implementations, which misses git worktrees where .git is a regular file (gitdir: ...), not a directory.
Root-fallback scope disagrees with new-agent.sh. detect_scope()'s filesystem-root fallback returns 'user' scope (pinned to real $HOME), while new-agent.sh's equivalent fallback returns 'project' scope rooted at the given path — the two scripts disagree on any directory outside $HOME with no .git/apm.yml above it.
Misclassifies legacy plugin.json-only plugins. detect_scope() no longer recognizes plugin.json (only apm.yml), so existing plugin.json-only plugins are misclassified as project scope with the wrong counterpart path.
Silent no-op on plugin.json-only plugins. find_plugin_root() shares validate.sh's plugin.json blind spot, so provenance validation silently exits 0 (no check performed) for every existing plugin.json-only plugin.
Documented parity with validate.sh doesn't hold. This usage text and agent-author/SKILL.md both claim this script walks up 'the same way validate.sh does', but it lacks validate.sh's $HOME-boundary and quote-tolerance handling — the documented behavioral parity is false (see the two paired findings above on this PR).
Not quote-tolerant, unlike validate.sh. TYPE_RE lacks the quote-tolerant ['\"]? group that validate.sh's APM_TYPE_RE has, so a quoted type: "skill" value is recognized as plugin scope by validate.sh but not by validate-provenance.sh (or new-agent.sh/new-skill.sh).
Loose regex lets malformed type: values false-match. This type: regex uses \b word-boundary matching (also present in validate.sh/validate-provenance.sh) instead of new-agent.sh's stricter `(:space:
Missing $HOME boundary check. find_package_root() has no $HOME boundary check (unlike new-agent.sh's), so the walk-up can continue past $HOME and bind to an unrelated ancestor package.