feat(kyberforge): execute plugin-to-apm marketplace conversion

Why: ADR-0015 established that Microsoft APM (apm.yml + .apm/) should replace this repo's hand-authored plugin.json/marketplace.json model, with those files becoming compiled output of `apm pack` instead of files edited by hand via the (now-retired) plugin-author/marketplace-author skills. Issue #90 was the deferred execution of that decision, gated on #88 (apm tooling) and #89 (apm-native agent-author/skill-author routing). Implementation notes: - All six plugins (bin, core, git, gitea, kyberforge, lint) now carry apm.yml + .apm/{skills,agents,hooks} as their authoring source. Skills moved with a plain git mv (content-identical across targets). Agents were re-authored, not moved: per ADR-0016, .apm/agents/*.agent.md compiles verbatim to both Claude and Copilot, so plugin-scope agents now carry only name/description/model/source_keys -- no tools: field, no Claude-only knobs (isolation, maxTurns, effort, memory, permissionMode). - Root apm.yml registers all 7 marketplace packages (6 local plus mattpocock-skills as a remote entry) under versioning: per_package, matching this repo's existing independent-plugin-versioning practice. - .claude-plugin/marketplace.json and every plugin's plugin.json are now apm-pack-compiled output, verified against the prior hand-maintained content: same names/descriptions/versions/licenses/authors, only cosmetic serialization differences (JSON key order, owner email vs. url, Unicode escaping). - plugin-author and marketplace-author are retired now that apm-based authoring fully replaces their job; kyberforge bumped 1.3.1 -> 1.4.0 for that removal, and the root marketplace catalog bumped 0.3.1 -> 0.3.2 to match, per the version-bump convention now documented in apm-workflow's reference docs instead of a dedicated script (apm has no native version-bump automation). - Fixed hardcoded pre-.apm/ path assumptions across .pre-commit-config.yaml, .pre-commit-hooks.yaml, scripts/check-scope-walkup-sync.sh, scripts/sync-vale-styles.sh, scripts/check-vale-style-sync.sh, six plugins' root plugin.json (stale skills/hooks/agents pointer fields that check-manifests.sh validates), and several tests/*.bats and tests/*.sh fixtures -- including a bats REPO_ROOT relative-path depth bug (10 files, one extra .apm/ directory level to walk up) and a vale probe-path isolation regression introduced mid-fix. - Corrected empirically-wrong assumptions surfaced this session in apm-workflow/apm-install's own reference docs: `apm marketplace package add` does not accept local paths (only owner/repo remote shorthand -- local packages are registered by editing apm.yml's marketplace.packages[] directly); `apm compile` is a consumer-side AGENTS.md/CLAUDE.md generator, not the plugin.json producer, and hard-fails on skill/agent-only packages without --clean; `apm plugin init <name>` nests a stray subdirectory when run with a positional name arg from inside a same-named directory; no native Copilot marketplace output profile exists; .mcp.json is merged into the compiled plugin.json content-aware and target-scoped, with no dependencies.mcp entry needed for simple passthrough; pipx is the correct pip fallback on externally-managed Python environments. - Renamed agent-author's copilot.agent.md template asset to copilot.agent.md.template so apm compile's recursive *.agent.md glob stops misparsing the placeholder template as a real agent primitive. Impact: plugin.json and marketplace.json are compiled artifacts from here on -- editing them by hand is no longer the workflow; edit apm.yml/.apm/ and run apm pack. CONTEXT.md's Plugin/Plugin marketplace glossary entries reflect this. ADR-0001 is marked superseded, ADR-0006 moot, and ADR-0010 updated for the new .apm/agents/ path (project/user scope unaffected, per ADR-0016). Full local verification: claude plugin validate --strict on all 6 plugins, apm audit --ci, apm marketplace check, check-manifests.sh, and the full test suite (165/165 bats, 13/13 shell scripts) all pass clean. Fixes: #90 Refs: #88, #89 ADR: 0015 ADR: 0016 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ub96PyaSRD9BHPktotj1pC
2026-08-12 18:09:37 +00:00
parent 50d5c30a3c
commit 5e232503c4
289 changed files with 741 additions and 1974 deletions
--- a/plugins/core/.apm/skills/agentsmd-audit/tests/README.md
+++ b/plugins/core/.apm/skills/agentsmd-audit/tests/README.md
@@ -0,0 +1,30 @@
+# tests/
+
+Test files for scripts bundled with this skill.
+
+## Dependencies
+
+Tests require [bats-support](https://github.com/bats-core/bats-support) and
+[bats-assert](https://github.com/bats-core/bats-assert). The test files load
+helpers from the repo root's `tests/test_helper/`.
+
+From the repo root:
+
+```bash
+git clone https://github.com/bats-core/bats-support tests/test_helper/bats-support
+git clone https://github.com/bats-core/bats-assert tests/test_helper/bats-assert
+```
+
+Run all tests for this skill (from the repo root):
+
+```bash
+bats plugins/core/.apm/skills/agentsmd-audit/tests/
+```
+
+## Files
+
+| File | Purpose |
+|------|---------|
+| `validate-secrets.bats` | Bats test suite for `scripts/validate-secrets.sh` |
+| `validate-structure.bats` | Bats test suite for `scripts/validate-structure.sh` |
+| `validate-drift.bats` | Bats test suite for `scripts/validate-drift.sh` |
--- a/plugins/core/.apm/skills/agentsmd-audit/tests/validate-drift.bats
+++ b/plugins/core/.apm/skills/agentsmd-audit/tests/validate-drift.bats
@@ -0,0 +1,105 @@
+#!/usr/bin/env bats
+
+setup() {
+    REPO_ROOT="$(cd "$BATS_TEST_DIRNAME/../../../../../../" && pwd)"
+    load "$REPO_ROOT/tests/test_helper/bats-support/load"
+    load "$REPO_ROOT/tests/test_helper/bats-assert/load"
+
+    SCRIPT="$(cd "$BATS_TEST_DIRNAME/../scripts" && pwd)/validate-drift.sh"
+    TMPDIR="$(mktemp -d)"
+}
+
+teardown() {
+    rm -rf "$TMPDIR"
+}
+
+@test "fails when AGENTS.md references a stale npm script" {
+    cat > "$TMPDIR/package.json" <<'EOF'
+{
+  "scripts": {
+    "test": "jest"
+  }
+}
+EOF
+    cat > "$TMPDIR/AGENTS.md" <<'EOF'
+# AGENTS.md
+
+## Testing
+- Run `pnpm run e2e` before committing.
+EOF
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_failure
+    assert_output --partial "e2e"
+}
+
+@test "passes when the referenced npm script exists" {
+    cat > "$TMPDIR/package.json" <<'EOF'
+{
+  "scripts": {
+    "test": "jest"
+  }
+}
+EOF
+    cat > "$TMPDIR/AGENTS.md" <<'EOF'
+# AGENTS.md
+
+## Testing
+- Run `npm run test` before committing.
+EOF
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_success
+}
+
+@test "fails when AGENTS.md references a stale make target" {
+    cat > "$TMPDIR/Makefile" <<'EOF'
+build:
+	echo building
+EOF
+    cat > "$TMPDIR/AGENTS.md" <<'EOF'
+# AGENTS.md
+
+## Setup
+Run `make deploy` to ship.
+EOF
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_failure
+    assert_output --partial "deploy"
+}
+
+@test "emits INFO instead of FAIL when there is no package.json to verify an npm script against" {
+    cat > "$TMPDIR/AGENTS.md" <<'EOF'
+# AGENTS.md
+
+## Testing
+Run `pnpm run e2e` before committing.
+EOF
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_success
+    assert_output --partial "INFO"
+    assert_output --partial "e2e"
+}
+
+@test "fails when a referenced file path does not exist" {
+    cat > "$TMPDIR/AGENTS.md" <<'EOF'
+# AGENTS.md
+
+## Setup
+See `scripts/bootstrap.sh` for environment setup.
+EOF
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_failure
+    assert_output --partial "scripts/bootstrap.sh"
+}
+
+@test "passes when the referenced file path exists" {
+    mkdir -p "$TMPDIR/scripts"
+    : > "$TMPDIR/scripts/bootstrap.sh"
+    cat > "$TMPDIR/AGENTS.md" <<'EOF'
+# AGENTS.md
+
+## Setup
+See `scripts/bootstrap.sh` for environment setup.
+EOF
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_success
+}
--- a/plugins/core/.apm/skills/agentsmd-audit/tests/validate-secrets.bats
+++ b/plugins/core/.apm/skills/agentsmd-audit/tests/validate-secrets.bats
@@ -0,0 +1,68 @@
+#!/usr/bin/env bats
+
+setup() {
+    REPO_ROOT="$(cd "$BATS_TEST_DIRNAME/../../../../../../" && pwd)"
+    load "$REPO_ROOT/tests/test_helper/bats-support/load"
+    load "$REPO_ROOT/tests/test_helper/bats-assert/load"
+
+    SCRIPT="$(cd "$BATS_TEST_DIRNAME/../scripts" && pwd)/validate-secrets.sh"
+    TMPDIR="$(mktemp -d)"
+}
+
+teardown() {
+    rm -rf "$TMPDIR"
+}
+
+@test "passes on AGENTS.md with no secrets, only placeholders" {
+    cat > "$TMPDIR/AGENTS.md" <<'EOF'
+# AGENTS.md
+
+## Setup
+- Set `export API_KEY=$API_KEY`
+- Token: <your-token-here>
+- DB: postgres://user:changeme@localhost/db
+EOF
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_success
+    assert_output ""
+}
+
+@test "fails on a real-looking AWS access key" {
+    cat > "$TMPDIR/AGENTS.md" <<'EOF'
+# AGENTS.md
+
+## Setup
+- AWS_ACCESS_KEY_ID=AKIAABCDEFGHIJKLMNOP # gitleaks:allow (synthetic fixture — this test verifies validate-secrets.sh catches exactly this pattern)
+EOF
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_failure
+    assert_output --partial "AWS access key ID"
+    assert_output --partial "AGENTS.md:4"
+}
+
+@test "fails on a credential-bearing connection string" {
+    cat > "$TMPDIR/AGENTS.md" <<'EOF'
+# AGENTS.md
+
+## Setup
+- DB: postgres://svc_user:h8x2Klm9pQrT@db.internal:5432/prod
+EOF
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_failure
+    assert_output --partial "connection string"
+}
+
+@test "detects secrets in a nested AGENTS.md, not just root" {
+    mkdir -p "$TMPDIR/packages/api"
+    cat > "$TMPDIR/AGENTS.md" <<'EOF'
+# AGENTS.md
+Clean root file.
+EOF
+    cat > "$TMPDIR/packages/api/AGENTS.md" <<'EOF'
+# API package
+- token: ghp_1234567890abcdefghijklmnopqrstuvwxyz01 # gitleaks:allow (synthetic fixture)
+EOF
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_failure
+    assert_output --partial "packages/api/AGENTS.md"
+}
--- a/plugins/core/.apm/skills/agentsmd-audit/tests/validate-structure.bats
+++ b/plugins/core/.apm/skills/agentsmd-audit/tests/validate-structure.bats
@@ -0,0 +1,76 @@
+#!/usr/bin/env bats
+
+setup() {
+    REPO_ROOT="$(cd "$BATS_TEST_DIRNAME/../../../../../../" && pwd)"
+    load "$REPO_ROOT/tests/test_helper/bats-support/load"
+    load "$REPO_ROOT/tests/test_helper/bats-assert/load"
+
+    SCRIPT="$(cd "$BATS_TEST_DIRNAME/../scripts" && pwd)/validate-structure.sh"
+    TMPDIR="$(mktemp -d)"
+}
+
+teardown() {
+    rm -rf "$TMPDIR"
+}
+
+@test "fails on an empty AGENTS.md" {
+    : > "$TMPDIR/AGENTS.md"
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_failure
+    assert_output --partial "empty"
+}
+
+@test "fails on an unfilled placeholder AGENTS.md" {
+    cat > "$TMPDIR/AGENTS.md" <<'EOF'
+# AGENTS.md
+
+## Setup
+FILL IN: describe setup commands here.
+EOF
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_failure
+    assert_output --partial "placeholder"
+}
+
+@test "passes with INFO on real content missing an optional section" {
+    cat > "$TMPDIR/AGENTS.md" <<'EOF'
+# AGENTS.md
+
+## Setup commands
+- Install deps: `pnpm install`
+- Run tests: `pnpm test`
+
+## Code style
+- TypeScript strict mode, single quotes, no semicolons.
+EOF
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_success
+    assert_output --partial "INFO"
+    assert_output --partial "security"
+}
+
+@test "suggests trimming a nested AGENTS.md that duplicates the root file" {
+    mkdir -p "$TMPDIR/packages/api"
+    cat > "$TMPDIR/AGENTS.md" <<'EOF'
+# AGENTS.md
+
+## Setup commands
+- Install deps: `pnpm install`
+- Run tests: `pnpm test`
+- Lint: `pnpm lint`
+- Build: `pnpm build`
+EOF
+    cat > "$TMPDIR/packages/api/AGENTS.md" <<'EOF'
+# AGENTS.md
+
+## Setup commands
+- Install deps: `pnpm install`
+- Run tests: `pnpm test`
+- Lint: `pnpm lint`
+- Build: `pnpm build`
+EOF
+    run bash "$SCRIPT" "$TMPDIR"
+    assert_success
+    assert_output --partial "SUGGESTION"
+    assert_output --partial "packages/api/AGENTS.md"
+}