feat(kyberforge): execute plugin-to-apm marketplace conversion

Why: ADR-0015 established that Microsoft APM (apm.yml + .apm/) should replace this repo's hand-authored plugin.json/marketplace.json model, with those files becoming compiled output of `apm pack` instead of files edited by hand via the (now-retired) plugin-author/marketplace-author skills. Issue #90 was the deferred execution of that decision, gated on #88 (apm tooling) and #89 (apm-native agent-author/skill-author routing). Implementation notes: - All six plugins (bin, core, git, gitea, kyberforge, lint) now carry apm.yml + .apm/{skills,agents,hooks} as their authoring source. Skills moved with a plain git mv (content-identical across targets). Agents were re-authored, not moved: per ADR-0016, .apm/agents/*.agent.md compiles verbatim to both Claude and Copilot, so plugin-scope agents now carry only name/description/model/source_keys -- no tools: field, no Claude-only knobs (isolation, maxTurns, effort, memory, permissionMode). - Root apm.yml registers all 7 marketplace packages (6 local plus mattpocock-skills as a remote entry) under versioning: per_package, matching this repo's existing independent-plugin-versioning practice. - .claude-plugin/marketplace.json and every plugin's plugin.json are now apm-pack-compiled output, verified against the prior hand-maintained content: same names/descriptions/versions/licenses/authors, only cosmetic serialization differences (JSON key order, owner email vs. url, Unicode escaping). - plugin-author and marketplace-author are retired now that apm-based authoring fully replaces their job; kyberforge bumped 1.3.1 -> 1.4.0 for that removal, and the root marketplace catalog bumped 0.3.1 -> 0.3.2 to match, per the version-bump convention now documented in apm-workflow's reference docs instead of a dedicated script (apm has no native version-bump automation). - Fixed hardcoded pre-.apm/ path assumptions across .pre-commit-config.yaml, .pre-commit-hooks.yaml, scripts/check-scope-walkup-sync.sh, scripts/sync-vale-styles.sh, scripts/check-vale-style-sync.sh, six plugins' root plugin.json (stale skills/hooks/agents pointer fields that check-manifests.sh validates), and several tests/*.bats and tests/*.sh fixtures -- including a bats REPO_ROOT relative-path depth bug (10 files, one extra .apm/ directory level to walk up) and a vale probe-path isolation regression introduced mid-fix. - Corrected empirically-wrong assumptions surfaced this session in apm-workflow/apm-install's own reference docs: `apm marketplace package add` does not accept local paths (only owner/repo remote shorthand -- local packages are registered by editing apm.yml's marketplace.packages[] directly); `apm compile` is a consumer-side AGENTS.md/CLAUDE.md generator, not the plugin.json producer, and hard-fails on skill/agent-only packages without --clean; `apm plugin init <name>` nests a stray subdirectory when run with a positional name arg from inside a same-named directory; no native Copilot marketplace output profile exists; .mcp.json is merged into the compiled plugin.json content-aware and target-scoped, with no dependencies.mcp entry needed for simple passthrough; pipx is the correct pip fallback on externally-managed Python environments. - Renamed agent-author's copilot.agent.md template asset to copilot.agent.md.template so apm compile's recursive *.agent.md glob stops misparsing the placeholder template as a real agent primitive. Impact: plugin.json and marketplace.json are compiled artifacts from here on -- editing them by hand is no longer the workflow; edit apm.yml/.apm/ and run apm pack. CONTEXT.md's Plugin/Plugin marketplace glossary entries reflect this. ADR-0001 is marked superseded, ADR-0006 moot, and ADR-0010 updated for the new .apm/agents/ path (project/user scope unaffected, per ADR-0016). Full local verification: claude plugin validate --strict on all 6 plugins, apm audit --ci, apm marketplace check, check-manifests.sh, and the full test suite (165/165 bats, 13/13 shell scripts) all pass clean. Fixes: #90 Refs: #88, #89 ADR: 0015 ADR: 0016 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ub96PyaSRD9BHPktotj1pC
2026-08-12 18:09:37 +00:00
parent 50d5c30a3c
commit 5e232503c4
289 changed files with 741 additions and 1974 deletions
--- a/plugins/kyberforge/.apm/skills/skill-audit/references/body-discipline.md
+++ b/plugins/kyberforge/.apm/skills/skill-audit/references/body-discipline.md
@@ -0,0 +1,88 @@
+---
+source_keys:
+  - agentskills-spec
+  - agentskills-best-practices
+---
+
+# Body Discipline Reference
+
+Source: agentskills.io — skill-authoring
+
+## The core test
+
+For every sentence in the body, ask: **"Would the agent get this wrong without this instruction?"**
+
+If no — cut it. The agent already knows it from general training. Adding it wastes tokens and dilutes the signal of what matters.
+
+## What belongs in the body
+
+Include content the agent lacks:
+- Project-specific conventions and domain procedures it cannot infer
+- Non-obvious edge cases and environment-specific gotchas
+- The specific tools or sequences to use (not the full range of options)
+- One default per decision point with one escape hatch
+
+Do not include:
+- Concepts the agent already knows (what JSON is, how HTTP works, what a CSV is)
+- Exhaustive option lists — pick a default; the agent doesn't benefit from choosing
+- Steps the agent handles independently — over-specifying leads to unproductive paths
+- Restatements of the description — it's already in context
+
+## Calibrating control
+
+**Be prescriptive** when operations are fragile, consistency matters, or a specific sequence must be followed:
+```markdown
+Run exactly:
+\`\`\`bash
+python scripts/migrate.py --verify --backup
+\`\`\`
+Do not modify the command or add additional flags.
+```
+
+**Give freedom** when multiple approaches are valid. Explaining *why* outperforms rigid directives — agents make better decisions when they understand the purpose.
+
+## Defaults not menus
+
+Never present a list of equivalent options — pick one and mention the alternative briefly:
+```markdown
+# Too many options
+Use pypdf, pdfplumber, PyMuPDF, or pdf2image...
+
+# Default with escape hatch
+Use pdfplumber for text extraction. For scanned PDFs requiring OCR, use pdf2image instead.
+```
+
+## Gotchas sections
+
+Highest value content — environment-specific facts that defy reasonable assumptions. Place near the top of the body so the agent reads them before encountering the situation.
+
+```markdown
+## Gotchas
+- The `users` table uses soft deletes. Always include `WHERE deleted_at IS NULL`.
+- User ID is `user_id` in the database, `uid` in auth, `accountId` in billing. Same value.
+```
+
+Each entry must be a specific, surprising fact — not a general tip or reminder.
+
+## Progressive disclosure
+
+Keep `SKILL.md` under 500 lines. When more content is needed, move it to `references/` and load conditionally:
+
+```markdown
+If the API returns a non-200 status, read `references/api-errors.md`.
+```
+
+"If X, read Y" is more useful than "see references/ for details." The agent loads on demand rather than up front.
+
+## Auditing guidance
+
+Flag as FAIL if:
+- A sentence answers "no" to the core test (would agent get this wrong without it?) — it is padding
+- Decision points present a menu of options with no default
+- Instructions repeat content already in the description
+- Prescriptive sequences are used where flexibility is fine, or vice versa
+
+Flag as SUGGESTION if:
+- A rationale is missing from an include/exclude rule (present but unexplained)
+- Gotchas are correct but placed late in the body rather than near the top
+- A conditional reference trigger is vague ("see references/") rather than specific ("If X, read Y")
--- a/plugins/kyberforge/.apm/skills/skill-audit/references/description-quality.md
+++ b/plugins/kyberforge/.apm/skills/skill-audit/references/description-quality.md
@@ -0,0 +1,54 @@
+---
+source_keys:
+  - agentskills-spec
+  - agentskills-optimizing-descriptions
+---
+
+# Description Quality Reference
+
+Source: agentskills.io — optimizing-descriptions
+
+## How triggering works
+
+At startup, agents load only the `name` and `description` of each skill. When a user's task matches a description, the agent reads the full `SKILL.md` into context. **The description carries the entire triggering burden** — the body is never seen until after triggering.
+
+Agents typically consult skills only for tasks requiring knowledge beyond their defaults. Specialized knowledge — unfamiliar APIs, domain-specific workflows, uncommon formats — is where description wording makes the difference.
+
+## What a good description does
+
+- **Imperative phrasing** — "Use when..." not "This skill does...". The agent is deciding whether to act.
+- **User intent, not mechanics** — describe what the user is trying to achieve, not how the skill works internally.
+- **Err toward being pushy** — explicitly name contexts where the skill applies, including cases where the user doesn't name the domain: "even if they don't mention X explicitly."
+- **Specificity over vagueness** — "parses and validates OpenAPI specs" beats "helps with APIs."
+- **Near-miss exclusions** — add "Do not use when..." only if a near-miss skill exists that could steal activations. Use strong near-misses (queries that share keywords but need something different), not weak ones ("write a fibonacci function").
+- **Hard limit: 1024 characters** — descriptions grow during revision; check length before finalising.
+
+## Before / after
+
+```yaml
+# Weak
+description: Process CSV files.
+
+# Strong
+description: >
+  Analyze CSV and tabular data files — compute summary statistics,
+  add derived columns, generate charts, and clean messy data. Use when
+  the user has a CSV, TSV, or Excel file and wants to explore, transform,
+  or visualize the data, even if they don't explicitly mention "CSV" or
+  "analysis."
+```
+
+The strong version names capabilities precisely and broadens applicability beyond explicit keyword matches.
+
+## Auditing guidance
+
+Flag as FAIL if:
+- Phrasing is descriptive ("This skill...") not imperative ("Use when...")
+- Capabilities are vague ("helps with APIs") — require precise verbs and nouns
+- No indirect trigger coverage when indirect cases clearly exist
+- No near-miss exclusions when a sibling skill could plausibly steal activations
+- Length exceeds 1024 characters
+
+Flag as SUGGESTION if:
+- Indirect trigger coverage exists but could be more specific
+- Near-miss exclusions are present but target weak near-misses only
--- a/plugins/kyberforge/.apm/skills/skill-audit/references/sources.md
+++ b/plugins/kyberforge/.apm/skills/skill-audit/references/sources.md
@@ -0,0 +1,59 @@
+# Sources
+
+<!-- agentskills.io/llms.txt was used for initial source discovery and is not listed below; it contributed no skill file content directly. -->
+
+## agentskills-home
+
+- **URL:** https://agentskills.io/home.md
+- **Research doc:** plugins/kyberforge/docs/research/docs/agentskillsio/sources.md
+- **Description:** Agent Skills overview — what it is, why it exists, progressive disclosure model, ecosystem of 35+ implementing tools
+- **Contributing files:** SKILL.md
+- **Status:** `extracted`
+
+## agentskills-spec
+
+- **URL:** https://agentskills.io/specification.md
+- **Research doc:** plugins/kyberforge/docs/research/docs/agentskillsio/sources.md
+- **Description:** Complete SKILL.md format specification — frontmatter fields, constraints, body content, optional directories, progressive disclosure levels, file references, validation
+- **Contributing files:** SKILL.md, references/body-discipline.md, references/description-quality.md
+- **Status:** `extracted`
+
+## agentskills-best-practices
+
+- **URL:** https://agentskills.io/skill-creation/best-practices.md
+- **Research doc:** plugins/kyberforge/docs/research/docs/agentskillsio/sources.md
+- **Description:** Best practices for skill creators — starting from real expertise, spending context wisely, calibrating control, instruction patterns (gotchas, templates, checklists, validation loops)
+- **Contributing files:** SKILL.md, references/body-discipline.md
+- **Status:** `extracted`
+
+## agentskills-optimizing-descriptions
+
+- **URL:** https://agentskills.io/skill-creation/optimizing-descriptions.md
+- **Research doc:** plugins/kyberforge/docs/research/docs/agentskillsio/sources.md
+- **Description:** How to systematically test and improve skill descriptions for triggering accuracy — eval queries, trigger rate testing, train/validation splits, optimization loop
+- **Contributing files:** SKILL.md, references/description-quality.md
+- **Status:** `extracted`
+
+## agentskills-evaluating-skills
+
+- **URL:** https://agentskills.io/skill-creation/evaluating-skills.md
+- **Research doc:** plugins/kyberforge/docs/research/docs/agentskillsio/sources.md
+- **Description:** Eval-driven skill quality improvement — test case design, workspace structure, assertion writing, grading, benchmarking, human review, iteration loop
+- **Contributing files:** (none — eval workflow not directly informing audit dimensions)
+- **Status:** `extracted`
+
+## agentskills-using-scripts
+
+- **URL:** https://agentskills.io/skill-creation/using-scripts.md
+- **Research doc:** plugins/kyberforge/docs/research/docs/agentskillsio/sources.md
+- **Description:** Using scripts in skills — one-off commands, self-contained scripts with inline dependencies, designing scripts for agentic use (no interactive prompts, --help, structured output, idempotency)
+- **Contributing files:** SKILL.md
+- **Status:** `extracted`
+
+## agentskills-quickstart
+
+- **URL:** https://agentskills.io/skill-creation/quickstart.md
+- **Research doc:** plugins/kyberforge/docs/research/docs/agentskillsio/sources.md
+- **Description:** Step-by-step guide to creating a first skill (roll-dice example), how discovery/activation/execution work in practice
+- **Contributing files:** (none — creation guide not directly informing audit criteria)
+- **Status:** `extracted`