kyberforge: factory-audit check suite for instructions files #151

New Issue

2026-10-01T06:23:49Z

Claude commented

2026-10-01 06:23:49 +00:00

Part of #94.

Depends on #147
Depends on #148

Why

factory-audit audits skills and agents only. A hand-edited *.instructions.md currently gets no audit, and the description field is dropped on Claude compile without any warning.

What to build

Register instructions as a primitive in the generic flow from #147:

A scripts/lib-checks-instructions.sh check suite, sourced from a new instructions mode in scripts/validate.sh, encoding the rules instructions-author (#148) already decided are correct. Do not design the rubric twice: derive it from that skill's references/.
A criteria file and any rubrics the flow needs, under references/.
A row in the primitive data table (target shape *.instructions.md, coverage line, "Run instructions-author to address findings").
Provenance handling: extend validate-provenance.sh only if instructions files carry source_keys; otherwise say so in the PR.
tests/validate-instructions.bats.

Not in scope

Any change to the skill or agent flows or check suites.

Acceptance criteria

factory-audit on a valid instructions file returns PASS; on one with a field that Claude compile drops, the finding names the field, the target and the fix.
tests/validate-instructions.bats passes, with the existing skill and agent bats suites still green.
Step 0 recognises *.instructions.md and the unrecognised-path message lists the new shape.
factory-audit metadata.version bumped (ADR-0022); description and body pass ADR-0020 budgets.
apm audit --ci clean.

References

plugins/kyberforge/docs/research/docs/microsoft-apm/instructions-primitive-schema.md
ADR-0020, ADR-0022, ADR-0025

Part of #94. Depends on #147 Depends on #148 ## Why `factory-audit` audits skills and agents only. A hand-edited `*.instructions.md` currently gets no audit, and the `description` field is dropped on Claude compile without any warning. ## What to build Register instructions as a primitive in the generic flow from #147: - A `scripts/lib-checks-instructions.sh` check suite, sourced from a new `instructions` mode in `scripts/validate.sh`, encoding the rules `instructions-author` (#148) already decided are correct. Do not design the rubric twice: derive it from that skill's `references/`. - A criteria file and any rubrics the flow needs, under `references/`. - A row in the primitive data table (target shape `*.instructions.md`, coverage line, "Run instructions-author to address findings"). - Provenance handling: extend `validate-provenance.sh` only if instructions files carry `source_keys`; otherwise say so in the PR. - `tests/validate-instructions.bats`. ## Not in scope - Any change to the skill or agent flows or check suites. ## Acceptance criteria - [ ] `factory-audit` on a valid instructions file returns PASS; on one with a field that Claude compile drops, the finding names the field, the target and the fix. - [ ] `tests/validate-instructions.bats` passes, with the existing skill and agent bats suites still green. - [ ] Step 0 recognises `*.instructions.md` and the unrecognised-path message lists the new shape. - [ ] `factory-audit` `metadata.version` bumped (ADR-0022); description and body pass ADR-0020 budgets. - [ ] `apm audit --ci` clean. ## References - `plugins/kyberforge/docs/research/docs/microsoft-apm/instructions-primitive-schema.md` - ADR-0020, ADR-0022, ADR-0025

Claude added this to the Kyberforge basics milestone 2026-10-01 06:23:49 +00:00

Claude added the Kind/Feature label 2026-10-01 06:23:49 +00:00

Claude referenced this issue

2026-10-01 06:24:04 +00:00

kyberforge: add authoring/audit support for hooks, instructions, and prompt primitives #94

Claude referenced this issue

2026-10-01 07:09:50 +00:00

feat(kyberforge): add instructions-author skill for .apm/instructions files #154

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Defame1297/holocron#151