fix(kyberforge): require git-log commit verification and forbid self-spawned rechecks #74

Merged
Defame1297 merged 8 commits from fix/69-71-factory-authoring-fixes into main 2026-07-05 13:24:52 +00:00

8 Commits

Author SHA1 Message Date
c60ec5f2f7 chore(kyberforge): bump plugin version to 1.2.3
skill-author and agent-author SKILL.md files received bug fixes (git-log
commit-hash verification before reporting completion, skill-author now
forbids self-spawning audit/recheck subagents during its authoring pass,
and agent-author closed checklist/coverage gaps). Patch bump to reflect
fixed behavior, not new capability.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FNJWdVvdgvZCHi1hZGqgVQ
2026-07-05 13:20:07 +00:00
f657123931 fix(kyberforge): fix checklist/action mixing and improve-flow source_keys gap in agent-author
The Prerequisites checklist mixed items to confirm (preconditions) with an
action to perform (capturing git log), so the following "stop and ask if
missing" gate didn't logically apply to the git-log step. The improve flow
also had no reminder to update source_keys/sources.md when an edit touches
research-sourced content, unlike the create flow's explicit step for it.

Refs #69
2026-07-05 13:20:07 +00:00
fe24f7d900 fix(kyberforge): close agent-author frontmatter-comment and audit-availability gaps
Independent skill-audit found that agent-author's closing checklists never
verified template <!-- --> comments were stripped from frontmatter (produces
invalid YAML if left in), the Copilot field-exclusion checklist omitted two
fields present in the authoritative list, and the improve flow had no
agent-audit availability check unlike the create flow.
2026-07-05 13:20:07 +00:00
b0903f190a fix(kyberforge): require commit-hash verification in agent-author
Prior sessions had authoring subagents report completion after only
staging changes (git diff --stat showing output, but no git commit).
agent-author's create and improve flows now require capturing
git log --oneline -1 before and after the authoring pass and asserting
the hash actually changed via a real commit, matching the fix already
applied to skill-author.

Refs #69
2026-07-05 13:20:07 +00:00
3eb216afa6 fix(kyberforge): use consistent slash-command form for forge reference
Refs #69, #71
2026-07-05 13:20:07 +00:00
fc79acfa05 fix(kyberforge): tighten skill-author checklist/phrasing/reference style
Address round-2 independent-audit suggestions: single-item checklist
misuse in the improve flow, inaccurate "before Step 1" phrasing, and an
unbackticked cross-skill reference to kyberforge:forge.

Refs #69, #71
2026-07-05 13:20:07 +00:00
8b92590dc9 fix(kyberforge): surface commit-hash checklist earlier, drop redundant scripts line in skill-author
Independent /skill-audit recheck flagged the git-log-capture instructions
as discoverable only at close-out (Step 6/Step 5), long after the step
where the hash should actually be snapshotted. Adds the capture checklist
item to Prerequisites (create flow) and Step 1 (improve flow) instead of
leaving it as a retrospective-only note. Also drops a sentence in the
improve flow's Step 4 that duplicated the preceding one on editing
scripts/reference files directly.

Refs #69
2026-07-05 13:20:07 +00:00
caebc42bad fix(kyberforge): require commit-hash verification and forbid self-spawned rechecks in skill-author
Prior sessions had authoring subagents report completion after only
staging changes (git diff --stat showing output, but no git commit),
and one run self-spawned its own audit/recheck subagent instead of
leaving that to forge's outer loop, losing an uncommitted draft when
the stray subagent's worktree was torn down.

Refs #69, #71
2026-07-05 13:20:07 +00:00