Retrofits all 39 skills to ADR-0020's description/body context contract, then fixes what six rounds of independent review found in that retrofit — including four ways the hot gate itself failed open. Closes #99, #107, #108, #110, #111, #114, #115, #120. ## The retrofit (waves 1-5) | | Start | Now | |---|---|---| | Description FAILs (>400 chars) | 26 | **0** | | Body FAILs (>900 words, body-only) | 9 | **0** | | Dangling routing targets | 2 | **0** | | `Kyberforge.CompositionNote` | 10 | **0** | | Preload tax | 21,005 chars | **~10,500** | Under the 12,000-char success criterion. Per-wave detail is on #99. ## The review fixes **The gate failed open four ways, three of them found after the retrofit shipped.** An unrecognised follower token made a dangling target vanish. A skill directory with no `SKILL.md` resolved as a valid target, so a commit could be green locally and red in a fresh clone — three existing fixtures were relying on that, one of which made the install-leak A/B pass vacuously. Then the free-standing `/name` sweep turned out to be gated on the sentence carrying a boundary marker, so route notation in any other sentence was invisible — not an ERROR, not a SUGGESTION, not an INFO — which left the documented "`/name` always blocks" promise false from a second direction. All four fixed and pinned. **Two checks were silently not running.** `validate-provenance.sh` checks 7-8 were dead across nine skills. Waking them exposed a deeper problem: they assume `Research doc:` names a source index, but 30 of 121 entries point at topic content documents, so every new check-7 INFO was a false positive and check 8 was saved from a false-FAIL flood only by an *unannounced* skip. Checks 7/8 are now scoped to source indexes and every skip announces itself (#121). **The retrofit's own anti-goal, four times.** ADR-0020 warns that a blunt gate gets satisfied by deleting content rather than relocating it. `diagnose` and `skill-audit` relocated prose and then read it unconditionally; `prototype` and `vale-config` deleted rules outright that survived nowhere. All four addressed. ## Verification - `bash tests/run-tests.sh --strict` — 24 suites, 0 skipped, 0 failed - `bash tests/run-bats.sh` — 325 tests, 0 failures - `pre-commit run --all-files` — 17/17 - `pre-commit run --hook-stage pre-push --all-files` — 16/16, with `apm marketplace check` and `apm pack --check-clean` run against the remote, not skipped - `scripts/skill-size-check.sh` over all 39 skills — rc 0, 0 ERROR/FAIL, SUGGESTION-only - Preload tax measured at **10,498 chars**, max description 390 — both inside budget - Every new test proven non-vacuous by a deliberate mutation of the behaviour it covers **Per-commit sync, stated accurately:** the ten commits from the latest review round each pass `check-plugin-content-sync` in isolation, verified by checking each out in a detached worktree with a clean between. The earlier gitea window (`dfacf05..bedbd1d`, nine commits) does **not** — its mirror was regenerated in one batch at `bbc7300`. An earlier revision of this description claimed the property held for every commit; it does not, and a bisect through that window lands on a red commit. **Squash-merge** to collapse it, or accept that this range is not bisectable. ## Version bump Six plugins and the catalog take a **patch**, not a minor. The branch is **89 commits — 40 `fix` / 30 `refactor` / 12 `docs` / 5 `chore` / 2 `test` — zero `feat`, zero `!`, zero `BREAKING CHANGE`** — and adds no skill, agent, command or hook. (Two earlier revisions of this section cited a stale histogram, most recently 78 commits; the figures above are measured at HEAD.) Both rules this repo ships (`forge/references/version-bump.md`, landing in this PR, and `git-commits/references/conventional-commits-spec.md`) make that a patch, and the catalog set is unchanged at 7 entries. Not settled by that: four published files were removed from the installed tree, three moved, and `caveman` gained `disable-model-invocation`, retiring its old triggers. Under a strict reading those are major-class and currently ship under `refactor:` with no marker. Whether the deployed skill surface is a public contract is written down nowhere — worth deciding, but it outlives this PR. ## Deliberately not in scope #112 (cherry-pick ownership, now resolved in favour of `git-commits`), #113 (`rtk git` normalisation), #116 (research fan-out), #101 (audit-skill merge), #122 (non-spec skill-root files), #123 (no PRD producer) stay open. #117 is the one worth reading: the contract's remedy is to move prose into `references/`, which is exactly where neither the size gate nor Vale looks — and the blind spot is wider than #117 currently records, since there is no root `.vale.ini` at all, so every ADR, `CONTEXT.md` and `README.md` is unlinted too. That blind spot let this branch carry two `level: error` `Kyberforge.SentenceOpenerThereIs` violations into `references/` files it created — `provider-adapter-author/references/provider-matrix.md:31` and `agent-audit/references/finding-criteria.md:95`. Both are reworded in `afadaae`, confirmed by routing each file through the audit's own `vale-wrap.sh` (1 error each before, 0 after). Five further occurrences sit in `references/` files already on `main`; those are the pre-existing corpus and stay with #117, which is the real fix. Also unfixed and not this PR's: `apm install` appends a duplicate `SessionStart` entry to `.claude/settings.json`, so a fresh clone cannot get pre-push green without an edit AGENTS.md warns against. Reproduces identically on `main`. Co-authored-by: Defame1297 <gitea@rkdr.net> Reviewed-on: https://git.dev.rkdr.net/Defame1297/holocron/pulls/129 Co-authored-by: Claude Code AI - Gitea MCP <claude@noreply.git.dev.rkdr.net> Co-committed-by: Claude Code AI - Gitea MCP <claude@noreply.git.dev.rkdr.net>
4.6 KiB
topic, source_keys
| topic | source_keys | |
|---|---|---|
| compile |
|
Compile
apm compile # fails on skill/agent-only packages — see Gotchas
apm compile --clean # zero-write sanity check; use for skill/agent-only packages
apm compile --clean --dry-run # pure preview, no writes
Compiles .apm/instructions/ + .apm/agents/*.agent.md primitives into consumer-side context files (AGENTS.md/CLAUDE.md CONTEXT files) for the deployment target, per the compilation: block in apm.yml. This is the consumer/deployment side — it is NOT the producer of plugin.json/marketplace.json; that's apm pack's job (below). Run apm compile after any change to .apm/instructions//.apm/agents/ content or to compilation:/targets: in apm.yml.
Pack
apm pack --dry-run # resolve and print; do not write
apm pack --offline # cached refs only
apm pack --include-prerelease # allow pre-release tags
apm pack -v # per-entry resolution detail
apm pack --marketplace=claude --json # JSON output for CI pipelines
Bundles a producer package into a distributable artifact. Default to --dry-run -v first when packing something for the first time or after a dependency change — resolution errors surface before anything is written.
.mcp.json merge mechanics
apm pack reads a package's root-level .mcp.json directly — no dependencies.mcp entry in apm.yml is needed for simple passthrough. Behavior is content-aware:
- An empty
.mcp.json({"mcpServers": {}}) is NOT included in the packed output at all. - A populated one gets its
mcpServerscontent merged directly into the compiledplugin.json, but only for theclaudetarget. - The
copilottarget's compiledplugin.jsonOMITSmcpServersentirely — it isn't part of Copilot's plugin manifest schema.
dependencies.mcp in apm.yml is for a different purpose — declaring a remote MCP-server package as an APM dependency — not local .mcp.json passthrough.
includes: auto and the packed bundle
includes: auto does NOT sweep generic root-level passthrough files (README.md, docs/, sources.md, config files, etc.) into the apm pack distribution bundle (build/<name>-<version>) — only .apm/ primitives, the compiled plugin.json, and the content-aware .mcp.json handling above make it into that bundle. This does not affect Claude Code's own plugin loading, which reads a plugin's working directory directly via its source: path in marketplace.json, not the apm pack bundle — but it matters for anyone relying on the packed bundle for distribution via apm install.
Run apm audit after compile/pack, not before — audit scans deployed/compiled output, not the source apm.yml manifest. Plain apm audit is not the CI-equivalent pass (that is apm audit --ci, which checks strictly more); see references/audit.md.
Publish
apm publish --package acme/my-skill --dry-run -v
apm publish --package acme/my-skill
Publishes a producer package (root containing apm.yml, .apm/, and optionally a registries: block) to a registry. Always dry-run with -v first — publishing is not trivially reversible once a version tag is claimed on a registry.
Publishing to a named registry requires apm experimental enable registries to have already run — see SKILL.md's Gotchas for the precondition and its silent-no-op failure mode.
Run
apm run <script> [--param key=value]
Executes a named script defined under scripts: in apm.yml, with --param substituting values into the script's parameters.
Gotchas
- Plain
apm compileHARD-FAILS with exit 1 andNo instruction files found in .apm/ directoryon any package that has skills/agents but no.apm/instructions/content — the common case for a skill-only or skill+agent package. Useapm compile --cleanas the zero-write sanity-check substitute: it setsallow_empty=Trueinternally and exits 0 cleanly with zero writes; add--dry-runfor a pure preview.compile≠pack— see above. claude plugin validate --strictauto-scans every.mdfile directly under a compiled plugin'sagents/directory and treats it as an agent definition requiring frontmatter, independent of any manifest declaration (an empirically observed Claude Code platform behavior, not anapmmechanic). A non-agent.mdfile (notes, provenance record, README) that ends up under.apm/agents/in the source tree will still fail validation once compiled to theclaudetarget. Keep such files outside.apm/agents/(e.g. at the package root), regardless of whatapm.ymldeclares.