Files

Claude Code AI - Gitea MCP 598a7c326a refactor(skills): retrofit the corpus to the ADR-0020 context contract (#129 )

Retrofits all 39 skills to ADR-0020's description/body context contract, then fixes what six rounds of independent review found in that retrofit — including four ways the hot gate itself failed open.

Closes #99, #107, #108, #110, #111, #114, #115, #120.

## The retrofit (waves 1-5)

| | Start | Now |
|---|---|---|
| Description FAILs (>400 chars) | 26 | **0** |
| Body FAILs (>900 words, body-only) | 9 | **0** |
| Dangling routing targets | 2 | **0** |
| `Kyberforge.CompositionNote` | 10 | **0** |
| Preload tax | 21,005 chars | **~10,500** |

Under the 12,000-char success criterion. Per-wave detail is on #99.

## The review fixes

**The gate failed open four ways, three of them found after the retrofit shipped.** An unrecognised follower token made a dangling target vanish. A skill directory with no `SKILL.md` resolved as a valid target, so a commit could be green locally and red in a fresh clone — three existing fixtures were relying on that, one of which made the install-leak A/B pass vacuously. Then the free-standing `/name` sweep turned out to be gated on the sentence carrying a boundary marker, so route notation in any other sentence was invisible — not an ERROR, not a SUGGESTION, not an INFO — which left the documented "`/name` always blocks" promise false from a second direction. All four fixed and pinned.

**Two checks were silently not running.** `validate-provenance.sh` checks 7-8 were dead across nine skills. Waking them exposed a deeper problem: they assume `Research doc:` names a source index, but 30 of 121 entries point at topic content documents, so every new check-7 INFO was a false positive and check 8 was saved from a false-FAIL flood only by an *unannounced* skip. Checks 7/8 are now scoped to source indexes and every skip announces itself (#121).

**The retrofit's own anti-goal, four times.** ADR-0020 warns that a blunt gate gets satisfied by deleting content rather than relocating it. `diagnose` and `skill-audit` relocated prose and then read it unconditionally; `prototype` and `vale-config` deleted rules outright that survived nowhere. All four addressed.

## Verification

- `bash tests/run-tests.sh --strict` — 24 suites, 0 skipped, 0 failed
- `bash tests/run-bats.sh` — 325 tests, 0 failures
- `pre-commit run --all-files` — 17/17
- `pre-commit run --hook-stage pre-push --all-files` — 16/16, with `apm marketplace check` and `apm pack --check-clean` run against the remote, not skipped
- `scripts/skill-size-check.sh` over all 39 skills — rc 0, 0 ERROR/FAIL, SUGGESTION-only
- Preload tax measured at **10,498 chars**, max description 390 — both inside budget
- Every new test proven non-vacuous by a deliberate mutation of the behaviour it covers

**Per-commit sync, stated accurately:** the ten commits from the latest review round each pass `check-plugin-content-sync` in isolation, verified by checking each out in a detached worktree with a clean between. The earlier gitea window (`dfacf05..bedbd1d`, nine commits) does **not** — its mirror was regenerated in one batch at `bbc7300`. An earlier revision of this description claimed the property held for every commit; it does not, and a bisect through that window lands on a red commit. **Squash-merge** to collapse it, or accept that this range is not bisectable.

## Version bump

Six plugins and the catalog take a **patch**, not a minor. The branch is **89 commits — 40 `fix` / 30 `refactor` / 12 `docs` / 5 `chore` / 2 `test` — zero `feat`, zero `!`, zero `BREAKING CHANGE`** — and adds no skill, agent, command or hook. (Two earlier revisions of this section cited a stale histogram, most recently 78 commits; the figures above are measured at HEAD.) Both rules this repo ships (`forge/references/version-bump.md`, landing in this PR, and `git-commits/references/conventional-commits-spec.md`) make that a patch, and the catalog set is unchanged at 7 entries.

Not settled by that: four published files were removed from the installed tree, three moved, and `caveman` gained `disable-model-invocation`, retiring its old triggers. Under a strict reading those are major-class and currently ship under `refactor:` with no marker. Whether the deployed skill surface is a public contract is written down nowhere — worth deciding, but it outlives this PR.

## Deliberately not in scope

#112 (cherry-pick ownership, now resolved in favour of `git-commits`), #113 (`rtk git` normalisation), #116 (research fan-out), #101 (audit-skill merge), #122 (non-spec skill-root files), #123 (no PRD producer) stay open. #117 is the one worth reading: the contract's remedy is to move prose into `references/`, which is exactly where neither the size gate nor Vale looks — and the blind spot is wider than #117 currently records, since there is no root `.vale.ini` at all, so every ADR, `CONTEXT.md` and `README.md` is unlinted too.

That blind spot let this branch carry two `level: error` `Kyberforge.SentenceOpenerThereIs` violations into `references/` files it created — `provider-adapter-author/references/provider-matrix.md:31` and `agent-audit/references/finding-criteria.md:95`. Both are reworded in `afadaae`, confirmed by routing each file through the audit's own `vale-wrap.sh` (1 error each before, 0 after). Five further occurrences sit in `references/` files already on `main`; those are the pre-existing corpus and stay with #117, which is the real fix.

Also unfixed and not this PR's: `apm install` appends a duplicate `SessionStart` entry to `.claude/settings.json`, so a fresh clone cannot get pre-push green without an edit AGENTS.md warns against. Reproduces identically on `main`.

Co-authored-by: Defame1297 <gitea@rkdr.net>
Reviewed-on: https://git.dev.rkdr.net/Defame1297/holocron/pulls/129
Co-authored-by: Claude Code AI - Gitea MCP <claude@noreply.git.dev.rkdr.net>
Co-committed-by: Claude Code AI - Gitea MCP <claude@noreply.git.dev.rkdr.net>

2026-09-01 13:47:46 +00:00

4.9 KiB

Raw Blame History

source_keys

conventional-commits-spec

commitlint-config-conventional

Conventional Commits Specification (v1.0.0)

Conventional Commits is a lightweight convention on top of commit messages that provides a set of rules for creating an explicit commit history. It enables automated tooling (CHANGELOG generation, semantic version bumping) and structured filtering.

Message Format

<type>[optional scope]: <description>

[optional body]

[optional footer(s)]

Each section is separated by a blank line. The header is the only required part.

Rules

Element	Rule
`type`	Required. Lowercase noun.
`scope`	Optional. Noun in parentheses directly after type: `feat(api):`.
`description`	Required. Immediately follows `type/scope:` . Imperative mood, no trailing period.
`body`	Optional. Begins one blank line after description. Free-form prose, multiple paragraphs allowed. Lines max 100 characters.
`footer(s)`	Optional. Begins one blank line after body (or description). `<token>: <value>` format. Lines max 100 characters.
`BREAKING CHANGE`	Must be uppercase. Either a footer token or signalled by `!` before the colon.

Standard Types

The spec itself mandates only feat and fix. The 11-type set below is the de-facto standard from @commitlint/config-conventional (Angular commit message guidelines), not a spec requirement — but it is what this skill validates against.

11-type set (commitlint/config-conventional)

Type	Meaning	SemVer impact	Appears in CHANGELOG
`feat`	New user-visible feature	MINOR	Yes
`fix`	Bug fix	PATCH	Yes
`perf`	Performance improvement, no API change	PATCH	Yes
`revert`	Reverts a previous commit	PATCH	Yes
`docs`	Documentation only	none	No
`style`	Formatting, whitespace — no logic change	none	No
`refactor`	Code restructuring — no feature or fix	none	No
`test`	Adding or fixing tests	none	No
`build`	Build system or external dependency changes	none	No
`ci`	CI configuration and scripts	none	No
`chore`	Anything not fitting above	none	No

A BREAKING CHANGE footer or ! on any type always triggers a MAJOR bump.

Breaking Changes

Two equivalent notations:

! in header (preferred — visible in git log --oneline):

feat!: drop support for Node 6
feat(api)!: remove deprecated endpoint

BREAKING CHANGE footer (machine-readable body):

feat: allow config to extend other configs

BREAKING CHANGE: `extends` key now used for extending config files

Both together (most explicit):

feat!: drop support for Node 6

BREAKING CHANGE: use JavaScript features not available in Node 6.

Rules:

BREAKING CHANGE must be all caps.
BREAKING-CHANGE (hyphenated) is an accepted synonym.
Any type can carry a breaking change, not just feat.
The footer value must describe what broke.

Footer Token Rules

<token>: <value>
<token> #<value>    # for issue references

Tokens use hyphens for word separation: Reviewed-by, Co-authored-by, Refs.
Exception: BREAKING CHANGE (space allowed, uppercase).
Multiple footers allowed, one per line.
Blank line required before the footer block.

Valid footer examples:

Reviewed-by: Z
Refs: #123
Co-authored-by: Alice <alice@example.com>
BREAKING CHANGE: the `--format` flag now requires a value

Examples

Minimal — no body, no footer:

docs: correct spelling of CHANGELOG

With scope:

feat(lang): add Polish language

Breaking change via !:

feat!: send an email to the customer when a product is shipped

Breaking change via footer:

feat: allow provided config object to extend other configs

BREAKING CHANGE: `extends` key in config file is now used for extending other config files

Multi-paragraph body with multiple footers:

fix: prevent racing of requests

Introduce a request id and a reference to latest request. Dismiss
incoming responses other than from latest request.

Remove timeouts which were used to mitigate the racing issue but are
obsolete now.

Reviewed-by: Z
Refs: #123

Revert:

revert: let us never again speak of the noodle incident

Refs: 676104e, a215868

commitlint Constraints (config-conventional)

Constraint	Value
Header max length	100 characters
Subject must not end with `.`	enforced
Subject must be lowercase (not sentence-case or UPPER-CASE)	enforced
Body / footer line max length	100 characters
Type must be one of the 11 standard types	error if not
Blank line before body	warning
Blank line before footer	warning

SemVer Mapping Summary

Condition	SemVer bump
`fix`, `perf`, `revert`	PATCH
`feat`	MINOR
Any type with `BREAKING CHANGE` or `!`	MAJOR
All other types (`docs`, `style`, `refactor`, `test`, `build`, `ci`, `chore`)	none

4.9 KiB Raw Blame History