Defame1297
1b01e25f3b
Trim the two comment blocks that re-derived ADR-0019's argument in full (apm's exact-dict-lookup key matching, and why the PyYAML fallback is not a hard requirement) down to a short summary plus a pointer at ADR-0019, which already carries that reasoning verbatim. 231 -> 222 lines. The hook is kept, not deleted, per the audit's own corrected scope: the "or drop it" option in SIMPLIFICATION-AUDIT.md finding #2 is off the table because ADR-0019's Consequences section and the script's own header both call this failure mode silent, and the ADR says a silent-staleness failure here is strictly worse than the duplication this repo's other gates catch. The dual-reader design (PyYAML preferred, hand-rolled shape-scan fallback) is also kept as-is: it exists specifically so a missing python3/PyYAML can't silently skip the check or block every push, which is exactly the loud-failure guarantee this finding must not weaken. No genuine redundancy was found in the parsing logic, the per-branch Why/Fix error messages (each tied to a specific test), or the test matrix (which verifies the two readers agree across every failure mode) without cutting something load-bearing -- so those are untouched, and tests/test-check-executables-allow-sync.sh needed no changes since script behavior and output are byte-identical. All 23 tests in tests/test-check-executables-allow-sync.sh pass, and `pre-commit run check-executables-allow-sync --all-files --hook-stage pre-push` passes against the real repo state. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YR2CjVumUbEGWcMikcoXBD
8.8 KiB
Executable File
8.8 KiB
Executable File