Defame1297
69119f4754
Why A six-agent review of the two preceding commits found their code sound -- the differential claim holds, the published hook contract is byte-unchanged -- but their prose drifted from it in three ways: statements of fact the code contradicts, markers in a convention this repo does not use, and figures that went stale when the merge changed what they counted. Implementation Notes ADR-0025's edge-path table is rewritten around one stated doctrine: exit 0 is audited and clean, exit 1 is audited with findings or a target present but unreadable, exit 2 is that nothing was audited. Its old row 1 promised "one generic matches-neither message" for three different inputs; there are three distinct messages, and the missing-path case exited 1 until the preceding commit fixed it. Rows are added for the preflight and CDPATH changes, because a table claiming to enumerate every entry-point behaviour change reproduces its own "an earlier revision of this ADR said they were behaviour-neutral" failure if it omits any. ADR-0025 also gains a Consequences supersession record in ADR-0016's form: partially-superseded entries for 0008, 0014, 0020 and 0021, and explicit "is not superseded" entries with reasoning for the rest. Twelve ADRs are amended and it previously listed none. ADR-0008 moves from an amendment note to partially superseded. Its contract genuinely narrowed -- an agent .md outside an agents/ directory was audited before the merge and is refused now -- and ADR-0020 already recorded that the merge "reopens ADR-0008". Its detector description said "a path under .apm/agents/", the phrasing ADR-0025 rejects as wider than the script and circular; the shipped rule is a .md whose immediate parent is named agents/, at any scope. ADR-0020's amendment claimed the boundary resolver is sourced by validate-provenance.sh. It is not, and never was; only validate.sh sources it, once per mode branch. Three Home-column entries pointed at reference filenames the merge renamed, one of which now resolves to two files because its row covers skills and agents. Five ADRs opened with "Skill renamed per ADR-0025", a form this repo does not use, in the same commit that used the conventional "Amended by ADR-0025" twice. They are normalized. "Renamed" was also wrong: the BREAKING-CHANGE trailer says the skills were removed and their flows merged. SIMPLIFICATION-AUDIT.md had 2026-09-15 notes attached to headlines that were never updated, against its own convention of correcting in place with strikethrough. Every figure here was re-derived at HEAD by command, and several differed from the review's own numbers, so the notes record the basis rather than the result alone. LESSONS.md asserted the two review-time suite failures were the SIGPIPE race. The commit that fixed that race explicitly declined to claim it -- the suite was running while agents edited live config files -- so the hedge is restored. Impact No code, test or configuration change; documentation only. Suites stay 20/20 strict with 0 skipped and 374/374 bats. No gate parses ADR or gates.md content, so nothing here is load-bearing for a hook. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YR2CjVumUbEGWcMikcoXBD
38 lines
2.1 KiB
Markdown
38 lines
2.1 KiB
Markdown
# Add INFO as a third finding level in skill-audit reports
|
|
|
|
**Amended by ADR-0025 (2026-09-15).** `skill-audit` and `agent-audit` were removed and their flows
|
|
merged into `factory-audit`, which dispatches to a skill flow and an agent flow at Step 0. Read
|
|
`skill-audit` below as `factory-audit`'s skill flow. The decision itself is unchanged — ADR-0025
|
|
carried every audit criterion, tier and finding level across as-is.
|
|
|
|
`skill-audit` shipped with two finding levels: FAIL (blocks shipping) and
|
|
SUGGESTION (optional improvement). Provenance validation introduced observations
|
|
that are worth surfacing but not actionable: a `references/*.md` file with no
|
|
`source_keys` when `sources.md` is present, and a skill-level source slug absent
|
|
from upstream research docs. Folding these into SUGGESTION would imply they
|
|
should be fixed — but retroactive source backfill after a reference file is
|
|
written is unreliable and not expected practice. A third level, INFO, is therefore
|
|
introduced: observational, no action implied, never changes the pass/fail verdict.
|
|
Counted separately in the result block as `· P info`.
|
|
|
|
## Considered options
|
|
|
|
**SUGGESTION with softer language (rejected)** — describe the finding as "worth
|
|
noting" rather than "should be fixed." Rejected because SUGGESTION already carries
|
|
an established meaning in the report; softening the language creates ambiguity
|
|
without changing the semantic level. Downstream consumers (humans, skill-improve)
|
|
would need to infer intent from prose rather than a stable token.
|
|
|
|
**Suppress entirely (rejected)** — omit findings that have no fix. Rejected
|
|
because the observations are useful for a human reviewing provenance completeness.
|
|
Silent omission loses information without reducing noise.
|
|
|
|
## Consequences
|
|
|
|
- Report format gains a third token: FAIL, SUGGESTION, INFO. INFO findings do not
|
|
affect pass/fail; counted as `· P info` in the result block.
|
|
- `skill-improve` currently ignores anything below FAIL — that behavior remains
|
|
correct; INFO findings are not forwarded to it.
|
|
- Future soft observations should use INFO rather than SUGGESTION when no fix is
|
|
actionable.
|