Defame1297
38f1ba4e03
Claude Code's (and Copilot's) native plugin installer has zero awareness of .apm/ nesting -- it convention-scans only flat skills/, agents/, commands/, hooks.json at each plugin's root. Confirmed via strings on the installed claude binary and live installs of git@holocron/gitea@holocron/kyberforge@ holocron, all reporting Skills(0) Agents(0) Hooks(0) post ADR-0015's apm conversion. Root cause (apm_cli/core/plugin_manifest.py): apm's plugin.json compiler deliberately strips skills/agents/commands keys, assuming the host already auto-discovers those convention directories -- it has no model of .apm/ being host-visible at all. Separately, apm's own bundle exporter (apm_cli/bundle/plugin_exporter.py, behind `apm pack --format plugin`) implements the correct .apm/ -> flat mapping, but only ever targeted build/<name>-<version>/, a path nothing in marketplace.json's source: points at. scripts/sync-plugin-content.sh wraps that bundle exporter and copies its agents/, skills/, commands/, instructions/, extensions/, and merged hooks.json back into each plugin's own root as a second tracked compiled-output category -- same governance status as .claude-plugin/plugin.json: generated from .apm/, never hand-edited. tests/ subdirectories are excluded from the mirror (dev fixtures, not host-visible runtime content; several hardcode a relative repo-root walk-up sized for the .apm/-nested depth, which breaks when duplicated one level shallower). Applied for real across all 6 plugins and verified two ways: `claude plugin validate --strict` passes on every real plugin directory, and a live `claude --plugin-dir <path> -p "list skills/agents"` behavioral test confirms content is now actually discovered. Also, from the same issue #90 review round: - scripts/check-manifests.sh pointed at each plugin's root-level plugin.json (checking skills/hooks/mcpServers/agents pointer fields) -- that file was a stale near-duplicate of .claude-plugin/plugin.json nothing else read or wrote, now deleted across all 6 plugins. check-manifests.sh is rewritten to validate .claude-plugin/plugin.json instead, and drops the pointer-field checks entirely (nothing to check -- those fields are correctly absent by design). Content-presence drift is now check-plugin-content-sync's job, a new pre-push hook wired in .pre-commit-config.yaml. docs/adr/0017 records the root cause and decision in full, including two rejected alternatives (patching plugin.json's path fields directly -- apm's compiler strips them on every run; pointing marketplace.json at apm pack's build/ output -- a version-suffixed non-source directory nothing can install from without an extra build step). ADR-0015 and CONTEXT.md are updated to point at it. Refs: #90
60 lines
2.5 KiB
Markdown
60 lines
2.5 KiB
Markdown
---
|
|
# Research sources referenced by this skill
|
|
# Each entry documents where the skill's guidance came from.
|
|
---
|
|
|
|
## nvie-gitflow-post
|
|
|
|
**Description:** Original 2010 post by Vincent Driessen introducing the Gitflow branching model, including a 2020 reflection note recommending GitHub Flow for continuous delivery teams.
|
|
|
|
**Source:** https://nvie.com/posts/a-successful-git-branching-model/
|
|
|
|
- **Research doc:** plugins/git/docs/research/docs/git/gitflow.md (whole-document reference)
|
|
|
|
**Contributing files:**
|
|
- SKILL.md (Interaction style — branching-model-aware tips)
|
|
|
|
## atlassian-gitflow-tutorial
|
|
|
|
**Description:** Atlassian's comprehensive Gitflow tutorial covering all five branch types, lifecycle steps, and CLI usage.
|
|
|
|
**Source:** https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow
|
|
|
|
- **Research doc:** plugins/git/docs/research/docs/git/gitflow.md (whole-document reference)
|
|
|
|
**Contributing files:**
|
|
- SKILL.md (Interaction style — branching-model-aware tips)
|
|
|
|
## gitflow-cheatsheet
|
|
|
|
**Description:** Visual cheatsheet for the git-flow CLI commands (git-flow-avh fork), covering all subcommands for feature, release, and hotfix branches.
|
|
|
|
**Source:** https://danielkummer.github.io/git-flow-cheatsheet/
|
|
|
|
- **Research doc:** plugins/git/docs/research/docs/git/gitflow.md (whole-document reference)
|
|
|
|
**Contributing files:**
|
|
- SKILL.md (Interaction style — branching-model-aware tips)
|
|
|
|
## context7-git-htmldocs
|
|
|
|
**Description:** Official Git HTML documentation from the git/htmldocs repository — covers all commands, concepts, and internals.
|
|
|
|
**Source:** context7:/git/htmldocs
|
|
|
|
- **Research doc:** plugins/git/docs/research/docs/git/overview.md (whole-document reference)
|
|
|
|
**Contributing files:**
|
|
- SKILL.md (Workflow — general git operation vocabulary)
|
|
|
|
## org-git-conventions
|
|
|
|
**Description:** This org's internal git conventions (hard rules on hooks, force-push, atomic commits, secrets, Conventional Commits, trailers, and the `rtk git` wrapper requirement). Originally maintained as a standalone instruction file loaded into every agent's context; embedded directly into this skill because that central file has been removed from the repo, and skill content must stay self-contained after plugin installation.
|
|
|
|
**Source:** org-internal (formerly `core/instructions/git.md` in this repo, prior to its removal)
|
|
|
|
- **Research doc:** none — org convention, not part of the plugin's research corpus (no `plugins/git/docs/research/` topic file backs this entry)
|
|
|
|
**Contributing files:**
|
|
- SKILL.md (Gotchas — Hard rules subsection, rtk git note)
|