Files

Defame1297 5e232503c4 feat(kyberforge): execute plugin-to-apm marketplace conversion

Why:
ADR-0015 established that Microsoft APM (apm.yml + .apm/) should replace
this repo's hand-authored plugin.json/marketplace.json model, with those
files becoming compiled output of `apm pack` instead of files edited by
hand via the (now-retired) plugin-author/marketplace-author skills.
Issue #90 was the deferred execution of that decision, gated on #88
(apm tooling) and #89 (apm-native agent-author/skill-author routing).

Implementation notes:
- All six plugins (bin, core, git, gitea, kyberforge, lint) now carry
  apm.yml + .apm/{skills,agents,hooks} as their authoring source. Skills
  moved with a plain git mv (content-identical across targets). Agents
  were re-authored, not moved: per ADR-0016, .apm/agents/*.agent.md
  compiles verbatim to both Claude and Copilot, so plugin-scope agents
  now carry only name/description/model/source_keys -- no tools: field,
  no Claude-only knobs (isolation, maxTurns, effort, memory,
  permissionMode).
- Root apm.yml registers all 7 marketplace packages (6 local plus
  mattpocock-skills as a remote entry) under versioning: per_package,
  matching this repo's existing independent-plugin-versioning practice.
- .claude-plugin/marketplace.json and every plugin's plugin.json are now
  apm-pack-compiled output, verified against the prior hand-maintained
  content: same names/descriptions/versions/licenses/authors, only
  cosmetic serialization differences (JSON key order, owner email vs.
  url, Unicode escaping).
- plugin-author and marketplace-author are retired now that apm-based
  authoring fully replaces their job; kyberforge bumped 1.3.1 -> 1.4.0
  for that removal, and the root marketplace catalog bumped
  0.3.1 -> 0.3.2 to match, per the version-bump convention now
  documented in apm-workflow's reference docs instead of a dedicated
  script (apm has no native version-bump automation).
- Fixed hardcoded pre-.apm/ path assumptions across
  .pre-commit-config.yaml, .pre-commit-hooks.yaml,
  scripts/check-scope-walkup-sync.sh, scripts/sync-vale-styles.sh,
  scripts/check-vale-style-sync.sh, six plugins' root plugin.json
  (stale skills/hooks/agents pointer fields that check-manifests.sh
  validates), and several tests/*.bats and tests/*.sh fixtures --
  including a bats REPO_ROOT relative-path depth bug (10 files, one
  extra .apm/ directory level to walk up) and a vale probe-path
  isolation regression introduced mid-fix.
- Corrected empirically-wrong assumptions surfaced this session in
  apm-workflow/apm-install's own reference docs: `apm marketplace
  package add` does not accept local paths (only owner/repo remote
  shorthand -- local packages are registered by editing apm.yml's
  marketplace.packages[] directly); `apm compile` is a consumer-side
  AGENTS.md/CLAUDE.md generator, not the plugin.json producer, and
  hard-fails on skill/agent-only packages without --clean; `apm plugin
  init <name>` nests a stray subdirectory when run with a positional
  name arg from inside a same-named directory; no native Copilot
  marketplace output profile exists; .mcp.json is merged into the
  compiled plugin.json content-aware and target-scoped, with no
  dependencies.mcp entry needed for simple passthrough; pipx is the
  correct pip fallback on externally-managed Python environments.
- Renamed agent-author's copilot.agent.md template asset to
  copilot.agent.md.template so apm compile's recursive *.agent.md glob
  stops misparsing the placeholder template as a real agent primitive.

Impact:
plugin.json and marketplace.json are compiled artifacts from here on --
editing them by hand is no longer the workflow; edit apm.yml/.apm/ and
run apm pack. CONTEXT.md's Plugin/Plugin marketplace glossary entries
reflect this. ADR-0001 is marked superseded, ADR-0006 moot, and
ADR-0010 updated for the new .apm/agents/ path (project/user scope
unaffected, per ADR-0016). Full local verification: claude plugin
validate --strict on all 6 plugins, apm audit --ci, apm marketplace
check, check-manifests.sh, and the full test suite (165/165 bats,
13/13 shell scripts) all pass clean.

Fixes: #90
Refs: #88, #89
ADR: 0015
ADR: 0016

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ub96PyaSRD9BHPktotj1pC

2026-08-12 18:21:24 +00:00

5.2 KiB

Raw Blame History

topic, source_keys

topic

source_keys

enrichments

gitea-mcp-repo

gitea-mcp-slim-go

context7-websites-gitea

Create-flow enrichments

Closes out the four enrichments deferred from issue #6 comment #848. Run in this order before the issue_write method: "create" call in SKILL.md's create dispatch: labels → milestone → assignee → dependency link. Each step is independent and skippable on its own — a missing milestone fit doesn't block label inference, and so on — but this is the order that lets later steps use context established earlier (e.g. the inferred Kind/* label can inform which milestone plausibly fits).

Cross-skill composition note: none of the steps below read gitea-labels-milestones's reference files directly by path. A plugin install copies each skill's directory into an isolated cache — any file path that leaves this skill's own directory breaks post-install. Instead, compose gitea-labels-milestones as a skill: describe the task to it (its own SKILL.md and description trigger it) and consume the resolved IDs it returns. This mirrors how gitea-labels-milestones's own description already frames the relationship ("gitea-issues and gitea-prs both compose it").

1. Label inference

Delegate the entire signal-to-label mapping to gitea-labels-milestones — this skill does not duplicate the Kind/*/Priority/*/Status/* taxonomy table.

Compose gitea-labels-milestones to resolve labels for the issue being created: give it the draft title/body and ask it to infer and resolve applicable labels (it calls label_read method: "list_repo_labels" internally and runs its own inference procedure).
Take back the resolved label IDs (and which scope groups, if any, need replacing — not relevant yet on a brand-new issue, since there's nothing to replace).
If gitea-labels-milestones reports low confidence and omits a Kind/* label, pass no Kind/* ID rather than guessing one yourself. Priority/Medium is the one label its own inference procedure defaults to when no urgency signal is present — that's expected, not a gap.
Pass the resulting label IDs to issue_write's labels parameter (omit the parameter entirely if the resolved list is empty).

2. Milestone assignment on create

Compose gitea-labels-milestones to list open milestones (it calls milestone_read method: "list" state: "open" internally).
Compare the issue's inferred scope (title, body, and any Kind/* label from step 1) against each open milestone's title/description. Assign a milestone only when the fit is clear — a milestone literally named for the feature area, or one whose description explicitly covers this kind of work. A milestone that's merely "the current one" without a clear scope match is not a confident fit.
If a milestone clearly fits, pass its numeric ID (never the title) as issue_write's milestone parameter. issue_write's milestone field only accepts the ID — see references/issues.md.
If no milestone clearly fits, omit milestone entirely. Guessing a milestone assignment is worse than leaving it unset — an issue can always be milestoned later, but a wrong milestone assignment pollutes that milestone's issue count and scope.

3. Assignee on create — the `get_me` workaround

issue_write accepts assignees: [<login>], but there is no way to discover the current user's own login to self-assign: get_me requires the read:user scope, and this repo's Gitea MCP token is scoped to write:issue + write:repository only, with no read:user grant. This is a hard capability gap, not something to work around with a guess.

Workaround: support an optional user-configured default assignee login, supplied one of two ways:

A config value the caller or orchestrator (e.g. gitea-workflow) already resolved and passes in when invoking this skill.
A login explicitly stated in the conversation ("assign this to alice") — use that login directly, no lookup needed, since Gitea accepts a login string without requiring you to resolve an ID first.

If neither is available, omit assignees entirely. Do not guess a login, do not fail the create over a missing assignee, and do not attempt get_me/search_users as a fallback — both are blocked by the same scope gap and will only produce a confusing secondary error.

4. Dependency-linking convention

gitea-mcp has no native issue-dependency field (no "blocks"/"blocked by" relationship in the API surface this skill has access to). The convention is to write "Depends on #N" as a line in the issue body.

This is not just a text convention with no effect — Gitea auto-renders #N (and !N for PRs) as a real clickable cross-reference with no separate API call, a documented platform behavior (see references/sources.md for the backing research). This works because issues and PRs share one repo-scoped number space. Use the bare #N form for same-repo dependencies; use owner/repo#N for a dependency in a different repo.

When creating an issue that depends on another, append a line like:

Depends on #42

to the body before calling issue_write method: "create". There is no separate field or follow-up call — the rendering happens automatically once the body is saved.

5.2 KiB Raw Blame History