Defame1297
38f1ba4e03
Claude Code's (and Copilot's) native plugin installer has zero awareness of .apm/ nesting -- it convention-scans only flat skills/, agents/, commands/, hooks.json at each plugin's root. Confirmed via strings on the installed claude binary and live installs of git@holocron/gitea@holocron/kyberforge@ holocron, all reporting Skills(0) Agents(0) Hooks(0) post ADR-0015's apm conversion. Root cause (apm_cli/core/plugin_manifest.py): apm's plugin.json compiler deliberately strips skills/agents/commands keys, assuming the host already auto-discovers those convention directories -- it has no model of .apm/ being host-visible at all. Separately, apm's own bundle exporter (apm_cli/bundle/plugin_exporter.py, behind `apm pack --format plugin`) implements the correct .apm/ -> flat mapping, but only ever targeted build/<name>-<version>/, a path nothing in marketplace.json's source: points at. scripts/sync-plugin-content.sh wraps that bundle exporter and copies its agents/, skills/, commands/, instructions/, extensions/, and merged hooks.json back into each plugin's own root as a second tracked compiled-output category -- same governance status as .claude-plugin/plugin.json: generated from .apm/, never hand-edited. tests/ subdirectories are excluded from the mirror (dev fixtures, not host-visible runtime content; several hardcode a relative repo-root walk-up sized for the .apm/-nested depth, which breaks when duplicated one level shallower). Applied for real across all 6 plugins and verified two ways: `claude plugin validate --strict` passes on every real plugin directory, and a live `claude --plugin-dir <path> -p "list skills/agents"` behavioral test confirms content is now actually discovered. Also, from the same issue #90 review round: - scripts/check-manifests.sh pointed at each plugin's root-level plugin.json (checking skills/hooks/mcpServers/agents pointer fields) -- that file was a stale near-duplicate of .claude-plugin/plugin.json nothing else read or wrote, now deleted across all 6 plugins. check-manifests.sh is rewritten to validate .claude-plugin/plugin.json instead, and drops the pointer-field checks entirely (nothing to check -- those fields are correctly absent by design). Content-presence drift is now check-plugin-content-sync's job, a new pre-push hook wired in .pre-commit-config.yaml. docs/adr/0017 records the root cause and decision in full, including two rejected alternatives (patching plugin.json's path fields directly -- apm's compiler strips them on every run; pointing marketplace.json at apm pack's build/ output -- a version-suffixed non-source directory nothing can install from without an extra build step). ADR-0015 and CONTEXT.md are updated to point at it. Refs: #90
48 lines
1.6 KiB
Markdown
48 lines
1.6 KiB
Markdown
# scripts/
|
|
|
|
Executable code bundled with this skill. Agents run scripts in this directory
|
|
to perform repeatable operations rather than reinventing the logic each run.
|
|
|
|
## When to add a script
|
|
|
|
Add a script when agents independently reinvent the same logic across runs —
|
|
building the same parser, chart, or validation routine from scratch each time.
|
|
Bundle it here once, tested and reliable.
|
|
|
|
## Script requirements (agentskills.io)
|
|
|
|
Scripts must be designed for non-interactive, agentic execution:
|
|
|
|
- **No interactive prompts** — agents run in non-interactive shells.
|
|
Accept all input via flags, env vars, or stdin. A script that blocks on
|
|
TTY input hangs indefinitely.
|
|
- **Expose `--help`** — this is how agents learn your script's interface.
|
|
Keep the output concise; it enters the agent's context window.
|
|
- **Structured output** — write data (JSON, CSV, TSV) to stdout.
|
|
Write progress, warnings, and diagnostics to stderr.
|
|
- **Idempotent** — prefer "create if not exists" over "create and fail on
|
|
duplicate". Agents may retry on failure.
|
|
- **Meaningful exit codes** — `0` for success, non-zero for failure.
|
|
Use distinct codes for different failure types; document them in `--help`.
|
|
- **Dry-run support** — add `--dry-run` for destructive operations.
|
|
|
|
## Self-contained scripts
|
|
|
|
Bundle dependencies inline so the agent can run the script with a single command.
|
|
|
|
Python (PEP 723 + uv):
|
|
```python
|
|
# /// script
|
|
# dependencies = ["requests>=2.31,<3"]
|
|
# requires-python = ">=3.11"
|
|
# ///
|
|
import requests
|
|
```
|
|
```bash
|
|
uv run scripts/my-script.py
|
|
```
|
|
|
|
## If no scripts are needed
|
|
|
|
Delete this README and the `scripts/` directory entirely.
|