Retrofits all 39 skills to ADR-0020's description/body context contract, then fixes what six rounds of independent review found in that retrofit — including four ways the hot gate itself failed open. Closes #99, #107, #108, #110, #111, #114, #115, #120. ## The retrofit (waves 1-5) | | Start | Now | |---|---|---| | Description FAILs (>400 chars) | 26 | **0** | | Body FAILs (>900 words, body-only) | 9 | **0** | | Dangling routing targets | 2 | **0** | | `Kyberforge.CompositionNote` | 10 | **0** | | Preload tax | 21,005 chars | **~10,500** | Under the 12,000-char success criterion. Per-wave detail is on #99. ## The review fixes **The gate failed open four ways, three of them found after the retrofit shipped.** An unrecognised follower token made a dangling target vanish. A skill directory with no `SKILL.md` resolved as a valid target, so a commit could be green locally and red in a fresh clone — three existing fixtures were relying on that, one of which made the install-leak A/B pass vacuously. Then the free-standing `/name` sweep turned out to be gated on the sentence carrying a boundary marker, so route notation in any other sentence was invisible — not an ERROR, not a SUGGESTION, not an INFO — which left the documented "`/name` always blocks" promise false from a second direction. All four fixed and pinned. **Two checks were silently not running.** `validate-provenance.sh` checks 7-8 were dead across nine skills. Waking them exposed a deeper problem: they assume `Research doc:` names a source index, but 30 of 121 entries point at topic content documents, so every new check-7 INFO was a false positive and check 8 was saved from a false-FAIL flood only by an *unannounced* skip. Checks 7/8 are now scoped to source indexes and every skip announces itself (#121). **The retrofit's own anti-goal, four times.** ADR-0020 warns that a blunt gate gets satisfied by deleting content rather than relocating it. `diagnose` and `skill-audit` relocated prose and then read it unconditionally; `prototype` and `vale-config` deleted rules outright that survived nowhere. All four addressed. ## Verification - `bash tests/run-tests.sh --strict` — 24 suites, 0 skipped, 0 failed - `bash tests/run-bats.sh` — 325 tests, 0 failures - `pre-commit run --all-files` — 17/17 - `pre-commit run --hook-stage pre-push --all-files` — 16/16, with `apm marketplace check` and `apm pack --check-clean` run against the remote, not skipped - `scripts/skill-size-check.sh` over all 39 skills — rc 0, 0 ERROR/FAIL, SUGGESTION-only - Preload tax measured at **10,498 chars**, max description 390 — both inside budget - Every new test proven non-vacuous by a deliberate mutation of the behaviour it covers **Per-commit sync, stated accurately:** the ten commits from the latest review round each pass `check-plugin-content-sync` in isolation, verified by checking each out in a detached worktree with a clean between. The earlier gitea window (`dfacf05..bedbd1d`, nine commits) does **not** — its mirror was regenerated in one batch at `bbc7300`. An earlier revision of this description claimed the property held for every commit; it does not, and a bisect through that window lands on a red commit. **Squash-merge** to collapse it, or accept that this range is not bisectable. ## Version bump Six plugins and the catalog take a **patch**, not a minor. The branch is **89 commits — 40 `fix` / 30 `refactor` / 12 `docs` / 5 `chore` / 2 `test` — zero `feat`, zero `!`, zero `BREAKING CHANGE`** — and adds no skill, agent, command or hook. (Two earlier revisions of this section cited a stale histogram, most recently 78 commits; the figures above are measured at HEAD.) Both rules this repo ships (`forge/references/version-bump.md`, landing in this PR, and `git-commits/references/conventional-commits-spec.md`) make that a patch, and the catalog set is unchanged at 7 entries. Not settled by that: four published files were removed from the installed tree, three moved, and `caveman` gained `disable-model-invocation`, retiring its old triggers. Under a strict reading those are major-class and currently ship under `refactor:` with no marker. Whether the deployed skill surface is a public contract is written down nowhere — worth deciding, but it outlives this PR. ## Deliberately not in scope #112 (cherry-pick ownership, now resolved in favour of `git-commits`), #113 (`rtk git` normalisation), #116 (research fan-out), #101 (audit-skill merge), #122 (non-spec skill-root files), #123 (no PRD producer) stay open. #117 is the one worth reading: the contract's remedy is to move prose into `references/`, which is exactly where neither the size gate nor Vale looks — and the blind spot is wider than #117 currently records, since there is no root `.vale.ini` at all, so every ADR, `CONTEXT.md` and `README.md` is unlinted too. That blind spot let this branch carry two `level: error` `Kyberforge.SentenceOpenerThereIs` violations into `references/` files it created — `provider-adapter-author/references/provider-matrix.md:31` and `agent-audit/references/finding-criteria.md:95`. Both are reworded in `afadaae`, confirmed by routing each file through the audit's own `vale-wrap.sh` (1 error each before, 0 after). Five further occurrences sit in `references/` files already on `main`; those are the pre-existing corpus and stay with #117, which is the real fix. Also unfixed and not this PR's: `apm install` appends a duplicate `SessionStart` entry to `.claude/settings.json`, so a fresh clone cannot get pre-push green without an edit AGENTS.md warns against. Reproduces identically on `main`. Co-authored-by: Defame1297 <gitea@rkdr.net> Reviewed-on: https://git.dev.rkdr.net/Defame1297/holocron/pulls/129 Co-authored-by: Claude Code AI - Gitea MCP <claude@noreply.git.dev.rkdr.net> Co-committed-by: Claude Code AI - Gitea MCP <claude@noreply.git.dev.rkdr.net>
6.1 KiB
topic, source_keys
| topic | source_keys | ||
|---|---|---|---|
| issues |
|
Issue operations
Call signatures below were verified live against the deployed gitea-mcp server via ToolSearch,
not copied from api-reference.md — this is deliberate: research docs are generated from source at
a point in time and can drift from the server actually deployed. Last verified against gitea-mcp
v1.7.0, as reported by get_gitea_mcp_server_version. Drift runs in both directions: this file
previously recorded list_issues as having neither a type nor a milestones parameter, and
v1.7.0 has both. Re-verify against the live schema if these tools appear to behave differently than
documented here.
list_issues
Parameters (live schema):
owner(string, required)repo(string, required)state(string, optional, default"all") — conventional values"open"/"closed"/"all", not schema-enforced as an enumlabels(array of strings, optional) — filter by label name (not ID)milestones(array of strings, optional) — filter by milestone name or numeric ID, both passed as stringstype(string, enum"issues"|"pulls", optional) — omit it and the response mixes bothsince(string, optional) — ISO 8601, issues updated after this timebefore(string, optional) — ISO 8601, issues updated before this timepage(number, optional, default1)per_page(number, optional, default30)
Pass type: "issues" on any listing meant to show issues. Issues and PRs share one repo number
space and the unfiltered response interleaves them; the only thing distinguishing them on a list
item is the html_url path segment (/issues/ vs /pulls/), since is_pull is not returned on
list items — see the Gotchas section of SKILL.md.
Call:
list_issues owner: <owner> repo: <repo> state: "open" type: "issues"
Response (list item): number, title, state, html_url, user, comments, created_at,
updated_at, and optionally labels ([]string), milestone ({id, title}), ref, deadline.
Body and closed_at are omitted from list responses — call issue_read method: "get" for those.
Paginate with page/per_page until the returned count is less than per_page.
issue_read
Parameters (live schema, matches api-reference.md):
method(string, required, enum) —"get"|"get_comments"|"get_labels"owner(string, required)repo(string, required)issue_number(number, required)
get — full issue: number, title, body, state, html_url, user, labels
([]string), comments, created_at, updated_at, closed_at, and optionally assignees
([]string), milestone ({id, title}), ref, deadline, is_pull (present only when this
number is backed by a pull request — absent, not false, on true issues).
get_comments — array of {id, body, user, html_url, created_at, updated_at}.
get_labels — array of full label objects (id, name, color, description — not slimmed
to name strings, unlike the labels array on get).
Call:
issue_read method: "get" owner: <owner> repo: <repo> issue_number: <N>
Always check is_pull before treating a number as a plain issue — see the shared number-space
gotcha in SKILL.md.
issue_write
Parameters (live schema, matches api-reference.md):
method(string, required, enum) —"create"|"update"|"add_comment"|"edit_comment"|"add_labels"|"remove_label"|"replace_labels"|"clear_labels"owner(string, required)repo(string, required)issue_number(number, required for every method except"create")title(string, required for"create")body(string, required for"create","add_comment","edit_comment")assignees(array of strings, optional) — login names (seereferences/enrichments.mdfor why this is usually omitted)milestone(number, optional) — milestone ID, never a titlestate(string, enum"open"/"closed"/"all", optional) — for"update"commentID(number, optional, required for"edit_comment")labels(array of numbers, optional) — label IDs, never names — foradd_labels/replace_labelslabel_id(number, optional, required for"remove_label") — singular, not the array formref(string, optional) — branch association, informational onlydeadline(string, optional) — ISO 8601remove_deadline(boolean, optional)
Create:
issue_write method: "create"
owner: <owner> repo: <repo>
title: <title> body: <body>
labels: [<resolved IDs>] ← omit if none confidently inferred
milestone: <resolved ID> ← omit if none clearly fits
assignees: ["<login>"] ← omit if no default configured
Close:
issue_write method: "update" owner: <owner> repo: <repo> issue_number: <N> state: "closed"
No method: "close" exists — using one errors.
Comment:
issue_write method: "add_comment" owner: <owner> repo: <repo> issue_number: <N> body: <text>
Apply resolved label IDs directly (bypassing references/enrichments.md's inference step, e.g.
when the caller already named exact labels):
issue_write method: "add_labels" owner: <owner> repo: <repo> issue_number: <N> labels: [<IDs>]
To replace all labels atomically instead of adding: method: "replace_labels".
To remove one: method: "remove_label" label_id: <single ID>.
Default to add_labels. replace_labels clears every label not in the array, so it drops
labels the caller never mentioned. Reach for it only when the caller asked for the issue's label
set to become exactly what they listed. In particular, do not use it to enforce one-label-per-scope:
exclusivity is a per-label property — the server drops the sibling itself for a label whose
exclusive field is true, and a label whose exclusive is false (every Kind/* on this
instance) is legitimately stackable. See gitea-labels-milestones for how to read that field.
Token scope
All of list_issues, issue_read, and issue_write are verified working under a token holding
write:issue + write:repository.