Addresses 7 verified findings from the /code-review pass on PR #91's APM-conversion changes: - apm-workflow's description omitted install triggers, misrouting "install my apm dependencies" requests to apm-install instead - `apm marketplace check` was listed under both the marketplace and audit dispatch rows, breaking the "one reference file per action" contract; kept under marketplace.md, its real usage-sequence home - ADR-0015 claimed apm-workflow docs are generic/repo-agnostic while marketplace.md cited this repo's AGENTS.md and git-commits/ git-remotes skills by name; stripped the holocron-specific citations (marketplace.md, compile.md) so the claim now holds - plugin-author/marketplace-author are superseded per ADR-0015 with deletion deferred to #90; added deprecation notices pointing to the replacing apm-workflow dispatch actions - apm-orchestrate/gitea-orchestrate/git-orchestrate all instruct dispatch "via Skill" without granting the Skill tool; added it to all three - apm-orchestrate mandated strictly sequential fan-out across independent packages with no shared state; relaxed to permit parallel dispatch, matching this repo's own subagent-parallelization guidance Refs: #91
3.7 KiB
3.7 KiB
name, description, metadata
| name | description | metadata | |||||
|---|---|---|---|---|---|---|---|
| apm-workflow | Use when the user wants to author or edit an apm.yml manifest (dependencies, scripts, compilation, policy, registries), scaffold a new apm package or marketplace (apm plugin init, apm marketplace init/package add), install or resolve dependencies declared in apm.yml (apm install, apm install [PACKAGE_REF]), register a marketplace as a consumer, compile/pack/publish an apm package for distribution, or validate/audit apm.yml and installed content (apm audit, apm marketplace check) — even if the user doesn't say "apm" explicitly, e.g. "set up the package manifest", "scaffold this as an apm package", "install my apm dependencies", "resolve apm.yml deps", "build the distributable", "check this passes CI". Do not use for installing the apm binary itself or setting up an agent runtime — use apm-install for those. |
|
Gotchas
apm.yml'stype:field (instructions,skill,hybrid,prompts) constrains what.apm/may contain — set it before scaffolding content, not after. Changing it later doesn't retroactively validate what's already on disk.includes: autopublishes the authoritative local layout as-is. Anything narrower needs an explicit repo-path list — don't assumeautomeans "scoped down to what's relevant."apm marketplace add(registering a marketplace as a consumer, pointing at someone else's catalog) andapm marketplace package add(registering a local package into a marketplace you're building) are opposite directions of the same command family — don't conflate them.apm packis the same command that both bundles a distributable artifact and emits.claude-plugin/marketplace.jsonas one of its compile targets — regenerating the Claude Code-native manifest isn't a separate step from packing.- MCP server secrets (headers, env vars) inside
apm.ymlmust use${VAR}indirection, never literal values, so they're resolved at install/runtime and never committed to the manifest. apm experimental enable registriesmust run before anyregistry.*config takes effect. Declaring aregistries:block or runningapm config set registry.*without it silently does nothing — no error, no warning.- Plain
apm auditandapm audit --cicheck different things: plainapm auditscans deployed files for hidden Unicode only;--ciadditionally runs lockfile-consistency checks, install-replay drift detection, and org policy checks. A clean plainapm auditis not a CI-equivalent pass.
Step 1 — Dispatch
| Invocation | Action | Reference |
|---|---|---|
/apm-workflow configure |
Author/edit apm.yml; scaffold a new package (apm plugin init) |
references/configure.md |
/apm-workflow install |
Resolve/fetch dependencies declared in apm.yml (apm install, apm install [PACKAGE_REF]) |
references/install.md |
/apm-workflow marketplace |
Build a marketplace, register packages into it, or register a marketplace as a consumer (apm marketplace init/check/package add/add) |
references/marketplace.md |
/apm-workflow compile |
Generate per-target output, bundle, or publish (apm compile, apm pack, apm publish) |
references/compile.md |
/apm-workflow audit |
Validate integrity/policy or wire a CI gate (apm audit, apm audit --ci) |
references/audit.md |
Read only the reference file matching the requested action — each is self-contained for its concern.
Step 2 — Execute
Follow the matched reference file's instructions. Report back which apm command(s) were run (or drafted, if the user asked for a plan rather than execution) and their outcome.